scimgateway 4.2.0 → 4.2.1

package/README.md

@@ -1165,6 +1165,14 @@ MIT © [Jarle Elshaug](https://www.elshaug.xyz)
 
 ## Change log  
 
+### v4.2.1  
+
+[Fixed]  
+
+- plugin-azure-ad createUser failed when manager was included
+- plugin-ldap slow when not using group/groupBase configuration
+
+
 ### v4.2.0  
 
 [Added]  

package/lib/plugin-azure-ad.js

@@ -243,11 +243,15 @@ scimgateway.createUser = async (baseEntity, userObj, ctx) => {
   const action = 'createUser'
   scimgateway.logger.debug(`${pluginName}[${baseEntity}] handling "${action}" userObj=${JSON.stringify(userObj)}`)
 
-  const attrObj = {}
+  const addonObj = {}
   if (userObj.servicePlan) {
-    attrObj.servicePlan = userObj.servicePlan // will be included in a modifyuser
+    addonObj.servicePlan = userObj.servicePlan
     delete userObj.servicePlan
   }
+  if (userObj.manager) {
+    addonObj.manager = userObj.manager
+    delete userObj.manager
+  }
 
   const method = 'POST'
   const path = '/users'
@@ -255,8 +259,8 @@ scimgateway.createUser = async (baseEntity, userObj, ctx) => {
 
   try {
     await doRequest(baseEntity, method, path, body)
-    if (attrObj.servicePlan) {
-      await scimgateway.modifyUser(baseEntity, userObj.userName, attrObj, ctx)
+    if (Object.keys(addonObj).length > 0) {
+      await scimgateway.modifyUser(baseEntity, userObj.userName, addonObj, ctx) // manager, servicePlan
       return null
     } else return (null)
   } catch (err) {

package/lib/plugin-ldap.js

@@ -240,7 +240,7 @@ scimgateway.getUsers = async (baseEntity, getObj, attributes, ctx) => {
 
       if (user.memberOf) {
         if (!config.map.group) user.memberOf = [] // empty any values
-        else if (config.useSID_id || config.useGUID_id) { // Active Directory - convert memberOf having dn values to objectSid/objectGUID
+        if (config.useSID_id || config.useGUID_id) { // Active Directory - convert memberOf having dn values to objectSid/objectGUID
           const arr = []
           try {
             if (Array.isArray(user.memberOf)) {
@@ -261,7 +261,9 @@ scimgateway.getUsers = async (baseEntity, getObj, attributes, ctx) => {
         }
       }
 
-      return scimgateway.endpointMapper('inbound', user, config.map.user)[0] // endpoint attribute naming => SCIM
+      const scimObj = scimgateway.endpointMapper('inbound', user, config.map.user)[0] // endpoint attribute naming => SCIM
+      if (!scimObj.groups) scimObj.groups = []
+      return scimObj
     }))
   } catch (err) {
     throw new Error(`${action} error: ${err.message}`)
@@ -509,8 +511,8 @@ scimgateway.getGroups = async (baseEntity, getObj, attributes, ctx) => {
     totalResults: null
   }
 
-  if (!config.map.group) { // not using groups
-    scimgateway.logger.debug(`${pluginName}[${baseEntity}] "${action}" stopped - missing configuration endpoint.map.group`)
+  if (!config.map.group || !config.entity[baseEntity].ldap.groupBase) { // not using groups
+    scimgateway.logger.debug(`${pluginName}[${baseEntity}] "${action}" stopped - missing configuration endpoint.map.group or groupBase`)
     return result
   }
 

package/lib/scimgateway.js

@@ -1801,7 +1801,7 @@ const ScimGateway = function () {
     },
 
     // cleanup options
-    timeout: config.kubernetes?.forceExitTimeout || 1000, // [optional = 1000] number of milliseconds before forceful exiting
+    timeout: config.kubernetes.forceExitTimeout || 1000, // [optional = 1000] number of milliseconds before forceful exiting
     beforeShutdown, // [optional] called before the HTTP server starts its shutdown
     onSignal, // [optional] cleanup function, returning a promise (used to be onSigterm)
     onShutdown // [optional] called right before exiting
@@ -2401,7 +2401,7 @@ ScimGateway.prototype.endpointMapper = function endpointMapper (direction, parse
         else dotKey = `${dotPath}.${key}`
         if (direction === 'outbound') { // outbound
           if (obj[key] === '') obj[key] = null
-          if (dotMap[dotKey] && dotMap[`${dotKey}.type`]) {
+          if (dotMap[`${dotKey}.type`]) {
             const type = dotMap[`${dotKey}.type`].toLowerCase()
             if (type === 'boolean' && obj[key].constructor === String) {
               if ((obj[key]).toLowerCase() === 'true') obj[key] = true

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scimgateway",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "description": "Using SCIM protocol as a gateway for user provisioning to other endpoints",
   "author": "Jarle Elshaug <jarle.elshaug@gmail.com> (https://elshaug.xyz)",
   "homepage": "https://elshaug.xyz",