scimgateway 4.1.10 → 4.1.11

package/README.md

@@ -1146,6 +1146,12 @@ MIT © [Jarle Elshaug](https://www.elshaug.xyz)
 
 ## Change log  
 
+### v4.1.11  
+
+[Fixed]  
+  
+- basic auth logon dialog should not show up when not configured 
+
 ### v4.1.10  
 
 [Added]  

package/lib/scimgateway.js

@@ -123,7 +123,7 @@ const ScimGateway = function () {
         logger.error(`${gwName}[${pluginName}] getPassword error: ${err.message}`)
         throw err // above logger.error included because this unhanledExcepton will be handled by winston and may fail with an other internal winston error e.g. related to memoryUsage collection logic when running in unikernel
       }
-      if (arr[i].password) foundBasic = true
+      if (arr[i].username && arr[i].password) foundBasic = true
     }
     if (!foundBasic) config.auth.basic = []
   }
@@ -223,7 +223,7 @@ const ScimGateway = function () {
   if (config.certificate.pfx.password) pwPfxPassword = ScimGateway.prototype.getPassword('scimgateway.certificate.pfx.password', configFile)
   if (config.emailOnError.smtp.password) config.emailOnError.smtp.password = ScimGateway.prototype.getPassword('scimgateway.emailOnError.smtp.password', configFile)
 
-  if (!foundBasic && !foundBearerToken && !foundBearerJwtAzure && !foundBearerJwt) {
+  if (!foundBasic && !foundBearerToken && !foundBearerJwtAzure && !foundBearerJwt && !foundBearerOAuth) {
     logger.error(`${gwName}[${pluginName}] Scimgateway password decryption failed or no password defined`)
     logger.error(`${gwName}[${pluginName}] stopping...\n`)
     throw (new Error('Using exception to stop further asynchronous code execution (ensure synchronous logger flush to logfile and exit program), please ignore this one...'))
@@ -505,7 +505,7 @@ const ScimGateway = function () {
         logger.debug(`${gwName}[${pluginName}] request jwt.decode(authToken) = ${JSON.stringify(jwt.decode(authToken))}`)
       }
       if (authType === 'Bearer') ctx.set('WWW-Authenticate', 'Bearer realm=""')
-      else ctx.set('WWW-Authenticate', 'Basic realm=""')
+      else if (foundBasic) ctx.set('WWW-Authenticate', 'Basic realm=""')
       ctx.set('Content-Type', 'application/json; charset=utf-8')
       ctx.status = 401
       ctx.body = { error: 'Access denied' }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scimgateway",
-  "version": "4.1.10",
+  "version": "4.1.11",
   "description": "Using SCIM protocol as a gateway for user provisioning to other endpoints",
   "author": "Jarle Elshaug <jarle.elshaug@gmail.com> (https://elshaug.xyz)",
   "homepage": "https://elshaug.xyz",