sci2-ts 0.8.1 → 0.8.2

package/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project. Versions follow [Semantic Versioning](https
 and the entries are generated from commit messages
 ([Conventional Commits](https://www.conventionalcommits.org/)) when a release is made.
 
+## [0.8.2](https://github.com/rlueder/sci-ts/compare/v0.8.1...v0.8.2) (2026-10-02)
+
+### Fixed
+
+* **lib:** actors walk past each other and are clicked only where they're drawn ([#10](https://github.com/rlueder/sci-ts/issues/10)) ([99deb4a](https://github.com/rlueder/sci-ts/commit/99deb4a1e63bb5170ab0742942041ce3fde1801d))
+
 ## [0.8.1](https://github.com/rlueder/sci-ts/compare/v0.8.0...v0.8.1) (2026-10-02)
 
 ### Fixed

package/lib/998.sc

@@ -208,10 +208,13 @@
       (curRoom doVerb: verb))))
 
 ;; A Feature drawn with a view: a screen item in the room's plane. One that's only there to
-;; look at (rain on a window, a sky) has clickable 0, and clicks go to what's behind it.
+;; look at (rain on a window, a sky) has clickable 0, and clicks go to what's behind it. With
+;; checkPixels, it's hit only where it's drawn, not anywhere in its cel (Actors: people are
+;; often drawn on canvases much wider than they are).
 (class View of Feature
   (properties
     clickable 1
+    checkPixels 0
     view -1 loop 0 cel 0
     z 0
     priority 0 fixPriority 0
@@ -232,7 +235,7 @@
     (if (not (& signal SIG_HIDDEN)) (UpdateScreenItem self)))
 
   (method (onMe theX theY)
-    (return (and clickable (not (& signal SIG_HIDDEN)) (IsOnMe theX theY self))))
+    (return (and clickable (not (& signal SIG_HIDDEN)) (IsOnMe theX theY self checkPixels))))
 
   (method (hide)
     (|= signal SIG_HIDDEN)
@@ -315,9 +318,13 @@
     (if script (script dispose:))
     (super dispose:)))
 
-;; A Prop that moves (a mover), facing where it goes.
+;; A Prop that moves (a mover), facing where it goes. Actors walk through each other unless
+;; ignoreActors is 0: the interpreter measures an actor by its whole cel, and characters are
+;; often drawn on canvases much wider than they are, so blocking would stop them far apart.
 (class Actor of Prop
   (properties
+    ignoreActors 1
+    checkPixels 1
     mover 0
     moveSpeed 2     ; cycles between steps
     heading 0
@@ -359,6 +366,7 @@
 
   ;; Whether another actor is in the way (DoBresen asks).
   (method (cantBeHere)
+    (if ignoreActors (return 0))
     (return (CantBeHere self (cast elements?))))
 
   (method (dispose)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sci2-ts",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "description": "An SCI2 adventure game engine in TypeScript, and the tools to make games with it",
   "license": "MIT",
   "type": "module",

package/packages/sci/src/vm/kernels/graphics.js

@@ -409,14 +409,22 @@ export const graphicsKernels = {
         vm.setProp(obj, "brBottom", fromInt(bottom));
         vm.setProp(obj, "brTop", fromInt(bottom - g.prop(obj, "yStep")));
     },
-    IsOnMe: (vm, [x = 0, y = 0, obj = 0]) => {
+    // IsOnMe(x, y, obj, checkPixels): with checkPixels, only where the cel isn't transparent.
+    IsOnMe: (vm, [x = 0, y = 0, obj = 0, checkPixels = 0]) => {
         const g = graphics(vm);
         const px = toSigned(x), py = toSigned(y);
         // Like SSCI, a screen item is hit where its cel is actually drawn (scaled, current
         // position): its ns* props can be stale, since only SetNowSeen updates them.
         const r = g.items.has(obj) ? g.viewRect(obj) : undefined;
-        if (r)
-            return bool(px >= r.x && px < r.x + r.width && py >= r.y && py < r.y + r.height);
+        if (r) {
+            if (!(px >= r.x && px < r.x + r.width && py >= r.y && py < r.y + r.height))
+                return 0;
+            if (!checkPixels)
+                return 1;
+            const cx = Math.min(r.cel.width - 1, Math.floor((px - r.x) / r.sx));
+            const cy = Math.min(r.cel.height - 1, Math.floor((py - r.y) / r.sy));
+            return bool(r.cel.pixels[cy * r.cel.width + (r.mirror ? r.cel.width - 1 - cx : cx)] !== r.cel.skipColor);
+        }
         return bool(px >= g.prop(obj, "nsLeft") && px <= g.prop(obj, "nsRight") && py >= g.prop(obj, "nsTop") && py <= g.prop(obj, "nsBottom"));
     },
     IsHiRes: () => 0,

package/packages/sci/src/vm/kernels/graphics.ts

@@ -448,13 +448,20 @@ export const graphicsKernels: Record<string, KernelFn> = {
     vm.setProp(obj, "brBottom", fromInt(bottom));
     vm.setProp(obj, "brTop", fromInt(bottom - g.prop(obj, "yStep")));
   },
-  IsOnMe: (vm, [x = 0, y = 0, obj = 0]) => {
+  // IsOnMe(x, y, obj, checkPixels): with checkPixels, only where the cel isn't transparent.
+  IsOnMe: (vm, [x = 0, y = 0, obj = 0, checkPixels = 0]) => {
     const g = graphics(vm);
     const px = toSigned(x), py = toSigned(y);
     // Like SSCI, a screen item is hit where its cel is actually drawn (scaled, current
     // position): its ns* props can be stale, since only SetNowSeen updates them.
     const r = g.items.has(obj) ? g.viewRect(obj) : undefined;
-    if (r) return bool(px >= r.x && px < r.x + r.width && py >= r.y && py < r.y + r.height);
+    if (r) {
+      if (!(px >= r.x && px < r.x + r.width && py >= r.y && py < r.y + r.height)) return 0;
+      if (!checkPixels) return 1;
+      const cx = Math.min(r.cel.width - 1, Math.floor((px - r.x) / r.sx));
+      const cy = Math.min(r.cel.height - 1, Math.floor((py - r.y) / r.sy));
+      return bool(r.cel.pixels[cy * r.cel.width + (r.mirror ? r.cel.width - 1 - cx : cx)] !== r.cel.skipColor);
+    }
     return bool(px >= g.prop(obj, "nsLeft") && px <= g.prop(obj, "nsRight") && py >= g.prop(obj, "nsTop") && py <= g.prop(obj, "nsBottom"));
   },
   IsHiRes: () => 0,