scalix 1.0.0 → 1.1.0

package/dist/tools-advanced.js

@@ -3,12 +3,47 @@ import { z } from 'zod';
 import fs from 'node:fs/promises';
 import { sandboxPath } from './sandbox.js';
 import { backgroundProcesses } from './tools.js';
-import { spawnSubAgent } from './sub-agent.js';
+import { spawnSubAgent, spawnParallelAgents } from './sub-agent.js';
 import { logger } from './logger.js';
 import { TOOL_DEFAULTS } from './constants.js';
 import { DEFAULT_LIMITS } from './settings.js';
+import { AgentRegistry } from './agent-registry.js';
+import { TaskBoard } from './task-board.js';
+import { getAgentDefinitions, isBuiltInAgentType } from './agent-definitions.js';
 let _limits = DEFAULT_LIMITS;
 export function setAdvancedToolLimits(limits) { _limits = limits; }
+const BUILT_IN_INSTRUCTIONS = {
+    plan: 'You are a planning assistant. Analyze the codebase and design an implementation approach. Be thorough and specific.',
+    explore: 'You are a code exploration assistant. Search and read files to answer questions. Be concise and factual.',
+    general: 'You are a focused assistant with full capabilities. Complete the task efficiently. You can spawn sub-agents if needed.',
+};
+async function resolveAgentType(subagentType) {
+    const agentType = subagentType || 'general';
+    if (isBuiltInAgentType(agentType)) {
+        const isReadOnly = agentType === 'explore' || agentType === 'plan';
+        return {
+            toolLevel: isReadOnly ? 'read-only' : 'all',
+            isReadOnly,
+            instructions: BUILT_IN_INSTRUCTIONS[agentType] || BUILT_IN_INSTRUCTIONS.general,
+            maxSteps: agentType === 'explore' ? _limits.exploreMaxSteps : _limits.subAgentMaxSteps,
+            allowSpawning: true,
+        };
+    }
+    const definitions = await getAgentDefinitions(process.cwd());
+    const def = definitions.get(agentType);
+    if (!def) {
+        throw new Error(`Unknown agent type "${agentType}". Built-in types: general, explore, plan. Check .scalix/agents/ for custom definitions.`);
+    }
+    return {
+        toolLevel: def.tools,
+        isReadOnly: def.tools === 'read-only',
+        instructions: def.instructions,
+        maxSteps: def.maxSteps ?? _limits.subAgentMaxSteps,
+        model: def.model,
+        allowSpawning: def.allowSpawning ?? true,
+        description: def.description,
+    };
+}
 let currentTodos = [];
 export function getTodos() {
     return [...currentTodos];
@@ -64,6 +99,10 @@ export const notebookEditTool = tool({
     execute: async ({ notebook_path, command, cell_type, cell_number, new_source, position }) => {
         try {
             const safePath = sandboxPath(notebook_path);
+            const stat = await fs.stat(safePath);
+            if (stat.size > TOOL_DEFAULTS.readFileMaxSize) {
+                return { error: `Notebook too large (${Math.round(stat.size / 1024 / 1024)}MB). Max: ${Math.round(TOOL_DEFAULTS.readFileMaxSize / 1024 / 1024)}MB.` };
+            }
             const raw = await fs.readFile(safePath, 'utf-8');
             const notebook = JSON.parse(raw);
             if (notebook.nbformat !== 4) {
@@ -115,7 +154,6 @@ export const notebookEditTool = tool({
                         return { error: `Invalid cell_number: ${cell_number}. Notebook has ${cells.length} cells.` };
                     }
                     const [cell] = cells.splice(cell_number, 1);
-                    // After splice, validate position against the reduced array
                     const maxPos = cells.length;
                     const targetPos = position !== undefined ? Math.min(position, maxPos) : maxPos;
                     cells.splice(targetPos, 0, cell);
@@ -168,65 +206,282 @@ let parentAgentConfig = null;
 export function setAgentToolConfig(config) {
     parentAgentConfig = config;
 }
+function resolveAgentConfig(context) {
+    if (context?.agentConfig)
+        return context.agentConfig;
+    return parentAgentConfig;
+}
 export const agentTool = tool({
     name: 'agent',
-    description: 'Spawn a sub-agent to handle a complex task in parallel or independently. The sub-agent has access to read/write tools but cannot spawn further agents. Returns the sub-agent\'s final response.',
+    description: `Spawn agents for complex tasks. Supports multiple actions:
+- spawn (default): Create a sub-agent to handle a task independently. Sub-agents have full tool access including spawning further agents.
+- message: Send a message to another active agent by ID.
+- spawn_parallel: Spawn multiple agents in parallel. Returns results from all agents.
+- list_agents: List all active and completed agents with their status and resource usage.`,
     inputSchema: z.object({
-        prompt: z.string().min(1).max(10000).describe('The task for the sub-agent to perform'),
-        description: z.string().min(1).max(100).describe('Short description of the task (3-5 words)'),
-        subagent_type: z.enum(['general', 'explore', 'plan']).optional().describe('Agent type: general (read+write), explore (read-only), plan (read-only analysis)'),
+        prompt: z.string().min(1).max(10000).optional().describe('The task for the sub-agent (required for spawn)'),
+        description: z.string().min(1).max(100).optional().describe('Short description of the task (3-5 words)'),
+        subagent_type: z.string().max(50).optional().describe('Agent type: general (full access), explore (read-only), plan (read-only analysis), or a custom type from .scalix/agents/'),
         model: z.string().max(100).optional().describe('Model override for the sub-agent'),
+        action: z.enum(['spawn', 'message', 'spawn_parallel', 'list_agents']).optional().describe('Action to perform (default: spawn)'),
+        target_agent_id: z.string().optional().describe('Target agent ID for message action'),
+        message_content: z.string().max(5000).optional().describe('Message content for message action'),
+        parallel_tasks: z.array(z.object({
+            prompt: z.string().min(1).max(10000),
+            description: z.string().min(1).max(100),
+            subagent_type: z.string().max(50).optional(),
+            model: z.string().max(100).optional(),
+        })).optional().describe('Array of tasks for spawn_parallel action'),
     }),
-    execute: async ({ prompt, description, subagent_type, model }) => {
-        if (!parentAgentConfig) {
-            return { error: 'Agent tool not configured. Parent agent config not set.' };
-        }
-        if (model && !parentAgentConfig.models.includes(model)) {
-            return { error: `Unknown model "${model}". Available: ${parentAgentConfig.models.join(', ')}` };
-        }
-        const isReadOnly = subagent_type === 'explore' || subagent_type === 'plan';
-        const toolLevel = isReadOnly ? 'read-only' : 'standard';
-        // General sub-agents inherit parent's permission mode (capped at 'auto' — never yolo)
-        // Read-only sub-agents always use 'plan' mode
-        let subPermissionMode = 'plan';
-        let subConfirmToolCall;
-        if (!isReadOnly && parentAgentConfig.permissionMode) {
-            const parentMode = parentAgentConfig.permissionMode;
-            subPermissionMode = parentMode === 'yolo' ? 'auto' : parentMode;
-            subConfirmToolCall = parentAgentConfig.confirmToolCall;
-        }
-        logger.info('Spawning sub-agent', { description, type: subagent_type || 'general', permissionMode: subPermissionMode });
-        try {
-            const result = await spawnSubAgent(parentAgentConfig, prompt, {
-                model,
-                tools: toolLevel,
-                permissionMode: subPermissionMode,
-                confirmToolCall: subConfirmToolCall,
-                maxSteps: subagent_type === 'explore' ? _limits.exploreMaxSteps : _limits.subAgentMaxSteps,
-                instructions: subagent_type === 'plan'
-                    ? 'You are a planning assistant. Analyze the codebase and design an implementation approach. Be thorough and specific.'
-                    : subagent_type === 'explore'
-                        ? 'You are a code exploration assistant. Search and read files to answer questions. Be concise and factual.'
-                        : 'You are a focused assistant. Complete the task efficiently. Be concise.',
-                timeout: _limits.agentToolTimeoutMs,
-            });
-            return {
-                description,
-                response: result.response,
-                model: result.model,
-                steps: result.steps,
-                tokenEstimate: result.tokenEstimate,
-            };
-        }
-        catch (error) {
-            return { error: `Sub-agent failed: ${error.message}` };
+    execute: async (args, context) => {
+        const config = resolveAgentConfig(context);
+        const agentId = context?.agentId;
+        const action = args.action || 'spawn';
+        switch (action) {
+            case 'list_agents': {
+                const registry = AgentRegistry.getInstance();
+                const active = registry.listActive();
+                const summary = registry.getUsageSummary();
+                return {
+                    activeAgents: active.length,
+                    totalTokens: summary.totalTokens,
+                    tree: registry.getAgentTree(),
+                    agents: summary.byAgent,
+                };
+            }
+            case 'message': {
+                if (!args.target_agent_id || !args.message_content) {
+                    return { error: 'target_agent_id and message_content are required for message action' };
+                }
+                const registry = AgentRegistry.getInstance();
+                const result = registry.sendMessage(agentId || 'unknown', args.target_agent_id, args.message_content);
+                if ('error' in result)
+                    return result;
+                return { success: true, messageId: result.id, to: args.target_agent_id };
+            }
+            case 'spawn_parallel': {
+                if (!config) {
+                    return { error: 'Agent tool not configured. Parent agent config not set.' };
+                }
+                if (!args.parallel_tasks || args.parallel_tasks.length === 0) {
+                    return { error: 'parallel_tasks array is required for spawn_parallel action' };
+                }
+                const tasks = await Promise.all(args.parallel_tasks.map(async (task) => {
+                    let resolved;
+                    try {
+                        resolved = await resolveAgentType(task.subagent_type);
+                    }
+                    catch (err) {
+                        return { error: `Invalid agent type "${task.subagent_type}": ${err.message}` };
+                    }
+                    const effectiveModel = task.model || resolved.model;
+                    const subPermissionMode = resolved.isReadOnly ? 'plan' : (config.permissionMode ?? 'default');
+                    const subConfirmToolCall = resolved.isReadOnly ? undefined : config.confirmToolCall;
+                    return {
+                        prompt: task.prompt,
+                        description: task.description,
+                        options: {
+                            model: effectiveModel,
+                            tools: resolved.toolLevel,
+                            permissionMode: subPermissionMode,
+                            confirmToolCall: subConfirmToolCall,
+                            allowAgentTool: resolved.allowSpawning,
+                            parentAgentId: agentId,
+                            agentDescription: task.description,
+                            maxSteps: resolved.maxSteps,
+                            instructions: resolved.instructions,
+                            timeout: _limits.agentToolTimeoutMs,
+                        },
+                    };
+                }));
+                const validTasks = tasks.filter((t) => !t.error);
+                const errorTasks = tasks.filter((t) => t.error);
+                if (validTasks.length === 0) {
+                    return { error: 'All parallel tasks failed validation', details: errorTasks };
+                }
+                logger.info('Spawning parallel agents', { count: validTasks.length, skipped: errorTasks.length });
+                const results = await spawnParallelAgents(config, validTasks);
+                const allResults = [
+                    ...errorTasks.map((t, i) => ({
+                        index: i,
+                        description: t.error,
+                        status: 'failed',
+                        error: t.error,
+                    })),
+                    ...results.map((r, i) => {
+                        if (r.status === 'fulfilled') {
+                            return {
+                                index: errorTasks.length + i,
+                                description: validTasks[i].description,
+                                status: 'completed',
+                                response: r.value.response,
+                                model: r.value.model,
+                                steps: r.value.steps,
+                                tokens: r.value.tokenEstimate,
+                                agentId: r.value.agentId,
+                            };
+                        }
+                        return {
+                            index: errorTasks.length + i,
+                            description: validTasks[i].description,
+                            status: 'failed',
+                            error: r.reason?.message || String(r.reason),
+                        };
+                    }),
+                ];
+                return {
+                    total: allResults.length,
+                    results: allResults,
+                };
+            }
+            case 'spawn':
+            default: {
+                if (!config) {
+                    return { error: 'Agent tool not configured. Parent agent config not set.' };
+                }
+                if (!args.prompt) {
+                    return { error: 'prompt is required for spawn action' };
+                }
+                if (!args.description) {
+                    return { error: 'description is required for spawn action' };
+                }
+                let resolved;
+                try {
+                    resolved = await resolveAgentType(args.subagent_type);
+                }
+                catch (err) {
+                    return { error: err.message };
+                }
+                const effectiveModel = args.model || resolved.model;
+                if (effectiveModel && !config.models.includes(effectiveModel)) {
+                    return { error: `Unknown model "${effectiveModel}". Available: ${config.models.join(', ')}` };
+                }
+                let subPermissionMode = resolved.isReadOnly ? 'plan' : (config.permissionMode ?? 'default');
+                let subConfirmToolCall;
+                if (!resolved.isReadOnly) {
+                    subConfirmToolCall = config.confirmToolCall;
+                }
+                logger.info('Spawning sub-agent', {
+                    description: args.description,
+                    type: args.subagent_type || 'general',
+                    permissionMode: subPermissionMode,
+                });
+                try {
+                    const result = await spawnSubAgent(config, args.prompt, {
+                        model: effectiveModel,
+                        tools: resolved.toolLevel,
+                        permissionMode: subPermissionMode,
+                        confirmToolCall: subConfirmToolCall,
+                        allowAgentTool: resolved.allowSpawning,
+                        parentAgentId: agentId,
+                        agentDescription: args.description,
+                        maxSteps: resolved.maxSteps,
+                        instructions: resolved.instructions,
+                        timeout: _limits.agentToolTimeoutMs,
+                    });
+                    return {
+                        description: args.description,
+                        response: result.response,
+                        model: result.model,
+                        steps: result.steps,
+                        tokenEstimate: result.tokenEstimate,
+                        agentId: result.agentId,
+                    };
+                }
+                catch (error) {
+                    return { error: `Sub-agent failed: ${error.message}` };
+                }
+            }
         }
     },
 });
+// ─── Send Message Tool ───
+export const sendMessageTool = tool({
+    name: 'send_message',
+    description: 'Send a message to another active agent by ID. Use this for inter-agent communication and coordination.',
+    inputSchema: z.object({
+        to: z.string().min(1).describe('Target agent ID'),
+        content: z.string().min(1).max(5000).describe('Message content'),
+    }),
+    execute: async ({ to, content }, context) => {
+        const from = context?.agentId || 'unknown';
+        const registry = AgentRegistry.getInstance();
+        const result = registry.sendMessage(from, to, content);
+        if ('error' in result)
+            return result;
+        return { success: true, messageId: result.id, to, from };
+    },
+});
+// ─── Task Board Tools ───
+export const taskCreateTool = tool({
+    name: 'task_create',
+    description: 'Create a new task on the shared task board. Tasks can be claimed and worked on by any agent.',
+    inputSchema: z.object({
+        title: z.string().min(1).max(200).describe('Task title'),
+        description: z.string().max(2000).optional().describe('Detailed task description'),
+    }),
+    execute: async ({ title, description }, context) => {
+        const agentId = context?.agentId || 'unknown';
+        const board = TaskBoard.getInstance();
+        const task = board.create(agentId, title, description);
+        return { success: true, task };
+    },
+});
+export const taskClaimTool = tool({
+    name: 'task_claim',
+    description: 'Claim an open task from the shared task board. Only open tasks can be claimed.',
+    inputSchema: z.object({
+        taskId: z.string().min(1).describe('Task ID to claim'),
+    }),
+    execute: async ({ taskId }, context) => {
+        const agentId = context?.agentId || 'unknown';
+        const board = TaskBoard.getInstance();
+        const result = board.claim(taskId, agentId);
+        if ('error' in result)
+            return result;
+        return { success: true, task: result };
+    },
+});
+export const taskUpdateTool = tool({
+    name: 'task_update',
+    description: 'Update a task\'s status or result on the shared task board. Use to mark tasks as in_progress, completed, or failed.',
+    inputSchema: z.object({
+        taskId: z.string().min(1).describe('Task ID to update'),
+        status: z.enum(['in_progress', 'completed', 'failed']).optional().describe('New task status'),
+        result: z.string().max(5000).optional().describe('Task result or output'),
+    }),
+    execute: async ({ taskId, status, result }, context) => {
+        const agentId = context?.agentId || 'unknown';
+        const board = TaskBoard.getInstance();
+        const updated = board.update(taskId, agentId, { status, result });
+        if ('error' in updated)
+            return updated;
+        return { success: true, task: updated };
+    },
+});
+export const taskListTool = tool({
+    name: 'task_list',
+    description: 'List tasks from the shared task board. Optionally filter by status or assignee.',
+    inputSchema: z.object({
+        status: z.enum(['open', 'claimed', 'in_progress', 'completed', 'failed']).optional().describe('Filter by status'),
+        assignee: z.string().optional().describe('Filter by assignee agent ID'),
+    }),
+    execute: async ({ status, assignee }) => {
+        const board = TaskBoard.getInstance();
+        const tasks = board.list({ status, assignee });
+        const stats = board.getStats();
+        return { tasks, stats };
+    },
+});
 // ─── Export ───
 export const advancedTools = [
     todoWriteTool,
     notebookEditTool,
     monitorTool,
     agentTool,
+    sendMessageTool,
+    taskCreateTool,
+    taskClaimTool,
+    taskUpdateTool,
+    taskListTool,
 ];