scai 0.1.178 → 1.0.0

package/dist/__tests__/agents/agentTools.test.js

@@ -0,0 +1,69 @@
+/**
+ * Covers repo/worktree path guards for the new simple agent tools.
+ *
+ * Why this file exists:
+ * - file reads should stay inside the active execution path
+ * - worktree-relative safety should not silently remap to another checkout
+ * - the shared path resolver should be easy to validate on its own
+ */
+import { describe, expect, it } from "vitest";
+import { createAgentMemory } from "../../agents/agentMemory.js";
+import { resolveAgentRepoFilePath, UnresolvedAgentTargetError, canReadExplicitTarget } from "../../agents/agentTools.js";
+import { buildTools } from "../../agent/tools/index.js";
+import fs from "fs";
+import os from "os";
+import path from "path";
+describe("resolveAgentRepoFilePath", () => {
+    it("rejects canonical repo-root paths outside the active worktree", () => {
+        const memory = createAgentMemory("Explain sample.ts", "/repo", "/repo/.scai-worktrees/feature");
+        expect(() => resolveAgentRepoFilePath(memory, "/repo/src/sample.ts")).toThrow("Path is outside the active repo/worktree");
+    });
+    it("resolves a basename target from one candidate file", () => {
+        const memory = createAgentMemory("Explain index.ts", "/repo", "/repo");
+        memory.evidence.candidateFiles = ["/repo/cli/src/index.ts"];
+        expect(resolveAgentRepoFilePath(memory, "index.ts")).toBe("/repo/cli/src/index.ts");
+        expect(canReadExplicitTarget(memory, "index.ts")).toBe(true);
+    });
+    it("does not silently choose between ambiguous basename candidates", () => {
+        const memory = createAgentMemory("Explain index.ts", "/repo", "/repo");
+        memory.evidence.candidateFiles = ["/repo/cli/src/index.ts", "/repo/web/src/index.ts"];
+        expect(() => resolveAgentRepoFilePath(memory, "index.ts")).toThrow(UnresolvedAgentTargetError);
+        expect(canReadExplicitTarget(memory, "index.ts")).toBe(false);
+    });
+    it("treats an unresolved basename target as not ready for read-file", () => {
+        const memory = createAgentMemory("Explain index.ts", "/repo", "/repo");
+        expect(() => resolveAgentRepoFilePath(memory, "index.ts")).toThrow(UnresolvedAgentTargetError);
+        expect(canReadExplicitTarget(memory, "index.ts")).toBe(false);
+    });
+    it("resolves a partial path target from one candidate suffix match", () => {
+        const memory = createAgentMemory("Explain commands/factory.ts", "/repo", "/repo");
+        memory.evidence.candidateFiles = ["/repo/cli/src/commands/factory.ts"];
+        expect(resolveAgentRepoFilePath(memory, "commands/factory.ts")).toBe("/repo/cli/src/commands/factory.ts");
+        expect(canReadExplicitTarget(memory, "commands/factory.ts")).toBe(true);
+    });
+    it("seeds ranked folder candidates after a successful directory listing", async () => {
+        const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "scai-agent-tools-folder-rank-"));
+        try {
+            const guardsDir = path.join(tempDir, "cli", "src", "agents", "guards");
+            const resolverFile = path.join(guardsDir, "executionPolicyResolver.ts");
+            const guardFile = path.join(guardsDir, "guardState.ts");
+            fs.mkdirSync(guardsDir, { recursive: true });
+            fs.writeFileSync(resolverFile, "export const resolver = true;\n", "utf8");
+            fs.writeFileSync(guardFile, "export const guard = true;\n", "utf8");
+            const memory = createAgentMemory(guardsDir, tempDir, tempDir);
+            memory.task.normalizedQuery = guardsDir;
+            memory.task.primaryIntent = "Explain the guards folder.";
+            memory.task.queryScope = "targeted";
+            memory.task.explicitTargets = [guardsDir];
+            const tools = buildTools();
+            await tools["search-list-directory"].invoke({ folderPath: guardsDir }, memory);
+            expect(memory.evidence.candidateFiles).toEqual(expect.arrayContaining([resolverFile, guardFile]));
+            expect(memory.evidence.candidateMetadata?.[resolverFile]?.searchScore).toBeTypeOf("number");
+            expect(memory.evidence.candidateMetadata?.[guardFile]?.searchScore).toBeTypeOf("number");
+        }
+        finally {
+            fs.rmSync(tempDir, { recursive: true, force: true });
+        }
+    });
+});
+//# sourceMappingURL=agentTools.test.js.map

package/dist/__tests__/agents/agentTools.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agentTools.test.js","sourceRoot":"","sources":["../../../src/__tests__/agents/agentTools.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AACH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAC;AAChE,OAAO,EAAE,wBAAwB,EAAE,0BAA0B,EAAE,qBAAqB,EAAE,MAAM,4BAA4B,CAAC;AACzH,OAAO,EAAE,UAAU,EAAE,MAAM,4BAA4B,CAAC;AACxD,OAAO,EAAE,MAAM,IAAI,CAAC;AACpB,OAAO,EAAE,MAAM,IAAI,CAAC;AACpB,OAAO,IAAI,MAAM,MAAM,CAAC;AAExB,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IACxC,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,MAAM,GAAG,iBAAiB,CAAC,mBAAmB,EAAE,OAAO,EAAE,+BAA+B,CAAC,CAAC;QAEhG,MAAM,CAAC,GAAG,EAAE,CAAC,wBAAwB,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAAC,OAAO,CAC3E,0CAA0C,CAC3C,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,MAAM,GAAG,iBAAiB,CAAC,kBAAkB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACvE,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,wBAAwB,CAAC,CAAC;QAE5D,MAAM,CAAC,wBAAwB,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;QACpF,MAAM,CAAC,qBAAqB,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,MAAM,MAAM,GAAG,iBAAiB,CAAC,kBAAkB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACvE,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,wBAAwB,EAAE,wBAAwB,CAAC,CAAC;QAEtF,MAAM,CAAC,GAAG,EAAE,CAAC,wBAAwB,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;QAC/F,MAAM,CAAC,qBAAqB,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iEAAiE,EAAE,GAAG,EAAE;QACzE,MAAM,MAAM,GAAG,iBAAiB,CAAC,kBAAkB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAEvE,MAAM,CAAC,GAAG,EAAE,CAAC,wBAAwB,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,0BAA0B,CAAC,CAAC;QAC/F,MAAM,CAAC,qBAAqB,CAAC,MAAM,EAAE,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,MAAM,MAAM,GAAG,iBAAiB,CAAC,6BAA6B,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAClF,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,mCAAmC,CAAC,CAAC;QAEvE,MAAM,CAAC,wBAAwB,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAAC,IAAI,CAAC,mCAAmC,CAAC,CAAC;QAC1G,MAAM,CAAC,qBAAqB,CAAC,MAAM,EAAE,qBAAqB,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC1E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,KAAK,IAAI,EAAE;QACnF,MAAM,OAAO,GAAG,EAAE,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,+BAA+B,CAAC,CAAC,CAAC;QACxF,IAAI,CAAC;YACH,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,QAAQ,CAAC,CAAC;YACvE,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,4BAA4B,CAAC,CAAC;YACxE,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,eAAe,CAAC,CAAC;YACxD,EAAE,CAAC,SAAS,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;YAC7C,EAAE,CAAC,aAAa,CAAC,YAAY,EAAE,iCAAiC,EAAE,MAAM,CAAC,CAAC;YAC1E,EAAE,CAAC,aAAa,CAAC,SAAS,EAAE,8BAA8B,EAAE,MAAM,CAAC,CAAC;YAEpE,MAAM,MAAM,GAAG,iBAAiB,CAAC,SAAS,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;YAC9D,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,SAAS,CAAC;YACxC,MAAM,CAAC,IAAI,CAAC,aAAa,GAAG,4BAA4B,CAAC;YACzD,MAAM,CAAC,IAAI,CAAC,UAAU,GAAG,UAAU,CAAC;YACpC,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,CAAC,SAAS,CAAC,CAAC;YAE1C,MAAM,KAAK,GAAG,UAAU,EAAE,CAAC;YAC3B,MAAM,KAAK,CAAC,uBAAuB,CAAC,CAAC,MAAM,CAAC,EAAE,UAAU,EAAE,SAAS,EAAE,EAAE,MAAM,CAAC,CAAC;YAE/E,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC,YAAY,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC;YAClG,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,EAAE,CAAC,YAAY,CAAC,EAAE,WAAW,CAAC,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC;YAC5F,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,EAAE,CAAC,SAAS,CAAC,EAAE,WAAW,CAAC,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC;QAC3F,CAAC;gBAAS,CAAC;YACT,EAAE,CAAC,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QACvD,CAAC;IACH,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Covers repo/worktree path guards for the new simple agent tools.\n *\n * Why this file exists:\n * - file reads should stay inside the active execution path\n * - worktree-relative safety should not silently remap to another checkout\n * - the shared path resolver should be easy to validate on its own\n */\nimport { describe, expect, it } from \"vitest\";\nimport { createAgentMemory } from \"../../agents/agentMemory.js\";\nimport { resolveAgentRepoFilePath, UnresolvedAgentTargetError, canReadExplicitTarget } from \"../../agents/agentTools.js\";\nimport { buildTools } from \"../../agent/tools/index.js\";\nimport fs from \"fs\";\nimport os from \"os\";\nimport path from \"path\";\n\ndescribe(\"resolveAgentRepoFilePath\", () => {\n  it(\"rejects canonical repo-root paths outside the active worktree\", () => {\n    const memory = createAgentMemory(\"Explain sample.ts\", \"/repo\", \"/repo/.scai-worktrees/feature\");\n\n    expect(() => resolveAgentRepoFilePath(memory, \"/repo/src/sample.ts\")).toThrow(\n      \"Path is outside the active repo/worktree\"\n    );\n  });\n\n  it(\"resolves a basename target from one candidate file\", () => {\n    const memory = createAgentMemory(\"Explain index.ts\", \"/repo\", \"/repo\");\n    memory.evidence.candidateFiles = [\"/repo/cli/src/index.ts\"];\n\n    expect(resolveAgentRepoFilePath(memory, \"index.ts\")).toBe(\"/repo/cli/src/index.ts\");\n    expect(canReadExplicitTarget(memory, \"index.ts\")).toBe(true);\n  });\n\n  it(\"does not silently choose between ambiguous basename candidates\", () => {\n    const memory = createAgentMemory(\"Explain index.ts\", \"/repo\", \"/repo\");\n    memory.evidence.candidateFiles = [\"/repo/cli/src/index.ts\", \"/repo/web/src/index.ts\"];\n\n    expect(() => resolveAgentRepoFilePath(memory, \"index.ts\")).toThrow(UnresolvedAgentTargetError);\n    expect(canReadExplicitTarget(memory, \"index.ts\")).toBe(false);\n  });\n\n  it(\"treats an unresolved basename target as not ready for read-file\", () => {\n    const memory = createAgentMemory(\"Explain index.ts\", \"/repo\", \"/repo\");\n\n    expect(() => resolveAgentRepoFilePath(memory, \"index.ts\")).toThrow(UnresolvedAgentTargetError);\n    expect(canReadExplicitTarget(memory, \"index.ts\")).toBe(false);\n  });\n\n  it(\"resolves a partial path target from one candidate suffix match\", () => {\n    const memory = createAgentMemory(\"Explain commands/factory.ts\", \"/repo\", \"/repo\");\n    memory.evidence.candidateFiles = [\"/repo/cli/src/commands/factory.ts\"];\n\n    expect(resolveAgentRepoFilePath(memory, \"commands/factory.ts\")).toBe(\"/repo/cli/src/commands/factory.ts\");\n    expect(canReadExplicitTarget(memory, \"commands/factory.ts\")).toBe(true);\n  });\n\n  it(\"seeds ranked folder candidates after a successful directory listing\", async () => {\n    const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), \"scai-agent-tools-folder-rank-\"));\n    try {\n      const guardsDir = path.join(tempDir, \"cli\", \"src\", \"agents\", \"guards\");\n      const resolverFile = path.join(guardsDir, \"executionPolicyResolver.ts\");\n      const guardFile = path.join(guardsDir, \"guardState.ts\");\n      fs.mkdirSync(guardsDir, { recursive: true });\n      fs.writeFileSync(resolverFile, \"export const resolver = true;\\n\", \"utf8\");\n      fs.writeFileSync(guardFile, \"export const guard = true;\\n\", \"utf8\");\n\n      const memory = createAgentMemory(guardsDir, tempDir, tempDir);\n      memory.task.normalizedQuery = guardsDir;\n      memory.task.primaryIntent = \"Explain the guards folder.\";\n      memory.task.queryScope = \"targeted\";\n      memory.task.explicitTargets = [guardsDir];\n\n      const tools = buildTools();\n      await tools[\"search-list-directory\"].invoke({ folderPath: guardsDir }, memory);\n\n      expect(memory.evidence.candidateFiles).toEqual(expect.arrayContaining([resolverFile, guardFile]));\n      expect(memory.evidence.candidateMetadata?.[resolverFile]?.searchScore).toBeTypeOf(\"number\");\n      expect(memory.evidence.candidateMetadata?.[guardFile]?.searchScore).toBeTypeOf(\"number\");\n    } finally {\n      fs.rmSync(tempDir, { recursive: true, force: true });\n    }\n  });\n});\n"]}