sbuilder-mcp 0.82.2 → 0.82.3

package/CHANGELOG.md

@@ -6,6 +6,12 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.82.3] - 2026-10-10
+
+### Fixed
+- `sb_media_upload` with `url` pins the address check to the connection itself, so a DNS answer that changes between the check and the connect (DNS rebinding) can no longer reach a private or loopback host.
+- `sb_media_upload` with `url` sends a user-agent header when it fetches a file, so CDNs that answer 403 without one now serve the download.
+
 ## [0.82.2] - 2026-10-10
 
 ### Fixed

package/CHANGELOG.vi.md

@@ -6,6 +6,12 @@ Mọi thay đổi đáng chú ý của dự án được ghi lại trong file n
 Định dạng dựa trên [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 và dự án tuân theo [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.82.3] - 2026-10-10
+
+### Fixed
+- `sb_media_upload` với `url` ghim bước kiểm tra địa chỉ vào chính kết nối, nên câu trả lời DNS thay đổi giữa lúc kiểm tra và lúc kết nối (DNS rebinding) không còn dẫn tới host riêng hoặc loopback.
+- `sb_media_upload` với `url` gửi header user-agent khi tải file, nên các CDN trả 403 khi thiếu header này giờ cho tải bình thường.
+
 ## [0.82.2] - 2026-10-10
 
 ### Fixed

package/dist/transport/media.js

@@ -4,6 +4,8 @@ import { guardLocal } from './localfile.js';
 import { basename, extname } from 'node:path';
 import { lookup } from 'node:dns/promises';
 import { BlockList, isIP } from 'node:net';
+import { request as httpRequest } from 'node:http';
+import { request as httpsRequest } from 'node:https';
 import { ApiError } from './http.js';
 import { siteToken } from '../tools/credentialpick.js';
 /**
@@ -140,9 +142,10 @@ async function fromUrl(ctx, siteId, url, source) {
  * checked — a hostname regex is beaten by `[::ffff:127.0.0.1]` or a DNS name that
  * points inward — and a redirect is followed by hand, each hop checked again.
  *
- * ponytail: resolve-then-fetch leaves a DNS-rebinding window between the two
- * lookups; pinning the checked IP into the connection (an undici dispatcher) is the
- * upgrade.
+ * The check is PINNED to the connection: the real fetch goes through node:http(s)
+ * with a `lookup` that checks the very address it hands to the socket, so a DNS
+ * answer that changes between "check" and "connect" (rebinding) still meets the
+ * check. Only an injected `ctx.fetchImpl` (tests) skips that path.
  */
 // No ::ffff:0:0/96 rule: Node's BlockList already applies the IPv4 rules to an
 // IPv4-mapped address, and that rule would match EVERY IPv4 address (measured).
@@ -169,15 +172,56 @@ async function assertPublic(ctx, raw) {
             throw new Error(`sbuilder: could not resolve ${host}.`);
         });
     for (const a of addrs) {
-        if (PRIVATE.check(a, isIP(a) === 6 ? 'ipv6' : 'ipv4'))
+        if (isPrivate(a))
             throw refuse();
     }
 }
-async function fetchPublic(ctx, doFetch, url) {
+const isPrivate = (a) => PRIVATE.check(a, isIP(a) === 6 ? 'ipv6' : 'ipv4');
+/** A `lookup` for node:net that refuses to hand a private address to the socket. */
+export function pinnedLookup(resolve = (h) => lookup(h, { all: true })) {
+    return (host, opts, cb) => {
+        resolve(host).then((addrs) => {
+            if (!addrs.length || addrs.some((a) => isPrivate(a.address))) {
+                cb(new Error('sbuilder: a media url must be a public http(s) address.'));
+            }
+            else if (opts.all)
+                cb(null, addrs);
+            else
+                cb(null, addrs[0].address, addrs[0].family);
+        }, (e) => cb(e));
+    };
+}
+const NULL_BODY = new Set([101, 204, 205, 304]);
+function pinnedFetch(url) {
+    const u = new URL(url);
+    const send = u.protocol === 'https:' ? httpsRequest : httpRequest;
+    return new Promise((resolve, reject) => {
+        // The headers global fetch sends: many CDNs answer 403 to a request with no agent.
+        const headers = { 'user-agent': 'sbuilder-mcp', accept: '*/*' };
+        const req = send(u, { method: 'GET', headers, lookup: pinnedLookup() }, (res) => {
+            const chunks = [];
+            res.on('data', (c) => chunks.push(c));
+            res.on('error', reject);
+            res.on('end', () => {
+                const headers = new Headers();
+                for (const [k, v] of Object.entries(res.headers)) {
+                    if (v !== undefined)
+                        headers.set(k, Array.isArray(v) ? v.join(', ') : v);
+                }
+                const status = res.statusCode ?? 502;
+                resolve(new Response(NULL_BODY.has(status) ? null : Buffer.concat(chunks), { status, headers }));
+            });
+        });
+        req.setTimeout(30_000, () => req.destroy(new Error('sbuilder: the media url timed out.')));
+        req.on('error', reject);
+        req.end();
+    });
+}
+export async function fetchPublic(ctx, doFetch, url) {
     let at = url;
     for (let hop = 0; hop < 4; hop++) {
         await assertPublic(ctx, at);
-        const res = await doFetch(at, { redirect: 'manual' });
+        const res = ctx.fetchImpl ? await doFetch(at, { redirect: 'manual' }) : await pinnedFetch(at);
         const next = res.status >= 300 && res.status < 400 ? res.headers.get('location') : null;
         if (!next)
             return res;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sbuilder-mcp",
-  "version": "0.82.2",
+  "version": "0.82.3",
   "description": "MCP server that designs and operates a Store Builder site — pages, data, theme and publish — through the platform's own API and live-edit protocol.",
   "mcpName": "io.github.vuluu2k/sbuilder-mcp",
   "type": "module",