sbuilder-mcp 0.76.4 → 0.78.0

package/dist/tools/live.js

@@ -2,6 +2,7 @@ import { randomBytes } from 'node:crypto';
 import { z } from 'zod';
 import { text, images } from '../mcp/response.js';
 import { BINDING_SOURCES, ELEMENTS } from '../catalog/elements.generated.js';
+import { bindableFields } from '../domains/site/writecheck.js';
 import { previewUrl } from '../vision/preview.js';
 import { uploadMedia } from '../transport/media.js';
 import { request } from '../transport/http.js';
@@ -26,7 +27,7 @@ import { RealtimeSocket } from '../transport/socket.js';
 import { LiveSession } from '../live/session.js';
 import { refuseAppBlockInterior } from '../domains/site/builder.js';
 import { soft } from '../domains/site/guard.js';
-import { hrefPatches, hasPurchaseBinding, PRODUCT_ACTION_BINDING_ID, } from '../domains/site/navhref.js';
+import { hrefPatches, hasPurchaseBinding, liveEventTable, PAYLOAD_NEEDS, PRODUCT_ACTION_BINDING_ID, } from '../domains/site/navhref.js';
 import { offscreenNodes, offscreenRootOf } from '../domains/site/offscreen.js';
 import { siteToken } from './credentialpick.js';
 import { searchStock, SearchUnavailable, NO_SEARCH_NEXT } from '../transport/stock.js';
@@ -70,6 +71,24 @@ export function bindNode(doc, id, source, field, action, guard) {
         throw new Error(`sbuilder: a binding field must be "specials.<key>", not "${field}". The renderer ignores ` +
             'every other namespace, so the binding would be stored and never applied.');
     }
+    // A FIELD THE ELEMENT NEVER PAINTS. `BOUND_SPECIALS` is read off each
+    // element's html.go, so a `specials.boundImage` binding on a text-dataset is
+    // stored, saved, published and rendered as placeholder text forever. Soft:
+    // the list is the catalog's copy of the renderer. The element's own generated
+    // binding fields count too — `boundProductId` is read by the runtime, not
+    // html.go, and every default product binding carries it.
+    const type = node.data?.type ?? '';
+    const key = field.slice(dot + 1);
+    const allowed = bindableFields(type);
+    if (action === undefined && allowed.length) {
+        if (!allowed.includes(key)) {
+            soft(guard, () => {
+                throw new Error(`sbuilder: a ${type} renders a binding only into ${allowed.map((k) => `specials.${k}`).join(', ')} ` +
+                    `— "${field}" would be stored and never painted. Allowed fields: ${allowed.join(', ')}. ` +
+                    'Bind one of those, or swap to an element that shows this value (sb_catalog_search).');
+            });
+        }
+    }
     // A PURCHASE BINDING, which is what makes a button add to the cart.
     //
     // It is not an ordinary binding and cannot be written as one: the renderer
@@ -109,23 +128,6 @@ export function bindNode(doc, id, source, field, action, guard) {
         },
     ];
 }
-/**
- * The click-action allow-list that is LIVE for this node.
- *
- * `activeEvents` in the platform, whose whole rule is one line in
- * `ActionTrait.vue`: `return action ? def.binding_events : def.events`. A
- * purchase control is a different kind of control — an unbound button navigates,
- * a bound one hands off to the cart or the checkout — and the two sets are
- * mutually exclusive, because "add this product, then go to an arbitrary URL" is
- * not a thing the cart runtime can express.
- */
-function liveEventTable(type, node) {
-    const meta = ELEMENTS[type];
-    if (!meta?.events)
-        return undefined;
-    const bound = (node.bindings ?? []).some((b) => b?.id === PRODUCT_ACTION_BINDING_ID);
-    return (bound && meta.bindingEvents) || meta.events;
-}
 /**
  * Put a click action on a node, or take one off.
  *
@@ -172,7 +174,7 @@ export function setEvent(doc, id, trigger, action, payload, guard) {
             ...project(next),
         ];
     }
-    const table = liveEventTable(node.data.type, node);
+    const table = liveEventTable(doc.doc.nodes, id);
     if (!table) {
         throw new Error(`sbuilder: a ${node.data.type} declares no click actions, so an event on it would be ` +
             'stored and never fired. Elements that do: ' +
@@ -192,6 +194,21 @@ export function setEvent(doc, id, trigger, action, payload, guard) {
                 : '') +
             `Allowed: ${allowed.join(', ')}.`);
     }
+    // A NAVIGATION WITH NOWHERE TO GO. The renderer turns a sole go_to_url /
+    // open_page click into `<a href>` from `payload.url` ALONE (navhref.ts) — an
+    // `open_page` with only a page id projects nothing, since neither renderer
+    // can resolve one — and a `popup` with no `payload.id` publishes a call with
+    // no target that opens nothing. All three store, save and publish clean.
+    const need = PAYLOAD_NEEDS[action];
+    if (need) {
+        const v = (payload ?? {})[need.key];
+        if (typeof v !== 'string' || v === '') {
+            soft(guard, () => {
+                throw new Error(`sbuilder: "${action}" needs payload.${need.key} — without it the click ${need.why}. ` +
+                    `Expected payload: ${need.shape}.`);
+            });
+        }
+    }
     const value = { id: `ev_${action}`, name: trigger, action, payload: payload ?? {} };
     if (at >= 0) {
         const next = events.map((e, i) => (i === at ? value : e));
@@ -258,7 +275,7 @@ export function joinRoom(ctx, session, siteId) {
     const socket = new RealtimeSocket(`${wsBase}/api/realtime/ws?site=${encodeURIComponent(siteId)}`, tokenFn);
     const live = new LiveSession(socket, {
         onRemote: (patches) => session.applyRemote(patches),
-        onDesync: (reason) => session.markStale(reason),
+        onDesync: (reason) => session.roomDesync(reason),
         onSource: (pageId, rev, peerId) => session.sourceSaved(pageId, rev, peerId),
         onMaster: (kind, id, op, rev) => session.masterSaved(kind, id, op, rev),
     });
@@ -661,8 +678,10 @@ export function registerLiveTools(server, ctx, session) {
         const guard = { force, forced: [] };
         const patches = setEvent(d, id, trigger ?? 'click', action, payload, guard);
         const forced = guard.forced.length ? { forced: guard.forced } : {};
-        if (dry_run !== false)
-            return text({ dry_run: true, patches, ...forced });
+        if (dry_run !== false) {
+            const refuse = session.wouldRefuse(patches);
+            return text({ dry_run: true, patches, ...(refuse ? { would_refuse: refuse } : {}), ...forced });
+        }
         await session.applyAndSave(patches);
         return text({ node: id, trigger: trigger ?? 'click', action, rev: d.rev, ...forced });
     });
@@ -692,8 +711,10 @@ export function registerLiveTools(server, ctx, session) {
         const guard = { force, forced: [] };
         const patches = bindNode(d, id, source, field, action, guard);
         const forced = guard.forced.length ? { forced: guard.forced } : {};
-        if (dry_run !== false)
-            return text({ dry_run: true, patches, ...forced });
+        if (dry_run !== false) {
+            const refuse = session.wouldRefuse(patches);
+            return text({ dry_run: true, patches, ...(refuse ? { would_refuse: refuse } : {}), ...forced });
+        }
         await session.applyAndSave(patches);
         return text({ bound: id, source, field, ...(action ? { action } : {}), rev: d.rev, ...forced });
     });

package/dist/tools/overlay.js

@@ -323,7 +323,7 @@ export async function ensureCartDrawer(ctx, session, siteId, dryRun) {
             note: 'Nothing was sent. Re-call with dry_run:false to create it; it shows on every page.',
         };
     }
-    const open = session.peek() ? session.location() : null;
+    const open = session.page();
     const onPage = open?.siteId === siteId;
     if (onPage)
         await session.applyAndSave([]);
@@ -365,7 +365,7 @@ export async function relocalizeCartDrawer(ctx, session, siteId, dryRun) {
     const raw = settings.settings?.locale;
     // No locale means no language to move the WORDS to; the thumbnail needs none.
     const language = typeof raw === 'string' && raw ? cartSeedLocale(raw) : null;
-    const open = session.peek() ? session.location() : null;
+    const open = session.page();
     const composed = open?.siteId === siteId
         ? Object.values(session.current().doc.nodes).find((n) => n.specials?.overlayId === cart.id)
         : undefined;