sbuilder-mcp 0.74.0 → 0.74.1

package/CHANGELOG.md

@@ -6,6 +6,11 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.74.1] - 2026-09-28
+
+### Fixed
+- `sb_review`'s `unreachablePage` gap no longer false-positives on a page that is only linked from the body of another page, such as a "read our story" button on the home page; when a candidate orphan page is found, it now also reads the other published pages' bodies (up to 40) and counts any href found there as reaching it.
+
 ## [0.74.0] - 2026-09-28
 
 ### Added

package/CHANGELOG.vi.md

@@ -6,6 +6,11 @@ Mọi thay đổi đáng chú ý của dự án được ghi lại trong file n
 Định dạng dựa trên [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 và dự án tuân theo [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.74.1] - 2026-09-28
+
+### Fixed
+- Gap `unreachablePage` của `sb_review` không còn báo sai với trang chỉ được liên kết từ thân nội dung của một trang khác, ví dụ nút "đọc câu chuyện" trên trang chủ; khi tìm thấy một trang mồ côi ứng viên, gap giờ đọc thêm thân các trang đã publish khác (tối đa 40 trang) và tính mọi href tìm thấy ở đó là đã tới được trang này.
+
 ## [0.74.0] - 2026-09-28
 
 ### Added

package/dist/domains/site/readiness-fetch.js

@@ -1,5 +1,6 @@
 import { request } from '../../transport/http.js';
 import { siteToken } from '../../tools/credentialpick.js';
+import { hrefsIn, unreachablePages } from './readiness.js';
 /**
  * Gather what the readiness rules need, tolerating every failure.
  *
@@ -138,7 +139,7 @@ export async function gatherReadiness(ctx, siteId, pageNodes, openPageId) {
             return { pageIds, hrefs };
         })()
         : null;
-    return {
+    const input = {
         pages: pageList?.pages ?? null,
         menuLinks,
         openPageType: open && open.isDefaultTemplate !== false ? open.type : undefined,
@@ -167,4 +168,21 @@ export async function gatherReadiness(ctx, siteId, pageNodes, openPageId) {
             ? siteRecord.site.maintenanceMode
             : null,
     };
+    // THE SECOND PASS, PAID ONLY WHEN THE FIRST FOUND A CANDIDATE. A page linked
+    // from the BODY of another page — a "read our story" button on the home
+    // page — is reachable, and neither the menus nor the chrome show it. Reading
+    // every page's document on every review would be one GET per page for a
+    // question that is usually already answered, so the sources are read only
+    // when a page looks unreachable, and only the other published pages' — the
+    // open page's nodes are already in hand. Capped; a source that fails to read
+    // counts as carrying no link.
+    if (input.menuLinks && unreachablePages(input).length > 0) {
+        const others = (input.pages ?? [])
+            .filter((p) => p.status === 'published' && typeof p.id === 'string' && p.id !== openPageId)
+            .slice(0, 40);
+        const sources = await Promise.all(others.map((p) => get(`/api/sites/${site}/pages/${encodeURIComponent(p.id)}/source`)));
+        const nodes = sources.flatMap((src) => Object.values(src?.document?.nodes ?? {}));
+        input.menuLinks.hrefs.push(...hrefsIn(nodes));
+    }
+    return input;
 }

package/dist/domains/site/readiness.js

@@ -81,13 +81,19 @@ const drafted = (pages, type) => pages.some((p) => p.type === type && p.status !
  * different question asked second. Shared chrome is a different question asked
  * FIRST, because it is true of every site and not only of a store.
  */
+/** "N published pages (a, b, c, …)" — the head of a problem sentence that names its pages. */
+function pageCount(rows) {
+    const named = rows.map((p) => p.name).filter((n) => !!n).slice(0, 3);
+    return (`${rows.length} published page${rows.length === 1 ? '' : 's'}` +
+        (named.length ? ` (${named.join(', ')}${rows.length > named.length ? ', …' : ''})` : ''));
+}
 /** "/about/", "/about?x=1" and "/about" are one address; "" is the home page. */
 function normalizePath(p) {
     const s = p.split(/[?#]/)[0].replace(/\/+$/, '');
     return s === '' ? '/' : s;
 }
 /** Every href a set of nodes carries: `specials.href`, and a menu node's own snapshot rows. */
-function hrefsIn(nodes) {
+export function hrefsIn(nodes) {
     const out = new Set();
     const rows = (items) => {
         if (!Array.isArray(items))
@@ -109,6 +115,29 @@ function hrefsIn(nodes) {
     }
     return out;
 }
+/**
+ * Published content pages nothing points at. Reachable means a menu item
+ * references the page or its path, or a node in the shared chrome, on the open
+ * page, or (menuLinks.hrefs, appended by gatherReadiness only when this list
+ * is otherwise non-empty) in the body of any other published page carries its
+ * path as an href. Empty when the menus or the shared sections were unread.
+ */
+export function unreachablePages(input) {
+    const pages = input.pages;
+    if (!pages || !input.menuLinks || !input.globalNodes)
+        return [];
+    const reach = new Set(input.menuLinks.hrefs.map(normalizePath));
+    for (const h of hrefsIn([...input.globalNodes, ...input.pageNodes]))
+        reach.add(h);
+    const byId = new Set(input.menuLinks.pageIds);
+    return pages.filter((p) => p.status === 'published' &&
+        INDEXED_PAGE_TYPES.has(p.type) &&
+        p.isHomepage !== true &&
+        typeof p.id === 'string' &&
+        typeof p.path === 'string' &&
+        !byId.has(p.id) &&
+        !reach.has(normalizePath(p.path)));
+}
 export function readinessGaps(input) {
     const gaps = [];
     const pages = input.pages;
@@ -140,7 +169,7 @@ export function readinessGaps(input) {
             });
         }
     }
-    // A PAGE NO VISITOR CAN GET TO.
+    // A PAGE NO VISITOR CAN GET TO — see unreachablePages().
     //
     // Every tool here authors one page and a menu is a separate record, so a
     // site can carry a published About page that nothing links to: the sitemap
@@ -150,27 +179,15 @@ export function readinessGaps(input) {
     // own snapshot included). Content pages only, never the home page, and only
     // when both the menus and the shared sections were read — a footer link
     // this rule could not see must not become a finding.
-    if (pages && input.menuLinks && input.globalNodes) {
-        const reach = new Set(input.menuLinks.hrefs.map(normalizePath));
-        for (const h of hrefsIn([...input.globalNodes, ...input.pageNodes]))
-            reach.add(h);
-        const byId = new Set(input.menuLinks.pageIds);
-        const orphans = pages.filter((p) => p.status === 'published' &&
-            INDEXED_PAGE_TYPES.has(p.type) &&
-            p.isHomepage !== true &&
-            typeof p.id === 'string' &&
-            typeof p.path === 'string' &&
-            !byId.has(p.id) &&
-            !reach.has(normalizePath(p.path)));
+    {
+        const orphans = unreachablePages(input);
         if (orphans.length > 0) {
-            const named = orphans.map((p) => p.name).filter((n) => !!n).slice(0, 3);
             gaps.push({
                 id: 'unreachablePage',
                 draft: false,
-                problem: `${orphans.length} published page${orphans.length === 1 ? '' : 's'}` +
-                    (named.length ? ` (${named.join(', ')}${orphans.length > named.length ? ', …' : ''})` : '') +
-                    ' that no menu item and no link in the shared header or footer points at. The address ' +
-                    'works and the sitemap lists it; no visitor ever arrives.',
+                problem: pageCount(orphans) +
+                    ' that no menu item and no link in the shared header, footer or any other page ' +
+                    'points at. The address works and the sitemap lists it; no visitor ever arrives.',
                 fix: 'Add it to the site menu — read GET /api/sites/{siteId}/menus, append ' +
                     '{ label, link: { type: "page", pageId } } and PUT the menu back; every bound menu ' +
                     'node follows. Or link it from the footer with sb_event go_to_url. A page kept out ' +
@@ -289,12 +306,10 @@ export function readinessGaps(input) {
             return !(has('title') && has('description'));
         });
         if (bare.length > 0) {
-            const named = bare.map((p) => p.name).filter((n) => !!n).slice(0, 3);
             gaps.push({
                 id: 'pageSeo',
                 draft: false,
-                problem: `${bare.length} published page${bare.length === 1 ? '' : 's'}` +
-                    (named.length ? ` (${named.join(', ')}${bare.length > named.length ? ', …' : ''})` : '') +
+                problem: pageCount(bare) +
                     ' carry no settings.title or settings.description. Each serves the SITE NAME as its ' +
                     '<title> and no meta description — a search result cannot tell them apart, and ' +
                     'nothing on the canvas or in a screenshot shows it.',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sbuilder-mcp",
-  "version": "0.74.0",
+  "version": "0.74.1",
   "description": "MCP server that designs and operates a Store Builder site — pages, data, theme and publish — through the platform's own API and live-edit protocol.",
   "mcpName": "io.github.vuluu2k/sbuilder-mcp",
   "type": "module",