sbuilder-mcp 0.73.0 → 0.74.1

package/CHANGELOG.md

@@ -6,6 +6,16 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.74.1] - 2026-09-28
+
+### Fixed
+- `sb_review`'s `unreachablePage` gap no longer false-positives on a page that is only linked from the body of another page, such as a "read our story" button on the home page; when a candidate orphan page is found, it now also reads the other published pages' bodies (up to 40) and counts any href found there as reaching it.
+
+## [0.74.0] - 2026-09-28
+
+### Added
+- `sb_review` gains an `unreachablePage` readiness gap: since a menu is a record separate from the page it links, a site can publish a page that no menu item and no href in the shared header, footer, or open page points at, so the address resolves and the sitemap lists it while no visitor ever arrives; it checks only published content pages (never the home page) and stays silent until both the menus and the shared sections have been read.
+
 ## [0.73.0] - 2026-09-28
 
 ### Added

package/CHANGELOG.vi.md

@@ -6,6 +6,16 @@ Mọi thay đổi đáng chú ý của dự án được ghi lại trong file n
 Định dạng dựa trên [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 và dự án tuân theo [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.74.1] - 2026-09-28
+
+### Fixed
+- Gap `unreachablePage` của `sb_review` không còn báo sai với trang chỉ được liên kết từ thân nội dung của một trang khác, ví dụ nút "đọc câu chuyện" trên trang chủ; khi tìm thấy một trang mồ côi ứng viên, gap giờ đọc thêm thân các trang đã publish khác (tối đa 40 trang) và tính mọi href tìm thấy ở đó là đã tới được trang này.
+
+## [0.74.0] - 2026-09-28
+
+### Added
+- `sb_review` có thêm gap readiness `unreachablePage`: vì menu là một bản ghi riêng biệt với trang mà nó trỏ tới, một site có thể publish một trang mà không mục menu nào và không href nào trong header/footer dùng chung hay trên trang đang mở trỏ tới, nên địa chỉ vẫn vào được và sitemap vẫn liệt kê trong khi không khách nào tới được; gap này chỉ xét các trang nội dung đã publish (không tính trang chủ) và im lặng cho tới khi cả menu lẫn các section dùng chung đều đã đọc được.
+
 ## [0.73.0] - 2026-09-28
 
 ### Added

package/dist/domains/site/readiness-fetch.js

@@ -1,5 +1,6 @@
 import { request } from '../../transport/http.js';
 import { siteToken } from '../../tools/credentialpick.js';
+import { hrefsIn, unreachablePages } from './readiness.js';
 /**
  * Gather what the readiness rules need, tolerating every failure.
  *
@@ -24,7 +25,7 @@ export async function gatherReadiness(ctx, siteId, pageNodes, openPageId) {
         }
     };
     const site = encodeURIComponent(siteId);
-    const [pageList, gateways, shipping, globals, productList, categoryList, pageLinks, formList, articleList, blogCategoryList, courseList, siteRecord, overlayList, settings] = await Promise.all([
+    const [pageList, gateways, shipping, globals, productList, categoryList, pageLinks, formList, articleList, blogCategoryList, courseList, siteRecord, overlayList, settings, menuList] = await Promise.all([
         get(`/api/sites/${site}/pages`),
         get(`/api/sites/${site}/payment-gateways`),
         get(`/api/sites/${site}/shipping-methods`),
@@ -67,6 +68,9 @@ export async function gatherReadiness(ctx, siteId, pageNodes, openPageId) {
         get(`/api/sites/${site}/overlays`),
         // `<html lang>` is served from this; see siteLanguage in readiness.ts.
         get(`/api/sites/${site}/settings`),
+        // THE MENUS, for what a visitor can reach: a page nothing links to is
+        // published, listed in the sitemap, and never arrived at.
+        get(`/api/sites/${site}/menus`),
     ]);
     // A gateway counts only when it is BOTH enabled and configured — the editor's
     // `live` getter also filters by the store's currency, which is a narrowing:
@@ -111,8 +115,33 @@ export async function gatherReadiness(ctx, siteId, pageNodes, openPageId) {
     // A page an entity links to is that entity's own; only the shared template
     // counts as the category template, and a row without the flag is read as one.
     const open = openPageId ? pageList?.pages?.find((p) => p.id === openPageId) : undefined;
-    return {
+    // Every level of every menu: page references by id, url links by address.
+    const menuLinks = Array.isArray(menuList?.menus)
+        ? (() => {
+            const pageIds = [];
+            const hrefs = [];
+            const walk = (items) => {
+                if (!Array.isArray(items))
+                    return;
+                for (const it of items) {
+                    if (!it || typeof it !== 'object')
+                        continue;
+                    const r = it;
+                    if (r.link?.type === 'page' && typeof r.link.pageId === 'string')
+                        pageIds.push(r.link.pageId);
+                    if (r.link?.type === 'url' && typeof r.link.url === 'string')
+                        hrefs.push(r.link.url);
+                    walk(r.items);
+                }
+            };
+            for (const m of menuList.menus)
+                walk(m?.items);
+            return { pageIds, hrefs };
+        })()
+        : null;
+    const input = {
         pages: pageList?.pages ?? null,
+        menuLinks,
         openPageType: open && open.isDefaultTemplate !== false ? open.type : undefined,
         products,
         liveGateways,
@@ -139,4 +168,21 @@ export async function gatherReadiness(ctx, siteId, pageNodes, openPageId) {
             ? siteRecord.site.maintenanceMode
             : null,
     };
+    // THE SECOND PASS, PAID ONLY WHEN THE FIRST FOUND A CANDIDATE. A page linked
+    // from the BODY of another page — a "read our story" button on the home
+    // page — is reachable, and neither the menus nor the chrome show it. Reading
+    // every page's document on every review would be one GET per page for a
+    // question that is usually already answered, so the sources are read only
+    // when a page looks unreachable, and only the other published pages' — the
+    // open page's nodes are already in hand. Capped; a source that fails to read
+    // counts as carrying no link.
+    if (input.menuLinks && unreachablePages(input).length > 0) {
+        const others = (input.pages ?? [])
+            .filter((p) => p.status === 'published' && typeof p.id === 'string' && p.id !== openPageId)
+            .slice(0, 40);
+        const sources = await Promise.all(others.map((p) => get(`/api/sites/${site}/pages/${encodeURIComponent(p.id)}/source`)));
+        const nodes = sources.flatMap((src) => Object.values(src?.document?.nodes ?? {}));
+        input.menuLinks.hrefs.push(...hrefsIn(nodes));
+    }
+    return input;
 }

package/dist/domains/site/readiness.js

@@ -81,6 +81,63 @@ const drafted = (pages, type) => pages.some((p) => p.type === type && p.status !
  * different question asked second. Shared chrome is a different question asked
  * FIRST, because it is true of every site and not only of a store.
  */
+/** "N published pages (a, b, c, …)" — the head of a problem sentence that names its pages. */
+function pageCount(rows) {
+    const named = rows.map((p) => p.name).filter((n) => !!n).slice(0, 3);
+    return (`${rows.length} published page${rows.length === 1 ? '' : 's'}` +
+        (named.length ? ` (${named.join(', ')}${rows.length > named.length ? ', …' : ''})` : ''));
+}
+/** "/about/", "/about?x=1" and "/about" are one address; "" is the home page. */
+function normalizePath(p) {
+    const s = p.split(/[?#]/)[0].replace(/\/+$/, '');
+    return s === '' ? '/' : s;
+}
+/** Every href a set of nodes carries: `specials.href`, and a menu node's own snapshot rows. */
+export function hrefsIn(nodes) {
+    const out = new Set();
+    const rows = (items) => {
+        if (!Array.isArray(items))
+            return;
+        for (const it of items) {
+            if (!it || typeof it !== 'object')
+                continue;
+            const r = it;
+            if (typeof r.href === 'string' && r.href !== '')
+                out.add(normalizePath(r.href));
+            rows(r.items);
+        }
+    };
+    for (const n of nodes) {
+        const h = n.specials?.href;
+        if (typeof h === 'string' && h !== '')
+            out.add(normalizePath(h));
+        rows(n.specials?.menuItems);
+    }
+    return out;
+}
+/**
+ * Published content pages nothing points at. Reachable means a menu item
+ * references the page or its path, or a node in the shared chrome, on the open
+ * page, or (menuLinks.hrefs, appended by gatherReadiness only when this list
+ * is otherwise non-empty) in the body of any other published page carries its
+ * path as an href. Empty when the menus or the shared sections were unread.
+ */
+export function unreachablePages(input) {
+    const pages = input.pages;
+    if (!pages || !input.menuLinks || !input.globalNodes)
+        return [];
+    const reach = new Set(input.menuLinks.hrefs.map(normalizePath));
+    for (const h of hrefsIn([...input.globalNodes, ...input.pageNodes]))
+        reach.add(h);
+    const byId = new Set(input.menuLinks.pageIds);
+    return pages.filter((p) => p.status === 'published' &&
+        INDEXED_PAGE_TYPES.has(p.type) &&
+        p.isHomepage !== true &&
+        typeof p.id === 'string' &&
+        typeof p.path === 'string' &&
+        !byId.has(p.id) &&
+        !reach.has(normalizePath(p.path)));
+}
 export function readinessGaps(input) {
     const gaps = [];
     const pages = input.pages;
@@ -112,6 +169,32 @@ export function readinessGaps(input) {
             });
         }
     }
+    // A PAGE NO VISITOR CAN GET TO — see unreachablePages().
+    //
+    // Every tool here authors one page and a menu is a separate record, so a
+    // site can carry a published About page that nothing links to: the sitemap
+    // lists it, the address works, and no visitor ever arrives. Reachable means
+    // a menu item references the page or its path, or something in the shared
+    // chrome or on the open page carries its path as an href (a `menu` node's
+    // own snapshot included). Content pages only, never the home page, and only
+    // when both the menus and the shared sections were read — a footer link
+    // this rule could not see must not become a finding.
+    {
+        const orphans = unreachablePages(input);
+        if (orphans.length > 0) {
+            gaps.push({
+                id: 'unreachablePage',
+                draft: false,
+                problem: pageCount(orphans) +
+                    ' that no menu item and no link in the shared header, footer or any other page ' +
+                    'points at. The address works and the sitemap lists it; no visitor ever arrives.',
+                fix: 'Add it to the site menu — read GET /api/sites/{siteId}/menus, append ' +
+                    '{ label, link: { type: "page", pageId } } and PUT the menu back; every bound menu ' +
+                    'node follows. Or link it from the footer with sb_event go_to_url. A page kept out ' +
+                    'on purpose (a landing page for ads) can stay out — say so.',
+            });
+        }
+    }
     // A SITE WITH NO SHARED SECTION IS NOT A SITE, IT IS A STACK OF PAGES.
     //
     // Nothing asked this. Every tool here authors ONE page, so a build that never
@@ -223,12 +306,10 @@ export function readinessGaps(input) {
             return !(has('title') && has('description'));
         });
         if (bare.length > 0) {
-            const named = bare.map((p) => p.name).filter((n) => !!n).slice(0, 3);
             gaps.push({
                 id: 'pageSeo',
                 draft: false,
-                problem: `${bare.length} published page${bare.length === 1 ? '' : 's'}` +
-                    (named.length ? ` (${named.join(', ')}${bare.length > named.length ? ', …' : ''})` : '') +
+                problem: pageCount(bare) +
                     ' carry no settings.title or settings.description. Each serves the SITE NAME as its ' +
                     '<title> and no meta description — a search result cannot tell them apart, and ' +
                     'nothing on the canvas or in a screenshot shows it.',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sbuilder-mcp",
-  "version": "0.73.0",
+  "version": "0.74.1",
   "description": "MCP server that designs and operates a Store Builder site — pages, data, theme and publish — through the platform's own API and live-edit protocol.",
   "mcpName": "io.github.vuluu2k/sbuilder-mcp",
   "type": "module",