sbuilder-mcp 0.46.1 → 0.46.2

package/CHANGELOG.md

@@ -6,6 +6,11 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.46.2] - 2026-09-14
+
+### Fixed
+- A page save that was refused for a reason it did not cause used to still apply and publish its patches locally before the refusal surfaced, so the next successful save on that page silently committed the earlier refused edit as well; a save is now refused before anything is applied whenever it would leave the page still unstorable, while a save that repairs the page's pre-existing problems still goes through.
+
 ## [0.46.1] - 2026-09-14
 
 ### Fixed

package/CHANGELOG.vi.md

@@ -6,6 +6,11 @@ Mọi thay đổi đáng chú ý của dự án được ghi lại trong file n
 Định dạng dựa trên [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 và dự án tuân theo [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.46.2] - 2026-09-14
+
+### Fixed
+- Một lần lưu trang bị từ chối vì lý do nó không gây ra trước đây vẫn áp dụng và publish các patch cục bộ trước khi việc từ chối được báo, nên lần lưu thành công tiếp theo trên trang đó âm thầm gộp luôn cả chỉnh sửa đã bị từ chối trước đó; giờ đây việc lưu bị từ chối trước khi áp dụng bất cứ gì mỗi khi nó khiến trang vẫn không thể lưu được, còn một lần lưu khắc phục được vấn đề đã tồn tại sẵn của trang thì vẫn được thực hiện bình thường.
+
 ## [0.46.1] - 2026-09-14
 
 ### Fixed

package/dist/tools/page.js

@@ -127,12 +127,35 @@ export class PageSession {
     async applyAndSave(patches) {
         const d = this.current();
         const before = new Set(validateForSave(d));
-        const introduced = validateForSave(d.preview(patches)).filter((p) => !before.has(p));
+        const after = validateForSave(d.preview(patches));
+        const introduced = after.filter((p) => !before.has(p));
         if (introduced.length > 0) {
             throw new Error(`sbuilder: refusing to save — ${introduced.join(' ')}`);
         }
+        // AND REFUSE BEFORE APPLYING WHEN THE PAGE STILL CANNOT BE STORED.
+        //
+        // This used to apply, publish, and only then let `save()` discover the
+        // inherited damage — which left the patches in the draft AND on the wire,
+        // so the next save that did pass committed an edit the caller had been told
+        // was refused. MEASURED on a live page: removing an empty section was
+        // refused over four orphans it had nothing to do with, and the next
+        // successful remove then stored a document missing FIVE nodes — the four it
+        // was asked for, plus the section whose removal had been refused.
+        //
+        // `6980ebb` named this exact defect ("a refused write left its patches in
+        // the draft and blamed the next command") and closed half of it: it stopped
+        // the pre-check refusing INHERITED damage, and left the inherited damage
+        // being discovered one step too late.
+        //
+        // An edit that REPAIRS the page still passes, which is what keeps a broken
+        // page editable: `after` is the state this write would leave behind, so a
+        // write that clears the damage leaves it empty and goes through.
+        if (after.length > 0) {
+            throw new Error(`sbuilder: refusing to save — this page already cannot be stored, and this write does ` +
+                `not repair it, so nothing was applied: ${after.join(' ')}`);
+        }
         this.applyAndPublish(patches);
-        await this.save();
+        await this.save(before);
     }
     applyRemote(patches) {
         this.doc?.apply(patches);
@@ -182,7 +205,7 @@ export class PageSession {
      * autosave later means the agent has spent the interval editing a tree nobody
      * will ever store.
      */
-    async save() {
+    async save(inherited = new Set()) {
         if (this.stale) {
             // THE YIELD RULE. The room moved in a way this client cannot reconcile, so
             // it must not write its copy over whatever is there now. Re-pull, and make
@@ -197,7 +220,28 @@ export class PageSession {
         const d = this.current();
         if (d.rev === this.savedRev)
             return;
-        const problems = validateForSave(d);
+        // THE SAME BASELINE `applyAndSave` USES, and the two gates disagreeing is
+        // precisely the defect `6980ebb` named and half-closed.
+        //
+        // That commit — "a refused write left its patches in the draft and blamed
+        // the next command" — taught `applyAndSave` to refuse only what an edit
+        // INTRODUCES, so a page that arrived broken can still be edited. It left
+        // this gate re-deriving the whole list from scratch, so the order became:
+        // applyAndSave passes, `applyAndPublish` APPLIES THE PATCHES LOCALLY, and
+        // then this throws over a problem that was already there. The patches stay
+        // in the draft, and the next save that does pass commits them.
+        //
+        // MEASURED ON A LIVE PAGE. Removing an empty section was refused here over
+        // four orphans it had nothing to do with; the next successful remove then
+        // saved a document missing FIVE nodes — the four it was asked for and the
+        // section whose removal had been refused. `rev: 3` after one command is the
+        // same fact from the other side.
+        //
+        // Rolling back after a failed save was the other candidate and is worse:
+        // `applyAndPublish` has already broadcast the patches over the live socket,
+        // so a local rollback would leave every watching editor showing an edit
+        // this session no longer has.
+        const problems = validateForSave(d).filter((p) => !inherited.has(p));
         if (problems.length > 0) {
             throw new Error(`sbuilder: refusing to save — ${problems.join(' ')}`);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sbuilder-mcp",
-  "version": "0.46.1",
+  "version": "0.46.2",
   "description": "MCP server that designs and operates a Store Builder site — pages, data, theme and publish — through the platform's own API and live-edit protocol.",
   "mcpName": "io.github.vuluu2k/sbuilder-mcp",
   "type": "module",