sbuilder-mcp 0.3.0 → 0.4.1

package/CHANGELOG.md

@@ -6,6 +6,18 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.1] - 2026-09-08
+
+### Fixed
+- sb_review now reports findings inside the cart drawer and other site overlays, tagged with overlay: true, instead of silently skipping them on the belief that an overlay is not the page's to fix; the review notice explains that an overlay:true finding is fixed the same way but is site-wide, so it only needs fixing once.
+- sb_api_call's path_params now matches a parameter name case-insensitively as a fallback, so a call using the common siteId spelling no longer fails against the 8 operations that spell it siteID; an exact match still wins and a genuinely missing parameter is still refused.
+
+## [0.4.0] - 2026-09-08
+
+### Added
+- sb_review reports a catalogue gap when a site has no active products, since every repeater on the site renders its empty state and the product template is bound to nothing on a store that otherwise reports ready.
+- sb_review reports the same catalogue gap when every active product is priced at zero, since a zero-priced product still renders, adds to the cart and totals nothing.
+
 ## [0.3.0] - 2026-09-08
 
 ### Added

package/CHANGELOG.vi.md

@@ -6,6 +6,18 @@ Mọi thay đổi đáng chú ý của dự án được ghi lại trong file n
 Định dạng dựa trên [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 và dự án tuân theo [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.1] - 2026-09-08
+
+### Fixed
+- sb_review giờ báo cáo các finding bên trong cart drawer và các overlay khác của site, gắn cờ overlay: true, thay vì âm thầm bỏ qua chúng vì cho rằng một overlay không phải trách nhiệm của trang; thông báo review giải thích rằng một finding có overlay: true được sửa theo cùng cách nhưng có phạm vi toàn site, nên chỉ cần sửa một lần.
+- path_params của sb_api_call giờ khớp tên tham số không phân biệt hoa thường như một phương án dự phòng, nên một lời gọi dùng cách viết phổ biến siteId không còn thất bại với 8 operation viết là siteID; một khớp chính xác vẫn được ưu tiên và một tham số thực sự thiếu vẫn bị từ chối.
+
+## [0.4.0] - 2026-09-08
+
+### Added
+- sb_review giờ báo cáo gap catalogue khi site chưa có sản phẩm active nào, vì mọi repeater trên site sẽ render trạng thái rỗng và product template không bind vào đâu cả trên một cửa hàng vốn báo cáo là đã sẵn sàng.
+- sb_review giờ báo cáo cùng gap catalogue khi mọi sản phẩm active đều có giá bằng không, vì một sản phẩm giá 0 vẫn render, vẫn thêm được vào giỏ hàng và tổng đơn hàng bằng không.
+
 ## [0.3.0] - 2026-09-08
 
 ### Added

package/dist/domains/site/readiness-fetch.js

@@ -24,11 +24,16 @@ export async function gatherReadiness(ctx, siteId, pageNodes) {
         }
     };
     const site = encodeURIComponent(siteId);
-    const [pageList, gateways, shipping, globals] = await Promise.all([
+    const [pageList, gateways, shipping, globals, productList] = await Promise.all([
         get(`/api/sites/${site}/pages`),
         get(`/api/sites/${site}/payment-gateways`),
         get(`/api/sites/${site}/shipping-methods`),
         get(`/api/sites/${site}/global-sections`),
+        // The SITE-SCOPED list, not /api/v1/products: this one takes either
+        // credential, so the check answers for a session install as well as a
+        // key-only one. A page is enough to tell empty from not; `total` carries the
+        // real count when the platform sends it.
+        get(`/api/sites/${site}/products?limit=200`),
     ]);
     // A gateway counts only when it is BOTH enabled and configured — the editor's
     // `live` getter also filters by the store's currency, which is a narrowing:
@@ -42,8 +47,19 @@ export async function gatherReadiness(ctx, siteId, pageNodes) {
     const globalNodes = globals?.globalSections
         ? globals.globalSections.flatMap((g) => Object.values(g.document?.nodes ?? {}))
         : null;
+    // ACTIVE means a shopper can see it; PURCHASABLE adds a price above zero. A
+    // product priced at zero renders, adds to the cart, and totals nothing — which
+    // reads as a working store right up to the money.
+    const rows = productList?.products;
+    const products = Array.isArray(rows)
+        ? {
+            active: rows.filter((p) => (p.status ?? 'active') === 'active').length,
+            purchasable: rows.filter((p) => (p.status ?? 'active') === 'active' && (p.priceCents ?? 0) > 0).length,
+        }
+        : null;
     return {
         pages: pageList?.pages ?? null,
+        products,
         liveGateways,
         shippingMethods,
         pageNodes,

package/dist/domains/site/readiness.js

@@ -100,6 +100,30 @@ export function readinessGaps(input) {
                 : 'Create a page of type "product" and publish it.',
         });
     }
+    // NOTHING TO SELL. Checked before the delivery option, because a shipping
+    // method for an empty catalogue is furniture.
+    if (input.products) {
+        if (input.products.active === 0) {
+            gaps.push({
+                id: 'catalogue',
+                draft: false,
+                problem: 'The store has no active products. Every product list on the site renders its empty ' +
+                    'state, the product template has nothing to bind to, and there is nothing to add to a ' +
+                    'cart — on a site that otherwise reports ready.',
+                fix: 'Create products (sb_api_find "create product"). priceCents is minor units — VND × 100.',
+            });
+        }
+        else if (input.products.purchasable === 0) {
+            gaps.push({
+                id: 'catalogue',
+                draft: false,
+                problem: `All ${input.products.active} active products are priced at zero. They render, they add ` +
+                    'to the cart, and the order totals nothing — which reads as a working store right up ' +
+                    'to the money.',
+                fix: 'Set priceCents on each product and its variants. Minor units: VND × 100.',
+            });
+        }
+    }
     if (input.shippingMethods === 0) {
         gaps.push({
             id: 'shipping',

package/dist/domains/site/review.js

@@ -12,7 +12,9 @@ import { fill } from './findings.js';
 export const REVIEW_NOTICE = 'FIX THESE. Each one is a defect a visitor will see on the published page, not a ' +
     'suggestion — a blank band, a placeholder sentence, a broken image. Apply the fix each ' +
     'finding names, then review again until the list is empty. Do not report the page as done ' +
-    'while findings stand; if you believe one is a false positive, say which and why.';
+    'while findings stand; if you believe one is a false positive, say which and why. ' +
+    'A finding marked overlay:true is in the cart drawer or a pop-up — fix it the same way ' +
+    '(sb_set lands there), but it is SITE-WIDE, so fix it once rather than once per page.';
 /** The specials keys an element seeds that hold its visible content. */
 function contentKeys(type) {
     const seeded = ELEMENTS[type]?.defaults.specials ?? {};
@@ -56,8 +58,19 @@ function drawsItsOwnContent(type) {
 /**
  * Everything wrong with this page that a person would notice.
  *
- * Overlays are skipped: the cart drawer is composed onto ROOT on read and is not
- * this page's to fix. So is the INSIDE of an app block (trap 5): its
+ * OVERLAYS ARE WALKED, and used not to be — on the stated reasoning that the
+ * cart drawer "is not this page's to fix", which is false. An overlay's content
+ * reaches storage THROUGH THE PAGE SAVE (`overlays/rest/rest.go`: content is
+ * "deliberately NOT written here"), so `sb_set` on a drawer node lands, and the
+ * skip meant nothing ever reported what shipped inside one. Measured: a
+ * rose-and-ink storefront whose drawer carried a static mock row reading
+ * "Product name / 0₫", a duplicate cart list, and English copy — none of it
+ * mentioned by any check, on a site that reviewed clean ten pages running.
+ *
+ * Their findings carry `overlay: true`, because the master is SHARED: without
+ * the flag the same drawer defect reads as ten problems on a ten-page site.
+ *
+ * The INSIDE of an app block is still skipped (trap 5): its
  * placeholders are the app's, and no fix this page could apply would survive a
  * save. The block root itself is still walked — it is a node the page owns and
  * can be an empty container. Findings are ordered by document order so a caller working
@@ -84,10 +97,14 @@ export function reviewDesign(doc) {
     // itself belongs to the scope OUTSIDE it, which is why this is set before the
     // scope for the children is computed.
     const inRepeater = new Map();
-    const go = (id, repeater) => {
-        if (seen.has(id) || overlayIds.has(id))
+    // Which nodes sit inside an overlay, so their findings can say so.
+    const inOverlay = new Set();
+    const go = (id, repeater, overlay = false) => {
+        if (seen.has(id))
             return;
         seen.add(id);
+        if (overlay)
+            inOverlay.add(id);
         walkOrder.push(id);
         if (repeater)
             inRepeater.set(id, repeater);
@@ -95,7 +112,7 @@ export function reviewDesign(doc) {
             return;
         const inner = repeats(d.nodes[id]?.data.type ?? '') ? (repeater ?? id) : repeater;
         for (const k of childrenOf(d, id))
-            go(k, inner);
+            go(k, inner, overlay || overlayIds.has(k));
     };
     go(d.root_node_id);
     for (const id of walkOrder) {
@@ -301,5 +318,12 @@ export function reviewDesign(doc) {
             }
         }
     }
+    // Tagged in ONE place rather than at eight push sites: whether a node sits
+    // inside an overlay is a fact about where it is, not about what is wrong with
+    // it, and threading it through every rule would put the same argument in eight
+    // signatures.
+    for (const f of out)
+        if (inOverlay.has(f.nodeId))
+            f.overlay = true;
     return out;
 }

package/dist/tools/api.js

@@ -171,7 +171,19 @@ export async function callOperation(ctx, args) {
     let path = op.path;
     for (const m of op.path.matchAll(/\{([^}]+)\}/g)) {
         const name = m[1];
-        const value = args.path_params?.[name];
+        // CASE-INSENSITIVE, because the platform spells one parameter two ways:
+        // `{siteId}` in 281 operations and `{siteID}` in 8. A caller who learned the
+        // common spelling passes the wrong key on those eight and is refused for a
+        // difference of one letter — a distinction no reader of the call sheet has
+        // any reason to notice, and one this tool has nothing to gain by enforcing.
+        // The exact name still wins; the fold is only a fallback.
+        const given = args.path_params ?? {};
+        let value = given[name];
+        if (value === undefined) {
+            const folded = Object.keys(given).find((k) => k.toLowerCase() === name.toLowerCase());
+            if (folded !== undefined)
+                value = given[folded];
+        }
         if (value === undefined) {
             // NAME THE ARGUMENT, not just the parameter. The call sheet lists these
             // under `params` while the call takes them in `path_params`, and a caller

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sbuilder-mcp",
-  "version": "0.3.0",
+  "version": "0.4.1",
   "description": "MCP server that designs and operates a Store Builder site — pages, data, theme and publish — through the platform's own API and live-edit protocol.",
   "mcpName": "io.github.vuluu2k/sbuilder-mcp",
   "type": "module",