savepoint 1.0.4 → 1.0.7

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/E14-Audit.md

@@ -1,267 +0,0 @@
----
-type: audit-findings
-audited: 2026-05-05
----
-
-# Audit Findings: E14 Structural Improvements
-
-## Main Findings
-
-Audit proposals were applied and E14 is closed as audited. The board model is grouped into focused embedded state structs, dead board helpers were removed, board and doctor now use consumer-side data-access interfaces, doctor orphan traversal goes through `Discover.ListRootDirs`, audit tab hidden-section filtering uses exact heading matches, `TaskStatus` has been removed in favor of the canonical column/status values, and shared Go test fixtures now live in `internal/testutil`.
-
-The shell tokenizer follow-up was applied: empty quoted arguments such as `-run ""` are preserved, trailing backslashes are retained, and the branch tests were added. Router state was advanced to `epic-design` for `E15-hardening`, `E14-Detail.md` now has `status: audited`, and `.savepoint/Design.md` has `last_audited: v1.1/E14-structural-improvements`.
-
-All seven task files include `## Context Files`; no `## Drift Notes` sections were found. The remaining review note is that `package.json` contains a version bump outside the explicit E14 task scope; it was left untouched as apparent release housekeeping.
-
-## Code Style Review
-
-- [x] One job per file - E14 keeps production responsibilities in board/data/doctor and moves shared test fixtures to `internal/testutil`.
-- [x] One job per function - the touched functions remain small and named around a single behavior.
-- [x] Test branches - `splitCommand` now covers empty quoted arguments and trailing escapes.
-- [x] Types are documentation - consumer-side interfaces and `ColumnType` document the intended contracts.
-- [x] Build, don't speculate - the implementation maps to the listed audit findings.
-- [x] Errors at boundaries - data discovery and quality-gate execution continue returning boundary errors.
-- [x] One source of truth - task status constants are consolidated under `ColumnType`.
-- [x] Comments explain WHY - new comments describe contracts or compatibility, not line-by-line mechanics.
-- [x] Content in data files - no new product copy is embedded in logic.
-- [ ] Small diffs - residual note: the `package.json` version bump remains outside the E14 task scope and was left untouched.
-
-## Proposed Changes
-
-### Target File
-internal/doctor/gates.go
-
-### Replace
-```go
-func splitCommand(command string) []string {
-	var parts []string
-	current := strings.Builder{}
-	inDoubleQuote := false
-	inSingleQuote := false
-
-	for i := 0; i < len(command); i++ {
-		c := command[i]
-
-		if inSingleQuote {
-			if c == '\'' {
-				inSingleQuote = false
-			} else {
-				current.WriteByte(c)
-			}
-			continue
-		}
-
-		if inDoubleQuote {
-			if c == '\\' && i+1 < len(command) {
-				next := command[i+1]
-				if next == '"' || next == '\\' || next == '$' || next == '`' {
-					i++
-					current.WriteByte(command[i])
-					continue
-				}
-			}
-			if c == '"' {
-				inDoubleQuote = false
-				continue
-			}
-			current.WriteByte(c)
-			continue
-		}
-
-		if c == '\\' && i+1 < len(command) {
-			i++
-			current.WriteByte(command[i])
-			continue
-		}
-		if c == '"' {
-			inDoubleQuote = true
-			continue
-		}
-		if c == '\'' {
-			inSingleQuote = true
-			continue
-		}
-		if c == ' ' {
-			if current.Len() > 0 {
-				parts = append(parts, current.String())
-				current.Reset()
-			}
-			continue
-		}
-		current.WriteByte(c)
-	}
-	if current.Len() > 0 {
-		parts = append(parts, current.String())
-	}
-	return parts
-}
-```
-
-### With
-```go
-func splitCommand(command string) []string {
-	var parts []string
-	current := strings.Builder{}
-	inDoubleQuote := false
-	inSingleQuote := false
-	tokenStarted := false
-
-	flush := func() {
-		if tokenStarted || current.Len() > 0 {
-			parts = append(parts, current.String())
-			current.Reset()
-			tokenStarted = false
-		}
-	}
-
-	for i := 0; i < len(command); i++ {
-		c := command[i]
-
-		if inSingleQuote {
-			tokenStarted = true
-			if c == '\'' {
-				inSingleQuote = false
-			} else {
-				current.WriteByte(c)
-			}
-			continue
-		}
-
-		if inDoubleQuote {
-			tokenStarted = true
-			if c == '\\' && i+1 < len(command) {
-				next := command[i+1]
-				if next == '"' || next == '\\' || next == '$' || next == '`' {
-					i++
-					current.WriteByte(command[i])
-					continue
-				}
-			}
-			if c == '"' {
-				inDoubleQuote = false
-				continue
-			}
-			current.WriteByte(c)
-			continue
-		}
-
-		switch c {
-		case '\\':
-			tokenStarted = true
-			if i+1 < len(command) {
-				i++
-				current.WriteByte(command[i])
-			} else {
-				current.WriteByte(c)
-			}
-		case '"':
-			tokenStarted = true
-			inDoubleQuote = true
-		case '\'':
-			tokenStarted = true
-			inSingleQuote = true
-		case ' ', '\t', '\n', '\r':
-			flush()
-		default:
-			tokenStarted = true
-			current.WriteByte(c)
-		}
-	}
-	flush()
-	return parts
-}
-```
-
-### Target File
-internal/doctor/gates_test.go
-
-### Replace
-```go
-		{"echo 'hello world'", []string{"echo", "hello world"}},
-		{"echo \"hello \\\"world\\\"\"", []string{"echo", "hello \"world\""}},
-		{"echo hello\\ world", []string{"echo", "hello world"}},
-		{"echo 'it''s'", []string{"echo", "its"}},
-		{"", nil},
-```
-
-### With
-```go
-		{"echo 'hello world'", []string{"echo", "hello world"}},
-		{"echo \"hello \\\"world\\\"\"", []string{"echo", "hello \"world\""}},
-		{"echo hello\\ world", []string{"echo", "hello world"}},
-		{"echo 'it''s'", []string{"echo", "its"}},
-		{"go test -run \"\" ./...", []string{"go", "test", "-run", "", "./..."}},
-		{"printf ''", []string{"printf", ""}},
-		{"echo trailing\\", []string{"echo", "trailing\\"}},
-		{"", nil},
-```
-
-### Target File
-.savepoint/router.md
-
-### Replace
-```yaml
-epic: E14
-```
-
-### With
-```yaml
-epic: E14-structural-improvements
-```
-
-### Target File
-.savepoint/Design.md
-
-### Replace
-```md
-- **Audit remediation baseline** (v1.1 E13) centralizes frontmatter/body splitting and line-ending normalization in `internal/data`, uses typed sentinel errors for doctor repair suggestions, applies a configurable `quality_gates.gate_timeout`, removes tracked build artifacts from source control, adds `.golangci.yml`, and moves board filesystem reads/writes behind Bubble Tea command messages while preserving direct file I/O inside command helpers.
-- **Agent audit workflow** is skill-driven, not a CLI pipeline. At `audit-pending`, a fresh audit agent writes one epic-local `E##-Audit.md`; the user reviews its Audit tab, then asks an agent to apply the admin proposal blocks, update the visible audit findings to reflect the applied outcome, and close the epic.
-```
-
-### With
-```md
-- **Audit remediation baseline** (v1.1 E13) centralizes frontmatter/body splitting and line-ending normalization in `internal/data`, uses typed sentinel errors for doctor repair suggestions, applies a configurable `quality_gates.gate_timeout`, removes tracked build artifacts from source control, adds `.golangci.yml`, and moves board filesystem reads/writes behind Bubble Tea command messages while preserving direct file I/O inside command helpers.
-- **Structural improvement baseline** (v1.1 E14) groups board `Model` fields into focused embedded state structs, defines consumer-side board/doctor data-access interfaces, routes doctor orphan discovery through `Discover.ListRootDirs`, renders audit-tab hidden sections via exact heading matches, improves quality-gate shell tokenization for quoted and escaped arguments, removes the separate `TaskStatus` enum in favor of `ColumnType`, and adds `internal/testutil` for shared Go test fixtures.
-- **Agent audit workflow** is skill-driven, not a CLI pipeline. At `audit-pending`, a fresh audit agent writes one epic-local `E##-Audit.md`; the user reviews its Audit tab, then asks an agent to apply the admin proposal blocks, update the visible audit findings to reflect the applied outcome, and close the epic.
-```
-
-### Target File
-AGENTS.md
-
-### Replace
-```md
-| `internal/data/` | Task/router models, frontmatter parsing/splitting, lifecycle validation/defaulting, discovery, canonical write helpers |
-| `internal/styles/` | Atari-Noir palette, TUI styles |
-```
-
-### With
-```md
-| `internal/data/` | Task/router models, frontmatter parsing/splitting, lifecycle validation/defaulting, discovery including root-dir traversal, unified task status constants, canonical write helpers |
-| `internal/testutil/` | Shared Go test fixtures and filesystem helpers for internal package tests |
-| `internal/styles/` | Atari-Noir palette, TUI styles |
-```
-
-### Target File
-.savepoint/releases/v1.1/epics/E14-structural-improvements/E14-Detail.md
-
-### Replace
-```md
-**Out of scope:**
-- New UI features or commands
-- Audit Phase 3 hardening items (separate epic E15)
-```
-
-### With
-```md
-**Out of scope:**
-- New UI features or commands
-- Audit Phase 3 hardening items (separate epic E15)
-
-## Implemented As
-
-- `Model` grouping landed as embedded state structs in `internal/board/model.go`, preserving existing call sites while separating view, data, navigation, epic, release, and data-access state.
-- Consumer-side interfaces landed in `internal/board/interfaces.go` and `internal/doctor/interfaces.go`; concrete `internal/data` types satisfy them without data-layer changes.
-- `TaskStatus` was removed. `ColumnType` is the canonical task lifecycle type, while `data.Task.Status` remains a string mirror for parsed frontmatter and board glyph compatibility.
-- `internal/testutil` was added for shared test filesystem and fixture helpers across board, doctor, data, and init tests.
-- Audit follow-up before close: preserve empty quoted shell arguments in `splitCommand` and normalize router epic from `E14` to `E14-structural-improvements`.
-```

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/E14-Detail.md

@@ -1,54 +0,0 @@
----
-type: epic-design
-status: audited
----
-
-# E14: Phase 2 — Structural Improvements
-
-## Purpose
-
-Address the remaining Phase 2 findings from the consolidated codebase audit (Opus 4.6 + GLM 5.1) that were not covered by E13: model decomposition, consumer-side interfaces, and structural Medium/Low items flagged by both audits.
-
-## What this epic adds
-
-- Model fields grouped into focused sub-structs for maintainability
-- Consumer-side interfaces for data-access types enabling test mocking
-- Discover-based traversal in CheckOrphans replacing raw os.ReadDir
-- Exact heading matching in epic_panel replacing fragile substrings
-- Improved shell tokenization with quote/escape support
-- Consolidated ColumnType/TaskStatus enumeration removing syncTaskStatus
-- Shared testutil package reducing fixture duplication
-
-## Components
-
-| Module | Purpose |
-|--------|---------|
-| `internal/board/model.go` | Group Model fields into sub-structs |
-| `internal/board/board.go` | Remove newProgramModel and loadAllTasks dead code |
-| `internal/board/` + `internal/doctor/` | Introduce consumer-side interfaces |
-| `internal/data/discover.go` | Add ListRootDirs method |
-| `internal/data/task.go` | Unify ColumnType/TaskStatus |
-| `internal/board/transitions.go` | Remove syncTaskStatus |
-| `internal/board/epic_panel.go` | Replace substring heading matching |
-| `internal/doctor/gates.go` | Improve splitCommand tokenizer |
-| `internal/doctor/checks.go` | Route CheckOrphans through Discover |
-| `internal/testutil/` | New package for shared test fixtures |
-
-## Boundaries
-
-**In scope:**
-- All Phase 2 audit findings not covered by E13 (Model grouping, interfaces)
-- Medium/Low audit findings that fit the structural theme (M4, M7, M9, L1, L9)
-- Dead code removal (M2, L3)
-
-**Out of scope:**
-- New UI features or commands
-- Audit Phase 3 hardening items (separate epic E15)
-
-## Implemented As
-
-- `Model` grouping landed as embedded state structs in `internal/board/model.go`, preserving existing call sites while separating view, data, navigation, epic, release, and data-access state.
-- Consumer-side interfaces landed in `internal/board/interfaces.go` and `internal/doctor/interfaces.go`; concrete `internal/data` types satisfy them without data-layer changes.
-- `TaskStatus` was removed. `ColumnType` is the canonical task lifecycle type, while `data.Task.Status` remains a string mirror for parsed frontmatter and board glyph compatibility.
-- `internal/testutil` was added for shared test filesystem and fixture helpers across board, doctor, data, and init tests.
-- Audit closeout preserved empty quoted shell arguments in `splitCommand` and advanced the router to `E15-hardening`.

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T001-group-model.md

@@ -1,39 +0,0 @@
----
-id: E14-structural-improvements/T001-group-model
-status: done
-objective: Group the 27-field Model struct into focused sub-structs; delete newProgramModel and loadAllTasks
-depends_on: []
----
-
-# T001: Group Model Fields Into Sub-structs and Remove Dead Code
-
-## Context Files
-
-- `internal/board/model.go` — Model struct with 27 flat fields
-- `internal/board/board.go:32-34` — newProgramModel with hardcoded slug
-- `internal/board/board.go:125-128` — loadAllTasks dead wrapper
-- `internal/board/board_test.go:13` — references newProgramModel
-
-## Acceptance Criteria
-
-- [x] Model fields grouped into sub-structs (e.g. ViewConfig, NavigationState, DataState)
-- [x] newProgramModel() removed from board.go
-- [x] loadAllTasks() removed from board.go
-- [x] board_test.go updated to not reference removed functions
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Identify logical field groups in Model struct
-- [x] Extract sub-struct type definitions
-- [x] Update all field references across the board package
-- [x] Delete newProgramModel() and loadAllTasks()
-- [x] Update board_test.go to construct Model directly
-- [x] Run `make build && make test`
-
-## Context Log
-
-- Files read: `.savepoint/router.md`, `.savepoint/releases/v1.1/epics/E14-structural-improvements/E14-Detail.md`, `.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T001-group-model.md`, `agent-skills/savepoint-build-task/SKILL.md`, `internal/board/model.go`, `internal/board/board.go`, `internal/board/board_test.go`
-- Files edited: `.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T001-group-model.md`, `internal/board/model.go`, `internal/board/board.go`, `internal/board/board_test.go`
-- Tokens used: approximately 16k
-- Quality gates: `make build` passed; `make test` passed. Initial sandboxed runs hit Go build-cache access errors, then passed with approved escalation.

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T002-data-interfaces.md

@@ -1,42 +0,0 @@
----
-id: E14-structural-improvements/T002-data-interfaces
-status: done
-objective: Define consumer-side interfaces for stateless data types and accept them in board/doctor constructors
-depends_on: []
----
-
-# T002: Extract Consumer-Side Interfaces for Data-Access Types
-
-## Context Files
-
-- `internal/data/discover.go` — NewDiscover() returns *Discover
-- `internal/data/parser.go` — NewParser() returns *Parser
-- `internal/data/config.go` — NewConfigReader() returns *ConfigReader
-- `internal/data/router.go` — NewRouterReader() returns *RouterReader
-- `internal/board/board.go` — calls data.NewDiscover() directly
-- `internal/doctor/checks.go` — calls data.NewDiscover() directly
-- `internal/board/model.go` — NewModel() signature
-
-## Acceptance Criteria
-
-- [x] Consumer-side interfaces defined for taskDiscoverer, taskParser, configReader, routerReader
-- [x] board.NewModel() accepts interfaces instead of calling constructors directly
-- [x] doctor.CheckXxx functions accept interfaces instead of calling constructors directly
-- [x] Existing concrete types satisfy the interfaces with no changes to internal/data
-- [x] Tests can inject mock implementations
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Define interfaces in board/types.go or at each consumer site
-- [x] Update NewModel signature to accept interfaces with zero-value defaults
-- [x] Update CheckOrphans, CheckDependencies, CheckRouter signatures
-- [x] Add doc comments documenting the interface contracts
-- [x] Run `make build && make test`
-
-## Context Log
-
-- Files read: `internal/data/discover.go`, `internal/data/parser.go`, `internal/data/config.go`, `internal/data/router.go`, `internal/board/board.go`, `internal/doctor/checks.go`, `internal/board/model.go`, related board/doctor tests.
-- Files edited: `internal/board/interfaces.go`, `internal/board/model.go`, `internal/board/board.go`, `internal/board/tui.go`, `internal/board/io.go`, `internal/board/update.go`, `internal/board/watch.go`, `internal/board/interfaces_test.go`, `internal/doctor/interfaces.go`, `internal/doctor/checks.go`, `internal/doctor/gates.go`, `internal/doctor/interfaces_test.go`.
-- Token estimate: ~18k.
-- Quality gates: `go test ./internal/board ./internal/doctor` passed; `make build && make test` passed (`go test ./...` all packages).

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T003-discover-orphans.md

@@ -1,33 +0,0 @@
----
-id: E14-structural-improvements/T003-discover-orphans
-status: done
-objective: Add ListRootDirs to Discover and use it in CheckOrphans instead of direct os.ReadDir
-depends_on: []
----
-
-# T003: Route CheckOrphans Through Discover
-
-## Context Files
-
-- `internal/doctor/checks.go:488-514` — CheckOrphans uses os.ReadDir directly
-- `internal/data/discover.go` — existing ListReleases, ListEpics, ListTasks methods
-
-## Acceptance Criteria
-
-- [x] ListRootDirs(releasesPath string) ([]string, error) added to Discover
-- [x] CheckOrphans uses data.Discover for filesystem traversal
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Add ListRootDirs method to Discover in discover.go
-- [x] Add tests for ListRootDirs in discover_test.go
-- [x] Refactor CheckOrphans to use Discover instead of os.ReadDir
-- [x] Run `make build && make test`
-
-## Context Log
-
-- Files read: `internal/doctor/checks.go`, `internal/data/discover.go`, `internal/data/discover_test.go`, `internal/doctor/interfaces.go`.
-- Files edited: `internal/data/discover.go`, `internal/data/discover_test.go`, `internal/doctor/interfaces.go`, `internal/doctor/interfaces_test.go`, `internal/doctor/checks.go`.
-- Token estimate: ~8k.
-- Quality gates: `go test ./internal/data ./internal/doctor` passed; `make build && make test` passed (`go test ./...` all packages).

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T004-epic-panel-headings.md

@@ -1,35 +0,0 @@
----
-id: E14-structural-improvements/T004-epic-panel-headings
-status: done
-objective: Replace substring heading matching in epic_panel with exact heading match and configurable blocklist
-depends_on: []
----
-
-# T004: Replace Ad-hoc Heading Matching in epic_panel
-
-## Context Files
-
-- `internal/board/epic_panel.go:131-136` — substring heading detection in epicAuditBody
-
-## Acceptance Criteria
-
-- [x] Heading filtering uses exact match against a blocklist (not substring)
-- [x] Blocklist is configurable via a named variable
-- [x] Existing behavior preserved for all known audit headings
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Identify current substring logic and blocklist
-- [x] Replace with exact heading matching
-- [x] Rename/restructure the blocklist variable
-- [x] Update tests if applicable
-- [x] Run `make build && make test`
-
-## Context Log
-
-- Files read: `internal/board/epic_panel.go`, `internal/board/epic_panel_test.go`.
-- Files edited: `internal/board/epic_panel.go`, `internal/board/epic_panel_test.go`.
-- Token estimate: ~6k.
-- Quality gates: `go test ./internal/board` passed; `make build && make test` passed (`go test ./...` all packages).
-- TUI note: could not press `p` from the agent environment; router already points at this task as current priority.

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T005-shell-tokenization.md

@@ -1,27 +0,0 @@
----
-id: E14-structural-improvements/T005-shell-tokenization
-status: done
-objective: Improve splitCommand to handle single quotes and backslash-escapes, or document limitations
-depends_on: []
----
-
-# T005: Improve Shell Tokenization in Gates
-
-## Context Files
-
-- `internal/doctor/gates.go:125` — splitCommand function (naïve shell tokenizer)
-
-## Acceptance Criteria
-
-- [x] splitCommand handles single-quote grouping or limitation is documented
-- [x] splitCommand handles backslash-escaped characters or limitation is documented
-- [x] Existing double-quote handling preserved
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Review current splitCommand implementation
-- [x] Add single-quote parsing
-- [x] Add backslash-escape handling
-- [x] Update existing tests and add new test cases
-- [x] Run `make build && make test`

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T006-unify-enums.md

@@ -1,29 +0,0 @@
----
-id: E14-structural-improvements/T006-unify-enums
-status: done
-objective: Consolidate ColumnType and TaskStatus into a single status type and remove syncTaskStatus
-depends_on: []
----
-
-# T006: Unify ColumnType and TaskStatus Enumerations
-
-## Context Files
-
-- `internal/data/task.go:13-36` — ColumnType and TaskStatus parallel definitions
-- `internal/board/transitions.go:57-59` — syncTaskStatus manually syncs both enums
-- Multiple consumer files reference Task.Status or Task.Column
-
-## Acceptance Criteria
-
-- [x] ColumnType and TaskStatus consolidated into a single type
-- [x] syncTaskStatus removed from transitions.go
-- [x] All consumer references updated
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Choose the surviving type (ColumnType has wider usage)
-- [x] Merge TaskStatus constants into ColumnType
-- [x] Remove syncTaskStatus and inline any callers
-- [x] Update all references across the codebase
-- [x] Run `make build && make test`

package/.savepoint/releases/v1.1/epics/E14-structural-improvements/tasks/T007-testutil-package.md

@@ -1,28 +0,0 @@
----
-id: E14-structural-improvements/T007-testutil-package
-status: done
-objective: Create internal/testutil with shared fixtures to reduce duplication across board/doctor/data/init tests
-depends_on: []
----
-
-# T007: Consolidate Test Helpers Into Testutil Package
-
-## Context Files
-
-- All test files across internal/board, internal/doctor, internal/data, internal/init
-- Common fixture patterns: temp directory creation, task file writing, config scaffolding
-
-## Acceptance Criteria
-
-- [x] internal/testutil package created
-- [x] Common fixture helpers extracted and shared
-- [x] All existing tests still pass after refactoring to use shared helpers
-- [x] No unnecessary exports in the public API
-- [x] `go test ./...` passes with no regressions
-
-## Implementation Plan
-
-- [x] Survey existing test helpers for duplication patterns
-- [x] Create internal/testutil with shared fixture functions
-- [x] Refactor each test package to use shared helpers
-- [x] Run `make build && make test`