savepoint 1.0.4 → 1.0.6

package/internal/data/config_test.go

@@ -1,122 +0,0 @@
-package data
-
-import (
-	"os"
-	"testing"
-)
-
-func TestConfigReaderDefault(t *testing.T) {
-	r := NewConfigReader()
-	config, err := r.Read("nonexistent.yml")
-	if err != nil {
-		t.Fatalf("Read() error = %v", err)
-	}
-
-	if config.Theme.BG != defaultTheme.BG {
-		t.Errorf("Theme.BG = %v, want %v", config.Theme.BG, defaultTheme.BG)
-	}
-}
-
-func TestConfigReaderRead(t *testing.T) {
-	content := `theme:
-  bg: "#000000"
-  surface: "#111111"
-  text: "#ffffff"
-  accents:
-    planned: "#222222"
-`
-	tmpfile, err := os.CreateTemp("", "config-*.yml")
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer os.Remove(tmpfile.Name())
-
-	if _, err := tmpfile.Write([]byte(content)); err != nil {
-		t.Fatal(err)
-	}
-	tmpfile.Close()
-
-	r := NewConfigReader()
-	config, err := r.Read(tmpfile.Name())
-	if err != nil {
-		t.Fatalf("Read() error = %v", err)
-	}
-
-	if config.Theme.BG != "#000000" {
-		t.Errorf("Theme.BG = %v, want #000000", config.Theme.BG)
-	}
-	if config.Theme.Surface2 != defaultTheme.Surface2 {
-		t.Errorf("Theme.Surface2 = %v, want default %v", config.Theme.Surface2, defaultTheme.Surface2)
-	}
-	if config.Theme.Accents["planned"] != "#222222" {
-		t.Errorf("Theme.Accents[planned] = %v, want #222222", config.Theme.Accents["planned"])
-	}
-}
-
-func TestFillThemeDefaults_PartialAccents(t *testing.T) {
-	theme := Theme{
-		BG:      "#000000",
-		Accents: map[string]string{"planned": "#ff0000"},
-	}
-	result := fillThemeDefaults(theme)
-	if result.Accents["planned"] != "#ff0000" {
-		t.Errorf("Accents[planned] = %v, want #ff0000 (user value preserved)", result.Accents["planned"])
-	}
-	if result.Accents["in_progress"] != defaultTheme.Accents["in_progress"] {
-		t.Errorf("Accents[in_progress] = %v, want default %v", result.Accents["in_progress"], defaultTheme.Accents["in_progress"])
-	}
-	if result.Accents["done"] != defaultTheme.Accents["done"] {
-		t.Errorf("Accents[done] = %v, want default %v", result.Accents["done"], defaultTheme.Accents["done"])
-	}
-	if result.Accents["blocked"] != defaultTheme.Accents["blocked"] {
-		t.Errorf("Accents[blocked] = %v, want default %v", result.Accents["blocked"], defaultTheme.Accents["blocked"])
-	}
-	if result.Accents["epic"] != defaultTheme.Accents["epic"] {
-		t.Errorf("Accents[epic] = %v, want default %v", result.Accents["epic"], defaultTheme.Accents["epic"])
-	}
-}
-
-func TestFillThemeDefaults_NilAccents(t *testing.T) {
-	theme := Theme{
-		BG:      "#000000",
-		Accents: nil,
-	}
-	result := fillThemeDefaults(theme)
-	for k, v := range defaultTheme.Accents {
-		if result.Accents[k] != v {
-			t.Errorf("Accents[%s] = %v, want default %v", k, result.Accents[k], v)
-		}
-	}
-}
-
-func TestFillThemeDefaults_EmptyAccents(t *testing.T) {
-	theme := Theme{
-		BG:      "#000000",
-		Accents: map[string]string{},
-	}
-	result := fillThemeDefaults(theme)
-	for k, v := range defaultTheme.Accents {
-		if result.Accents[k] != v {
-			t.Errorf("Accents[%s] = %v, want default %v", k, result.Accents[k], v)
-		}
-	}
-}
-
-func TestConfigReaderMalformedYAML(t *testing.T) {
-	tmpfile, err := os.CreateTemp("", "config-*.yml")
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer os.Remove(tmpfile.Name())
-
-	if _, err := tmpfile.Write([]byte("theme: [broken")); err != nil {
-		t.Fatal(err)
-	}
-	tmpfile.Close()
-
-	r := NewConfigReader()
-	_, err = r.Read(tmpfile.Name())
-	if err == nil {
-		t.Fatal("Read() expected malformed YAML error")
-	}
-}

package/internal/data/discover.go

@@ -1,178 +0,0 @@
-package data
-
-import (
-	"fmt"
-	"os"
-	"path/filepath"
-	"sort"
-	"strings"
-)
-
-type ReleaseInfo struct {
-	ID    string
-	Path  string
-	Epics []EpicInfo
-}
-
-type EpicInfo struct {
-	ID    string
-	Path  string
-	Tasks []TaskInfo
-}
-
-type TaskInfo struct {
-	ID   string
-	Path string
-}
-
-type Discover struct{}
-
-func NewDiscover() *Discover {
-	return &Discover{}
-}
-
-func (d *Discover) FindSavepointRoot(start string) (string, error) {
-	dir, err := filepath.Abs(start)
-	if err != nil {
-		return "", err
-	}
-
-	for {
-		savepointPath := filepath.Join(dir, ".savepoint")
-		info, err := os.Stat(savepointPath)
-		if err == nil && info.IsDir() {
-			return savepointPath, nil
-		}
-
-		parent := filepath.Dir(dir)
-		if parent == dir {
-			return "", ErrSavepointDirectoryMissing
-		}
-		dir = parent
-	}
-}
-
-func (d *Discover) ListReleases(root string) ([]ReleaseInfo, error) {
-	releasesPath := filepath.Join(root, "releases")
-	info, err := os.Stat(releasesPath)
-	if err != nil {
-		return nil, fmt.Errorf("releases directory not found: %w", err)
-	}
-	if !info.IsDir() {
-		return nil, fmt.Errorf("releases is not a directory")
-	}
-
-	entries, err := os.ReadDir(releasesPath)
-	if err != nil {
-		return nil, err
-	}
-
-	var releases []ReleaseInfo
-	for _, entry := range entries {
-		if !entry.IsDir() {
-			continue
-		}
-		id := entry.Name()
-		releases = append(releases, ReleaseInfo{
-			ID:   id,
-			Path: filepath.Join(releasesPath, id),
-		})
-	}
-
-	sort.Slice(releases, func(i, j int) bool {
-		return releases[i].ID < releases[j].ID
-	})
-	return releases, nil
-}
-
-// ListRootDirs returns sorted child directory names directly under root.
-func (d *Discover) ListRootDirs(root string) ([]string, error) {
-	info, err := os.Stat(root)
-	if err != nil {
-		return nil, err
-	}
-	if !info.IsDir() {
-		return nil, fmt.Errorf("%s is not a directory", root)
-	}
-
-	entries, err := os.ReadDir(root)
-	if err != nil {
-		return nil, err
-	}
-
-	var dirs []string
-	for _, entry := range entries {
-		if entry.IsDir() {
-			dirs = append(dirs, entry.Name())
-		}
-	}
-
-	sort.Strings(dirs)
-	return dirs, nil
-}
-
-func (d *Discover) ListEpics(root, release string) ([]EpicInfo, error) {
-	epicsPath := filepath.Join(root, "releases", release, "epics")
-	info, err := os.Stat(epicsPath)
-	if err != nil {
-		return nil, fmt.Errorf("epics directory not found: %w", err)
-	}
-	if !info.IsDir() {
-		return nil, fmt.Errorf("epics is not a directory")
-	}
-
-	entries, err := os.ReadDir(epicsPath)
-	if err != nil {
-		return nil, err
-	}
-
-	var epics []EpicInfo
-	for _, entry := range entries {
-		if !entry.IsDir() || strings.HasPrefix(entry.Name(), "_") {
-			continue
-		}
-		id := entry.Name()
-		epics = append(epics, EpicInfo{
-			ID:   id,
-			Path: filepath.Join(epicsPath, id),
-		})
-	}
-
-	sort.Slice(epics, func(i, j int) bool {
-		return epics[i].ID < epics[j].ID
-	})
-	return epics, nil
-}
-
-func (d *Discover) ListTasks(root, release, epic string) ([]TaskInfo, error) {
-	tasksPath := filepath.Join(root, "releases", release, "epics", epic, "tasks")
-	info, err := os.Stat(tasksPath)
-	if err != nil {
-		return nil, fmt.Errorf("tasks directory not found: %w", err)
-	}
-	if !info.IsDir() {
-		return nil, fmt.Errorf("tasks is not a directory")
-	}
-
-	entries, err := os.ReadDir(tasksPath)
-	if err != nil {
-		return nil, err
-	}
-
-	var tasks []TaskInfo
-	for _, entry := range entries {
-		if entry.IsDir() || filepath.Ext(entry.Name()) != ".md" {
-			continue
-		}
-		id := entry.Name()[:len(entry.Name())-3]
-		tasks = append(tasks, TaskInfo{
-			ID:   id,
-			Path: filepath.Join(tasksPath, entry.Name()),
-		})
-	}
-
-	sort.Slice(tasks, func(i, j int) bool {
-		return tasks[i].ID < tasks[j].ID
-	})
-	return tasks, nil
-}

package/internal/data/discover_test.go

@@ -1,130 +0,0 @@
-package data
-
-import (
-	"path/filepath"
-	"testing"
-
-	"github.com/opencode/savepoint/internal/testutil"
-)
-
-func TestFindSavepointRoot(t *testing.T) {
-	d := NewDiscover()
-	savepointRoot := createDiscoveryFixture(t)
-	start := filepath.Join(filepath.Dir(savepointRoot), "nested", "child")
-	testutil.MkdirAll(t, start)
-
-	root, err := d.FindSavepointRoot(start)
-	if err != nil {
-		t.Fatalf("FindSavepointRoot() error = %v", err)
-	}
-	if root != savepointRoot {
-		t.Errorf("FindSavepointRoot() = %v, want %v", root, savepointRoot)
-	}
-}
-
-func TestListReleases(t *testing.T) {
-	d := NewDiscover()
-	root := createDiscoveryFixture(t)
-
-	releases, err := d.ListReleases(root)
-	if err != nil {
-		t.Fatalf("ListReleases() error = %v", err)
-	}
-
-	if len(releases) != 2 {
-		t.Fatalf("ListReleases() returned %d releases, want 2", len(releases))
-	}
-	if releases[0].ID != "v1" || releases[1].ID != "v2" {
-		t.Errorf("ListReleases() IDs = %v, want [v1 v2]", []string{releases[0].ID, releases[1].ID})
-	}
-}
-
-func TestListRootDirs(t *testing.T) {
-	d := NewDiscover()
-	root := t.TempDir()
-	testutil.MkdirAll(t, filepath.Join(root, "beta"))
-	testutil.MkdirAll(t, filepath.Join(root, "alpha"))
-	testutil.WriteFile(t, filepath.Join(root, "notes.txt"), "test")
-
-	dirs, err := d.ListRootDirs(root)
-	if err != nil {
-		t.Fatalf("ListRootDirs() error = %v", err)
-	}
-
-	if len(dirs) != 2 || dirs[0] != "alpha" || dirs[1] != "beta" {
-		t.Fatalf("ListRootDirs() = %v, want [alpha beta]", dirs)
-	}
-}
-
-func TestListRootDirsRejectsFile(t *testing.T) {
-	d := NewDiscover()
-	root := t.TempDir()
-	path := filepath.Join(root, "not-dir")
-	testutil.WriteFile(t, path, "test")
-
-	_, err := d.ListRootDirs(path)
-	if err == nil {
-		t.Fatal("ListRootDirs() error = nil, want not directory error")
-	}
-}
-
-func TestListEpics(t *testing.T) {
-	d := NewDiscover()
-	root := createDiscoveryFixture(t)
-
-	epics, err := d.ListEpics(root, "v1")
-	if err != nil {
-		t.Fatalf("ListEpics() error = %v", err)
-	}
-
-	if len(epics) != 2 {
-		t.Fatalf("ListEpics() returned %d epics, want 2", len(epics))
-	}
-	if epics[0].ID != "E01-go-setup" || epics[1].ID != "E02-data-readers" {
-		t.Errorf("ListEpics() IDs = %v, want [E01-go-setup E02-data-readers]", []string{epics[0].ID, epics[1].ID})
-	}
-}
-
-func TestListTasks(t *testing.T) {
-	d := NewDiscover()
-	root := createDiscoveryFixture(t)
-
-	tasks, err := d.ListTasks(root, "v1", "E02-data-readers")
-	if err != nil {
-		t.Fatalf("ListTasks() error = %v", err)
-	}
-
-	if len(tasks) != 2 {
-		t.Fatalf("ListTasks() returned %d tasks, want 2", len(tasks))
-	}
-	if tasks[0].ID != "T001-task-struct" || tasks[1].ID != "T002-frontmatter-parser" {
-		t.Errorf("ListTasks() IDs = %v, want [T001-task-struct T002-frontmatter-parser]", []string{tasks[0].ID, tasks[1].ID})
-	}
-}
-
-func createDiscoveryFixture(t *testing.T) string {
-	t.Helper()
-
-	root := t.TempDir()
-	savepointRoot := filepath.Join(root, ".savepoint")
-	paths := []string{
-		filepath.Join(savepointRoot, "releases", "v1", "epics", "E02-data-readers", "tasks"),
-		filepath.Join(savepointRoot, "releases", "v1", "epics", "E01-go-setup", "tasks"),
-		filepath.Join(savepointRoot, "releases", "v1", "epics", "_archived"),
-		filepath.Join(savepointRoot, "releases", "v2", "epics"),
-	}
-	for _, path := range paths {
-		testutil.MkdirAll(t, path)
-	}
-
-	files := []string{
-		filepath.Join(savepointRoot, "releases", "v1", "epics", "E02-data-readers", "tasks", "T002-frontmatter-parser.md"),
-		filepath.Join(savepointRoot, "releases", "v1", "epics", "E02-data-readers", "tasks", "T001-task-struct.md"),
-		filepath.Join(savepointRoot, "releases", "v1", "epics", "E02-data-readers", "tasks", "notes.txt"),
-	}
-	for _, file := range files {
-		testutil.WriteFile(t, file, "test")
-	}
-
-	return savepointRoot
-}

package/internal/data/errors.go

@@ -1,13 +0,0 @@
-package data
-
-import "errors"
-
-var (
-	ErrNoFrontmatter             = errors.New("no frontmatter found")
-	ErrNoClosingFrontmatter      = errors.New("no closing frontmatter delimiter found")
-	ErrSavepointDirectoryMissing = errors.New(".savepoint directory not found")
-	ErrInvalidStatus             = errors.New("invalid router state")
-	ErrMissingFrontmatter        = errors.New("missing or invalid frontmatter")
-	ErrConfigNotFound            = errors.New("configuration file not found")
-	ErrStructureProblem          = errors.New("project structure problem")
-)

package/internal/data/fuzz_test.go

@@ -1,75 +0,0 @@
-package data
-
-import (
-	"testing"
-)
-
-func FuzzExtractFrontmatter(f *testing.F) {
-	seeds := []string{
-		"---\nid: E01/T001\nstatus: planned\n---\nbody",
-		"---\n---\n",
-		"---\n\n---\n",
-		"---\nid: test\n---",
-		"",
-		"# no frontmatter",
-		"---\nid: [broken\n---\n",
-		"---\nname: héllo wörld\n---\n",
-		"---\nid: test\nstatus: in_progress\nphase: build\n---\nbody content",
-		"---\r\nid: test\r\n---\r\nbody",
-	}
-	for _, s := range seeds {
-		f.Add(s)
-	}
-	f.Fuzz(func(t *testing.T, content string) {
-		_, _ = extractFrontmatter(content)
-	})
-}
-
-func FuzzParseFrontmatter(f *testing.F) {
-	seeds := []string{
-		"---\nid: E01/T001\nstatus: planned\n---\nbody",
-		"---\n---\n",
-		"---\nid: [broken\n---\n",
-		"---\nname: héllo\n---\n",
-		"",
-		"no frontmatter",
-		"---\ntags: [a, b, c]\n---\n",
-		"---\nnested:\n  key: val\n---\n",
-	}
-	for _, s := range seeds {
-		f.Add(s)
-	}
-	f.Fuzz(func(t *testing.T, content string) {
-		p := NewParser()
-		_, _ = p.ParseFrontmatter(content)
-	})
-}
-
-func FuzzSplitFrontmatterBody(f *testing.F) {
-	seeds := []string{
-		"---\nid: E01/T001\nstatus: planned\n---\nbody",
-		"---\n---\n",
-		"---\nkey: value\n---",
-		"",
-		"# no frontmatter",
-		"---\nid: test\nstatus: in_progress\n---\n\n## Section\n\nContent.",
-		"---\nid: test\n---\n\nbody with unicode: 日本語",
-	}
-	for _, s := range seeds {
-		f.Add(s)
-	}
-	f.Fuzz(func(t *testing.T, content string) {
-		yamlStr, body, err := SplitFrontmatterBody(content)
-		if err != nil {
-			return
-		}
-		reconstructed := "---\n" + yamlStr + "\n---" + body
-		_, body2, err2 := SplitFrontmatterBody(reconstructed)
-		if err2 != nil {
-			t.Errorf("round-trip SplitFrontmatterBody failed on reconstructed: %v", err2)
-		}
-		if body2 != body {
-			t.Errorf("round-trip body mismatch: got %q, want %q", body2, body)
-		}
-	})
-}

package/internal/data/lifecycle.go

@@ -1,44 +0,0 @@
-package data
-
-import "fmt"
-
-func ValidateTaskLifecycle(task *Task) error {
-	if !IsCanonicalColumn(task.Column) {
-		return fmt.Errorf("invalid status %q: use planned, in_progress, or done. Add 'status: planned' or 'status: in_progress' to task frontmatter", task.Column)
-	}
-
-	if task.Column == ColumnInProgress {
-		if task.Stage == "" {
-			task.Stage = StageBuild
-			return nil
-		}
-		if !IsCanonicalStage(task.Stage) {
-			return fmt.Errorf("invalid phase %q: use build, test, or audit. Add 'phase: build' to task frontmatter", task.Stage)
-		}
-		return nil
-	}
-
-	if task.Stage != "" {
-		return fmt.Errorf("phase field %q is only valid when status is in_progress. Remove 'phase' or change status to in_progress", task.Stage)
-	}
-
-	return nil
-}
-
-func IsCanonicalColumn(value ColumnType) bool {
-	switch value {
-	case ColumnPlanned, ColumnInProgress, ColumnDone:
-		return true
-	default:
-		return false
-	}
-}
-
-func IsCanonicalStage(value ProgressStage) bool {
-	switch value {
-	case StageBuild, StageTest, StageAudit:
-		return true
-	default:
-		return false
-	}
-}

package/internal/data/lifecycle_test.go

@@ -1,41 +0,0 @@
-package data
-
-import "testing"
-
-func TestValidateTaskLifecycle_allowsPlannedWithoutPhase(t *testing.T) {
-	task := Task{Column: ColumnPlanned}
-	if err := ValidateTaskLifecycle(&task); err != nil {
-		t.Fatalf("ValidateTaskLifecycle() error = %v", err)
-	}
-}
-
-func TestValidateTaskLifecycle_defaultsInProgressWithoutPhase(t *testing.T) {
-	task := Task{Column: ColumnInProgress}
-	if err := ValidateTaskLifecycle(&task); err != nil {
-		t.Fatalf("ValidateTaskLifecycle() error = %v", err)
-	}
-	if task.Stage != StageBuild {
-		t.Fatalf("Task.Stage = %q, want %q", task.Stage, StageBuild)
-	}
-}
-
-func TestValidateTaskLifecycle_allowsInProgressWithPhase(t *testing.T) {
-	task := Task{Column: ColumnInProgress, Stage: StageAudit}
-	if err := ValidateTaskLifecycle(&task); err != nil {
-		t.Fatalf("ValidateTaskLifecycle() error = %v", err)
-	}
-}
-
-func TestValidateTaskLifecycle_rejectsUnknownStatus(t *testing.T) {
-	task := Task{Column: "review"}
-	if err := ValidateTaskLifecycle(&task); err == nil {
-		t.Fatal("ValidateTaskLifecycle() expected unknown status error")
-	}
-}
-
-func TestValidateTaskLifecycle_rejectsPhaseOutsideInProgress(t *testing.T) {
-	task := Task{Column: ColumnPlanned, Stage: StageBuild}
-	if err := ValidateTaskLifecycle(&task); err == nil {
-		t.Fatal("ValidateTaskLifecycle() expected phase/status error")
-	}
-}