savepoint 1.0.2 → 1.0.4

package/internal/board/column_test.go

@@ -1,6 +1,7 @@
 package board
 
 import (
+	"fmt"
 	"strings"
 	"testing"
 
@@ -118,12 +119,15 @@ func TestRenderColumn_viewportShowsScrollIndicators(t *testing.T) {
 	if !strings.Contains(got, "↑ 1 above") {
 		t.Error("RenderColumn missing above indicator")
 	}
-	if !strings.Contains(got, "↓ 1 more") {
-		t.Error("RenderColumn missing more indicator")
+	if !strings.Contains(got, "↓ 2 more") {
+		t.Errorf("RenderColumn missing more indicator, got:\n%s", got)
 	}
 	if strings.Contains(got, "Task one") {
 		t.Error("RenderColumn should not render tasks above viewport")
 	}
+	if strings.Contains(got, "Task three") {
+		t.Error("RenderColumn should not render tasks that don't fit budget")
+	}
 	if strings.Contains(got, "Task four") {
 		t.Error("RenderColumn should not render tasks below viewport")
 	}
@@ -134,3 +138,73 @@ func TestVisibleColumnTaskLimitDefaultsToFourAtStandardHeight(t *testing.T) {
 		t.Errorf("visibleColumnTaskLimit(standard height) = %d, want 4", got)
 	}
 }
+
+func BenchmarkRenderColumn_empty(b *testing.B) {
+	b.ReportAllocs()
+	for b.Loop() {
+		RenderColumn(nil, data.ColumnPlanned, 30, 20, 0, 0, false, nil)
+	}
+}
+
+func BenchmarkRenderColumn_fewTasks(b *testing.B) {
+	tasks := []data.Task{
+		{ID: "E06/T001", Title: "First task", Column: data.ColumnPlanned, Stage: data.StageBuild},
+		{ID: "E06/T002", Title: "Second task", Column: data.ColumnPlanned, Stage: data.StageTest},
+		{ID: "E06/T003", Title: "Third task", Column: data.ColumnPlanned, Stage: data.StageAudit},
+	}
+	b.ReportAllocs()
+	for b.Loop() {
+		RenderColumn(tasks, data.ColumnPlanned, 30, 20, 0, 0, false, nil)
+	}
+}
+
+func BenchmarkRenderColumn_manyTasks(b *testing.B) {
+	tasks := make([]data.Task, 20)
+	stages := []data.ProgressStage{data.StageBuild, data.StageTest, data.StageAudit}
+	for i := range tasks {
+		tasks[i] = data.Task{
+			ID:      fmt.Sprintf("E06/T%03d", i+1),
+			Title:   fmt.Sprintf("Task number %d with a reasonable length title", i+1),
+			Column:  data.ColumnPlanned,
+			Stage:   stages[i%3],
+			Release: "v1.1",
+		}
+	}
+	b.ReportAllocs()
+	for b.Loop() {
+		RenderColumn(tasks, data.ColumnPlanned, 40, 24, 0, 0, false, nil)
+	}
+}
+
+func BenchmarkRenderColumn_focused(b *testing.B) {
+	tasks := []data.Task{
+		{ID: "E06/T001", Title: "First task", Column: data.ColumnInProgress, Stage: data.StageBuild},
+		{ID: "E06/T002", Title: "Second task", Column: data.ColumnInProgress, Stage: data.StageTest},
+		{ID: "E06/T003", Title: "Third task", Column: data.ColumnInProgress, Stage: data.StageAudit},
+	}
+	router := &data.RouterState{Release: "v1", Epic: "E06", Task: "T001"}
+	b.ReportAllocs()
+	for b.Loop() {
+		RenderColumn(tasks, data.ColumnInProgress, 40, 20, 0, 0, true, router)
+	}
+}
+
+func TestRenderColumn_focusedLastTaskVisibleWhenScrolled(t *testing.T) {
+	// When scrolled (offset > 0) the top scroll indicator steals 1 line.
+	// The focused last-in-page task must still appear, not be cut off.
+	tasks := []data.Task{
+		{ID: "T1", Title: "Task one", Column: data.ColumnPlanned},
+		{ID: "T2", Title: "Task two", Column: data.ColumnPlanned},
+		{ID: "T3", Title: "Task three", Column: data.ColumnPlanned},
+		{ID: "T4", Title: "Task four", Column: data.ColumnPlanned},
+		{ID: "T5", Title: "Task five", Column: data.ColumnPlanned},
+	}
+	// offset=2, focusedTask=4 (last task), maxHeight=14 (24-line terminal)
+	got := RenderColumn(tasks, data.ColumnPlanned, 30, 14, 2, 4, true, nil)
+	if !strings.Contains(got, "Task five") {
+		t.Errorf("focused last task must be visible when scrolled, got:\n%s", got)
+	}
+	if !strings.Contains(got, "↑") {
+		t.Error("scroll indicator above must appear when offset > 0")
+	}
+}

package/internal/board/debug.go

@@ -0,0 +1,26 @@
+package board
+
+import (
+	"fmt"
+	"os"
+	"sync/atomic"
+)
+
+var debugEnabled atomic.Bool
+
+// SetDebug enables or disables debug logging for the board package.
+func SetDebug(enabled bool) {
+	debugEnabled.Store(enabled)
+}
+
+// DebugEnabled reports whether debug logging is active.
+func DebugEnabled() bool {
+	return debugEnabled.Load()
+}
+
+func debugf(format string, args ...any) {
+	if !debugEnabled.Load() {
+		return
+	}
+	fmt.Fprintf(os.Stderr, "[savepoint debug] "+format+"\n", args...)
+}

package/internal/board/debug_test.go

@@ -0,0 +1,108 @@
+package board
+
+import (
+	"bytes"
+	"fmt"
+	"io"
+	"os"
+	"strings"
+	"testing"
+)
+
+func TestSetDebugToggle(t *testing.T) {
+	t.Cleanup(func() { SetDebug(false) })
+
+	if DebugEnabled() {
+		t.Fatal("debug should be off by default")
+	}
+
+	SetDebug(true)
+	if !DebugEnabled() {
+		t.Fatal("debug should be on after SetDebug(true)")
+	}
+
+	SetDebug(false)
+	if DebugEnabled() {
+		t.Fatal("debug should be off after SetDebug(false)")
+	}
+}
+
+func TestDebugfWritesToStderr(t *testing.T) {
+	t.Cleanup(func() { SetDebug(false) })
+
+	r, w, err := os.Pipe()
+	if err != nil {
+		t.Fatal(err)
+	}
+	orig := os.Stderr
+	os.Stderr = w
+
+	SetDebug(true)
+	debugf("test message %d", 42)
+
+	os.Stderr = orig
+	w.Close()
+
+	var buf bytes.Buffer
+	io.Copy(&buf, r)
+	r.Close()
+
+	out := buf.String()
+	if !strings.Contains(out, "test message 42") {
+		t.Fatalf("expected debug output, got: %q", out)
+	}
+	if !strings.Contains(out, "[savepoint debug]") {
+		t.Fatalf("expected debug prefix, got: %q", out)
+	}
+}
+
+func TestDebugfSilentWhenDisabled(t *testing.T) {
+	t.Cleanup(func() { SetDebug(false) })
+
+	r, w, err := os.Pipe()
+	if err != nil {
+		t.Fatal(err)
+	}
+	orig := os.Stderr
+	os.Stderr = w
+
+	SetDebug(false)
+	debugf("should not appear")
+
+	os.Stderr = orig
+	w.Close()
+
+	var buf bytes.Buffer
+	io.Copy(&buf, r)
+	r.Close()
+
+	if buf.Len() != 0 {
+		t.Fatalf("expected no debug output when disabled, got: %q", buf.String())
+	}
+}
+
+func TestDebugfFormat(t *testing.T) {
+	t.Cleanup(func() { SetDebug(false) })
+
+	r, w, err := os.Pipe()
+	if err != nil {
+		t.Fatal(err)
+	}
+	orig := os.Stderr
+	os.Stderr = w
+
+	SetDebug(true)
+	debugf("key=%q value=%d", "hello", 7)
+
+	os.Stderr = orig
+	w.Close()
+
+	var buf bytes.Buffer
+	io.Copy(&buf, r)
+	r.Close()
+
+	want := fmt.Sprintf("[savepoint debug] key=%q value=%d\n", "hello", 7)
+	if buf.String() != want {
+		t.Fatalf("expected %q, got %q", want, buf.String())
+	}
+}

package/internal/board/detail.go

@@ -85,6 +85,36 @@ func renderChecklistSentences(text, glyph string, width int, style lipgloss.Styl
 	return lines
 }
 
+// knownAbbreviations is the set of dot-terminated tokens that must not trigger
+// sentence splits. Add entries (lowercase, trailing dot) to extend the list.
+var knownAbbreviations = map[string]bool{
+	"e.g.":    true,
+	"i.e.":    true,
+	"vs.":     true,
+	"etc.":    true,
+	"fig.":    true,
+	"no.":     true,
+	"mr.":     true,
+	"mrs.":    true,
+	"dr.":     true,
+	"st.":     true,
+	"jr.":     true,
+	"sr.":     true,
+	"prof.":   true,
+	"approx.": true,
+	"est.":    true,
+}
+
+// isKnownAbbreviation reports whether the period at dotPos in s is the trailing
+// dot of a known abbreviation (e.g. "e.g.", "Dr.").
+func isKnownAbbreviation(s string, dotPos int) bool {
+	start := dotPos
+	for start > 0 && s[start-1] != ' ' {
+		start--
+	}
+	return knownAbbreviations[strings.ToLower(s[start:dotPos+1])]
+}
+
 func splitChecklistSentences(text string) []string {
 	fields := strings.Fields(text)
 	if len(fields) == 0 {
@@ -98,6 +128,9 @@ func splitChecklistSentences(text string) []string {
 		if r != '.' && r != '!' && r != '?' {
 			continue
 		}
+		if r == '.' && isKnownAbbreviation(normalized, i) {
+			continue
+		}
 		end := i + len(string(r))
 		if end < len(normalized) && normalized[end] != ' ' {
 			continue
@@ -182,51 +215,4 @@ func phaseLabel(s data.ProgressStage) string {
 	}
 }
 
-func WrapText(s string, width int) []string {
-	if width < 4 {
-		width = 4
-	}
-	words := strings.Fields(s)
-	if len(words) == 0 {
-		return nil
-	}
-	lines := []string{}
-	current := ""
-	for _, word := range words {
-		if len([]rune(word)) > width {
-			if current != "" {
-				lines = append(lines, current)
-				current = ""
-			}
-			lines = append(lines, SplitLongWord(word, width)...)
-			continue
-		}
-		if current == "" {
-			current = word
-			continue
-		}
-		if len([]rune(current))+1+len([]rune(word)) <= width {
-			current += " " + word
-			continue
-		}
-		lines = append(lines, current)
-		current = word
-	}
-	if current != "" {
-		lines = append(lines, current)
-	}
-	return lines
-}
 
-func SplitLongWord(word string, width int) []string {
-	runes := []rune(word)
-	lines := []string{}
-	for len(runes) > width {
-		lines = append(lines, string(runes[:width]))
-		runes = runes[width:]
-	}
-	if len(runes) > 0 {
-		lines = append(lines, string(runes))
-	}
-	return lines
-}

package/internal/board/detail_test.go

@@ -321,6 +321,54 @@ func TestUpdate_detailOverlayScrollsWithJK(t *testing.T) {
 	}
 }
 
+func TestSplitChecklistSentences_abbreviationEg(t *testing.T) {
+	got := splitChecklistSentences("Use e.g. a widget. Done.")
+	if len(got) != 2 {
+		t.Fatalf("splitChecklistSentences with e.g. = %d sentences, want 2: %v", len(got), got)
+	}
+	if got[0] != "Use e.g. a widget." {
+		t.Errorf("sentence[0] = %q, want %q", got[0], "Use e.g. a widget.")
+	}
+}
+
+func TestSplitChecklistSentences_abbreviationIe(t *testing.T) {
+	got := splitChecklistSentences("Call i.e. the function. Done.")
+	if len(got) != 2 {
+		t.Fatalf("splitChecklistSentences with i.e. = %d sentences, want 2: %v", len(got), got)
+	}
+}
+
+func TestSplitChecklistSentences_abbreviationDr(t *testing.T) {
+	got := splitChecklistSentences("Dr. Smith approved it. Done.")
+	if len(got) != 2 {
+		t.Fatalf("splitChecklistSentences with Dr. = %d sentences, want 2: %v", len(got), got)
+	}
+	if got[0] != "Dr. Smith approved it." {
+		t.Errorf("sentence[0] = %q, want %q", got[0], "Dr. Smith approved it.")
+	}
+}
+
+func TestSplitChecklistSentences_abbreviationEtc(t *testing.T) {
+	got := splitChecklistSentences("Add widgets, buttons, etc. to the panel. Done.")
+	if len(got) != 2 {
+		t.Fatalf("splitChecklistSentences with etc. = %d sentences, want 2: %v", len(got), got)
+	}
+}
+
+func TestSplitChecklistSentences_abbreviationCaseInsensitive(t *testing.T) {
+	got := splitChecklistSentences("See Fig. 3 for details. Done.")
+	if len(got) != 2 {
+		t.Fatalf("splitChecklistSentences with Fig. = %d sentences, want 2: %v", len(got), got)
+	}
+}
+
+func TestSplitChecklistSentences_normalSplitUnaffected(t *testing.T) {
+	got := splitChecklistSentences("First sentence. Second sentence.")
+	if len(got) != 2 {
+		t.Fatalf("splitChecklistSentences normal split = %d sentences, want 2: %v", len(got), got)
+	}
+}
+
 func TestOverlayWidth_clampMax(t *testing.T) {
 	if got := overlayWidth(120); got != 80 {
 		t.Errorf("overlayWidth(120) = %d, want 80", got)

package/internal/board/epic_panel.go

@@ -8,33 +8,40 @@ import (
 )
 
 // RenderEpicDetail renders an overlay showing the content of an E##-Detail.md file.
-func RenderEpicDetail(epicSlug, content string, overlayW, maxHeight, offset int) string {
+func RenderEpicDetail(epicSlug, content string, overlayW, maxHeight, offset int, tab int) string {
 	inner := overlayW - detailBorderPad
 	if inner < 4 {
 		inner = 4
 	}
 
+	tabIndicator := renderTabIndicator(tab, inner)
 	lines := []string{
 		styles.EpicTitleFocused.Render("EPIC DETAIL"),
-		strings.Repeat("─", inner),
+		tabIndicator,
 	}
 
 	body := epicDetailBody(content, inner)
-	body = append(body, "", styles.CardMeta.Render("esc:close"))
-	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead, offset)...)
+	body = append(body, "", styles.CardMeta.Render("1:Detail 2:Audit  esc:close"))
+	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead-1, offset)...)
 
 	return styles.EpicDetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
 }
 
-// epicDetailBody parses markdown content into display lines, stripping frontmatter.
-func epicDetailBody(content string, width int) []string {
-	if strings.TrimSpace(content) == "" || content == "(no detail available)" {
-		return []string{styles.CardMeta.Render("(no detail available)")}
+func renderTabIndicator(tab int, width int) string {
+	var detail, audit string
+	if tab == 0 {
+		detail = styles.EpicItemFocused.Render("DETAIL [1]")
+		audit = styles.CardMeta.Render("AUDIT [2]")
+	} else {
+		detail = styles.CardMeta.Render("DETAIL [1]")
+		audit = styles.EpicItemFocused.Render("AUDIT [2]")
 	}
+	return detail + styles.CardMeta.Render(" │ ") + audit
+}
 
+// stripFrontmatter removes YAML frontmatter (between leading --- markers) from content.
+func stripFrontmatter(content string) []string {
 	lines := strings.Split(content, "\n")
-
-	// Strip YAML frontmatter between leading --- markers.
 	start := 0
 	if len(lines) > 0 && strings.TrimSpace(lines[0]) == "---" {
 		for i := 1; i < len(lines); i++ {
@@ -44,7 +51,16 @@ func epicDetailBody(content string, width int) []string {
 			}
 		}
 	}
-	lines = lines[start:]
+	return lines[start:]
+}
+
+// epicDetailBody parses markdown content into display lines, stripping frontmatter.
+func epicDetailBody(content string, width int) []string {
+	if strings.TrimSpace(content) == "" || content == "(no detail available)" {
+		return []string{styles.CardMeta.Render("(no detail available)")}
+	}
+
+	lines := stripFrontmatter(content)
 
 	var body []string
 	skip := false
@@ -77,11 +93,89 @@ func epicDetailBody(content string, width int) []string {
 	return body
 }
 
+// RenderEpicAuditTab renders an overlay showing audit findings from an E##-Audit.md file.
+func RenderEpicAuditTab(epicSlug, content string, overlayW, maxHeight, offset int, tab int) string {
+	inner := overlayW - detailBorderPad
+	if inner < 4 {
+		inner = 4
+	}
+
+	tabIndicator := renderTabIndicator(tab, inner)
+	lines := []string{
+		styles.GlyphAudit.Render("EPIC AUDIT"),
+		tabIndicator,
+	}
+
+	body := epicAuditBody(content, inner)
+	body = append(body, "", styles.CardMeta.Render("1:Detail 2:Audit  esc:close"))
+	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead-1, offset)...)
+
+	return styles.EpicDetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
+}
+
+// epicAuditHiddenSectionHeadings lists markdown section headings suppressed in the audit tab overlay.
+// Sections that are implementation details or planning artifacts clutter the summary view.
+var epicAuditHiddenSectionHeadings = map[string]struct{}{
+	"12. Distribution & build": {},
+	"Acceptance Criteria":      {},
+	"Architectural notes":      {},
+	"Boundaries":               {},
+	"Context Files":            {},
+	"Implemented As":           {},
+	"Implemented as":           {},
+	"Implementation Plan":      {},
+	"Manual audit override":    {},
+	"Proposed Changes":         {},
+	"Quality Review":           {},
+	"With":                     {},
+}
+
+func epicAuditBody(content string, width int) []string {
+	if strings.TrimSpace(content) == "" || content == "(no audit available)" {
+		return []string{styles.CardMeta.Render("(no audit available)")}
+	}
+
+	lines := stripFrontmatter(content)
+
+	var body []string
+	inHiddenSection := false
+
+	for _, line := range lines {
+		trimmed := strings.TrimRight(line, " \t\r")
+		switch {
+		case strings.HasPrefix(trimmed, "## "):
+			sectionName := strings.TrimPrefix(trimmed, "## ")
+			_, inHiddenSection = epicAuditHiddenSectionHeadings[sectionName]
+			if !inHiddenSection {
+				body = append(body, "", styles.EpicItemFocused.Render(sectionName))
+			}
+		case inHiddenSection:
+		case strings.HasPrefix(trimmed, "### "):
+			body = append(body, styles.EpicItemFocused.Render(strings.TrimPrefix(trimmed, "### ")))
+		case strings.HasPrefix(trimmed, "- [x] ") || strings.HasPrefix(trimmed, "- [X] "):
+			text := strings.TrimPrefix(strings.TrimPrefix(trimmed, "- [x] "), "- [X] ")
+			body = append(body, renderChecklistSentences(text, "[x] ", width, styles.TagDone)...)
+		case strings.HasPrefix(trimmed, "- [ ] "):
+			text := strings.TrimPrefix(trimmed, "- [ ] ")
+			body = append(body, renderChecklistSentences(text, "[ ] ", width, styles.CardMeta)...)
+		case strings.HasPrefix(trimmed, "- "):
+			body = append(body, styles.CardMeta.Render("• "+strings.TrimPrefix(trimmed, "- ")))
+		case trimmed == "":
+			body = append(body, "")
+		default:
+			for _, wrapped := range WrapText(trimmed, width) {
+				body = append(body, styles.CardMeta.Render(wrapped))
+			}
+		}
+	}
+	return body
+}
+
 const epicActiveMarker = "►"
 
 // RenderEpicSidebar renders the fixed left sidebar listing epics with active indicator.
 // If epics is empty and selected is non-empty, selected is shown as the sole entry.
-func RenderEpicSidebar(epics []string, selected string, width int, focus bool, cursor int, status map[string]string) string {
+func RenderEpicSidebar(epics []string, selected string, width int, focus bool, cursor int, status map[string]string, maxHeight int) string {
 	inner := width - epicPanelOverhead
 	if inner < 2 {
 		inner = 2
@@ -114,6 +208,20 @@ func RenderEpicSidebar(epics []string, selected string, width int, focus bool, c
 	if len(list) == 0 {
 		lines = append(lines, styles.TaskItem.Render("(none)"))
 	}
+	if maxHeight > 0 && len(lines) > maxHeight {
+		items := lines[2:]
+		available := maxHeight - 3
+		if available < 1 {
+			available = 1
+		}
+		clipped := make([]string, 0, maxHeight)
+		clipped = append(clipped, lines[0], lines[1])
+		clipped = append(clipped, items[:min(available, len(items))]...)
+		if len(items) > available {
+			clipped = append(clipped, renderScrollIndicator("↓", len(items)-available, "more"))
+		}
+		lines = clipped
+	}
 	style := styles.EpicPanel.Width(width)
 	if focus && len(epics) > 0 {
 		style = styles.EpicPanelFocused.Width(width)
@@ -154,13 +262,3 @@ func RenderEpicDropdown(epics []string, cursor int, width int) string {
 	lines = append(lines, "", styles.CardMeta.Render("↑↓:nav  enter:select  esc:cancel"))
 	return styles.EpicPanel.Width(width).Render(strings.Join(lines, "\n"))
 }
-
-// epicIndex returns the index of selected in epics, or 0 if not found.
-func epicIndex(epics []string, selected string) int {
-	for i, e := range epics {
-		if e == selected {
-			return i
-		}
-	}
-	return 0
-}