savepoint 1.0.1 → 1.0.3

package/internal/board/detail.go

@@ -3,15 +3,17 @@ package board
 import (
 	"strings"
 
+	"github.com/charmbracelet/lipgloss"
 	"github.com/opencode/savepoint/internal/data"
 	"github.com/opencode/savepoint/internal/styles"
 )
 
-const detailBorderPad = 4 // rounded border (2) + padding (2×1)
+const detailBorderPad = 4        // rounded border (2) + padding (2×1)
+const detailVerticalOverhead = 4 // overlay border (2) + fixed title/header rows (2)
 
 // RenderDetail renders a task detail overlay panel at the given display width.
-// When routerTaskID matches t.ID, a "(router priority)" label is shown.
-func RenderDetail(t data.Task, overlayW int, routerTaskID string) string {
+// When router state matches t's release/epic/task, a "(router priority)" label is shown.
+func RenderDetail(t data.Task, overlayW int, routerState *data.RouterState, maxHeight, offset int) string {
 	inner := overlayW - detailBorderPad
 	if inner < 4 {
 		inner = 4
@@ -21,57 +23,137 @@ func RenderDetail(t data.Task, overlayW int, routerTaskID string) string {
 		styles.ColumnTitleFocused.Render("TASK DETAIL"),
 		strings.Repeat("─", inner),
 	}
-	lines = append(lines,
+	body := []string{
 		detailRow("ID", t.ID, inner),
 		detailRow("Title", t.Title, inner),
 		detailRow("Epic", t.Epic, inner),
 		detailRow("Release", t.Release, inner),
 		detailRow("Status", string(t.Column), inner),
 		detailRow("Phase", phaseLabel(t.Stage), inner),
-	)
+	}
 
 	if t.Description != "" {
-		lines = append(lines,
+		body = append(body,
 			"",
 			styles.ColumnTitle.Render("Description:"),
 		)
 		for _, line := range WrapText(t.Description, inner) {
-			lines = append(lines, styles.CardMeta.Render(line))
-		}
-	}
-
-	if len(t.Acceptance) > 0 {
-		lines = append(lines, "", styles.ColumnTitle.Render("Acceptance Criteria:"), "")
-		for _, a := range t.Acceptance {
-			for _, line := range WrapText(a, inner-2) {
-				lines = append(lines, styles.CardMeta.Render("  • "+line))
-			}
+			body = append(body, styles.CardMeta.Render(line))
 		}
 	}
 
 	if len(t.Checklist) > 0 {
-		lines = append(lines, "", styles.ColumnTitle.Render("Implementation Plan:"), "")
+		body = append(body, "", styles.ColumnTitle.Render("Implementation Plan:"), "")
 		for _, item := range t.Checklist {
-			glyph := "□ "
+			glyph := "[ ] "
 			style := styles.CardMeta
 			if item.Done {
-				glyph = "☑ "
+				glyph = "[x] "
 				style = styles.TagDone
 			}
-			for _, line := range WrapText(item.Text, inner-2) {
-				lines = append(lines, style.Render("  "+glyph+line))
-			}
+			body = append(body, renderChecklistSentences(item.Text, glyph, inner, style)...)
 		}
 	}
 
-	if routerTaskID != "" && t.ID == routerTaskID {
-		lines = append(lines, "", styles.TagDone.Render("(router priority)"))
+	if t.Column != data.ColumnDone && isRouterPriority(t, routerState) {
+		body = append(body, "", styles.TagDone.Render("(router priority)"))
 	}
-	lines = append(lines, "", styles.CardMeta.Render("esc:close"))
+	body = append(body, "", styles.CardMeta.Render("esc:close"))
+	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead, offset)...)
 
 	return styles.DetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
 }
 
+func renderChecklistSentences(text, glyph string, width int, style lipgloss.Style) []string {
+	textWidth := width - len(glyph)
+	if textWidth < 4 {
+		textWidth = 4
+	}
+
+	lines := []string{}
+	continuationIndent := strings.Repeat(" ", len(glyph))
+	for _, sentence := range splitChecklistSentences(text) {
+		wrapped := WrapText(sentence, textWidth)
+		for i, line := range wrapped {
+			if i == 0 {
+				lines = append(lines, style.Render(glyph+line))
+				continue
+			}
+			lines = append(lines, style.Render(continuationIndent+line))
+		}
+	}
+	return lines
+}
+
+func splitChecklistSentences(text string) []string {
+	fields := strings.Fields(text)
+	if len(fields) == 0 {
+		return nil
+	}
+	normalized := strings.Join(fields, " ")
+
+	sentences := []string{}
+	start := 0
+	for i, r := range normalized {
+		if r != '.' && r != '!' && r != '?' {
+			continue
+		}
+		end := i + len(string(r))
+		if end < len(normalized) && normalized[end] != ' ' {
+			continue
+		}
+		sentence := strings.TrimSpace(normalized[start:end])
+		if sentence != "" {
+			sentences = append(sentences, sentence)
+		}
+		start = end
+	}
+	if tail := strings.TrimSpace(normalized[start:]); tail != "" {
+		sentences = append(sentences, tail)
+	}
+	return sentences
+}
+
+func visibleDetailLines(lines []string, maxBodyHeight, offset int) []string {
+	total := len(lines)
+	if maxBodyHeight <= 0 || total <= maxBodyHeight {
+		return lines
+	}
+	offset = clampDetailOffset(offset, total)
+	available := maxBodyHeight
+	if offset > 0 {
+		available--
+	}
+	if available < 1 {
+		available = 1
+	}
+	end := min(offset+available, total)
+	if end < total && available > 1 {
+		available--
+		end = min(offset+available, total)
+	}
+
+	visible := make([]string, 0, available+2)
+	if offset > 0 {
+		visible = append(visible, renderScrollIndicator("↑", offset, "above"))
+	}
+	visible = append(visible, lines[offset:end]...)
+	if end < total {
+		visible = append(visible, renderScrollIndicator("↓", total-end, "more"))
+	}
+	return visible
+}
+
+func clampDetailOffset(offset, total int) int {
+	if offset < 0 || total <= 0 {
+		return 0
+	}
+	if offset >= total {
+		return total - 1
+	}
+	return offset
+}
+
 func detailRow(label, value string, width int) string {
 	prefix := label + ": "
 	wrapped := WrapText(value, width-len(prefix))
@@ -100,51 +182,4 @@ func phaseLabel(s data.ProgressStage) string {
 	}
 }
 
-func WrapText(s string, width int) []string {
-	if width < 4 {
-		width = 4
-	}
-	words := strings.Fields(s)
-	if len(words) == 0 {
-		return nil
-	}
-	lines := []string{}
-	current := ""
-	for _, word := range words {
-		if len([]rune(word)) > width {
-			if current != "" {
-				lines = append(lines, current)
-				current = ""
-			}
-			lines = append(lines, SplitLongWord(word, width)...)
-			continue
-		}
-		if current == "" {
-			current = word
-			continue
-		}
-		if len([]rune(current))+1+len([]rune(word)) <= width {
-			current += " " + word
-			continue
-		}
-		lines = append(lines, current)
-		current = word
-	}
-	if current != "" {
-		lines = append(lines, current)
-	}
-	return lines
-}
 
-func SplitLongWord(word string, width int) []string {
-	runes := []rune(word)
-	lines := []string{}
-	for len(runes) > width {
-		lines = append(lines, string(runes[:width]))
-		runes = runes[width:]
-	}
-	if len(runes) > 0 {
-		lines = append(lines, string(runes))
-	}
-	return lines
-}

package/internal/board/detail_test.go

@@ -1,6 +1,7 @@
 package board
 
 import (
+	"regexp"
 	"strings"
 	"testing"
 
@@ -8,6 +9,12 @@ import (
 	"github.com/opencode/savepoint/internal/data"
 )
 
+var ansiPattern = regexp.MustCompile(`\x1b\[[0-9;?]*[ -/]*[@-~]`)
+
+func plainTerminal(s string) string {
+	return ansiPattern.ReplaceAllString(s, "")
+}
+
 func sampleTask() data.Task {
 	return data.Task{
 		ID:      "E04/T001",
@@ -20,49 +27,49 @@ func sampleTask() data.Task {
 }
 
 func TestRenderDetail_containsID(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "E04/T001") {
 		t.Error("RenderDetail missing task ID")
 	}
 }
 
 func TestRenderDetail_containsTitle(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "My Task") {
 		t.Error("RenderDetail missing task title")
 	}
 }
 
 func TestRenderDetail_containsEpic(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "E04-board-components") {
 		t.Error("RenderDetail missing epic")
 	}
 }
 
 func TestRenderDetail_containsRelease(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "v1") {
 		t.Error("RenderDetail missing release")
 	}
 }
 
 func TestRenderDetail_containsStatus(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "in_progress") {
 		t.Error("RenderDetail missing status")
 	}
 }
 
 func TestRenderDetail_containsPhase(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "build") {
 		t.Error("RenderDetail missing phase")
 	}
 }
 
 func TestRenderDetail_containsEscHint(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if !strings.Contains(got, "esc") {
 		t.Error("RenderDetail missing esc:close hint")
 	}
@@ -71,35 +78,23 @@ func TestRenderDetail_containsEscHint(t *testing.T) {
 func TestRenderDetail_containsDescription(t *testing.T) {
 	tk := sampleTask()
 	tk.Description = "some description text"
-	got := RenderDetail(tk, 60, "")
+	got := RenderDetail(tk, 60, nil, 0, 0)
 	if !strings.Contains(got, "some description text") {
 		t.Error("RenderDetail missing description text")
 	}
 }
 
 func TestRenderDetail_noDescriptionSectionWhenEmpty(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if strings.Contains(got, "Description:") {
 		t.Error("RenderDetail should not show Description section when empty")
 	}
 }
 
-func TestRenderDetail_containsAcceptanceCriteria(t *testing.T) {
-	tk := sampleTask()
-	tk.Acceptance = []string{"criterion one", "criterion two"}
-	got := RenderDetail(tk, 60, "")
-	if !strings.Contains(got, "criterion one") {
-		t.Error("RenderDetail missing first acceptance criterion")
-	}
-	if !strings.Contains(got, "criterion two") {
-		t.Error("RenderDetail missing second acceptance criterion")
-	}
-}
-
 func TestRenderDetail_containsChecklist(t *testing.T) {
 	tk := sampleTask()
 	tk.Checklist = []data.CheckItem{{Text: "first implementation item"}, {Text: "second implementation item", Done: true}}
-	got := RenderDetail(tk, 60, "")
+	got := RenderDetail(tk, 60, nil, 0, 0)
 	if !strings.Contains(got, "Implementation Plan:") {
 		t.Error("RenderDetail missing implementation plan heading")
 	}
@@ -111,10 +106,70 @@ func TestRenderDetail_containsChecklist(t *testing.T) {
 	}
 }
 
+func TestRenderDetail_checklistSingleSentenceGetsOneCheckbox(t *testing.T) {
+	tk := sampleTask()
+	tk.Checklist = []data.CheckItem{{Text: "single sentence task"}}
+
+	got := plainTerminal(RenderDetail(tk, 60, nil, 0, 0))
+
+	if count := strings.Count(got, "[ ]"); count != 1 {
+		t.Fatalf("RenderDetail checkbox count = %d, want 1\n%s", count, got)
+	}
+	if strings.Contains(got, "[x]") {
+		t.Fatal("RenderDetail should not render checked marker for unchecked item")
+	}
+}
+
+func TestRenderDetail_checklistMultiSentenceGetsOneCheckboxPerSentence(t *testing.T) {
+	tk := sampleTask()
+	tk.Checklist = []data.CheckItem{{Text: "First sentence. Second sentence! Third sentence?"}}
+
+	got := plainTerminal(RenderDetail(tk, 60, nil, 0, 0))
+
+	if count := strings.Count(got, "[ ]"); count != 3 {
+		t.Fatalf("RenderDetail checkbox count = %d, want 3\n%s", count, got)
+	}
+	for _, want := range []string{"[ ] First sentence.", "[ ] Second sentence!", "[ ] Third sentence?"} {
+		if !strings.Contains(got, want) {
+			t.Fatalf("RenderDetail missing sentence checkbox line %q\n%s", want, got)
+		}
+	}
+}
+
+func TestRenderDetail_checklistHardWrappedSentenceDoesNotDuplicateCheckbox(t *testing.T) {
+	tk := sampleTask()
+	tk.Checklist = []data.CheckItem{{
+		Text: "This sentence is intentionally long enough to wrap inside a narrow detail overlay while remaining one semantic sentence.",
+	}}
+
+	got := plainTerminal(RenderDetail(tk, 34, nil, 0, 0))
+
+	if count := strings.Count(got, "[ ]"); count != 1 {
+		t.Fatalf("RenderDetail checkbox count = %d, want 1\n%s", count, got)
+	}
+	if !strings.Contains(got, "    intentionally long enough") {
+		t.Fatalf("RenderDetail continuation line should align under checkbox text\n%s", got)
+	}
+}
+
+func TestRenderDetail_checklistCheckedSentenceUsesCheckedMarker(t *testing.T) {
+	tk := sampleTask()
+	tk.Checklist = []data.CheckItem{{Text: "already done. still done.", Done: true}}
+
+	got := plainTerminal(RenderDetail(tk, 60, nil, 0, 0))
+
+	if count := strings.Count(got, "[x]"); count != 2 {
+		t.Fatalf("RenderDetail checked checkbox count = %d, want 2\n%s", count, got)
+	}
+	if strings.Contains(got, "[ ]") {
+		t.Fatal("RenderDetail should not render unchecked marker for checked item")
+	}
+}
+
 func TestRenderDetail_wrapsLongDescription(t *testing.T) {
 	tk := sampleTask()
 	tk.Description = "alpha beta gamma delta epsilon zeta eta theta iota kappa lambda"
-	got := RenderDetail(tk, 30, "")
+	got := RenderDetail(tk, 30, nil, 0, 0)
 	if strings.Contains(got, tk.Description) {
 		t.Error("RenderDetail should wrap long description text")
 	}
@@ -124,7 +179,7 @@ func TestRenderDetail_wrapsLongDescription(t *testing.T) {
 }
 
 func TestRenderDetail_noAcceptanceSectionWhenEmpty(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, "")
+	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
 	if strings.Contains(got, "Acceptance Criteria:") {
 		t.Error("RenderDetail should not show Acceptance section when empty")
 	}
@@ -216,7 +271,8 @@ func TestView_detailOverlayRendered(t *testing.T) {
 
 func TestRenderDetail_routerPriorityLabel(t *testing.T) {
 	task := sampleTask()
-	got := RenderDetail(task, 60, task.ID)
+	router := &data.RouterState{Release: task.Release, Epic: task.Epic, Task: task.ID}
+	got := RenderDetail(task, 60, router, 0, 0)
 	if !strings.Contains(got, "(router priority)") {
 		t.Error("RenderDetail missing router priority label for matching task")
 	}
@@ -224,12 +280,47 @@ func TestRenderDetail_routerPriorityLabel(t *testing.T) {
 
 func TestRenderDetail_noRouterPriorityLabelWhenNoMatch(t *testing.T) {
 	task := sampleTask()
-	got := RenderDetail(task, 60, "other-id")
+	router := &data.RouterState{Release: task.Release, Epic: task.Epic, Task: "other-id"}
+	got := RenderDetail(task, 60, router, 0, 0)
 	if strings.Contains(got, "(router priority)") {
 		t.Error("RenderDetail should not show router priority label for non-matching task")
 	}
 }
 
+func TestRenderDetail_viewportShowsScrollIndicators(t *testing.T) {
+	task := sampleTask()
+	task.Description = "alpha beta gamma delta epsilon zeta eta theta iota kappa lambda mu nu xi omicron"
+
+	got := RenderDetail(task, 32, nil, 8, 2)
+
+	if !strings.Contains(got, "↑ 2 above") {
+		t.Error("RenderDetail missing above indicator")
+	}
+	if !strings.Contains(got, "↓") || !strings.Contains(got, "more") {
+		t.Error("RenderDetail missing more indicator")
+	}
+	if strings.Contains(got, "ID:") {
+		t.Error("RenderDetail should not render body lines above viewport")
+	}
+}
+
+func TestUpdate_detailOverlayScrollsWithJK(t *testing.T) {
+	m := NewModel([]data.Task{sampleTask()}, "v1", "E04-board-components")
+	m.Overlay = OverlayDetail
+
+	got, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune("j")})
+	updated := requireModel(t, got)
+	if updated.DetailOffset != 1 {
+		t.Errorf("DetailOffset after j = %d, want 1", updated.DetailOffset)
+	}
+
+	got, _ = updated.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune("k")})
+	updated = requireModel(t, got)
+	if updated.DetailOffset != 0 {
+		t.Errorf("DetailOffset after k = %d, want 0", updated.DetailOffset)
+	}
+}
+
 func TestOverlayWidth_clampMax(t *testing.T) {
 	if got := overlayWidth(120); got != 80 {
 		t.Errorf("overlayWidth(120) = %d, want 80", got)