savepoint 1.0.0 → 1.0.2

package/internal/board/model.go

@@ -5,37 +5,49 @@ import (
 	"path/filepath"
 
 	tea "github.com/charmbracelet/bubbletea"
+	"github.com/fsnotify/fsnotify"
 	"github.com/opencode/savepoint/internal/data"
 )
 
 type OverlayType string
 
 const (
-	OverlayNone    OverlayType = ""
-	OverlayHelp    OverlayType = "help"
-	OverlayEpic    OverlayType = "epic"
-	OverlayRelease OverlayType = "release"
-	OverlayDetail  OverlayType = "detail"
+	OverlayNone       OverlayType = ""
+	OverlayHelp       OverlayType = "help"
+	OverlayEpic       OverlayType = "epic"
+	OverlayRelease    OverlayType = "release"
+	OverlayDetail     OverlayType = "detail"
+	OverlayEpicDetail OverlayType = "detail-epic"
 )
 
 // Model holds all board state. Tasks are grouped by column for O(1) column access.
 type Model struct {
-	AllTasks        []data.Task
-	Tasks           map[data.ColumnType][]data.Task
-	FocusedColumn   data.ColumnType
-	FocusedTask     int
-	SelectedEpic    string
-	SelectedRelease string
-	Epics           []string
-	EpicCursor      int
-	Releases        []string
-	ReleaseEpics    map[string][]string
-	ReleaseCursor   int
-	Overlay         OverlayType
-	Width           int
-	Height          int
-	StatusMessage   string
-	Root            string
+	AllTasks          []data.Task
+	Tasks             map[data.ColumnType][]data.Task
+	FocusedColumn     data.ColumnType
+	FocusedTask       int
+	ColumnOffsets     map[data.ColumnType]int
+	DetailOffset      int
+	SelectedEpic      string
+	SelectedRelease   string
+	Epics             []string
+	EpicCursor        int
+	EpicPanelFocus    bool
+	EpicPanelCursor   int
+	EpicDetailOffset  int
+	EpicDetailContent string
+	Releases          []string
+	ReleaseEpics      map[string][]string
+	ReleaseCursor     int
+	Overlay           OverlayType
+	Width             int
+	Height            int
+	StatusMessage     string
+	Root              string
+	EpicStatus        map[string]string
+	RouterTask        string
+	RouterState       *data.RouterState
+	Watcher           *fsnotify.Watcher
 }
 
 // NewModel groups tasks by column and returns an initialized Model.
@@ -44,6 +56,7 @@ func NewModel(tasks []data.Task, release, epic string) Model {
 		AllTasks:        append([]data.Task(nil), tasks...),
 		FocusedColumn:   data.ColumnPlanned,
 		FocusedTask:     0,
+		ColumnOffsets:   newColumnOffsets(),
 		SelectedEpic:    epic,
 		SelectedRelease: release,
 		Overlay:         OverlayNone,
@@ -53,7 +66,10 @@ func NewModel(tasks []data.Task, release, epic string) Model {
 }
 
 func (m Model) Init() tea.Cmd {
-	return tea.Batch()
+	if m.Watcher == nil {
+		return nil
+	}
+	return watchFiles(m.Watcher)
 }
 
 func groupedTasks(tasks []data.Task) map[data.ColumnType][]data.Task {
@@ -85,6 +101,15 @@ func (m *Model) refreshTasks() {
 	}
 	m.Tasks = groupedTasks(visible)
 	m.clampFocusedTask()
+	m.clampColumnOffsets()
+}
+
+func newColumnOffsets() map[data.ColumnType]int {
+	return map[data.ColumnType]int{
+		data.ColumnPlanned:    0,
+		data.ColumnInProgress: 0,
+		data.ColumnDone:       0,
+	}
 }
 
 func (m *Model) refreshEpicsForRelease() {
@@ -97,18 +122,36 @@ func (m *Model) refreshEpicsForRelease() {
 	if len(m.Epics) == 0 {
 		m.SelectedEpic = ""
 		m.EpicCursor = 0
+		m.EpicPanelCursor = 0
+		m.EpicPanelFocus = false
 		return
 	}
 
 	for _, epic := range m.Epics {
 		if epic == m.SelectedEpic {
 			m.EpicCursor = epicIndex(m.Epics, m.SelectedEpic)
+			m.clampEpicPanelCursor()
 			return
 		}
 	}
 
 	m.SelectedEpic = m.Epics[0]
 	m.EpicCursor = 0
+	m.clampEpicPanelCursor()
+}
+
+func (m *Model) clampEpicPanelCursor() {
+	if len(m.Epics) == 0 {
+		m.EpicPanelCursor = 0
+		m.EpicPanelFocus = false
+		return
+	}
+	if m.EpicPanelCursor >= len(m.Epics) {
+		m.EpicPanelCursor = len(m.Epics) - 1
+	}
+	if m.EpicPanelCursor < 0 {
+		m.EpicPanelCursor = 0
+	}
 }
 
 func (m *Model) clampFocusedTask() {
@@ -125,6 +168,23 @@ func (m *Model) clampFocusedTask() {
 	}
 }
 
+func (m *Model) clampColumnOffsets() {
+	if m.ColumnOffsets == nil {
+		m.ColumnOffsets = newColumnOffsets()
+	}
+	for _, col := range columnOrder {
+		tasks := m.Tasks[col]
+		offset := m.ColumnOffsets[col]
+		if offset < 0 || len(tasks) == 0 {
+			m.ColumnOffsets[col] = 0
+			continue
+		}
+		if offset >= len(tasks) {
+			m.ColumnOffsets[col] = len(tasks) - 1
+		}
+	}
+}
+
 func (m *Model) writeRouterReleaseEpic() error {
 	routerPath := filepath.Join(m.Root, "router.md")
 
@@ -144,8 +204,71 @@ func (m *Model) writeRouterReleaseEpic() error {
 		return err
 	}
 
-	state.Epic = m.SelectedEpic
+	state.Epic = shortID(m.SelectedEpic)
 	state.Release = m.SelectedRelease
 
 	return data.WriteRouterState(m.Root, state, fi.ModTime())
 }
+
+func (m *Model) writeRouterTask(task data.Task) (string, error) {
+	routerPath := filepath.Join(m.Root, "router.md")
+
+	fi, err := os.Stat(routerPath)
+	if err != nil {
+		return "", err
+	}
+
+	content, err := os.ReadFile(routerPath)
+	if err != nil {
+		return "", err
+	}
+
+	r := data.NewRouterReader()
+	state, err := r.ReadState(string(content))
+	if err != nil {
+		return "", err
+	}
+
+	state.Release = task.Release
+	state.Epic = task.Epic
+	if m.isLastUncompletedTask(task) {
+		state.State = "audit-pending"
+		state.Task = ""
+		state.NextAction = "Audit " + task.Epic + "."
+		if err := data.WriteRouterState(m.Root, state, fi.ModTime()); err != nil {
+			return "", err
+		}
+		m.RouterState = state
+		m.RouterTask = ""
+		return "Audit pending for " + task.Epic, nil
+	}
+
+	state.State = "task-building"
+	state.Task = task.ID
+	state.NextAction = "Build " + task.ID + "."
+	if err := data.WriteRouterState(m.Root, state, fi.ModTime()); err != nil {
+		return "", err
+	}
+	m.RouterState = state
+	m.RouterTask = task.ID
+	return "Router set to " + task.Release + " " + task.Epic + "/" + shortID(task.ID), nil
+}
+
+func (m Model) isLastUncompletedTask(task data.Task) bool {
+	for _, candidate := range m.AllTasks {
+		if candidate.ID == task.ID {
+			continue
+		}
+		if candidate.Release != task.Release || candidate.Epic != task.Epic {
+			continue
+		}
+		if !taskDone(candidate) {
+			return false
+		}
+	}
+	return true
+}
+
+func taskDone(task data.Task) bool {
+	return task.Column == data.ColumnDone || task.Status == string(data.StatusDone)
+}

package/internal/board/render_policy_test.go

@@ -0,0 +1,77 @@
+package board
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/charmbracelet/lipgloss"
+	"github.com/muesli/termenv"
+	"github.com/opencode/savepoint/internal/data"
+)
+
+func TestRenderPolicy_noBackgroundEscapes(t *testing.T) {
+	lipgloss.SetColorProfile(termenv.ANSI256)
+
+	task := data.Task{
+		ID:      "E05-tasking-permissions/T004-implement-m-hotkey",
+		Title:   "Implement router priority",
+		Release: "v1.1",
+		Epic:    "E05-tasking-permissions",
+		Column:  data.ColumnInProgress,
+		Stage:   data.StageBuild,
+	}
+	m := NewModel([]data.Task{
+		{
+			ID:      task.ID,
+			Title:   task.Title,
+			Release: task.Release,
+			Epic:    task.Epic,
+			Column:  task.Column,
+			Stage:   task.Stage,
+		},
+	}, "v1.1", "E05-tasking-permissions")
+	m.Width = 120
+	m.Height = 30
+	m.FocusedColumn = data.ColumnInProgress
+	m.RouterState = &data.RouterState{
+		State:      "task-building",
+		Release:    "v1.1",
+		Epic:       "E05-tasking-permissions",
+		Task:       "E05-tasking-permissions/T004-implement-m-hotkey",
+		NextAction: "Build E05-tasking-permissions/T004-implement-m-hotkey.",
+	}
+
+	cases := map[string]string{
+		"board":            m.View(),
+		"card":             RenderCard(task, 30, true, m.RouterState),
+		"detail":           RenderDetail(task, 60, m.RouterState, 0, 0),
+		"epic dropdown":    RenderEpicDropdown([]string{"E05-tasking-permissions"}, 0, 40),
+		"release dropdown": RenderReleaseDropdown([]string{"v1.1"}, 0, 40),
+		"help":             RenderHelp(60),
+	}
+	for name, got := range cases {
+		assertNoBackgroundEscapes(t, name, got)
+	}
+}
+
+func assertNoBackgroundEscapes(t *testing.T, name, got string) {
+	t.Helper()
+	for _, escape := range []string{"\x1b[48;", "\x1b[40m"} {
+		if strings.Contains(got, escape) {
+			t.Fatalf("%s emitted background escape prefix %q in %q", name, escape, got)
+		}
+	}
+}
+
+func TestRenderPolicy_usesSingleLineBorders(t *testing.T) {
+	m := NewModel([]data.Task{{ID: "T001", Title: "Task", Column: data.ColumnPlanned}}, "v1", "E01")
+	m.Width = 120
+	got := m.View()
+
+	if strings.Contains(got, "╭") || strings.Contains(got, "╮") || strings.Contains(got, "╰") || strings.Contains(got, "╯") {
+		t.Fatalf("View should use single-line borders, got rounded border glyphs in %q", got)
+	}
+	if !strings.Contains(got, "┌") || !strings.Contains(got, "┐") || !strings.Contains(got, "└") || !strings.Contains(got, "┘") {
+		t.Fatalf("View missing expected single-line border glyphs in %q", got)
+	}
+}

package/internal/board/status.go

@@ -0,0 +1,23 @@
+package board
+
+import (
+	"github.com/opencode/savepoint/internal/data"
+	"github.com/opencode/savepoint/internal/styles"
+)
+
+const statusGlyphDefault = " "
+
+func statusGlyph(status string) string {
+	switch status {
+	case string(data.StatusPlanned):
+		return styles.CardMeta.Render("○")
+	case string(data.StatusInProgress):
+		return styles.GlyphBuild.Render("▶")
+	case string(data.StatusDone):
+		return styles.TagDone.Render("◉")
+	case string(data.StatusAudited):
+		return styles.TagDone.Render("✓")
+	default:
+		return statusGlyphDefault
+	}
+}