sass-loader 13.2.2 → 13.3.1

package/README.md

@@ -11,7 +11,7 @@
 [![node][node]][node-url]
 [![tests][tests]][tests-url]
 [![coverage][cover]][cover-url]
-[![chat][chat]][chat-url]
+[![discussion][discussion]][discussion-url]
 [![size][size]][size-url]
 
 # sass-loader
@@ -952,7 +952,7 @@ Please take a moment to read our contributing guidelines if you haven't yet done
 [tests-url]: https://github.com/webpack-contrib/sass-loader/actions
 [cover]: https://codecov.io/gh/webpack-contrib/sass-loader/branch/master/graph/badge.svg
 [cover-url]: https://codecov.io/gh/webpack-contrib/sass-loader
-[chat]: https://badges.gitter.im/webpack/webpack.svg
-[chat-url]: https://gitter.im/webpack/webpack
+[discussion]: https://img.shields.io/github/discussions/webpack/webpack
+[discussion-url]: https://github.com/webpack/webpack/discussions
 [size]: https://packagephobia.now.sh/badge?p=sass-loader
 [size-url]: https://packagephobia.now.sh/result?p=sass-loader

package/dist/index.js

@@ -8,7 +8,6 @@ var _url = _interopRequireDefault(require("url"));
 var _path = _interopRequireDefault(require("path"));
 var _options = _interopRequireDefault(require("./options.json"));
 var _utils = require("./utils");
-var _SassError = _interopRequireDefault(require("./SassError"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 /**
  * The sass-loader makes node-sass and dart-sass available to webpack modules.
@@ -19,9 +18,11 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 async function loader(content) {
   const options = this.getOptions(_options.default);
   const callback = this.async();
-  const implementation = (0, _utils.getSassImplementation)(this, options.implementation);
-  if (!implementation) {
-    callback();
+  let implementation;
+  try {
+    implementation = (0, _utils.getSassImplementation)(this, options.implementation);
+  } catch (error) {
+    callback(error);
     return;
   }
   const useSourceMap = typeof options.sourceMap === "boolean" ? options.sourceMap : this.sourceMap;
@@ -38,7 +39,13 @@ async function loader(content) {
       sassOptions.importers.push((0, _utils.getModernWebpackImporter)(this, implementation));
     }
   }
-  const compile = (0, _utils.getCompileFn)(implementation, options);
+  let compile;
+  try {
+    compile = (0, _utils.getCompileFn)(implementation, options);
+  } catch (error) {
+    callback(error);
+    return;
+  }
   let result;
   try {
     result = await compile(sassOptions, options);
@@ -53,7 +60,7 @@ async function loader(content) {
       // `node-sass` returns POSIX paths
       this.addDependency(_path.default.normalize(error.file));
     }
-    callback(new _SassError.default(error));
+    callback((0, _utils.errorFactory)(error));
     return;
   }
   let map =

package/dist/utils.js

@@ -3,6 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
+exports.errorFactory = errorFactory;
 exports.getCompileFn = getCompileFn;
 exports.getModernWebpackImporter = getModernWebpackImporter;
 exports.getSassImplementation = getSassImplementation;
@@ -15,7 +16,6 @@ var _url = _interopRequireDefault(require("url"));
 var _path = _interopRequireDefault(require("path"));
 var _full = require("klona/full");
 var _neoAsync = _interopRequireDefault(require("neo-async"));
-var _SassWarning = _interopRequireDefault(require("./SassWarning"));
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 function getDefaultSassImplementation() {
   let sassImplPkg = "sass";
@@ -45,35 +45,21 @@ function getDefaultSassImplementation() {
 function getSassImplementation(loaderContext, implementation) {
   let resolvedImplementation = implementation;
   if (!resolvedImplementation) {
-    try {
-      resolvedImplementation = getDefaultSassImplementation();
-    } catch (error) {
-      loaderContext.emitError(error);
-      return;
-    }
+    resolvedImplementation = getDefaultSassImplementation();
   }
   if (typeof resolvedImplementation === "string") {
-    try {
-      // eslint-disable-next-line import/no-dynamic-require, global-require
-      resolvedImplementation = require(resolvedImplementation);
-    } catch (error) {
-      loaderContext.emitError(error);
-
-      // eslint-disable-next-line consistent-return
-      return;
-    }
+    // eslint-disable-next-line import/no-dynamic-require, global-require
+    resolvedImplementation = require(resolvedImplementation);
   }
   const {
     info
   } = resolvedImplementation;
   if (!info) {
-    loaderContext.emitError(new Error("Unknown Sass implementation."));
-    return;
+    throw new Error("Unknown Sass implementation.");
   }
   const infoParts = info.split("\t");
   if (infoParts.length < 2) {
-    loaderContext.emitError(new Error(`Unknown Sass implementation "${info}".`));
-    return;
+    throw new Error(`Unknown Sass implementation "${info}".`);
   }
   const [implementationName] = infoParts;
   if (implementationName === "dart-sass") {
@@ -86,7 +72,7 @@ function getSassImplementation(loaderContext, implementation) {
     // eslint-disable-next-line consistent-return
     return resolvedImplementation;
   }
-  loaderContext.emitError(new Error(`Unknown Sass implementation "${implementationName}".`));
+  throw new Error(`Unknown Sass implementation "${implementationName}".`);
 }
 
 /**
@@ -152,7 +138,10 @@ async function getSassOptions(loaderContext, loaderOptions, content, implementat
           builtMessage += `\n\n${loggerOptions.stack}`;
         }
         if (needEmitWarning) {
-          loaderContext.emitWarning(new _SassWarning.default(builtMessage, loggerOptions));
+          const warning = new Error(builtMessage);
+          warning.name = "SassWarning";
+          warning.stack = null;
+          loaderContext.emitWarning(warning);
         } else {
           logger.warn(builtMessage);
         }
@@ -623,4 +612,20 @@ function normalizeSourceMap(map, rootContext) {
     return source;
   });
   return newMap;
+}
+function errorFactory(error) {
+  let message;
+  if (error.formatted) {
+    message = error.formatted.replace(/^Error: /, "");
+  } else {
+    // Keep original error if `sassError.formatted` is unavailable
+    ({
+      message
+    } = error);
+  }
+  const obj = new Error(message, {
+    cause: error
+  });
+  obj.stack = null;
+  return obj;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sass-loader",
-  "version": "13.2.2",
+  "version": "13.3.1",
   "description": "Sass loader for webpack",
   "license": "MIT",
   "repository": "webpack-contrib/sass-loader",
@@ -26,6 +26,9 @@
     "lint:js": "eslint --cache .",
     "lint": "npm-run-all -l -p \"lint:**\"",
     "test:only": "cross-env NODE_ENV=test jest",
+    "fix:js": "npm run lint:js -- --fix",
+    "fix:prettier": "npm run lint:prettier -- --write",
+    "fix": "npm-run-all -l fix:js fix:prettier",
     "lint:spelling": "cspell \"**/*.*\"",
     "test:watch": "npm run test:only -- --watch",
     "test:manual": "npm run build && webpack-dev-server test/manual/src/index.js --open --config test/manual/webpack.config.js",
@@ -40,7 +43,7 @@
   ],
   "peerDependencies": {
     "fibers": ">= 3.1.0",
-    "node-sass": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0",
+    "node-sass": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0",
     "sass": "^1.3.0",
     "sass-embedded": "*",
     "webpack": "^5.0.0"
@@ -64,11 +67,11 @@
     "neo-async": "^2.6.2"
   },
   "devDependencies": {
-    "@babel/cli": "^7.21.0",
-    "@babel/core": "^7.21.3",
-    "@babel/preset-env": "^7.20.2",
-    "@commitlint/cli": "^17.5.0",
-    "@commitlint/config-conventional": "^17.4.4",
+    "@babel/cli": "^7.21.5",
+    "@babel/core": "^7.21.5",
+    "@babel/preset-env": "^7.21.5",
+    "@commitlint/cli": "^17.6.1",
+    "@commitlint/config-conventional": "^17.6.1",
     "@webpack-contrib/eslint-config-webpack": "^3.0.0",
     "babel-jest": "^29.5.0",
     "bootstrap-sass": "^3.4.1",
@@ -79,8 +82,8 @@
     "css-loader": "^6.7.3",
     "del": "^6.1.1",
     "del-cli": "^4.0.1",
-    "enhanced-resolve": "^5.12.0",
-    "eslint": "^8.36.0",
+    "enhanced-resolve": "^5.13.0",
+    "eslint": "^8.39.0",
     "eslint-config-prettier": "^8.8.0",
     "eslint-plugin-import": "^2.27.5",
     "fibers": "^5.0.3",
@@ -89,19 +92,19 @@
     "husky": "^8.0.3",
     "jest": "^29.5.0",
     "jest-environment-node-single-context": "^29.0.0",
-    "lint-staged": "^12.5.0",
-    "material-components-web": "^8.0.0",
-    "memfs": "^3.4.13",
+    "lint-staged": "^13.2.2",
+    "material-components-web": "^9.0.0",
+    "memfs": "^3.5.1",
     "node-sass": "^8.0.0",
     "node-sass-glob-importer": "^5.3.2",
     "npm-run-all": "^4.1.5",
-    "prettier": "^2.8.7",
-    "sass": "^1.58.0",
-    "sass-embedded": "^1.57.1",
-    "semver": "^7.3.8",
+    "prettier": "^2.8.8",
+    "sass": "^1.62.1",
+    "sass-embedded": "^1.62.0",
+    "semver": "^7.5.0",
     "standard-version": "^9.3.1",
-    "style-loader": "^3.2.1",
-    "webpack": "^5.76.3"
+    "style-loader": "^3.3.2",
+    "webpack": "^5.81.0"
   },
   "keywords": [
     "sass",

package/dist/SassError.js

@@ -1,31 +0,0 @@
-"use strict";
-
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports.default = void 0;
-class SassError extends Error {
-  constructor(sassError) {
-    super();
-    this.name = "SassError";
-
-    // Instruct webpack to hide the JS stack from the console.
-    // Usually you're only interested in the SASS error in this case.
-    this.hideStack = true;
-    Error.captureStackTrace(this, this.constructor);
-    if (typeof sassError.line !== "undefined" || typeof sassError.column !== "undefined") {
-      this.loc = {
-        line: sassError.line,
-        column: sassError.column
-      };
-    }
-
-    // Keep original error if `sassError.formatted` is unavailable
-    this.message = `${this.name}: ${typeof sassError.message !== "undefined" ? sassError.message : sassError}`;
-    if (sassError.formatted) {
-      this.message = `${this.name}: ${sassError.formatted.replace(/^Error: /, "")}`;
-    }
-  }
-}
-var _default = SassError;
-exports.default = _default;

package/dist/SassWarning.js

@@ -1,21 +0,0 @@
-"use strict";
-
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports.default = void 0;
-class SassWarning extends Error {
-  constructor(warning, options) {
-    super(warning);
-    this.name = "SassWarning";
-    this.hideStack = true;
-    if (options.span) {
-      this.loc = {
-        line: options.span.start.line,
-        column: options.span.start.column
-      };
-    }
-  }
-}
-var _default = SassWarning;
-exports.default = _default;