sass-loader 10.0.1 → 10.0.2

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [10.0.2](https://github.com/webpack-contrib/sass-loader/compare/v10.0.1...v10.0.2) (2020-09-03)
+
+
+### Bug Fixes
+
+* source maps generation ([#886](https://github.com/webpack-contrib/sass-loader/issues/886)) ([8327d55](https://github.com/webpack-contrib/sass-loader/commit/8327d55df9e8fc6e24d2759d7bd50174ed1ff1e4))
+
 ### [10.0.1](https://github.com/webpack-contrib/sass-loader/compare/v10.0.0...v10.0.1) (2020-08-25)
 
 ### Chore

package/dist/index.js

@@ -55,29 +55,18 @@ function loader(content) {
 
       callback(new _SassError.default(error));
       return;
-    } // Modify source paths only for webpack, otherwise we do nothing
-
-
-    if (result.map && useSourceMap) {
-      // eslint-disable-next-line no-param-reassign
-      result.map = JSON.parse(result.map); // result.map.file is an optional property that provides the output filename.
-      // Since we don't know the final filename in the webpack build chain yet, it makes no sense to have it.
-      // eslint-disable-next-line no-param-reassign
-
-      delete result.map.file; // eslint-disable-next-line no-param-reassign
+    }
 
-      result.sourceRoot = ''; // node-sass returns POSIX paths, that's why we need to transform them back to native paths.
-      // This fixes an error on windows where the source-map module cannot resolve the source maps.
-      // @see https://github.com/webpack-contrib/sass-loader/issues/366#issuecomment-279460722
-      // eslint-disable-next-line no-param-reassign
+    let map = result.map ? JSON.parse(result.map) : null; // Modify source paths only for webpack, otherwise we do nothing
 
-      result.map.sources = result.map.sources.map(source => (0, _utils.absolutifySourceMapSource)(this.rootContext, source));
+    if (map && useSourceMap) {
+      map = (0, _utils.normalizeSourceMap)(map, this.rootContext);
     }
 
     result.stats.includedFiles.forEach(includedFile => {
       this.addDependency(_path.default.normalize(includedFile));
     });
-    callback(null, result.css.toString(), result.map);
+    callback(null, result.css.toString(), map);
   });
 }
 

package/dist/utils.js

@@ -8,7 +8,7 @@ exports.getSassOptions = getSassOptions;
 exports.getWebpackResolver = getWebpackResolver;
 exports.getWebpackImporter = getWebpackImporter;
 exports.getRenderFunctionFromSassImplementation = getRenderFunctionFromSassImplementation;
-exports.absolutifySourceMapSource = absolutifySourceMapSource;
+exports.normalizeSourceMap = normalizeSourceMap;
 
 var _url = _interopRequireDefault(require("url"));
 
@@ -157,8 +157,7 @@ function getSassOptions(loaderContext, loaderOptions, content, implementation, u
     // all paths in sourceMap.sources will be relative to that path.
     // Pretty complicated... :(
     options.sourceMap = true;
-    options.outFile = _path.default.join(loaderContext.rootContext, 'style.css.map'); // options.sourceMapRoot = process.cwd();
-
+    options.outFile = _path.default.join(loaderContext.rootContext, 'style.css.map');
     options.sourceMapContents = true;
     options.omitSourceMapUrl = true;
     options.sourceMapEmbed = false;
@@ -447,12 +446,26 @@ function getURLType(source) {
   return ABSOLUTE_SCHEME.test(source) ? 'absolute' : 'path-relative';
 }
 
-function absolutifySourceMapSource(sourceRoot, source) {
-  const sourceType = getURLType(source); // Do no touch `scheme-relative`, `path-absolute` and `absolute` types
+function normalizeSourceMap(map, rootContext) {
+  const newMap = map; // result.map.file is an optional property that provides the output filename.
+  // Since we don't know the final filename in the webpack build chain yet, it makes no sense to have it.
+  // eslint-disable-next-line no-param-reassign
 
-  if (sourceType === 'path-relative') {
-    return _path.default.resolve(sourceRoot, _path.default.normalize(source));
-  }
+  delete newMap.file; // eslint-disable-next-line no-param-reassign
+
+  newMap.sourceRoot = ''; // node-sass returns POSIX paths, that's why we need to transform them back to native paths.
+  // This fixes an error on windows where the source-map module cannot resolve the source maps.
+  // @see https://github.com/webpack-contrib/sass-loader/issues/366#issuecomment-279460722
+  // eslint-disable-next-line no-param-reassign
+
+  newMap.sources = newMap.sources.map(source => {
+    const sourceType = getURLType(source); // Do no touch `scheme-relative`, `path-absolute` and `absolute` types
 
-  return source;
+    if (sourceType === 'path-relative') {
+      return _path.default.resolve(rootContext, _path.default.normalize(source));
+    }
+
+    return source;
+  });
+  return newMap;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sass-loader",
-  "version": "10.0.1",
+  "version": "10.0.2",
   "description": "Sass loader for webpack",
   "license": "MIT",
   "repository": "webpack-contrib/sass-loader",
@@ -59,13 +59,13 @@
     "klona": "^2.0.3",
     "loader-utils": "^2.0.0",
     "neo-async": "^2.6.2",
-    "schema-utils": "^2.7.0",
+    "schema-utils": "^2.7.1",
     "semver": "^7.3.2"
   },
   "devDependencies": {
-    "@babel/cli": "^7.10.5",
-    "@babel/core": "^7.11.4",
-    "@babel/preset-env": "^7.11.0",
+    "@babel/cli": "^7.11.5",
+    "@babel/core": "^7.11.5",
+    "@babel/preset-env": "^7.11.5",
     "@commitlint/cli": "^10.0.0",
     "@commitlint/config-conventional": "^10.0.0",
     "@webpack-contrib/defaults": "^6.3.0",
@@ -78,20 +78,20 @@
     "del": "^5.1.0",
     "del-cli": "^3.0.1",
     "enhanced-resolve": "^4.3.0",
-    "eslint": "^7.7.0",
+    "eslint": "^7.8.1",
     "eslint-config-prettier": "^6.11.0",
     "eslint-plugin-import": "^2.21.2",
     "fibers": "^5.0.0",
-    "file-loader": "^6.0.0",
+    "file-loader": "^6.1.0",
     "foundation-sites": "^6.6.3",
     "husky": "^4.2.5",
     "jest": "^26.4.2",
-    "lint-staged": "^10.2.12",
+    "lint-staged": "^10.3.0",
     "material-components-web": "^7.0.0",
     "memfs": "^3.2.0",
     "node-sass": "^4.14.1",
     "npm-run-all": "^4.1.5",
-    "prettier": "^2.1.0",
+    "prettier": "^2.1.1",
     "sass": "^1.26.10",
     "standard-version": "^9.0.0",
     "style-loader": "^1.2.1",