sap-ai-dev-toolkit 0.6.2 → 0.6.5

package/README.md

@@ -763,7 +763,7 @@ The relay between the VSP child and each BAS destination recovers from the failu
 2. **Session refresh** — when SAP explicitly rejects a CSRF token, the cached session is dropped, a fresh token+cookie pair is fetched, and the request is retried within the configured bound. Generic authorization 401/403 responses are returned without being mislabeled or retried as CSRF failures.
 3. **Proxy tunnel fallback** — when the BAS proxy refuses absolute-form requests (502/504 or transport errors), the relay switches to a CONNECT tunnel through the same proxy and keeps going.
 4. **Child crash recovery** — a crashed VSP child is restarted transparently, re-initialized, tools re-registered, and the interrupted `tools/call` retried once before any error reaches the client.
-5. **Configured destination authentication** — the add-on always uses the URL, authentication mode, and credentials already configured for the selected destination. Setup does not prompt for or store SAP usernames/passwords, and the relay does not connect directly to a backend host as a credential fallback. Correct the credentials in BAS or the Cloud Foundry Destination service if SAP rejects them.
+5. **Configured destination authentication** — BAS destination children use the selected BAS destination as their only SAP identity. The toolkit clears VSP local authentication environment values so a project `.env` cannot override or conflict with destination authentication. Setup does not prompt for or store SAP usernames/passwords, and the relay does not connect directly to a backend host as a credential fallback. Cloud Foundry destinations use only credentials returned by their configured Destination service record.
 Existing installs that still set the previous `BAS_VSP_*` environment variables remain supported. The setup wizard writes new MCP entries with the `SAP_AI_DEV_TOOLKIT_*` names.
 
 #### Server logging

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sap-ai-dev-toolkit",
-  "version": "0.6.2",
+  "version": "0.6.5",
   "description": "SAP AI development toolkit for BAS, ABAP, RAP, CAP, HANA Cloud, Fiori, UI5, and MCP",
   "author": "Gurkan Yilmaz",
   "type": "module",

package/src/mcp-proxy.mjs

@@ -174,8 +174,22 @@ function useBasDestinationRelay(destination, env = process.env) {
   return Boolean(destination.url && String(destination.url).includes('.dest'));
 }
 
+function useProxyAuthentication(destination) {
+  return destination.source !== 'cloud-foundry' || destination.authentication === 'PrincipalPropagation';
+}
+
 function childEnvironment(destination, env) {
   const childEnv = { ...sanitizeChildEnv(env), ...(destination.childEnv || {}) };
+  if (useProxyAuthentication(destination)) {
+    // VSP loads SAP_* values from local .env files. Set every supported local
+    // auth variable explicitly empty so dotenv cannot supply a fallback
+    // identity or session instead of the selected BAS destination identity.
+    for (const key of [
+      'SAP_USER', 'SAP_USERNAME', 'SAP_PASSWORD', 'SAP_PASS',
+      'SAP_COOKIE_FILE', 'SAP_COOKIE_STRING', 'SAP_BROWSER_AUTH', 'SAP_SSO',
+      'SAP_SAML_AUTH', 'SAP_SAML_USER', 'SAP_SAML_PASSWORD', 'SAP_CREDENTIAL_CMD'
+    ]) childEnv[key] = '';
+  }
   // The VSP child must reach the local BAS relay directly, never through the
   // BAS .dest proxy. Without a loopback exception every child request would
   // be double-proxied and the relay's session pairing could never apply.
@@ -196,7 +210,7 @@ export function childArguments(destination, env = process.env) {
   // controlled by SAP_ALLOW_TRANSPORTABLE_EDITS and SAP authorizations.
   const mode = brandedEnvValue(env, 'MODE') || 'expert';
   const args = ['--url', destination.url, '--client', destination.client || '001', '--mode', mode];
-  if (destination.source !== 'cloud-foundry' || destination.authentication === 'PrincipalPropagation') args.push('--proxy-auth');
+  if (useProxyAuthentication(destination)) args.push('--proxy-auth');
   args.push('--enable-transports');
   return args;
 }