sap-ai-dev-toolkit 0.5.5 → 0.5.6

package/test/launcher.test.mjs

@@ -1,401 +0,0 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import { createServer } from 'node:http';
-import { spawn } from 'node:child_process';
-import { fileURLToPath } from 'node:url';
-import { chmod, mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { spawnWithPty } from './pty.mjs';
-import { storeDestinationCredentials } from '../src/credentials-store.mjs';
-import { credentialKeyForDestination, enrichWithStoredCredentials } from '../src/credential-overrides.mjs';
-
-const launcher = fileURLToPath(new URL('../src/launcher.mjs', import.meta.url));
-const fakeVsp = fileURLToPath(new URL('./fixtures/fake-vsp.mjs', import.meta.url));
-
-function runLauncher(args, env) {
-  return new Promise((resolve, reject) => {
-    const child = spawn(process.execPath, [launcher, ...args], { env, stdio: ['ignore', 'pipe', 'pipe'] });
-    let stdout = '';
-    let stderr = '';
-    child.stdout.on('data', chunk => { stdout += chunk; });
-    child.stderr.on('data', chunk => { stderr += chunk; });
-    child.on('error', reject);
-    child.on('exit', (code, signal) => resolve({ code, signal, stdout, stderr }));
-  });
-}
-function runLauncherTty(env, input, args = ['--setup']) {
-  return new Promise((resolve, reject) => {
-    const command = `${process.execPath} ${launcher} ${args.join(' ')}`;
-    const child = spawnWithPty(command, { env, stdio: ['pipe', 'pipe', 'pipe'] });
-    let stdout = '';
-    let stderr = '';
-    let inputSent = false;
-    const timeout = setTimeout(() => child.kill('SIGKILL'), 15000);
-    child.stdout.on('data', chunk => {
-      stdout += chunk.toString();
-      if (!inputSent && stdout.includes('Select destinations')) {
-        inputSent = true;
-        child.stdin.end(input);
-      }
-    });
-    child.stderr.on('data', chunk => { stderr += chunk.toString(); });
-    child.on('error', error => { clearTimeout(timeout); reject(error); });
-    child.on('exit', (code, signal) => { clearTimeout(timeout); resolve({ code, signal, stdout, stderr, inputSent }); });
-  });
-}
-
-test('enriches stored credentials without switching BAS OnPremise or CF Connectivity routes', async t => {
-  const directory = await mkdtemp(join(tmpdir(), 'bas-launcher-credentials-'));
-  const credentialsPath = join(directory, 'credentials.json');
-  t.after(async () => { await rm(directory, { recursive: true, force: true }); });
-
-  const internet = {
-    name: 'internet-system', url: 'http://internet-system.dest', backendUrl: 'https://internet.example:44300',
-    authentication: 'BasicAuthentication', proxyType: 'Internet'
-  };
-  const basOnPremise = {
-    name: 'shared-system', url: 'http://shared-system.dest', backendUrl: 'https://internal.example:44300',
-    authentication: 'BasicAuthentication', proxyType: 'OnPremise'
-  };
-  const cfOnPremise = {
-    source: 'cloud-foundry', name: 'shared-system', serverName: 'cf:space-one:instance-one:shared-system',
-    url: 'https://sap.internal:44300', authentication: 'BasicAuthentication', proxyType: 'OnPremise',
-    childEnv: { HTTP_PROXY: 'http://127.0.0.1:3333', SAP_USER: 'configured-user', SAP_PASSWORD: 'configured-password' }
-  };
-  const principalPropagation = { ...cfOnPremise, name: 'principal-system', serverName: 'cf:space-one:instance-one:principal-system', authentication: 'PrincipalPropagation' };
-
-  await storeDestinationCredentials(credentialsPath, 'internet-system', {
-    host: internet.backendUrl, user: 'INTERNET_USER', password: 'internet-secret'
-  });
-  await storeDestinationCredentials(credentialsPath, 'shared-system', {
-    user: 'BAS_USER', password: 'bas-secret', mode: 'bas-tunnel'
-  });
-  await storeDestinationCredentials(credentialsPath, credentialKeyForDestination(cfOnPremise), {
-    user: 'CF_USER', password: 'cf-secret', mode: 'cf-connectivity'
-  });
-  await storeDestinationCredentials(credentialsPath, credentialKeyForDestination(principalPropagation), {
-    user: 'SHOULD_NOT_APPLY', password: 'pp-secret', mode: 'cf-connectivity'
-  });
-
-  const result = await enrichWithStoredCredentials(
-    [internet, basOnPremise, cfOnPremise, principalPropagation],
-    { SAP_AI_DEV_TOOLKIT_CREDENTIALS_FILE: credentialsPath },
-    () => {}
-  );
-  assert.deepEqual(result[0].credentials, {
-    host: internet.backendUrl, user: 'INTERNET_USER', password: 'internet-secret', mode: 'direct'
-  });
-  assert.deepEqual(result[1].credentials, { user: 'BAS_USER', password: 'bas-secret', mode: 'bas-tunnel' });
-  assert.equal(result[1].credentials.host, undefined, 'OnPremise must not bypass the BAS destination route');
-  assert.deepEqual(result[2].childEnv, {
-    HTTP_PROXY: 'http://127.0.0.1:3333', SAP_USER: 'CF_USER', SAP_PASSWORD: 'cf-secret', SAP_VERBOSE: 'false'
-  });
-  assert.equal(result[3].childEnv.SAP_USER, 'configured-user', 'PrincipalPropagation must not receive a Basic override');
-  assert.equal(result[3].childEnv.SAP_PASSWORD, 'configured-password');
-});
-
-test('help exits before BAS destination discovery', async t => {
-  let requests = 0;
-  const server = createServer((_request, response) => {
-    requests++;
-    response.setHeader('content-type', 'application/json');
-    response.end('[]');
-  });
-  await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
-  t.after(() => new Promise(resolve => server.close(resolve)));
-
-  const result = await runLauncher(['--help'], { ...process.env, H2O_URL: `http://127.0.0.1:${server.address().port}`, NO_PROXY: '127.0.0.1' });
-  assert.equal(result.code, 0, result.stderr);
-  assert.equal(result.stderr, '');
-  assert.match(result.stdout, /Usage: sap-ai-dev/);
-  assert.match(result.stdout, /Use an MCP client to call server tools/);
-  assert.equal(requests, 0);
-});
-
-test('doctor reports missing BAS configuration as redacted JSON', async () => {
-  const result = await runLauncher(['--doctor', '--json'], {
-    ...process.env,
-    H2O_URL: '',
-    SAP_AI_DEV_TOOLKIT_DESTINATION_SOURCE: '',
-    BAS_VSP_DESTINATION_SOURCE: ''
-  });
-  assert.equal(result.code, 1);
-  assert.equal(result.stderr, '');
-  assert.deepEqual(JSON.parse(result.stdout), {
-    ok: false,
-    destinations: 0,
-    checks: [{
-      name: '-',
-      stage: 'destination discovery',
-      status: 'failed',
-      detail: 'H2O_URL is required for BAS destination discovery'
-    }]
-  });
-});
-
-test('doctor preflights the failing ADT endpoint through the runtime relay and repairs its owned config', async t => {
-  const directory = await mkdtemp(join(tmpdir(), 'bas-doctor-csrf-'));
-  const configPath = join(directory, 'mcp.json');
-  const config = {
-    servers: {
-      'doctor-system': {
-        type: 'stdio',
-        command: 'sap-ai-dev',
-        env: {
-          H2O_URL: 'http://stale-bas.example',
-          SAP_AI_DEV_TOOLKIT_DESTINATION: 'doctor-system'
-        },
-        BAS_EXT: 'true'
-      },
-      ActionS4D_100: { type: 'stdio', command: 'third-party' }
-    }
-  };
-  await writeFile(configPath, JSON.stringify(config));
-  const requests = [];
-  const server = createServer((request, response) => {
-    let requestPath;
-    try { requestPath = new URL(request.url, `http://${request.headers.host}`).pathname; }
-    catch { requestPath = request.url; }
-    requests.push({ method: request.method, path: requestPath, csrf: request.headers['x-csrf-token'], cookie: request.headers.cookie });
-    if (request.url === '/api/listDestinations') {
-      response.setHeader('content-type', 'application/json');
-      response.end(JSON.stringify([{
-        Name: 'doctor-system',
-        WebIDEEnabled: true,
-        'HTML5.DynamicDestination': true,
-        WebIDEUsage: 'dev_abap',
-        Authentication: 'BasicAuthentication'
-      }]));
-      return;
-    }
-    if (requestPath === '/sap/bc/adt/discovery' && request.method === 'GET' && request.headers['x-csrf-token'] === 'Fetch') {
-      // Real SAP issues CSRF tokens from GET-capable endpoints only.
-      response.writeHead(200, {
-        'x-csrf-token': 'doctor-token',
-        'set-cookie': 'sap-session=doctor-session; Path=/'
-      });
-      response.end('<ok/>');
-      return;
-    }
-    if (requestPath === '/sap/bc/adt/datapreview/freestyle') {
-      if (request.method === 'POST'
-        && request.headers['x-csrf-token'] === 'doctor-token'
-        && String(request.headers.cookie).includes('sap-session=doctor-session')) {
-        response.writeHead(200);
-        response.end('<written/>');
-        return;
-      }
-      response.writeHead(403, { 'x-csrf-token': 'Required' });
-      response.end('CSRF token validation failed');
-      return;
-    }
-    response.writeHead(200);
-    response.end('<ok/>');
-  });
-  await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
-  t.after(async () => {
-    await new Promise(resolve => server.close(resolve));
-    await rm(directory, { recursive: true, force: true });
-  });
-  const proxy = `http://127.0.0.1:${server.address().port}`;
-  const result = await runLauncher(['--doctor', '--json'], {
-    ...process.env,
-    SAP_AI_DEV_TOOLKIT_BINARY: fakeVsp,
-    FAKE_RELAY_CSRF_TEST: 'true',
-    SAP_AI_DEV_MCP_CONFIG: configPath,
-    SAP_AI_DEV_TOOLKIT_DESTINATION: 'doctor-system',
-    H2O_URL: `http://127.0.0.1:${server.address().port}`,
-    HTTP_PROXY: proxy,
-    http_proxy: proxy,
-    NO_PROXY: '127.0.0.1,localhost',
-    no_proxy: '127.0.0.1,localhost'
-  });
-  assert.equal(result.code, 0, `${result.stdout}\n${result.stderr}`);
-  const report = JSON.parse(result.stdout);
-  assert.equal(report.ok, true);
-  assert.ok(report.checks.some(check => check.stage === 'BAS relay CSRF preflight' && check.status === 'passed'));
-  assert.ok(report.checks.some(check => check.stage === 'SAP system check' && check.status === 'passed'));
-  assert.ok(report.checks.some(check => check.stage === 'MCP config repair' && check.status === 'passed' && /1 managed BAS entry repaired/.test(check.detail)));
-  assert.ok(report.checks.some(check => check.stage === 'MCP tools/list' && /total MCP tools returned; chat-picker binding is host-managed/.test(check.detail)));
-  assert.ok(requests.some(request => request.method === 'GET' && request.path === '/sap/bc/adt/discovery' && request.csrf === 'Fetch'));
-  assert.ok(requests.some(request => request.method === 'POST' && request.path === '/sap/bc/adt/datapreview/freestyle' && request.csrf === 'doctor-token' && String(request.cookie).includes('sap-session=doctor-session')));
-  const repairedConfig = JSON.parse(await readFile(configPath, 'utf8'));
-  assert.equal(repairedConfig.servers['doctor-system'].env.H2O_URL, `http://127.0.0.1:${server.address().port}`);
-  assert.deepEqual(repairedConfig.servers.ActionS4D_100, config.servers.ActionS4D_100);
-});
-
-test('doctor stops before GetSystemInfo when the runtime CSRF preflight receives no token', async t => {
-  const directory = await mkdtemp(join(tmpdir(), 'bas-doctor-csrf-missing-cookie-'));
-  const configPath = join(directory, 'mcp.json');
-  await writeFile(configPath, JSON.stringify({ servers: {} }));
-  const requests = [];
-  const server = createServer((request, response) => {
-    let requestPath;
-    try { requestPath = new URL(request.url, `http://${request.headers.host}`).pathname; }
-    catch { requestPath = request.url; }
-    requests.push({ method: request.method, path: requestPath, csrf: request.headers['x-csrf-token'] });
-    if (request.url === '/api/listDestinations') {
-      response.setHeader('content-type', 'application/json');
-      response.end(JSON.stringify([{
-        Name: 'doctor-system',
-        WebIDEEnabled: true,
-        'HTML5.DynamicDestination': true,
-        WebIDEUsage: 'dev_abap',
-        Authentication: 'BasicAuthentication'
-      }]));
-      return;
-    }
-    if (requestPath === '/sap/bc/adt/discovery' && request.method === 'GET' && request.headers['x-csrf-token'] === 'Fetch') {
-      // Issues no token at all: the relay must fail closed before any write.
-      response.writeHead(200);
-      response.end('<ok/>');
-      return;
-    }
-    response.writeHead(200);
-    response.end('<ok/>');
-  });
-  await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
-  t.after(async () => {
-    await new Promise(resolve => server.close(resolve));
-    await rm(directory, { recursive: true, force: true });
-  });
-  const proxy = `http://127.0.0.1:${server.address().port}`;
-  const result = await runLauncher(['--doctor', '--json'], {
-    ...process.env,
-    SAP_AI_DEV_TOOLKIT_BINARY: fakeVsp,
-    FAKE_RELAY_CSRF_TEST: 'true',
-    SAP_AI_DEV_MCP_CONFIG: configPath,
-    SAP_AI_DEV_TOOLKIT_DESTINATION: 'doctor-system',
-    H2O_URL: `http://127.0.0.1:${server.address().port}`,
-    HTTP_PROXY: proxy,
-    http_proxy: proxy,
-    NO_PROXY: '127.0.0.1,localhost',
-    no_proxy: '127.0.0.1,localhost'
-  });
-  assert.equal(result.code, 1);
-  const report = JSON.parse(result.stdout);
-  assert.equal(report.ok, false);
-  assert.ok(report.checks.some(check => check.stage === 'BAS relay CSRF preflight' && check.status === 'failed' && /cookies=0; usableSession=false/.test(check.detail)));
-  assert.ok(report.checks.some(check => check.stage === 'SAP system check' && check.status === 'skipped' && /validated BAS proxy tunnel credential override/.test(check.detail)));
-  assert.equal(requests.some(request => request.method === 'GET' && request.path === '/sap/bc/adt/discovery' && request.csrf === 'Fetch'), true);
-  assert.equal(requests.some(request => request.method === 'POST' && request.path === '/sap/bc/adt/datapreview/freestyle'), false, 'doctor must not call GetSystemInfo after a failed preflight');
-});
-
-test('list-destinations JSON is redacted and probes through the BAS proxy', async () => {
-  const requests = [];
-  const server = createServer((request, response) => {
-    requests.push({ host: request.headers.host, path: request.url });
-    if (request.url === '/api/listDestinations') {
-      response.setHeader('content-type', 'application/json');
-      response.end(JSON.stringify([{ Name: 'launch-system', WebIDEEnabled: true, 'HTML5.DynamicDestination': true, WebIDEUsage: 'dev_abap', Authentication: 'PrincipalPropagation', Password: 'do-not-print' }]));
-      return;
-    }
-    response.writeHead(403);
-    response.end();
-  });
-  await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
-  const port = server.address().port;
-  const result = await runLauncher(['--list-destinations', '--json'], { ...process.env, H2O_URL: `http://127.0.0.1:${port}`, HTTP_PROXY: `http://127.0.0.1:${port}`, HTTPS_PROXY: `http://127.0.0.1:${port}`, NO_PROXY: '127.0.0.1' });
-  await new Promise(resolve => server.close(resolve));
-  assert.equal(result.code, 0, result.stderr);
-  assert.deepEqual(JSON.parse(result.stdout), [{ name: 'launch-system', client: '001', authentication: 'PrincipalPropagation', probe: 'auth-required' }]);
-  assert.deepEqual(requests, [
-    { host: `127.0.0.1:${port}`, path: '/api/listDestinations' },
-    { host: 'launch-system.dest', path: 'http://launch-system.dest/sap/bc/adt/discovery' }
-  ]);
-  assert.equal(result.stdout.includes('do-not-print'), false);
-});
-test('runtime starts destinations even when their ADT probes fail', async () => {
-  const server = createServer((request, response) => {
-    if (request.url.includes('/api/listDestinations')) {
-      response.setHeader('content-type', 'application/json');
-      response.end(JSON.stringify([{ Name: 'launch-system', WebIDEEnabled: true, 'HTML5.DynamicDestination': true, WebIDEUsage: 'dev_abap' }]));
-      return;
-    }
-    response.writeHead(503);
-    response.end();
-  });
-  await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
-  const proxy = `http://127.0.0.1:${server.address().port}`;
-  try {
-    const result = await runLauncher([], {
-      ...process.env,
-      SAP_AI_DEV_TOOLKIT_BINARY: fakeVsp,
-      H2O_URL: 'http://bas.example',
-      SAP_AI_DEV_TOOLKIT_DESTINATION: 'launch-system',
-      HTTP_PROXY: proxy,
-      http_proxy: proxy,
-      NO_PROXY: '',
-      no_proxy: ''
-    });
-    assert.equal(result.code, 0, result.stderr);
-    assert.equal(result.stdout, '');
-    assert.match(result.stderr, /launch-system: probe=unavailable \(HTTP 503\)/);
-    assert.match(result.stderr, /starting MCP proxy for launch-system \(client=001\)/);
-    assert.match(result.stderr, /\[launch-system\] starting VSP child/);
-  } finally {
-    await new Promise(resolve => server.close(resolve));
-  }
-});
-test('setup subprocess writes one isolated MCP entry per selected destination', async () => {
-  const directory = await mkdtemp(join(tmpdir(), 'bas-launcher-setup-'));
-  const bin = join(directory, 'bin');
-  await mkdir(bin);
-  const cfCli = join(bin, 'cf');
-  await writeFile(cfCli, '#!/bin/sh\nexit 1\n');
-  await chmod(cfCli, 0o755);
-  const config = join(directory, 'mcp.json');
-  await writeFile(config, JSON.stringify({ inputs: [], servers: {
-    unrelated: { type: 'stdio', command: 'other' },
-    'alpha-system': {
-      type: 'stdio',
-      command: 'bas-vsp-mcp',
-      env: { H2O_URL: 'http://old-h2o.example', BAS_VSP_DESTINATION: 'alpha-system' },
-      BAS_EXT: 'true'
-    }
-  } }));
-  const server = createServer((request, response) => {
-    if (request.url === '/api/listDestinations') {
-      response.setHeader('content-type', 'application/json');
-      response.end(JSON.stringify([
-        { Name: 'alpha-system', WebIDEEnabled: true, 'HTML5.DynamicDestination': true, WebIDEUsage: 'dev_abap', 'SAP-Client': '100' },
-        { Name: 'beta-system', WebIDEEnabled: true, 'HTML5.DynamicDestination': true, WebIDEUsage: 'dev_abap', 'SAP-Client': '200' }
-      ]));
-      return;
-    }
-    response.writeHead(404);
-    response.end();
-  });
-  await new Promise(resolve => server.listen(0, '127.0.0.1', resolve));
-  const env = { ...process.env, PATH: `${bin}:${process.env.PATH || ''}`, H2O_URL: `http://127.0.0.1:${server.address().port}`, SAP_AI_DEV_TOOLKIT_SKIP_PROBE: 'true', SAP_AI_DEV_TOOLKIT_MCP_CONFIG: config };
-  try {
-    const first = await runLauncherTty(env, 'a\r', ['--setup', '--npx']);
-    assert.equal(first.code, 0, `${first.stdout}\n${first.stderr}`);
-    let current = JSON.parse(await readFile(config, 'utf8'));
-    let generated = Object.entries(current.servers).filter(([, entry]) => entry.BAS_EXT === 'true');
-    assert.deepEqual(generated.map(([, entry]) => entry.env.SAP_AI_DEV_TOOLKIT_DESTINATION), ['alpha-system', 'beta-system'], `${first.stdout}\n${first.stderr}`);
-    assert.equal(current.servers['alpha-system'].env.BAS_VSP_DESTINATION, undefined);
-    assert.equal(generated.every(([, entry]) => entry.env.H2O_URL === env.H2O_URL), true);
-    const packageJson = JSON.parse(await readFile(new URL('../package.json', import.meta.url), 'utf8'));
-    assert.deepEqual(generated.map(([, entry]) => [entry.command, entry.args]), [
-      ['npx', ['--yes', '--ignore-scripts', `--package=sap-ai-dev-toolkit@${packageJson.version}`, 'sap-ai-dev']],
-      ['npx', ['--yes', '--ignore-scripts', `--package=sap-ai-dev-toolkit@${packageJson.version}`, 'sap-ai-dev']]
-    ]);
-    const second = await runLauncherTty(env, '\r', ['--setup', '--npx']);
-    assert.equal(second.code, 0, `${second.stdout}\\n${second.stderr}`);
-    current = JSON.parse(await readFile(config, 'utf8'));
-    generated = Object.keys(current.servers).filter(name => name !== 'unrelated');
-    assert.deepEqual(generated, []);
-    assert.deepEqual(current.servers.unrelated, { type: 'stdio', command: 'other' });
-  } finally {
-    await new Promise(resolve => server.close(resolve));
-    await rm(directory, { recursive: true, force: true });
-  }
-});
-
-test('non-BAS list mode reports the required discovery boundary', async () => {
-  const result = await runLauncher(['--list-destinations', '--json'], { ...process.env, H2O_URL: '' });
-  assert.equal(result.code, 1);
-  assert.match(result.stderr, /H2O_URL is required/);
-});

package/test/live-s4h.test.mjs

@@ -1,204 +0,0 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import { spawn } from 'node:child_process';
-import { once } from 'node:events';
-import { readFile } from 'node:fs/promises';
-import { homedir } from 'node:os';
-import { join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { slugifyDestination } from '../src/bas-discovery.mjs';
-import { snakeCaseName, TOOL_NAME_PREFIX } from '../src/mcp-proxy.mjs';
-
-const launcher = fileURLToPath(new URL('../src/launcher.mjs', import.meta.url));
-const LIVE = /^(1|true|yes)$/iu.test(process.env.SAP_AI_DEV_LIVE_S4H || '');
-const DESTINATION = process.env.SAP_AI_DEV_LIVE_DESTINATION || 'S4H';
-const SLUG = process.env.SAP_AI_DEV_LIVE_DESTINATION_SLUG || slugifyDestination(DESTINATION);
-const REQUEST_TIMEOUT_MS = Number(process.env.SAP_AI_DEV_LIVE_TIMEOUT_MS || 45_000);
-
-async function readConfiguredServer() {
-  if (/^(0|false|no)$/iu.test(process.env.SAP_AI_DEV_LIVE_USE_MCP_CONFIG || '')) return null;
-  const candidates = [
-    process.env.SAP_AI_DEV_MCP_CONFIG,
-    process.env.BAS_VSP_MCP_CONFIG,
-    join(homedir(), '.vscode', 'data', 'User', 'mcp.json'),
-    join(homedir(), '.vscode-server', 'data', 'User', 'mcp.json'),
-    join(homedir(), '.code-server', 'data', 'User', 'mcp.json')
-  ].filter(Boolean);
-  for (const path of candidates) {
-    let parsed;
-    try {
-      parsed = JSON.parse(await readFile(path, 'utf8'));
-    } catch {
-      continue;
-    }
-    const server = parsed?.servers?.[SLUG] || parsed?.servers?.[DESTINATION];
-    if (server?.command) return { path, server };
-  }
-  return null;
-}
-
-class StdioMcpClient {
-  constructor(command, args, env) {
-    this.child = spawn(command, args, { env, stdio: ['pipe', 'pipe', 'pipe'] });
-    this.nextId = 1;
-    this.pending = new Map();
-    this.stdout = '';
-    this.stderr = '';
-    this.notifications = [];
-    this.child.stdout.setEncoding('utf8');
-    this.child.stderr.setEncoding('utf8');
-    this.child.stdout.on('data', chunk => this.#onStdout(chunk));
-    this.child.stderr.on('data', chunk => { this.stderr += chunk; });
-    this.child.on('exit', (code, signal) => {
-      const error = new Error(`MCP process exited (${code ?? signal})\n${this.stderr.slice(-4000)}`);
-      for (const pending of this.pending.values()) pending.reject(error);
-      this.pending.clear();
-    });
-  }
-
-  #onStdout(chunk) {
-    this.stdout += chunk;
-    let newline;
-    while ((newline = this.stdout.indexOf('\n')) >= 0) {
-      const line = this.stdout.slice(0, newline).trim();
-      this.stdout = this.stdout.slice(newline + 1);
-      if (!line) continue;
-      let message;
-      try {
-        message = JSON.parse(line);
-      } catch (error) {
-        for (const pending of this.pending.values()) pending.reject(new Error(`Invalid JSON-RPC line: ${line}`));
-        this.pending.clear();
-        return;
-      }
-      if (message.id === undefined || message.id === null) {
-        this.notifications.push(message);
-        continue;
-      }
-      const pending = this.pending.get(message.id);
-      if (!pending) continue;
-      this.pending.delete(message.id);
-      clearTimeout(pending.timeout);
-      if (message.error) pending.reject(Object.assign(new Error(message.error.message), { response: message }));
-      else pending.resolve(message.result);
-    }
-  }
-
-  request(method, params) {
-    const id = this.nextId++;
-    const payload = { jsonrpc: '2.0', id, method, ...(params === undefined ? {} : { params }) };
-    return new Promise((resolve, reject) => {
-      const timeout = setTimeout(() => {
-        this.pending.delete(id);
-        reject(new Error(`Timed out waiting for ${method}\n${this.stderr.slice(-4000)}`));
-      }, REQUEST_TIMEOUT_MS);
-      this.pending.set(id, { resolve, reject, timeout });
-      this.child.stdin.write(`${JSON.stringify(payload)}\n`);
-    });
-  }
-
-  notify(method, params) {
-    this.child.stdin.write(`${JSON.stringify({ jsonrpc: '2.0', method, ...(params === undefined ? {} : { params }) })}\n`);
-  }
-
-  async close() {
-    this.child.stdin.end();
-    this.child.kill('SIGTERM');
-    await Promise.race([
-      once(this.child, 'exit').catch(() => {}),
-      new Promise(resolve => setTimeout(resolve, 1500))
-    ]);
-    if (!this.child.killed) this.child.kill('SIGKILL');
-  }
-}
-
-function textPayload(result) {
-  return (result?.content || []).filter(item => item.type === 'text').map(item => item.text).join('\n');
-}
-
-async function withLiveClient(t) {
-  const configured = await readConfiguredServer();
-  const server = configured?.server;
-  const command = process.env.SAP_AI_DEV_LIVE_COMMAND || server?.command || process.execPath;
-  const args = process.env.SAP_AI_DEV_LIVE_COMMAND
-    ? (process.env.SAP_AI_DEV_LIVE_ARGS ? JSON.parse(process.env.SAP_AI_DEV_LIVE_ARGS) : [])
-    : (server?.command ? (server.args || []) : [launcher]);
-  const client = new StdioMcpClient(command, args, {
-    ...process.env,
-    ...(server?.env || {}),
-    SAP_AI_DEV_TOOLKIT_DESTINATION: server?.env?.SAP_AI_DEV_TOOLKIT_DESTINATION || DESTINATION,
-    SAP_AI_DEV_TOOLKIT_MODE: process.env.SAP_AI_DEV_TOOLKIT_MODE || server?.env?.SAP_AI_DEV_TOOLKIT_MODE || 'expert',
-    SAP_ALLOW_TRANSPORTABLE_EDITS: process.env.SAP_ALLOW_TRANSPORTABLE_EDITS || server?.env?.SAP_ALLOW_TRANSPORTABLE_EDITS || 'true'
-  });
-  t.after(() => client.close());
-  const initialized = await client.request('initialize', { protocolVersion: '2024-11-05', capabilities: {}, clientInfo: { name: 'sap-ai-dev-live-test', version: '1.0.0' } });
-  client.notify('notifications/initialized');
-  assert.equal(initialized.serverInfo.name, SLUG);
-  return client;
-}
-
-test('live S4H MCP exposes a curated ABAP lifecycle surface under 60 tools', { skip: LIVE ? false : 'set SAP_AI_DEV_LIVE_S4H=1 to run against a live BAS/S4H destination' }, async t => {
-  const client = await withLiveClient(t);
-  const listed = await client.request('tools/list', {});
-  const tools = listed.tools || [];
-  const names = new Set(tools.map(tool => tool.name));
-  const prefix = `${TOOL_NAME_PREFIX}${SLUG}_`;
-
-  assert.ok(tools.length > 25, `expected a useful ABAP lifecycle surface, got ${tools.length}`);
-  assert.ok(tools.length < 60, `curated destination tool count must stay below 60, got ${tools.length}`);
-  assert.ok(tools.every(tool => tool.name.startsWith(prefix)), 'every tool is destination-prefixed for the selected S4H server');
-
-  for (const required of [
-    'LintABAP', 'GetSystemInfo', 'GetConnectionInfo', 'GetFeatures',
-    'SearchObject', 'GrepObjects', 'GrepPackages', 'GetSource', 'WriteSource', 'EditSource', 'CompareSource',
-    'SyntaxCheck', 'PrettyPrint', 'Activate', 'RunUnitTests', 'RunATCCheck', 'GetInactiveObjects',
-    'GetClass', 'GetProgram', 'GetPackage', 'GetTable', 'GetTableContents', 'RunQuery',
-    'GetTransport', 'GetTransportInfo', 'ListTransports', 'CreateTransport',
-    'GetApplicationLog', 'PrepareABAPChangeSet', 'ApplyABAPChangeSet', 'CheckTransportReadiness', 'PlanABAPCloudMigration'
-  ]) {
-    assert.ok(names.has(`${prefix}${snakeCaseName(required)}`), `expected curated lifecycle tool ${required}`);
-  }
-
-  for (const hidden of [
-    'SAP', 'ReleaseTransport', 'DeleteTransport', 'DeleteObject', 'ExecuteABAP', 'CallRFC',
-    'ListSQLTraces', 'AnalyzeABAPCode', 'CreateObject', 'CreateClassWithTests', 'WriteClass', 'UpdateSource'
-  ]) {
-    assert.equal(names.has(`${prefix}${snakeCaseName(hidden)}`), false, `broad/destructive tool ${hidden} must remain hidden`);
-  }
-});
-
-test('live S4H MCP handles safe local and read-only SAP calls', { skip: LIVE ? false : 'set SAP_AI_DEV_LIVE_S4H=1 to run against a live BAS/S4H destination' }, async t => {
-  const client = await withLiveClient(t);
-  const prefix = `${TOOL_NAME_PREFIX}${SLUG}_`;
-  await client.request('tools/list', {});
-
-  const lint = await client.request('tools/call', {
-    name: `${prefix}lint_abap`,
-    arguments: { files: [{ filename: 'zlive_probe.prog.abap', source: "REPORT zlive_probe.\nWRITE / 'ok'.\n" }] }
-  });
-  const lintJson = JSON.parse(textPayload(lint));
-  assert.equal(lintJson.filesChecked, 1);
-
-  for (const [tool, args] of [
-    ['GetSystemInfo', {}],
-    ['GetConnectionInfo', {}],
-    ['GetFeatures', {}],
-    ['GetInstalledComponents', {}]
-  ]) {
-    const result = await client.request('tools/call', { name: `${prefix}${snakeCaseName(tool)}`, arguments: args });
-    assert.notEqual(result.isError, true, `${tool} returned an MCP tool error: ${textPayload(result)}`);
-  }
-
-  const query = await client.request('tools/call', {
-    name: `${prefix}run_query`,
-    arguments: { sql_query: 'SELECT * FROM T000', max_rows: 1 }
-  });
-  assert.notEqual(query.isError, true, `RunQuery returned an MCP tool error: ${textPayload(query)}`);
-  assert.match(textPayload(query), /T000|MANDT|client|rows|\[/iu);
-
-  const appLog = await client.request('tools/call', {
-    name: `${prefix}get_application_log`,
-    arguments: { max_results: 1 }
-  });
-  assert.notEqual(appLog.isError, true, `GetApplicationLog returned an MCP tool error: ${textPayload(appLog)}`);
-});