sap-ai-dev-toolkit 0.3.4 → 0.4.0

package/test/mcp-proxy.test.mjs

@@ -5,24 +5,13 @@ import { tmpdir } from 'node:os';
 import { join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { once } from 'node:events';
-import { childArguments, MCPProxy } from '../src/mcp-proxy.mjs';
+import { childArguments, MCPProxy, PUBLIC_VSP_TOOLS } from '../src/mcp-proxy.mjs';
 import { PassThrough } from 'node:stream';
 
 const fixture = fileURLToPath(new URL('./fixtures/fake-vsp.mjs', import.meta.url));
-const REQUESTED_TOOLS = [
-  'AnalyzeABAPCode', 'AnalyzeCallGraph', 'CodeCompletion', 'GetAbapHelp',
-  'GetCallGraph', 'GetCalleesOf', 'GetCallersOf', 'GetCodeCoverage',
-  'GetConnectionInfo', 'GetObjectStructure', 'GetTypeHierarchy', 'GetTypeInfo',
-  'GrepObject', 'GrepPackage', 'CallRFC', 'DebuggerAttach', 'DebuggerDetach',
-  'DebuggerGetStack', 'DebuggerGetVariables', 'DebuggerListen', 'DebuggerStep',
-  'DeleteBreakpoint', 'GetBreakpoints', 'GetDump', 'GetSQLTraceState', 'GetTrace',
-  'ListDumps', 'SetBreakpoint', 'CloneObject', 'CreateAndActivateProgram',
-  'CreateClassWithTests', 'CreateObject', 'CreateTestInclude', 'DeleteObject',
-  'ExecuteABAP', 'GetClass', 'GetClassComponents', 'GetClassInclude', 'GetFunction',
-  'GetInclude', 'GetInterface', 'GetProgram', 'GetStructure', 'GetTransaction',
-  'LockObject', 'MoveObject', 'RecoverFailedCreate', 'RenameObject', 'SaveToFile',
-  'UnlockObject', 'UpdateClassInclude', 'UpdateSource', 'WriteClass', 'WriteProgram',
-  'CreateTransport', 'ListDependencies', 'PublishServiceBinding', 'UnpublishServiceBinding'
+const HIDDEN_VSP_TOOLS = [
+  'AnalyzeABAPCode', 'DebuggerListen', 'DeleteBreakpoint', 'DeleteObject', 'ExecuteABAP', 'ReleaseTransport',
+  'DeleteTransport', 'SAP', 'ListSQLTraces', 'PublishServiceBinding', 'UnpublishServiceBinding'
 ];
 
 
@@ -166,22 +155,23 @@ test('merges paged tools and routes calls to the selected child', async t => {
   assert.deepEqual(lintTool.inputSchema.required, ['files']);
   assert.deepEqual(lintTool.inputSchema.properties.files.items.required, ['filename', 'source']);
 
+  const localWorkflowTools = [
+    'LintABAP', 'GetApplicationLog', 'PrepareABAPChangeSet', 'ApplyABAPChangeSet',
+    'CheckTransportReadiness', 'PlanABAPCloudMigration', 'GenerateRAPRegressionSuite', 'RunRAPRegressionSuite'
+  ];
   for (const destination of ['alpha', 'beta']) {
-    for (const toolName of REQUESTED_TOOLS) {
-      assert.ok(names.has(`${destination}__${toolName}`), `${destination} exposes ${toolName}`);
+    for (const toolName of PUBLIC_VSP_TOOLS) {
+      assert.ok(names.has(`${destination}__${toolName}`), `${destination} exposes curated ${toolName}`);
     }
-    for (const coreTool of [
-      'GetSource', 'RunQuery', 'GetSystemInfo', 'GetInstalledComponents',
-      'GetFeatures', 'GetAPIReleaseState', 'PrettyPrint', 'ListTransports',
-      'GetTransport', 'GetUserTransports', 'GetTransportInfo',
-      'GetApplicationLog', 'ActivateMultiple'
-    ]) {
-      assert.ok(names.has(`${destination}__${coreTool}`), `${destination} exposes ${coreTool}`);
+    for (const toolName of localWorkflowTools) {
+      assert.ok(names.has(`${destination}__${toolName}`), `${destination} exposes local ${toolName}`);
     }
-    for (const formerlyExcludedTool of ['ListSQLTraces', 'ReleaseTransport', 'DeleteTransport', 'SAP']) {
-      assert.ok(names.has(`${destination}__${formerlyExcludedTool}`), `${destination} exposes ${formerlyExcludedTool}`);
+    for (const hiddenTool of HIDDEN_VSP_TOOLS) {
+      assert.equal(names.has(`${destination}__${hiddenTool}`), false, `${destination} hides ${hiddenTool}`);
     }
   }
+  assert.equal(listed.result.tools.filter(tool => tool.name.startsWith('alpha__')).length, PUBLIC_VSP_TOOLS.size + localWorkflowTools.length);
+  assert.equal(PUBLIC_VSP_TOOLS.size + localWorkflowTools.length, 59);
 
   const requiredArguments = {
     GetFeatures: [],
@@ -234,11 +224,7 @@ test('merges paged tools and routes calls to the selected child', async t => {
       params: { type: 'delete' }
     }],
     ['ActivateMultiple', { objects: ['PROG ZDEMO'] }],
-    ['CreateTransport', {}],
-    ['ReleaseTransport', {}],
-    ['DeleteTransport', {}],
-    ['ListSQLTraces', {}],
-    ['SAP', { action: 'analyze', params: { type: 'application_log' } }]
+    ['CreateTransport', {}]
   ];
   for (const [index, [name, arguments_]] of additionalCalls.entries()) {
     const response = await proxy.handle({

package/test/setup.test.mjs

@@ -70,7 +70,7 @@ function runPostinstallInPty(env, keys, assetsAnswer = '\r') {
         selectionSent = true;
         child.stdin.write(keys);
       }
-      if (!assetsAnswerSent && stdout.includes('Install the bundled agents and eleven skills')) {
+      if (!assetsAnswerSent && stdout.includes('Install the bundled agents and all skills')) {
         assetsAnswerSent = true;
         child.stdin.write(assetsAnswer);
       }
@@ -90,6 +90,7 @@ function runPostinstallInPty(env, keys, assetsAnswer = '\r') {
 async function assertUserCopilotAssets(home) {
   const copilotRoot = join(home, '.copilot');
   assert.equal((await stat(join(copilotRoot, 'agents', 'abap-developer.agent.md'))).isFile(), true);
+  assert.equal((await stat(join(copilotRoot, 'agents', 'hana-cloud-hdi-specialist.agent.md'))).isFile(), true);
   const skillNames = (await readdir(join(copilotRoot, 'skills'))).sort();
   assert.deepEqual(skillNames, [
     'abap-debugging',
@@ -98,6 +99,9 @@ async function assertUserCopilotAssets(home) {
     'abap-testing-quality',
     'cds-development',
     'clean-core-extensibility',
+    'hana-cloud-inspection',
+    'hana-cloud-native-development',
+    'hana-cloud-validation',
     'rap-development',
     'rap-service-delivery',
     'sap-sdlc-orchestration',
@@ -279,13 +283,13 @@ test('global postinstall completes BAS selection before optional Copilot assets'
   const declineLogs = `${declined.stdout}\n${declined.stderr}`;
   assert.match(declineLogs, /Configured 0 MCP servers/);
   assert.match(declineLogs, /\[Y\/n\]/);
-  assert.match(declineLogs, /Press Enter to install the bundled agents and eleven skills in the path shown below; type n then press Enter to skip/);
+  assert.match(declineLogs, /Press Enter to install the bundled agents and all skills in the path shown below; type n then press Enter to skip/);
   assert.match(declineLogs, /🤖 sap-ai-dev-toolkit/);
   assert.match(declineLogs, /\u001b\[1;35m/);
   assert.match(declineLogs, /Optional Copilot setup is waiting for your choice/);
   assert.match(declineLogs, /Copilot agent and skills were skipped\. Your files were not changed/);
   assert.ok(declineLogs.indexOf('Optional Copilot setup is waiting for your choice') > declineLogs.indexOf('Configured 0 MCP servers'), declineLogs);
-  assert.ok(declineLogs.indexOf('Install the bundled agents and eleven skills') > declineLogs.indexOf('Optional Copilot setup is waiting for your choice'), declineLogs);
+  assert.ok(declineLogs.indexOf('Install the bundled agents and all skills') > declineLogs.indexOf('Optional Copilot setup is waiting for your choice'), declineLogs);
   assert.ok(declineLogs.indexOf('No MCP server entries are configured for this add-on.') > declineLogs.indexOf('Copilot agent and skills were skipped'), declineLogs);
   assert.ok(declineLogs.includes(`MCP config file: ${config}`), declineLogs);
   const configAfterDecline = JSON.parse(await readFile(config, 'utf8'));
@@ -297,9 +301,9 @@ test('global postinstall completes BAS selection before optional Copilot assets'
   assert.equal(accepted.selectionSent, true, accepted.stdout);
   assert.equal(accepted.assetsAnswerSent, true, accepted.stdout);
   const acceptLogs = `${accepted.stdout}\n${accepted.stderr}`;
-  assert.ok(acceptLogs.indexOf('Install the bundled agents and eleven skills') > acceptLogs.indexOf('Configured 1 MCP server'), acceptLogs);
-  assert.match(acceptLogs, /Installed 15 Copilot files/);
-  assert.ok(acceptLogs.indexOf('Installation configuration summary') > acceptLogs.indexOf('Installed 15 Copilot files'), acceptLogs);
+  assert.ok(acceptLogs.indexOf('Install the bundled agents and all skills') > acceptLogs.indexOf('Configured 1 MCP server'), acceptLogs);
+  assert.match(acceptLogs, /Installed 19 Copilot files/);
+  assert.ok(acceptLogs.indexOf('Installation configuration summary') > acceptLogs.indexOf('Installed 19 Copilot files'), acceptLogs);
   assert.ok(acceptLogs.includes(`MCP config file: ${config}`), acceptLogs);
   assert.ok(acceptLogs.includes('Destination: BAS · alpha-system · client 100 · Basic'), acceptLogs);
   assert.ok(acceptLogs.includes('Launch: stdio · sap-ai-dev'), acceptLogs);

package/tools.md

@@ -1,79 +1,87 @@
+# Curated VSP tools exposed through the BAS proxy
 
-# Additional VSP tools exposed through the BAS proxy
+The proxy no longer advertises every VSP tool. To keep the developer-lifecycle MCP surface manageable, each generated one-destination server exposes a cherry-picked set of VSP tools plus local workflow tools (currently 59 tools when all curated VSP capabilities are registered).
 
-The proxy forwards these tools when the installed VSP mode registers them. They extend its existing curated tool set.
+Hidden upstream VSP tools are not directly callable through the proxy. Local workflow tools may still call hidden or non-advertised upstream operations internally when they are required for a bounded workflow.
 
-## Analysis, metadata, debugging, and trace
+## Public VSP tools
 
-- `AnalyzeABAPCode`
-- `AnalyzeCallGraph`
-- `CodeCompletion`
-- `GetAbapHelp`
-- `GetCallGraph`
-- `GetCalleesOf`
-- `GetCallersOf`
-- `GetCodeCoverage`
-- `GetConnectionInfo`
-- `GetObjectStructure`
-- `GetTypeHierarchy`
-- `GetTypeInfo`
-- `GrepObject`
-- `GrepPackage`
-- `CallRFC`
+- `Activate`
+- `ActivateMultiple`
+- `CompareSource`
+- `CreateTransport`
 - `DebuggerAttach`
 - `DebuggerDetach`
 - `DebuggerGetStack`
 - `DebuggerGetVariables`
-- `DebuggerListen`
 - `DebuggerStep`
-- `DeleteBreakpoint`
+- `EditSource`
+- `FindDefinition`
+- `FindReferences`
+- `GetAPIReleaseState`
 - `GetBreakpoints`
-- `GetDump`
-- `GetSQLTraceState`
-- `GetTrace`
-- `ListDumps`
-- `SetBreakpoint`
-
-## Object, source, transport, and service operations
-
-- `CloneObject`
-- `CreateAndActivateProgram`
-- `CreateClassWithTests`
-- `CreateObject`
-- `CreateTestInclude`
-- `DeleteObject`
-- `ExecuteABAP`
+- `GetCDSDependencies`
+- `GetCDSElementInfo`
+- `GetCDSImpactAnalysis`
 - `GetClass`
 - `GetClassComponents`
 - `GetClassInclude`
+- `GetClassInfo`
+- `GetConnectionInfo`
+- `GetContext`
+- `GetFeatures`
 - `GetFunction`
+- `GetFunctionGroup`
+- `GetInactiveObjects`
 - `GetInclude`
+- `GetInstalledComponents`
 - `GetInterface`
+- `GetPackage`
 - `GetProgram`
-- `GetStructure`
-- `GetTransaction`
-- `LockObject`
-- `MoveObject`
-- `RecoverFailedCreate`
-- `RenameObject`
-- `SaveToFile`
-- `UnlockObject`
-- `UpdateClassInclude`
-- `UpdateSource`
-- `WriteClass`
-- `WriteProgram`
-- `CreateTransport`
+- `GetSource`
+- `GetSystemInfo`
+- `GetTable`
+- `GetTableContents`
+- `GetTransport`
+- `GetTransportInfo`
+- `GetUserTransports`
+- `GrepObjects`
+- `GrepPackages`
 - `ListDependencies`
-- `PublishServiceBinding`
-- `UnpublishServiceBinding`
+- `ListTransports`
+- `PrettyPrint`
+- `RunATCCheck`
+- `RunQuery`
+- `RunUnitTests`
+- `SearchObject`
+- `SetBreakpoint`
+- `SyntaxCheck`
+- `WriteSource`
+
+## Hidden from direct proxy calls
+
+Broad/destructive surfaces such as object deletion, SQL trace, arbitrary SAP router calls, transport release/delete, RFC execution, debugger listen/delete-breakpoint helpers, and one-off generator/update helpers are intentionally not advertised by the BAS proxy.
 
 ## Destination-scoped workflow tools
 
 The proxy adds local multi-step tools to each destination when their required VSP capabilities are available:
 
+- `LintABAP` — local in-memory ABAP linting.
+- `GetApplicationLog` — bounded convenience mapping to the upstream SAP application-log route when available.
 - `PrepareABAPChangeSet` and `ApplyABAPChangeSet` — review full-source diffs and recheck source before explicit writes.
 - `CheckTransportReadiness` — collect a whitelisted bundle of transport, dependency, inactive-object, ABAP Unit, and ATC results.
 - `PlanABAPCloudMigration` — batch SAP API release-state checks and prioritize recognized unreleased results.
 - `GenerateRAPRegressionSuite` and `RunRAPRegressionSuite` — create and run reusable OData GET-only checks under the selected service root.
 
 `sap-ai-dev-toolkit --doctor` checks destination probing, VSP startup, `GetSystemInfo`, and MCP tool listing. `sap-ai-dev-toolkit --demo` runs the sample tools and OData fixtures without contacting SAP; demo writes and transport creation remain in memory until that process exits.
+
+## Separate optional HANA Cloud inspector
+
+The optional `hana-cloud-inspector` companion starts `sap-ai-hana` as a separate stdio MCP server. It does not use the VSP proxy, BAS destination prefix, or ABAP SQL `RunQuery`. When selected and configured with a dedicated read-only identity, it exposes:
+
+- `hana_connection_info` — verify the configured endpoint, service/binding, current user, schema, and TLS state without returning credentials.
+- `hana_list_objects` — list tables/views in the bound HDI schema, with a 200-object maximum.
+- `hana_describe_object` — inspect columns for a catalog-verified object in that schema.
+- `hana_read_rows` — perform parameterized reads of selected columns, capped at 200 rows; credential-like columns are blocked and arbitrary SQL is not accepted.
+
+Connection secrets are read from the MCP host environment via explicit `HANA_RO_*` variables or a selected `VCAP_SERVICES` binding and are not written to `mcp.json`. TLS certificate verification is mandatory. No HANA write, DDL/DML, deploy/undeploy, grants, or service-key tools are exposed; deployment remains a user-run project workflow.