sap-adt-mcp 0.8.2 → 0.8.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sap-adt-mcp",
-  "version": "0.8.2",
+  "version": "0.8.4",
   "description": "MCP server giving Claude live access to SAP systems via ADT (ABAP Development Tools) REST. Read source, search, run syntax checks, and edit ABAP objects from any MCP-compatible client.",
   "type": "module",
   "main": "src/server.js",

package/src/adt-client.js

@@ -240,6 +240,21 @@ export class AdtClient {
           { cause: err }
         );
       }
+      // undici throws a generic "fetch failed" whose real reason (ECONNRESET,
+      // ENOTFOUND, TLS error, socket hang up…) lives on err.cause. Surface a
+      // clear message and carry the underlying code so this reads as the
+      // network/environment problem it is — not a tool bug.
+      if (err instanceof TypeError && /fetch failed/i.test(err.message ?? "")) {
+        const cause = err.cause;
+        const reason = cause?.code || cause?.message || "network error";
+        const wrapped = new Error(
+          `ADT request failed (${method} ${adtPath}): ${reason}. ` +
+            `Check connectivity to the SAP host, VPN, and TLS/cert settings.`
+        );
+        wrapped.code = cause?.code ?? "ADT_FETCH_FAILED";
+        wrapped.cause = err;
+        throw wrapped;
+      }
       throw err;
     } finally {
       clearTimeout(timer);

package/src/object-uris.js

@@ -72,6 +72,9 @@ export function normalizeType(input) {
 
 export function objectUri({ type, name, group }) {
   const t = normalizeType(type);
+  if (typeof name !== "string" || name.length === 0) {
+    throw new Error("Object name is required");
+  }
   const n = name.toLowerCase();
   switch (t) {
     case "PROG":

package/src/reporter.js

@@ -29,9 +29,10 @@ const MAX_FIELD = 4000;
 
 const SKIP_NAMES = new Set(["ReadOnlyViolationError", "AbortError"]);
 
-// Configuration / setup mistakes — the user's environment, not a bug.
+// Configuration / setup mistakes and input-validation errors — the user's
+// environment or a mis-shaped tool call, not a bug in the tool.
 const SKIP_MESSAGE_RE =
-  /(No config found|must be a non-empty string|env var .* is not set|No system specified|Unknown system '|No systems configured|password must be a string|Failed to parse config)/i;
+  /(No config found|must be a non-empty string|env var .* is not set|No system specified|Unknown system '|No systems configured|password must be a string|Failed to parse config|is required\b|Unsupported object type|ADT request failed|ADT request timed out|fetch failed)/i;
 
 // Network / TLS problems live on the user's side (firewall, VPN, cert, host down).
 const NETWORK_CODES = new Set([
@@ -48,15 +49,30 @@ const NETWORK_CODES = new Set([
   "UNABLE_TO_VERIFY_LEAF_SIGNATURE",
   "CERT_HAS_EXPIRED",
   "ERR_TLS_CERT_ALTNAME_INVALID",
+  // undici / our wrapped network failures.
+  "ADT_FETCH_FAILED",
+  "UND_ERR_SOCKET",
+  "UND_ERR_CONNECT_TIMEOUT",
+  "UND_ERR_HEADERS_TIMEOUT",
+  "UND_ERR_BODY_TIMEOUT",
+  "EPROTO",
+  "ECONNABORTED",
 ]);
 
+function isNetworkError(err) {
+  if (err?.code && NETWORK_CODES.has(err.code)) return true;
+  // undici nests the real reason on .cause.
+  if (err?.cause?.code && NETWORK_CODES.has(err.cause.code)) return true;
+  return false;
+}
+
 // Authentication / authorization — wrong credentials or missing SAP roles.
 const AUTH_RE = /\b(401|403)\b|unauthor|forbidden|invalid credential|logon failed/i;
 
 function shouldReport(err) {
   if (!err) return false;
   if (SKIP_NAMES.has(err.name)) return false;
-  if (err.code && NETWORK_CODES.has(err.code)) return false;
+  if (isNetworkError(err)) return false;
   const msg = String(err.message ?? "");
   if (SKIP_MESSAGE_RE.test(msg)) return false;
   if (AUTH_RE.test(msg)) return false;
@@ -168,6 +184,12 @@ const BUSINESS_TYPE_RE =
 // toward NOT reporting; the relay labels survivors `auto-adt-error` for cheap
 // human triage.
 function shouldReportAdt(meta = {}) {
+  // adt_request is the raw escape hatch — the caller fully specifies the
+  // method/path/headers, so a non-2xx is their request shape, not a tool defect.
+  // Never auto-file these (the agent improvising over the escape hatch would
+  // otherwise spam the tracker).
+  if (meta.tool === "adt_request") return false;
+
   const s = Number(meta.status);
   const type = String(meta.type ?? "");
   const t100id = String(meta.t100?.id ?? "");

package/src/tools/discovery.js

@@ -314,8 +314,17 @@ export function register({ getClient }) {
     },
 
     adt_list_packages: async (args) => {
+      // `package` is the field name on the sibling adt_browse_package tool, so
+      // callers reach for it here too — accept it as an alias for `root`.
+      const rootArg = args.root ?? args.package;
+      if (typeof rootArg !== "string" || rootArg.length === 0) {
+        return textResult(
+          "adt_list_packages: `root` is required (the root package to walk from, e.g. 'ZFLEET').",
+          true
+        );
+      }
       const { client, name: sys } = getClient(args.system);
-      const root = args.root.toUpperCase();
+      const root = rootArg.toUpperCase();
       const max = args.maxPackages ?? 200;
       const prefix = args.prefix ?? defaultDescendPrefix(root);
 

package/src/tools/source.js

@@ -1,6 +1,6 @@
 import { sourceUri, objectUri, normalizeType, METADATA_XML_ACCEPT } from "../object-uris.js";
 import { acquireLock, releaseLock } from "../lock.js";
-import { errorResult, jsonResult } from "../result.js";
+import { errorResult, jsonResult, textResult } from "../result.js";
 import { OBJECT_TYPE_HINT, SYSTEM_HINT } from "./_shared.js";
 
 const TOP_LEVEL_KEYWORDS = [
@@ -272,6 +272,19 @@ export const tools = [
 export function register({ getClient }) {
   return {
     adt_get_source: async (args) => {
+      if (typeof args.object !== "string" || args.object.length === 0) {
+        const hint =
+          args.name !== undefined
+            ? " (you passed `name` — the field is `object`)"
+            : "";
+        return textResult(
+          `adt_get_source: \`object\` is required${hint}. Also use \`firstLine\`/\`lastLine\` (not \`line\`/\`endLine\`) to paginate.`,
+          true
+        );
+      }
+      if (typeof args.type !== "string" || args.type.length === 0) {
+        return textResult("adt_get_source: `type` is required (e.g. 'class', 'program', 'dataelement').", true);
+      }
       const { client, name: sys } = getClient(args.system);
       const t = normalizeType(args.type);
       const path = sourceUri({