saltcorn-samba 0.3.2 → 0.3.4

package/CHANGELOG.md

@@ -4,6 +4,33 @@ All notable changes to `saltcorn-samba` are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 and this project adheres to [Semantic Versioning](https://semver.org/).
 
+## [0.3.4] – 2026-07-05
+
+### Fixed
+- **`function is not iterable` beim Installieren behoben.**
+  In v0.3.3 hatte ich überkompensiert: der Manifest-Key `dependencies`
+  wurde in eine Factory-Funktion umgewandelt — Saltcorn liest `dependencies`
+  jedoch NICHT über `withCfg`, sondern iteriert es direkt mit `for..of`
+  ([`saltcorn-data/models/plugin.ts` Zeile 638](https://github.com/saltcorn/saltcorn/blob/master/packages/saltcorn-data/models/plugin.ts)).
+  Deshalb muss `dependencies` ein statisches Array bleiben. Alle anderen
+  Keys (viewtemplates, routes, headers) werden weiterhin über `withCfg`
+  gelesen und bleiben Factory-Funktionen. Ein ausführlicher Header-Kommentar
+  über `module.exports` dokumentiert nun beide Zugriffsmuster.
+
+## [0.3.3] – 2026-07-05
+
+### Fixed
+- **`plugin[key] is not a function` beim Installieren behoben.**
+  Saltcorns Plugin-Loader ruft — sobald ein Plugin `configuration_workflow`
+  exportiert — *jeden* weiteren Manifest-Key als Funktion mit der aktuellen
+  Konfiguration als Argument auf (siehe
+  [saltcorn-data/db/state.ts, Fn `withCfg`](https://github.com/saltcorn/saltcorn/blob/master/packages/saltcorn-data/db/state.ts)).
+  In v0.3.2 waren `viewtemplates`, `routes`, `headers` und `dependencies`
+  jedoch statische Arrays — der Aufruf `plugin.viewtemplates(cfg)` warf
+  daher den Fehler. Alle Keys sind jetzt Factory-Funktionen, die den Wert
+  zurückgeben. `plugin_name` als Top-Level-Key wurde entfernt (aus
+  demselben Grund unaufrufbar).
+
 ## [0.3.2] – 2026-07-05
 
 ### Fixed

package/index.js

@@ -607,15 +607,48 @@ function wrapView(v) {
 // Manifest
 // ---------------------------------------------------------------------------
 
+// ---------------------------------------------------------------------------
+// IMPORTANT: how Saltcorn reads the manifest
+// ---------------------------------------------------------------------------
+// Two access patterns coexist in Saltcorn's plugin loader:
+//
+// 1. `withCfg(key)` in `saltcorn-data/db/state.ts` — when a plugin exports
+//    `configuration_workflow`, this helper calls `plugin[key](cfg)` and then
+//    iterates the return value. Any key it consults MUST therefore be a
+//    factory function that returns the real value.
+//    Keys consumed via `withCfg`: types, viewtemplates, functions,
+//    modelpatterns, fileviews, actions, eventTypes, fonts, icons,
+//    table_providers, authentication, exchange, copilot_skills,
+//    external_tables, headers, routes, capacitor_plugins.
+//
+// 2. Direct property access in `saltcorn-data/models/plugin.ts` — the
+//    loader reads a handful of keys straight off the module, WITHOUT going
+//    through `withCfg`. Those must be the raw value (not a function).
+//    Direct-access keys: dependencies (for..of loop), onLoad (called as fn),
+//    authentication (truthy check + later withCfg), user_config_form,
+//    plugin_name (string), layout / types / functions / viewtemplates
+//    (truthy checks in the plugin-store info card).
+//
+// The intersection is where confusion lives:
+// - `dependencies` is read *directly* as an iterable and MUST be an array.
+// - `viewtemplates`, `routes`, `headers` etc. are read via `withCfg` and
+//   MUST be functions when `configuration_workflow` is present.
+//
+// See:
+//   https://github.com/saltcorn/saltcorn/blob/master/packages/saltcorn-data/db/state.ts
+//   https://github.com/saltcorn/saltcorn/blob/master/packages/saltcorn-data/models/plugin.ts
+// ---------------------------------------------------------------------------
+
 module.exports = {
   sc_plugin_api_version: 1,
-  plugin_name: PLUGIN_NAME,
   configuration_workflow,
-  viewtemplates: [wrapView(fileManagerView), wrapView(treeView)],
-  routes,
-  headers: [
+  // The four keys below are consumed via `withCfg` → must be factory fns.
+  viewtemplates: () => [wrapView(fileManagerView), wrapView(treeView)],
+  routes: () => routes,
+  headers: () => [
     { css: `/plugins/public/${PLUGIN_NAME}/samba.css` },
   ],
+  // `dependencies` is iterated directly (for..of) → must be a raw array.
   dependencies: [],
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "saltcorn-samba",
-  "version": "0.3.2",
+  "version": "0.3.4",
   "description": "Saltcorn plugin: browse, upload, rename and delete files on a Samba/CIFS share. File-manager view, directory tree, inline PDF viewer, external-app open (smb://).",
   "main": "index.js",
   "scripts": {