saltcorn-samba 0.3.2 → 0.3.3

package/CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to `saltcorn-samba` are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 and this project adheres to [Semantic Versioning](https://semver.org/).
 
+## [0.3.3] – 2026-07-05
+
+### Fixed
+- **`plugin[key] is not a function` beim Installieren behoben.**
+  Saltcorns Plugin-Loader ruft — sobald ein Plugin `configuration_workflow`
+  exportiert — *jeden* weiteren Manifest-Key als Funktion mit der aktuellen
+  Konfiguration als Argument auf (siehe
+  [saltcorn-data/db/state.ts, Fn `withCfg`](https://github.com/saltcorn/saltcorn/blob/master/packages/saltcorn-data/db/state.ts)).
+  In v0.3.2 waren `viewtemplates`, `routes`, `headers` und `dependencies`
+  jedoch statische Arrays — der Aufruf `plugin.viewtemplates(cfg)` warf
+  daher den Fehler. Alle Keys sind jetzt Factory-Funktionen, die den Wert
+  zurückgeben. `plugin_name` als Top-Level-Key wurde entfernt (aus
+  demselben Grund unaufrufbar).
+
 ## [0.3.2] – 2026-07-05
 
 ### Fixed

package/index.js

@@ -607,16 +607,28 @@ function wrapView(v) {
 // Manifest
 // ---------------------------------------------------------------------------
 
+// ---------------------------------------------------------------------------
+// IMPORTANT: how Saltcorn iterates the manifest
+// ---------------------------------------------------------------------------
+// When a plugin exports `configuration_workflow`, Saltcorn's state loader
+// treats EVERY other manifest key as a factory function and calls it with the
+// current plugin configuration — see
+// packages/saltcorn-data/db/state.ts `withCfg` (`plugin[key](cfg || {})`).
+// So each key below must be a function that returns the value, otherwise
+// Node throws `plugin[key] is not a function`. The only exceptions are the
+// bookkeeping keys `sc_plugin_api_version` and `configuration_workflow`
+// itself, which the loader accesses directly.
+// ---------------------------------------------------------------------------
+
 module.exports = {
   sc_plugin_api_version: 1,
-  plugin_name: PLUGIN_NAME,
   configuration_workflow,
-  viewtemplates: [wrapView(fileManagerView), wrapView(treeView)],
-  routes,
-  headers: [
+  viewtemplates: () => [wrapView(fileManagerView), wrapView(treeView)],
+  routes: () => routes,
+  headers: () => [
     { css: `/plugins/public/${PLUGIN_NAME}/samba.css` },
   ],
-  dependencies: [],
+  dependencies: () => [],
 };
 
 // Note: the `samba_pdf` fieldview shipped in v0.1–0.3.1 has been removed from

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "saltcorn-samba",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Saltcorn plugin: browse, upload, rename and delete files on a Samba/CIFS share. File-manager view, directory tree, inline PDF viewer, external-app open (smb://).",
   "main": "index.js",
   "scripts": {