salmon-loop 0.4.1 → 0.5.0

package/dist/core/llm/retry-utils.js

@@ -1,4 +1,8 @@
+/**
+ * Utility for retrying asynchronous operations with exponential backoff.
+ */
 import { LIMITS } from '../config/limits.js';
+import { getLogger } from '../observability/logger.js';
 const DEFAULT_OPTIONS = {
     maxRetries: LIMITS.retry.api.maxAttempts,
     initialDelayMs: LIMITS.retry.api.initialDelayMs,
@@ -42,8 +46,9 @@ export async function withRetry(fn, options = {}) {
             try {
                 await opts.onRetry({ attempt: attempt + 1, delayMs: effectiveDelay, error });
             }
-            catch {
+            catch (retryHandlerError) {
                 // Ignore onRetry handler failures.
+                getLogger().debug(`[RetryUtils] onRetry handler failed: ${retryHandlerError instanceof Error ? retryHandlerError.message : String(retryHandlerError)}`);
             }
             await new Promise((resolve, reject) => {
                 const timer = setTimeout(() => {
@@ -91,8 +96,9 @@ export async function* withStreamRetry(streamFactory, options = {}) {
             try {
                 await opts.onRetry({ attempt: attempt + 1, delayMs: effectiveDelay, error });
             }
-            catch {
+            catch (retryHandlerError) {
                 // Ignore onRetry handler failures.
+                getLogger().debug(`[RetryUtils] onRetry handler failed (stream): ${retryHandlerError instanceof Error ? retryHandlerError.message : String(retryHandlerError)}`);
             }
             await new Promise((resolve, reject) => {
                 const timer = setTimeout(() => {

package/dist/core/llm/stream-utils.js

@@ -1,3 +1,4 @@
+import { getLogger } from '../observability/logger.js';
 function normalizeToolInput(raw) {
     if (typeof raw !== 'string')
         return raw;
@@ -12,14 +13,15 @@ function normalizeToolInput(raw) {
                 try {
                     parsed = JSON.parse(nested);
                 }
-                catch {
-                    // ignored
+                catch (error) {
+                    getLogger().debug(`[StreamUtils] Failed to parse nested JSON string: ${error instanceof Error ? error.message : String(error)}`);
                 }
             }
         }
         return parsed;
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[StreamUtils] Failed to normalize tool input JSON: ${error instanceof Error ? error.message : String(error)}`);
         return raw;
     }
 }

package/dist/core/llm/sub-agent-factory.js

@@ -23,6 +23,9 @@ function resolveModelId(alias) {
  */
 export function createSubAgentLlmFactory(baseProvider) {
     return (modelAlias) => {
+        // 'inherit' means use the parent LLM — don't create a new instance.
+        if (!modelAlias || modelAlias === 'inherit')
+            return undefined;
         const modelId = resolveModelId(modelAlias);
         if (baseProvider.type === 'openai-compatible' || baseProvider.type === 'openai') {
             const clientPackage = baseProvider.clientPackage === '@ai-sdk/openai'

package/dist/core/mcp/bridge/resource-context-provider.js

@@ -1,3 +1,4 @@
+import { getLogger } from '../../observability/logger.js';
 import { ResourceCache } from '../cache/resource-cache.js';
 export class ResourceContextProviderError extends Error {
     diagnostic;
@@ -252,7 +253,8 @@ function normalizeText(text, mimeType) {
     try {
         return JSON.stringify(JSON.parse(text), null, 2);
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[ResourceContextProvider] Failed to normalize JSON text: ${error instanceof Error ? error.message : String(error)}`);
         return text;
     }
 }

package/dist/core/mcp/catalog/discovery.js

@@ -1,3 +1,4 @@
+import { getLogger } from '../../observability/logger.js';
 import { withPromptServer } from './prompt-catalog.js';
 import { withResourceServer, withResourceTemplateServer } from './resource-catalog.js';
 import { withToolServer } from './tool-catalog.js';
@@ -5,7 +6,8 @@ async function safeList(fn, fallback) {
     try {
         return await fn();
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[McpDiscovery] safeList call failed, returning fallback: ${error instanceof Error ? error.message : String(error)}`);
         return fallback;
     }
 }

package/dist/core/mcp/client/connection-manager.js

@@ -208,8 +208,9 @@ export class McpConnectionManager {
             try {
                 await entry.client.unsubscribeResource({ uri }, { timeout: LIMITS.defaultToolTimeoutMs });
             }
-            catch {
+            catch (error) {
                 // best-effort unsubscribe during shutdown
+                getLogger().debug(`[McpConnectionManager] Failed to unsubscribe resource ${uri}: ${error instanceof Error ? error.message : String(error)}`);
             }
         }
         entry.subscribedResources.clear();
@@ -224,8 +225,9 @@ export class McpConnectionManager {
             }
             await entry.client.close();
         }
-        catch {
+        catch (error) {
             // best-effort shutdown
+            getLogger().debug(`[McpConnectionManager] Error during connection shutdown: ${error instanceof Error ? error.message : String(error)}`);
         }
     }
     view(entry) {

package/dist/core/mcp/client/transport-factory.js

@@ -1,6 +1,7 @@
 import { PassThrough } from 'node:stream';
 import { StreamableHTTPClientTransport } from '@modelcontextprotocol/sdk/client/streamableHttp.js';
 import { ReadBuffer, serializeMessage } from '@modelcontextprotocol/sdk/shared/stdio.js';
+import { getLogger } from '../../observability/logger.js';
 import { spawnInteractiveProcess } from '../../runtime/process-runner.js';
 export function buildStrictStdioEnvironment(env) {
     return { ...env };
@@ -81,16 +82,18 @@ export class StrictStdioClientTransport {
         try {
             child.stdin?.end?.();
         }
-        catch {
+        catch (error) {
             // best-effort shutdown
+            getLogger().debug(`[TransportFactory] Error ending stdin: ${error instanceof Error ? error.message : String(error)}`);
         }
         await Promise.race([closePromise, unrefTimeout(2_000)]);
         if (child.exitCode === null) {
             try {
                 child.kill('SIGTERM');
             }
-            catch {
+            catch (error) {
                 // best-effort shutdown
+                getLogger().debug(`[TransportFactory] Error sending SIGTERM: ${error instanceof Error ? error.message : String(error)}`);
             }
             await Promise.race([closePromise, unrefTimeout(2_000)]);
         }
@@ -98,8 +101,9 @@ export class StrictStdioClientTransport {
             try {
                 child.kill('SIGKILL');
             }
-            catch {
+            catch (error) {
                 // best-effort shutdown
+                getLogger().debug(`[TransportFactory] Error sending SIGKILL: ${error instanceof Error ? error.message : String(error)}`);
             }
         }
         this.readBuffer.clear();

package/dist/core/observability/audit-file.js

@@ -28,8 +28,9 @@ async function writeJsonAtomic(targetPath, data) {
     try {
         await rename(tmpPath, targetPath);
     }
-    catch {
+    catch (error) {
         // Retry once with a fresh temp file to reduce transient rename failures.
+        getLogger().debug(`[AuditFile] Atomic rename failed, retrying: ${error instanceof Error ? error.message : String(error)}`);
         const retryTmpPath = path.join(dir, `.${base}.tmp-${process.pid}-${Date.now()}-retry`);
         await writeFile(retryTmpPath, payload);
         await rename(retryTmpPath, targetPath);

package/dist/core/observability/audit-trail.js

@@ -1,3 +1,4 @@
+import { getLogger } from './logger.js';
 const auditTrail = [];
 const auditContext = {};
 const DEFAULT_BUFFER_LIMITS = {
@@ -19,7 +20,8 @@ function estimateEventSize(event) {
     try {
         return Buffer.byteLength(JSON.stringify(event), 'utf-8');
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[AuditTrail] Failed to estimate event size: ${error instanceof Error ? error.message : String(error)}`);
         return 0;
     }
 }

package/dist/core/observability/logger.js

@@ -307,8 +307,9 @@ export class Logger {
             // Only remove from queue if write was successful
             this.logQueue.splice(0, contentToFlush.length);
         }
-        catch {
+        catch (error) {
             // Keep logs in queue for next retry
+            this.debug(`[Logger] Failed to flush logs to file: ${error instanceof Error ? error.message : String(error)}`);
         }
         finally {
             this.isFlushing = false;

package/dist/core/observability/monitor.js

@@ -177,6 +177,30 @@ export class Monitor {
     /**
      * Generate metrics report
      */
+    getStructuredReport() {
+        const durations = [...this.applyBackMetrics.durations].sort((a, b) => a - b);
+        return {
+            checkpoint: {
+                createAttempts: this.checkpointMetrics.createAttempts,
+                createFailures: this.checkpointMetrics.createFailures,
+                createFailureRate: this.getCheckpointCreateFailureRate(),
+                cleanupAttempts: this.checkpointMetrics.cleanupAttempts,
+                cleanupFailures: this.checkpointMetrics.cleanupFailures,
+            },
+            applyBack: {
+                attempts: this.applyBackMetrics.attempts,
+                failures: this.applyBackMetrics.failures,
+                avgDurationMs: this.getApplyBackAvgDuration(),
+                p50DurationMs: durations.length > 0 ? durations[Math.floor(durations.length * 0.5)] : 0,
+                p95DurationMs: durations.length > 0 ? durations[Math.floor(durations.length * 0.95)] : 0,
+            },
+            errors: this.errorHistory.toArray().map((e) => ({
+                type: e.type,
+                message: e.message,
+                timestamp: e.timestamp.toISOString(),
+            })),
+        };
+    }
     getMetricsReport() {
         let report = `\n${text.monitor.metricsTitle}\n`;
         report += `\n${text.monitor.checkpointCreation}\n`;

package/dist/core/observability/run-outcome-reporter.js

@@ -7,6 +7,7 @@ export function buildRunOutcomeReport(result) {
         safeHint: result.safeHint,
         remediationSteps: result.remediationSteps,
         attempts: result.attempts,
+        durationMs: result.durationMs,
         failurePhase: result.failurePhase,
         errorCode: result.errorCode,
         changedFiles: result.changedFiles,

package/dist/core/permission-gate/default-gate.js

@@ -93,19 +93,16 @@ class DefaultPermissionGate {
         };
     }
     mapAuthorizationDecision(decision) {
+        const source = decision.source === 'auto' || decision.source === 'allowlist' ? 'policy' : decision.source;
         if (decision.outcome === 'deny') {
-            return {
-                kind: 'deny',
-                reason: decision.reason ?? 'denied',
-                source: decision.source === 'auto' || decision.source === 'allowlist'
-                    ? 'policy'
-                    : decision.source,
-            };
+            return { kind: 'deny', reason: decision.reason ?? 'denied', source };
         }
         return {
             kind: 'allow',
             reason: decision.reason,
-            source: decision.source === 'auto' || decision.source === 'allowlist' ? 'policy' : decision.source,
+            source,
+            ttlMs: decision.ttlMs,
+            persist: decision.persist,
         };
     }
 }

package/dist/core/plan/storage.js

@@ -1,6 +1,7 @@
 import { randomBytes, createHash } from 'crypto';
 import path from 'path';
 import { mkdir, readFile, rename, stat, writeFile } from '../adapters/fs/node-fs.js';
+import { getLogger } from '../observability/logger.js';
 const SESSION_ID_RE = /^[a-zA-Z0-9_-]{6,64}$/;
 export function assertValidSessionId(sessionId) {
     if (!SESSION_ID_RE.test(sessionId)) {
@@ -31,8 +32,8 @@ async function resolveGitDir(repoRoot) {
         if (st.isDirectory())
             return dotGit;
     }
-    catch {
-        // ignore
+    catch (error) {
+        getLogger().debug(`[PlanStorage] .git stat failed: ${error instanceof Error ? error.message : String(error)}`);
     }
     try {
         const raw = await readFile(dotGit, 'utf-8');
@@ -43,7 +44,8 @@ async function resolveGitDir(repoRoot) {
         const gitdir = m[1].trim();
         return path.isAbsolute(gitdir) ? gitdir : path.resolve(repoRoot, gitdir);
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[PlanStorage] .git read failed: ${error instanceof Error ? error.message : String(error)}`);
         return null;
     }
 }
@@ -61,7 +63,8 @@ export async function ensureSalmonloopIgnored(repoRoot) {
     try {
         existing = await readFile(excludePath, 'utf-8');
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[PlanStorage] Failed to read git exclude file: ${error instanceof Error ? error.message : String(error)}`);
         existing = '';
     }
     if (existing.split('\n').some((l) => l.trim() === '.salmonloop/'))

package/dist/core/plugin/loader.js

@@ -1,4 +1,5 @@
 import { join } from 'path';
+import { pythonPlugin } from '../../languages/python/index.js';
 import { typescriptPlugin, tsxPlugin, javascriptPlugin } from '../../languages/typescript/index.js';
 import { readdir } from '../adapters/fs/node-fs.js';
 import { getLogger } from '../observability/logger.js';
@@ -19,10 +20,11 @@ export class PluginLoader {
         try {
             // Phase 1: Manually register TypeScript/JavaScript plugins
             getLogger().debug('Loading built-in plugins...');
+            this.registerWithValidation(registry, pythonPlugin);
             this.registerWithValidation(registry, typescriptPlugin);
             this.registerWithValidation(registry, tsxPlugin);
             this.registerWithValidation(registry, javascriptPlugin);
-            getLogger().debug(`Plugins loaded: ${typescriptPlugin.meta.name}, ${tsxPlugin.meta.name}, ${javascriptPlugin.meta.name}`);
+            getLogger().debug(`Plugins loaded: ${pythonPlugin.meta.name}, ${typescriptPlugin.meta.name}, ${tsxPlugin.meta.name}, ${javascriptPlugin.meta.name}`);
             // Phase 2: Load user plugins from .salmonloop/languages/
             if (repoPath) {
                 await this.loadUserPlugins(registry, repoPath);

package/dist/core/prompts/registry.js

@@ -156,7 +156,7 @@ export class PromptRegistry {
         return this.render('explore_system', { tools: this.getToolsForTemplate() });
     }
     renderAutopilotSystem() {
-        return this.render('autopilot_system', {});
+        return this.render('autopilot_system', { tools: this.getToolsForTemplate() });
     }
     renderAnswerSystem() {
         return this.render('answer_system', {});

package/dist/core/prompts/runtime.js

@@ -1,3 +1,4 @@
+import { getLogger } from '../observability/logger.js';
 import { resolvePhaseVisibleTools } from '../tools/tool-visibility.js';
 import { Phase } from '../types/runtime.js';
 import { getPromptRegistry } from './registry.js';
@@ -16,7 +17,8 @@ function extractTargetFiles(plan) {
         const files = parsed.files.filter((f) => typeof f === 'string');
         return files.length > 0 ? files.join(', ') : undefined;
     }
-    catch {
+    catch (error) {
+        getLogger().debug(`[PromptRuntime] Failed to extract target files from plan JSON: ${error instanceof Error ? error.message : String(error)}`);
         return undefined;
     }
 }

package/dist/core/prompts/templates/system/autopilot_system.hbs

@@ -1,11 +1,35 @@
 You are a coding assistant running in "autopilot" mode.
-Drive the task forward autonomously and answer in the same language as the user.
-Use the repository context available in the current turn when present.
-If no repository action is possible yet, explain the next best action succinctly.
-Prefer taking a reasonable repository action over asking the user for confirmation.
+Your job is to complete the given task by using the available tools to inspect and modify the repository.
+You MUST use tools to accomplish the task — do not just describe what needs to be done, actually do it.
+
+## Problem-Solving Strategy
+
+1. **Understand**: Read the problem statement carefully. Identify what is failing and what the expected behavior should be.
+2. **Locate**: Find the source file to fix AND all test files that will be affected. Use `code.search` to search for the rule name, function name, or error message across the entire codebase. Pay special attention to CLI integration tests, snapshot tests, and end-to-end tests that assert on the behavior you are changing. Read ALL affected test files before writing any code.
+3. **Diagnose**: Understand the root cause before writing any code. Read surrounding context, not just the error site.
+4. **Fix**: Write the minimal change that fixes the issue. Update ALL affected test files to match the new behavior. Do not refactor unrelated code.
+5. **Verify**: Run the FULL test suite with `shell.exec` (e.g. `pytest`). If tests fail, analyze the output and iterate. Do NOT run only targeted tests — behavioral changes cascade to other tests.
+
+## Efficiency Rules
+- Do NOT reproduce the bug. The problem statement already describes it. Go straight from understanding to fixing.
+- Do NOT run multiple exploratory shell commands. Read the source code, understand the logic, write the fix.
+- If you understand the root cause after reading the source, write the fix immediately. Do not verify the bug first.
+- IMPORTANT: The Locate step is not optional. Spending time finding all affected tests upfront saves rounds later.
+
+## Rules
+- After writing code, you MUST run tests with `shell.exec` to verify your changes. This is not optional — a fix without verification is incomplete.
+- If tests fail, read the failure output carefully, diagnose the issue, and fix it. Do not stop until tests pass. A failing test means your fix is incomplete — find all affected tests and update them.
+- Read test files before modifying code — tests define the expected behavior.
+- Do not modify test files unless the test itself is incorrect. If your fix changes behavior correctly, update the test's expected output to match.
+- Before writing any code, use `code.search` to find ALL tests that reference the changed behavior. Search for: the rule name (e.g. "L031"), the function name, error messages, and expected test output. CLI integration tests and snapshot tests often contain hardcoded expected output that must be updated when behavior changes.
+- Make the smallest possible change. Avoid unrelated refactoring or style changes.
+- Drive the task forward autonomously and answer in the same language as the user.
+
 Treat simple repo-relative paths like "smoke.txt", "README.md", or "src/index.ts" as valid paths from the repository root.
 Do not ask the user to validate a path that is already a valid relative path or can be inferred directly from the instruction.
 Use `interaction.ask_user` only when the task is genuinely ambiguous and you cannot safely infer the next action.
 When calling `interaction.ask_user`, the arguments MUST be valid JSON with exactly this shape: {"questions":[{"header":"Short header","question":"One clear question","options":[{"label":"Option 1","description":"Why pick it"},{"label":"Option 2","description":"Why pick it"}],"multiSelect":false}]}.
 Do not call `interaction.ask_user` with free-form strings, a single question field, string-only options, or empty options arrays.
 For simple file creation or edits, call `fs.write_file` directly with {"file":"relative/path.ext","content":"..."} instead of asking the user for the path again.
+
+{{> tool_defs}}

package/dist/core/protocols/a2a/sdk/executor.js

@@ -1,4 +1,5 @@
 import { InMemoryTaskStore } from '@a2a-js/sdk/server';
+import { getLogger } from '../../../observability/logger.js';
 import { buildCanonicalExecutionRequest, buildInstructionFromParts, } from '../../shared/execution-request.js';
 import { parseA2ASkillFlowMode } from '../../shared/flow-mode-mapping.js';
 export function createA2AInteractionExecutor(deps) {
@@ -346,7 +347,8 @@ export function createA2AInteractionExecutor(deps) {
                     data: JSON.parse(artifact.content),
                 };
             }
-            catch {
+            catch (error) {
+                getLogger().debug(`[A2AExecutor] Failed to parse artifact content as JSON: ${error instanceof Error ? error.message : String(error)}`);
                 // Fall through to text
             }
         }

package/dist/core/protocols/a2a/sdk/server.js

@@ -406,6 +406,7 @@ const normalizeA2AExtensionHeadersByVersion = (req, res, next) => {
     });
     next();
 };
+import { getLogger } from '../../../observability/logger.js';
 import { isRecord } from '../../../utils/serialize.js';
 const isObjectRecord = isRecord;
 function looksLikeTask(result) {
@@ -825,7 +826,8 @@ function normalizeSseJsonRpcChunkByMethod(chunk, method) {
             const payload = JSON.parse(line.slice('data: '.length));
             return `data: ${JSON.stringify(normalizeJsonRpcPayloadByMethod(method, payload))}`;
         }
-        catch {
+        catch (error) {
+            getLogger().debug(`[A2AServer] Failed to parse SSE JSON-RPC chunk: ${error instanceof Error ? error.message : String(error)}`);
             return line;
         }
     })

package/dist/core/protocols/acp/acp-command-runner.js

@@ -1,3 +1,4 @@
+import { getLogger } from '../../observability/logger.js';
 function sleep(ms) {
     if (ms <= 0)
         return Promise.resolve();
@@ -72,8 +73,8 @@ async function safeRelease(terminal) {
     try {
         await terminal.release();
     }
-    catch {
-        // Ignore release errors.
+    catch (error) {
+        getLogger().debug(`[AcpCommandRunner] Failed to release terminal: ${error instanceof Error ? error.message : String(error)}`);
     }
 }
 export function createAcpCommandRunner(params) {
@@ -134,8 +135,8 @@ export function createAcpCommandRunner(params) {
                         try {
                             await terminal.kill();
                         }
-                        catch {
-                            // Ignore kill errors.
+                        catch (error) {
+                            getLogger().debug(`[AcpCommandRunner] Failed to kill terminal on abort: ${error instanceof Error ? error.message : String(error)}`);
                         }
                         break;
                     }
@@ -144,8 +145,8 @@ export function createAcpCommandRunner(params) {
                         try {
                             await terminal.kill();
                         }
-                        catch {
-                            // Ignore kill errors.
+                        catch (error) {
+                            getLogger().debug(`[AcpCommandRunner] Failed to kill terminal on timeout: ${error instanceof Error ? error.message : String(error)}`);
                         }
                         break;
                     }

package/dist/core/protocols/acp/acp-session-persistence.js

@@ -1,6 +1,7 @@
 import { mkdir, open, readFile, rename, stat, unlink, writeFile, } from '../../adapters/fs/node-fs.js';
 import { defaultPathAdapter } from '../../adapters/path/path-adapter.js';
 import { recordAuditEvent } from '../../observability/audit-trail.js';
+import { getLogger } from '../../observability/logger.js';
 import { hashRepoPath, isPermissionPolicyValue, parseTimestamp, } from './acp-types.js';
 export function createAcpSessionPersistence(options) {
     const deletedSessionIds = new Map();
@@ -219,7 +220,8 @@ export function createAcpSessionPersistence(options) {
                     phase: 'PREFLIGHT',
                 });
             }
-            catch {
+            catch (error) {
+                getLogger().debug(`[AcpSessionPersistence] Failed to parse stale lock file: ${error instanceof Error ? error.message : String(error)}`);
                 try {
                     const lockStat = await stat(lockPath);
                     const ageMs = Date.now() - lockStat.mtimeMs;
@@ -231,8 +233,8 @@ export function createAcpSessionPersistence(options) {
                         }, { source: 'acp', severity: 'medium', scope: 'session', phase: 'PREFLIGHT' });
                     }
                 }
-                catch {
-                    // ignore
+                catch (innerError) {
+                    getLogger().debug(`[AcpSessionPersistence] Failed to stat lock file for age check: ${innerError instanceof Error ? innerError.message : String(innerError)}`);
                 }
             }
         };
@@ -246,7 +248,8 @@ export function createAcpSessionPersistence(options) {
                     await lockHandle.writeFile(JSON.stringify({ pid: process.pid, createdAtMs: Date.now() }), 'utf8');
                     break;
                 }
-                catch {
+                catch (error) {
+                    getLogger().debug(`[AcpSessionPersistence] Lock acquire attempt failed: ${error instanceof Error ? error.message : String(error)}`);
                     await tryClearStaleLock();
                     const delayMs = Math.min(250, 20 * (attempt + 1));
                     await new Promise((resolve) => setTimeout(resolve, delayMs));
@@ -271,8 +274,8 @@ export function createAcpSessionPersistence(options) {
                     const existingRaw = await readFile(options.path, 'utf8');
                     existing = normalizePersistedSessionStore(JSON.parse(existingRaw));
                 }
-                catch {
-                    // ignore read failure; writing fresh payload is acceptable
+                catch (error) {
+                    getLogger().debug(`[AcpSessionPersistence] Failed to read existing session store for merge: ${error instanceof Error ? error.message : String(error)}`);
                 }
                 const merged = new Map();
                 const mergedDeletedSessions = pruneDeletedSessionRecords([
@@ -311,14 +314,14 @@ export function createAcpSessionPersistence(options) {
                 try {
                     await lockHandle.close();
                 }
-                catch {
-                    // ignore
+                catch (error) {
+                    getLogger().debug(`[AcpSessionPersistence] Failed to close lock handle: ${error instanceof Error ? error.message : String(error)}`);
                 }
                 try {
                     await unlink(lockPath);
                 }
-                catch {
-                    // ignore
+                catch (error) {
+                    getLogger().debug(`[AcpSessionPersistence] Failed to unlink lock file: ${error instanceof Error ? error.message : String(error)}`);
                 }
             }
         }

package/dist/core/protocols/acp/formal-agent.js

@@ -3,6 +3,7 @@ import { text } from '../../../locales/index.js';
 import { defaultPathAdapter } from '../../adapters/path/path-adapter.js';
 import { inferTurnStopReasonFromFailure } from '../../interaction/turn-stop-reason.js';
 import { recordAuditEvent } from '../../observability/audit-trail.js';
+import { getLogger } from '../../observability/logger.js';
 import { toAcpPublicModes } from '../../public-capabilities/projections.js';
 import { buildPublicCapabilityRegistry } from '../../public-capabilities/registry.js';
 import { parseSlashInput } from '../../slash/parser.js';
@@ -641,8 +642,8 @@ export function createAcpFormalAgent(deps) {
         try {
             await emitSessionUpdate(sessionId, update);
         }
-        catch {
-            // Best-effort: do not fail the request due to notification delivery issues.
+        catch (error) {
+            getLogger().debug(`[AcpFormalAgent] Best-effort session info update failed: ${error instanceof Error ? error.message : String(error)}`);
         }
     }
     async function emitRuntimePlanUpdateIfNeeded(params) {

package/dist/core/protocols/acp/permission-provider.js

@@ -1,4 +1,5 @@
 import { text } from '../../../locales/index.js';
+import { getLogger } from '../../observability/logger.js';
 import { mapToolKind } from './tool-kind-mapping.js';
 function buildPermissionOptions() {
     return [
@@ -45,8 +46,8 @@ export function createAcpToolAuthorizationProvider(params) {
             };
             await params.conn.sessionUpdate({ sessionId: params.sessionId, update });
         }
-        catch {
-            // Best-effort: do not block authorization if the client can't accept updates.
+        catch (error) {
+            getLogger().debug(`[AcpPermissionProvider] Best-effort in_progress update failed: ${error instanceof Error ? error.message : String(error)}`);
         }
     };
     return {