sailkick-boat 0.22.0 → 0.22.1

package/lib/cloud/index.js

@@ -164,7 +164,23 @@ function createCloud (app, options = {}) {
     res.end(JSON.stringify(obj))
   }
 
+  // Signal K mounts plugin routers AFTER its own bodyParser.json(), so on that path the
+  // body is already parsed and the request stream is spent — listening for 'data'/'end'
+  // waits for events that will never fire, and the request hangs for ever with no error.
+  // (That is exactly what happened: the Sync page sat on "Signing in…".) On the mirror
+  // there is no body parser and the stream is live, so both paths must be handled.
   function readJson (req) {
+    if (req.body !== undefined && req.body !== null) {
+      if (typeof req.body === 'string') {
+        if (!req.body.trim()) return Promise.resolve(null)
+        try { return Promise.resolve(JSON.parse(req.body)) } catch { return Promise.resolve(undefined) }
+      }
+      if (typeof req.body === 'object') {
+        // bodyParser.json() gives {} for an absent body; treat that as "nothing sent".
+        return Promise.resolve(Object.keys(req.body).length || Array.isArray(req.body) ? req.body : null)
+      }
+    }
+    if (req.readableEnded || req.complete) return Promise.resolve(null) // stream already drained
     return new Promise((resolve) => {
       let size = 0
       const chunks = []

package/lib/profile/index.js

@@ -84,16 +84,32 @@ function createProfile (app, options = {}) {
   const badBody = (res, what) => send(res, 400, { ok: false, code: 'bad-body', message: `${what} must be a JSON object` })
   const failed = (res, e) => { lastError = e.message; warn(e.message); send(res, 500, { ok: false, code: 'profile-error', message: e.message }) }
 
+  // Signal K mounts plugin routers AFTER its own bodyParser.json(), so on that path the
+  // body is already parsed and the request stream is spent — listening for 'data'/'end'
+  // waits for events that will never fire, and the request hangs for ever with no error.
+  // (That is exactly what happened: the Sync page sat on "Signing in…".) On the mirror
+  // there is no body parser and the stream is live, so both paths must be handled.
   function readJson (req) {
-    return new Promise((resolve, reject) => {
+    if (req.body !== undefined && req.body !== null) {
+      if (typeof req.body === 'string') {
+        if (!req.body.trim()) return Promise.resolve(null)
+        try { return Promise.resolve(JSON.parse(req.body)) } catch { return Promise.resolve(undefined) }
+      }
+      if (typeof req.body === 'object') {
+        // bodyParser.json() gives {} for an absent body; treat that as "nothing sent".
+        return Promise.resolve(Object.keys(req.body).length || Array.isArray(req.body) ? req.body : null)
+      }
+    }
+    if (req.readableEnded || req.complete) return Promise.resolve(null) // stream already drained
+    return new Promise((resolve) => {
       let size = 0
       const chunks = []
       req.on('data', (c) => {
         size += c.length
-        if (size > MAX_BODY_BYTES) { reject(new Error('body too large')); req.destroy(); return }
+        if (size > MAX_BODY_BYTES) { req.destroy(); resolve(undefined); return }
         chunks.push(c)
       })
-      req.on('error', reject)
+      req.on('error', () => resolve(undefined))
       req.on('end', () => {
         const raw = Buffer.concat(chunks).toString('utf8')
         if (!raw.trim()) return resolve(null)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sailkick-boat",
-  "version": "0.22.0",
+  "version": "0.22.1",
   "description": "Run the sailkick app on board with no internet: charts, weather, climatology, trends and AIS all served from the boat itself. With a sailkick account it also syncs your metrics to the cloud in real time. Alpha, invite-only \u2014 info@sailkick.io",
   "main": "index.js",
   "scripts": {