safeword 0.2.4 → 0.2.6

package/packages/cli/templates/skills/safeword-quality-reviewer/SKILL.md

@@ -1,207 +0,0 @@
----
-name: quality-reviewer
-description: Deep code quality review with web research. Use when user explicitly requests verification against latest docs ('double check against latest', 'verify versions', 'check security'), needs deeper analysis beyond automatic hook, or is working on projects without SAFEWORD.md/CLAUDE.md. Fetches current documentation (WebFetch), checks latest versions (WebSearch), and provides deep analysis (performance, security, alternatives).
-allowed-tools: '*'
----
-
-# Quality Reviewer
-
-Deep quality review with web research to verify code against the latest ecosystem state.
-
-**Primary differentiator**: Web research (WebSearch, WebFetch) to verify against current versions, documentation, and best practices.
-
-**Triggers**:
-
-- **Explicit web research request**: "double check against latest docs", "verify we're using latest version", "check for security issues"
-- **Deep dive needed**: User wants analysis beyond automatic hook (performance, architecture alternatives, trade-offs)
-- **No SAFEWORD.md/CLAUDE.md**: Projects without context files (automatic hook won't run, manual review needed)
-- **Pre-change review**: User wants review before making changes (automatic hook only triggers after changes)
-- **Model-invoked**: Claude determines web research would be valuable
-
-**Relationship to automatic quality hook**:
-
-- **Automatic hook**: Fast quality check using existing knowledge + project context (guaranteed, runs on every change)
-- **This skill**: Deep review with web research when verification against current ecosystem is needed (on-demand, 2-3 min)
-
-## Review Protocol
-
-### 1. Identify What Changed
-
-Understand context:
-
-- What files were just modified?
-- What problem is being solved?
-- What was the implementation approach?
-
-### 2. Read Project Standards
-
-```bash
-ls CLAUDE.md SAFEWORD.md ARCHITECTURE.md .claude/
-```
-
-Read relevant standards:
-
-- `CLAUDE.md` or `SAFEWORD.md` - Project-specific guidelines
-- `ARCHITECTURE.md` - Architectural principles
-- `@./.safeword/guides/code-philosophy.md` - Core coding principles
-
-### 3. Evaluate Correctness
-
-**Will it work?**
-
-- Does the logic make sense?
-- Are there obvious bugs?
-
-**Edge cases:**
-
-- Empty inputs, null/undefined, boundary conditions (0, -1, max)?
-- Concurrent access, network failures?
-
-**Error handling:**
-
-- Are errors caught appropriately?
-- Helpful error messages?
-- Cleanup handled (resources, connections)?
-
-**Logic errors:**
-
-- Off-by-one errors, race conditions, wrong assumptions?
-
-### 4. Evaluate Anti-Bloat
-
-- Are all dependencies necessary? Could we use stdlib/built-ins?
-- Are abstractions solving real problems or imaginary ones?
-- YAGNI: Is this feature actually needed now?
-
-### 5. Evaluate Elegance
-
-- Is the code easy to understand?
-- Are names clear and descriptive?
-- Is the intent obvious?
-- Will this be easy to change later?
-
-### 6. Check Standards Compliance
-
-**Project standards** (from CLAUDE.md/SAFEWORD.md/ARCHITECTURE.md):
-
-- Does it follow established patterns?
-- Does it violate any documented principles?
-
-**Library best practices:**
-
-- Are we using libraries correctly?
-- Are we following official documentation?
-
-### 7. Verify Latest Versions ⭐ **PRIMARY VALUE**
-
-**CRITICAL**: This is your main differentiator from automatic hook. ALWAYS check versions.
-
-```
-WebSearch: "[library name] latest stable version 2025"
-WebSearch: "[library name] security vulnerabilities"
-```
-
-**Flag if outdated:**
-
-- Major versions behind → WARN (e.g., React 17 when 19 is stable)
-- Minor versions behind → NOTE (e.g., React 19.0.0 when 19.1.0 is stable)
-- Security vulnerabilities → CRITICAL (must upgrade)
-- Using latest → Confirm
-
-**Common libraries**: React, TypeScript, Vite, Next.js, Node.js, Vitest, Playwright, Jest, esbuild
-
-**Check even if dependencies didn't change** - User might be using outdated patterns.
-
-### 8. Verify Latest Documentation ⭐ **PRIMARY VALUE**
-
-**CRITICAL**: This is your main differentiator from automatic hook. ALWAYS verify against current docs.
-
-```
-WebFetch: https://react.dev (for React)
-WebFetch: https://vitejs.dev (for Vite)
-WebFetch: https://www.electronjs.org/docs (for Electron)
-```
-
-**Look for:**
-
-- Are we using deprecated APIs?
-- Are there newer, better patterns?
-- Did the library's recommendations change since training data?
-
-**Cache results**: If you checked docs recently in this session, don't re-fetch.
-
-## Output Format
-
-**Simple question** ("is it correct?"):
-
-```
-**Correctness:** ✓ Logic is sound, edge cases handled, no obvious errors.
-```
-
-**Full review** ("double check and critique"):
-
-```markdown
-## Quality Review
-
-**Correctness:** [✓/⚠️/❌] [Brief assessment]
-**Anti-Bloat:** [✓/⚠️/❌] [Brief assessment]
-**Elegance:** [✓/⚠️/❌] [Brief assessment]
-**Standards:** [✓/⚠️/❌] [Brief assessment]
-**Versions:** [✓/⚠️/❌] [Latest version check with WebSearch]
-**Documentation:** [✓/⚠️/❌] [Current docs check with WebFetch]
-
-**Verdict:** [APPROVE / REQUEST CHANGES / NEEDS DISCUSSION]
-
-**Critical issues:** [List or "None"]
-**Suggested improvements:** [List or "None"]
-```
-
-Use structured format for "double check"/"critique". Use brief format for specific questions.
-
-## Example: Full Review
-
-```markdown
-## Quality Review
-
-**Correctness:** ✓ Logic sound, edge cases covered, error handling adequate
-**Anti-Bloat:** ✓ Minimal dependencies, appropriate abstractions
-**Elegance:** ✓ Clear code, good naming, well-structured
-**Standards:** ✓ Follows CLAUDE.md patterns
-**Versions:** ✓ React 19.0.0 (latest stable), TypeScript 5.7.2 (latest)
-**Documentation:** ✓ Using current React patterns per https://react.dev
-
-**Verdict:** APPROVE - Production ready
-
-**Critical issues:** None
-**Suggested improvements:** None
-```
-
-## Critical Reminders
-
-1. **Primary value: Web research** - Use WebSearch/WebFetch to verify against current ecosystem (versions, docs, security)
-2. **Complement automatic hook** - Hook does fast check with existing knowledge, you do deep dive with web research
-3. **Explicit triggers matter** - "double check against latest docs", "verify versions", "check security" = invoke web research
-4. **Projects without SAFEWORD.md** - Automatic hook won't run, you're the only quality check
-5. **Always check latest docs** - Verify patterns are current, not outdated (WebFetch)
-6. **Always verify versions** - Flag outdated dependencies (WebSearch)
-7. **Be thorough but concise** - Cover all areas but keep explanations brief
-8. **Provide actionable feedback** - Specific line numbers, concrete suggestions
-9. **Clear verdict** - Always end with APPROVE/REQUEST CHANGES/NEEDS DISCUSSION
-10. **Separate critical vs nice-to-have** - User needs to know what's blocking vs optional
-
-## Non-Obvious Edge Cases
-
-**User requests review after automatic hook ran:**
-
-- Acknowledge hook ran: "The automatic quality hook already did a fast check. I'll now do deeper analysis with web research..."
-- Focus on what automatic hook doesn't do: fetch latest docs, verify versions, security checks, performance analysis
-
-**WebSearch/WebFetch fails:**
-
-- Continue review without version/docs checks
-- Note: "Couldn't verify latest versions/docs, skipping that check"
-
-**Project has no CLAUDE.md/SAFEWORD.md:**
-
-- Use `@./.safeword/guides/code-philosophy.md` as fallback
-- Note: "No project-specific standards found, using general best practices"

package/packages/cli/tests/commands/check.test.ts

@@ -1,129 +0,0 @@
-/**
- * Test Suite 8: Health Check
- *
- * Tests for `safeword check` command.
- */
-
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import {
-  createTempDir,
-  removeTempDir,
-  createTypeScriptPackageJson,
-  createConfiguredProject,
-  runCli,
-  readTestFile,
-  writeTestFile,
-  fileExists,
-  initGitRepo,
-} from '../helpers';
-import { unlinkSync } from 'node:fs';
-import { join } from 'node:path';
-
-describe('Test Suite 8: Health Check', () => {
-  let tempDir: string;
-
-  beforeEach(() => {
-    tempDir = createTempDir();
-  });
-
-  afterEach(() => {
-    removeTempDir(tempDir);
-  });
-
-  describe('Test 8.1: Shows CLI version', () => {
-    it('should display CLI version', async () => {
-      await createConfiguredProject(tempDir);
-
-      const result = await runCli(['check'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-      expect(result.stdout.toLowerCase()).toMatch(/cli|safeword/i);
-      expect(result.stdout).toMatch(/\d+\.\d+\.\d+/); // semver pattern
-    });
-  });
-
-  describe('Test 8.2: Shows project config version', () => {
-    it('should display version from .safeword/version', async () => {
-      await createConfiguredProject(tempDir);
-
-      const result = await runCli(['check'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-      expect(result.stdout.toLowerCase()).toMatch(/project|config/i);
-
-      // Should show the version from .safeword/version
-      const projectVersion = readTestFile(tempDir, '.safeword/version').trim();
-      expect(result.stdout).toContain(projectVersion);
-    });
-  });
-
-  describe('Test 8.3: Shows update available', () => {
-    it('should indicate when update is available', async () => {
-      await createConfiguredProject(tempDir);
-
-      // Write an older version
-      writeTestFile(tempDir, '.safeword/version', '0.0.1');
-
-      const result = await runCli(['check'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-      // Should mention available update or version difference
-      expect(result.stdout.toLowerCase()).toMatch(/update|available|upgrade|newer/i);
-    });
-  });
-
-  describe('Test 8.4: Unconfigured project message', () => {
-    it('should show not configured message', async () => {
-      createTypeScriptPackageJson(tempDir);
-      // No setup run
-
-      const result = await runCli(['check'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-      expect(result.stdout.toLowerCase()).toContain('not configured');
-      expect(result.stdout.toLowerCase()).toContain('setup');
-    });
-  });
-
-  describe('Test 8.5: Graceful timeout on version check', () => {
-    it('should handle network timeout gracefully', async () => {
-      await createConfiguredProject(tempDir);
-
-      // This test verifies the check completes without hanging
-      // Network mocking would be needed for full timeout simulation
-      const result = await runCli(['check'], {
-        cwd: tempDir,
-        timeout: 10000,
-      });
-
-      expect(result.exitCode).toBe(0);
-      // Should either show version info or timeout message
-    });
-  });
-
-  describe('Test 8.6: --offline skips version check', () => {
-    it('should skip remote version check', async () => {
-      await createConfiguredProject(tempDir);
-
-      const result = await runCli(['check', '--offline'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-      // Should show local versions only
-      expect(result.stdout).toMatch(/\d+\.\d+\.\d+/);
-    });
-  });
-
-  describe('Test 8.7: Detects corrupted .safeword structure', () => {
-    it('should detect missing critical files', async () => {
-      await createConfiguredProject(tempDir);
-
-      // Delete a critical file
-      unlinkSync(join(tempDir, '.safeword/SAFEWORD.md'));
-
-      const result = await runCli(['check'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0); // Warning, not failure
-      expect(result.stdout.toLowerCase()).toMatch(/missing|issue|repair|upgrade/i);
-    });
-  });
-});

package/packages/cli/tests/commands/cli.test.ts

@@ -1,89 +0,0 @@
-/**
- * Test Suite 1: Version and Help
- *
- * Tests for CLI entry point, version display, and help output.
- */
-
-import { describe, it, expect } from 'vitest';
-import { runCli, runCliSync } from '../helpers';
-
-describe('Test Suite 1: Version and Help', () => {
-  describe('Test 1.1: --version flag shows CLI version', () => {
-    it('should output version matching semver pattern', async () => {
-      const result = await runCli(['--version']);
-
-      expect(result.exitCode).toBe(0);
-      // Matches semver: X.Y.Z with optional prerelease/build metadata
-      expect(result.stdout.trim()).toMatch(/^\d+\.\d+\.\d+(-[\w.]+)?(\+[\w.]+)?$/);
-    });
-
-    it('should return exit code 0', () => {
-      const result = runCliSync(['--version']);
-      expect(result.exitCode).toBe(0);
-    });
-  });
-
-  describe('Test 1.2: --help flag shows help text', () => {
-    it('should display comprehensive help with all commands', async () => {
-      const result = await runCli(['--help']);
-
-      expect(result.exitCode).toBe(0);
-
-      const output = result.stdout;
-
-      // All commands should be listed
-      expect(output).toContain('setup');
-      expect(output).toContain('check');
-      expect(output).toContain('upgrade');
-      expect(output).toContain('diff');
-      expect(output).toContain('reset');
-    });
-
-    it('should display all global flags', async () => {
-      const result = await runCli(['--help']);
-
-      expect(result.exitCode).toBe(0);
-
-      const output = result.stdout;
-
-      // Global flags
-      expect(output).toMatch(/--version|-V/);
-      expect(output).toMatch(/--help|-h/);
-    });
-
-    it('should display command-specific flags in command help', async () => {
-      // Check setup --help for --yes flag
-      const setupHelp = await runCli(['setup', '--help']);
-      expect(setupHelp.stdout).toMatch(/--yes|-y/);
-
-      // Check diff --help for --verbose flag
-      const diffHelp = await runCli(['diff', '--help']);
-      expect(diffHelp.stdout).toMatch(/--verbose|-v/);
-
-      // Check check --help for --offline flag
-      const checkHelp = await runCli(['check', '--help']);
-      expect(checkHelp.stdout).toContain('--offline');
-
-      // Check reset --help for --yes flag
-      const resetHelp = await runCli(['reset', '--help']);
-      expect(resetHelp.stdout).toMatch(/--yes|-y/);
-    });
-  });
-
-  describe('Test 1.3: Bare command shows help', () => {
-    it('should show help when run with no arguments', async () => {
-      const bareResult = await runCli([]);
-      const helpResult = await runCli(['--help']);
-
-      expect(bareResult.exitCode).toBe(0);
-
-      // Should have similar content to --help
-      // (Commander may format slightly differently, so check key content)
-      expect(bareResult.stdout).toContain('setup');
-      expect(bareResult.stdout).toContain('check');
-      expect(bareResult.stdout).toContain('upgrade');
-      expect(bareResult.stdout).toContain('diff');
-      expect(bareResult.stdout).toContain('reset');
-    });
-  });
-});

package/packages/cli/tests/commands/diff.test.ts

@@ -1,115 +0,0 @@
-/**
- * Test Suite 10: Diff
- *
- * Tests for `safeword diff` command.
- */
-
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
-import {
-  createTempDir,
-  removeTempDir,
-  createTypeScriptPackageJson,
-  createConfiguredProject,
-  runCli,
-  writeTestFile,
-} from '../helpers';
-
-describe('Test Suite 10: Diff', () => {
-  let tempDir: string;
-
-  beforeEach(() => {
-    tempDir = createTempDir();
-  });
-
-  afterEach(() => {
-    removeTempDir(tempDir);
-  });
-
-  describe('Test 10.1: Shows summary by default', () => {
-    it('should show file counts without full diff', async () => {
-      await createConfiguredProject(tempDir);
-
-      // Modify version to create differences
-      writeTestFile(tempDir, '.safeword/version', '0.0.1');
-
-      const result = await runCli(['diff'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-
-      // Should show counts
-      expect(result.stdout).toMatch(/\d+/);
-
-      // Should NOT show full diff markers by default
-      expect(result.stdout).not.toMatch(/^[+-]{3}/m);
-      expect(result.stdout).not.toMatch(/^@@/m);
-    });
-  });
-
-  describe('Test 10.2: Lists files by category', () => {
-    it('should categorize files as Added, Modified, or Unchanged', async () => {
-      await createConfiguredProject(tempDir);
-
-      // Create a difference
-      writeTestFile(tempDir, '.safeword/version', '0.0.1');
-
-      const result = await runCli(['diff'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-
-      // Should have some categorization
-      const output = result.stdout.toLowerCase();
-      expect(output).toMatch(/add|modif|chang|updat|unchanged/i);
-    });
-  });
-
-  describe('Test 10.3: Shows version transition', () => {
-    it('should show from/to versions', async () => {
-      await createConfiguredProject(tempDir);
-
-      // Set older project version
-      writeTestFile(tempDir, '.safeword/version', '1.0.0');
-
-      const result = await runCli(['diff'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-
-      // Should show version info
-      expect(result.stdout).toContain('1.0.0');
-      // Should show transition (→ or similar)
-      expect(result.stdout).toMatch(/→|->|to|from/);
-    });
-  });
-
-  describe('Test 10.4: --verbose shows full diff', () => {
-    it('should show unified diff with --verbose', async () => {
-      await createConfiguredProject(tempDir);
-
-      // Create a modification
-      writeTestFile(tempDir, '.safeword/SAFEWORD.md', '# Modified\n');
-
-      const result = await runCli(['diff', '--verbose'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(0);
-
-      // Should show unified diff format
-      // --- file
-      // +++ file
-      // @@ line numbers @@
-      expect(result.stdout).toMatch(/^---/m);
-      expect(result.stdout).toMatch(/^\+\+\+/m);
-      expect(result.stdout).toMatch(/^@@.*@@/m);
-    });
-  });
-
-  describe('Test 10.5: Unconfigured project error', () => {
-    it('should error on unconfigured project', async () => {
-      createTypeScriptPackageJson(tempDir);
-      // No setup
-
-      const result = await runCli(['diff'], { cwd: tempDir });
-
-      expect(result.exitCode).toBe(1);
-      expect(result.stderr.toLowerCase()).toContain('not configured');
-    });
-  });
-});