safegres 1.28.3 → 1.28.4

package/checks/indexes.d.ts

@@ -44,6 +44,11 @@ export declare function checkUnindexedForeignKeys(table: TableIndexSnapshot, pat
  * leading-column prefix of a wider index. Both cost write throughput and
  * disk for nothing. Constraint-backed indexes (PK/UNIQUE/EXCLUDE) are never
  * reported — dropping them would drop the constraint.
+ *
+ * An index attached to a parent's partitioned index is never reported either:
+ * it can only be dropped with the parent's index, and the parent carries that
+ * finding once instead of every partition repeating it. An index created on
+ * the partition alone is the partition's own, and is reported there.
  */
 export declare function checkRedundantIndexes(table: TableIndexSnapshot): Finding[];
 /**

package/checks/indexes.js

@@ -69,10 +69,15 @@ function checkUnindexedForeignKeys(table, paths, onWriteOncePointer = 'report')
  * leading-column prefix of a wider index. Both cost write throughput and
  * disk for nothing. Constraint-backed indexes (PK/UNIQUE/EXCLUDE) are never
  * reported — dropping them would drop the constraint.
+ *
+ * An index attached to a parent's partitioned index is never reported either:
+ * it can only be dropped with the parent's index, and the parent carries that
+ * finding once instead of every partition repeating it. An index created on
+ * the partition alone is the partition's own, and is reported there.
  */
 function checkRedundantIndexes(table) {
     const findings = [];
-    const candidates = table.indexes.filter((i) => !i.primary && !i.constraint && !i.partial && !i.expression && !i.unique);
+    const candidates = new Set(table.indexes.filter((i) => !i.primary && !i.constraint && !i.partial && !i.expression && !i.unique && !i.attached));
     for (const idx of candidates) {
         const covering = table.indexes.find((other) => {
             if (other.name === idx.name)
@@ -83,8 +88,11 @@ function checkRedundantIndexes(table) {
                 return false;
             if (!isPrefix(idx.columns, other.columns))
                 return false;
-            // Exact duplicates: report only one of the pair, deterministically.
-            if (idx.columns.length === other.columns.length && idx.name < other.name)
+            // Exact duplicates: when both are droppable, report only one of the
+            // pair, deterministically.
+            if (idx.columns.length === other.columns.length
+                && candidates.has(other)
+                && idx.name < other.name)
                 return false;
             return true;
         });

package/esm/checks/indexes.d.ts

@@ -44,6 +44,11 @@ export declare function checkUnindexedForeignKeys(table: TableIndexSnapshot, pat
  * leading-column prefix of a wider index. Both cost write throughput and
  * disk for nothing. Constraint-backed indexes (PK/UNIQUE/EXCLUDE) are never
  * reported — dropping them would drop the constraint.
+ *
+ * An index attached to a parent's partitioned index is never reported either:
+ * it can only be dropped with the parent's index, and the parent carries that
+ * finding once instead of every partition repeating it. An index created on
+ * the partition alone is the partition's own, and is reported there.
  */
 export declare function checkRedundantIndexes(table: TableIndexSnapshot): Finding[];
 /**

package/esm/checks/indexes.js

@@ -62,10 +62,15 @@ export function checkUnindexedForeignKeys(table, paths, onWriteOncePointer = 're
  * leading-column prefix of a wider index. Both cost write throughput and
  * disk for nothing. Constraint-backed indexes (PK/UNIQUE/EXCLUDE) are never
  * reported — dropping them would drop the constraint.
+ *
+ * An index attached to a parent's partitioned index is never reported either:
+ * it can only be dropped with the parent's index, and the parent carries that
+ * finding once instead of every partition repeating it. An index created on
+ * the partition alone is the partition's own, and is reported there.
  */
 export function checkRedundantIndexes(table) {
     const findings = [];
-    const candidates = table.indexes.filter((i) => !i.primary && !i.constraint && !i.partial && !i.expression && !i.unique);
+    const candidates = new Set(table.indexes.filter((i) => !i.primary && !i.constraint && !i.partial && !i.expression && !i.unique && !i.attached));
     for (const idx of candidates) {
         const covering = table.indexes.find((other) => {
             if (other.name === idx.name)
@@ -76,8 +81,11 @@ export function checkRedundantIndexes(table) {
                 return false;
             if (!isPrefix(idx.columns, other.columns))
                 return false;
-            // Exact duplicates: report only one of the pair, deterministically.
-            if (idx.columns.length === other.columns.length && idx.name < other.name)
+            // Exact duplicates: when both are droppable, report only one of the
+            // pair, deterministically.
+            if (idx.columns.length === other.columns.length
+                && candidates.has(other)
+                && idx.name < other.name)
                 return false;
             return true;
         });

package/esm/pg/indexes.d.ts

@@ -26,6 +26,12 @@ export interface IndexInfo {
     /** Access method (`btree`, `gin`, …). */
     method: string;
     definition: string;
+    /**
+     * A partition of an index on the parent partitioned table
+     * (`pg_class.relispartition` on the index). Such an index cannot be dropped
+     * on its own; it exists because the parent's index does.
+     */
+    attached: boolean;
 }
 export interface ColumnInfo {
     name: string;

package/esm/pg/indexes.js

@@ -49,7 +49,8 @@ export async function introspectIndexes(exec, options = {}) {
         (ix.indpred IS NOT NULL)                        AS is_partial,
         (ix.indexprs IS NOT NULL)                       AS is_expression,
         am.amname                                       AS method,
-        pg_get_indexdef(i.oid)                          AS definition
+        pg_get_indexdef(i.oid)                          AS definition,
+        i.relispartition                                AS is_attached
       FROM pg_index ix
       JOIN pg_class i ON i.oid = ix.indexrelid
       JOIN pg_am am ON am.oid = i.relam
@@ -84,7 +85,8 @@ export async function introspectIndexes(exec, options = {}) {
           'partial', x.is_partial,
           'expression', x.is_expression,
           'method', x.method,
-          'definition', x.definition
+          'definition', x.definition,
+          'attached', x.is_attached
         ) ORDER BY x.name) FROM indexes x WHERE x.oid = r.oid),
         '[]'::jsonb
       )                                                 AS indexes,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "safegres",
-  "version": "1.28.3",
+  "version": "1.28.4",
   "author": "Constructive <developers@constructive.io>",
   "description": "Postgres security and performance auditor: RLS, grants and effective-access analysis plus index and policy-cost checks, scored on two independent axes. One connection, no framework.",
   "main": "index.js",
@@ -85,5 +85,5 @@
     "makage": "^0.8.0",
     "pgsql-test": "^5.17.0"
   },
-  "gitHead": "4c68f85c7d9b3c72082f8305dffc0b3dfca80941"
+  "gitHead": "77c3196a3b35b3886f40413157e40c71634cc3fc"
 }

package/pg/indexes.d.ts

@@ -26,6 +26,12 @@ export interface IndexInfo {
     /** Access method (`btree`, `gin`, …). */
     method: string;
     definition: string;
+    /**
+     * A partition of an index on the parent partitioned table
+     * (`pg_class.relispartition` on the index). Such an index cannot be dropped
+     * on its own; it exists because the parent's index does.
+     */
+    attached: boolean;
 }
 export interface ColumnInfo {
     name: string;

package/pg/indexes.js

@@ -54,7 +54,8 @@ async function introspectIndexes(exec, options = {}) {
         (ix.indpred IS NOT NULL)                        AS is_partial,
         (ix.indexprs IS NOT NULL)                       AS is_expression,
         am.amname                                       AS method,
-        pg_get_indexdef(i.oid)                          AS definition
+        pg_get_indexdef(i.oid)                          AS definition,
+        i.relispartition                                AS is_attached
       FROM pg_index ix
       JOIN pg_class i ON i.oid = ix.indexrelid
       JOIN pg_am am ON am.oid = i.relam
@@ -89,7 +90,8 @@ async function introspectIndexes(exec, options = {}) {
           'partial', x.is_partial,
           'expression', x.is_expression,
           'method', x.method,
-          'definition', x.definition
+          'definition', x.definition,
+          'attached', x.is_attached
         ) ORDER BY x.name) FROM indexes x WHERE x.oid = r.oid),
         '[]'::jsonb
       )                                                 AS indexes,