safari-mcp 2.7.8 → 2.7.9

package/README.md

@@ -426,13 +426,22 @@ The extension requires a one-time build with Xcode (free, included with macOS).
 # 1. Clone the repo (the npm package does not include the Xcode project)
 git clone https://github.com/achiya-automation/safari-mcp.git
 cd safari-mcp
+
+# 2. Build the extension
 xcodebuild -project "xcode/Safari MCP/Safari MCP.xcodeproj" \
   -scheme "Safari MCP (macOS)" -configuration Release build
 
-# 2. Find and open the built app
-open ~/Library/Developer/Xcode/DerivedData/Safari_MCP-*/Build/Products/Release/Safari\ MCP.app
+# 3. Ad-hoc sign the built app so Safari will load it
+# (xcodebuild without a signing identity produces a bundle Safari silently rejects)
+APP_PATH=$(find ~/Library/Developer/Xcode/DerivedData/Safari_MCP-*/Build/Products/Release -name "Safari MCP.app" -maxdepth 2 | head -1)
+codesign --sign - --force --deep "$APP_PATH"
+
+# 4. Open the app (needed once so Safari registers the extension)
+open "$APP_PATH"
 ```
 
+Alternatively, open `xcode/Safari MCP/Safari MCP.xcodeproj` directly in Xcode, select your Apple ID under Signing & Capabilities, and click Run. A free personal Apple Developer account is sufficient for local use.
+
 Then in Safari:
 1. Safari → Settings → Advanced → enable **Show features for web developers**
 2. Safari → Develop → **Allow Unsigned Extensions** (required each Safari restart)
@@ -456,8 +465,21 @@ Safari MCP needs these one-time permissions:
 | Permission | Where | Why |
 |-----------|-------|-----|
 | JavaScript from Apple Events | Safari → Develop menu | Required for `do JavaScript` |
-| Screen Recording | System Settings → Privacy | Required for `safari_screenshot` |
-| Accessibility | System Settings → Privacy | Required for `safari_save_pdf` only |
+| Automation → Safari | System Settings → Privacy & Security → Automation | Required for all AppleScript-backed tools |
+| Screen Recording | System Settings → Privacy & Security → Screen Recording | Required for `safari_screenshot` |
+| Accessibility | System Settings → Privacy & Security → Accessibility | Required for `safari_save_pdf` only |
+
+### Granting Automation → Safari (important for IDE users)
+
+macOS TCC grants Automation permission to the **parent process** that spawns the MCP server, not to `safari-mcp` itself. So you need to grant **Automation → Safari** to the app that runs Claude Code / Cursor / Windsurf — typically **Visual Studio Code** or **Terminal**.
+
+If the permission dialog never appears automatically, run this command once from a Terminal that already has Automation permission:
+
+```bash
+osascript -e 'tell application "Safari" to get URL of current tab of window 1'
+```
+
+That call registers the Terminal app in the Automation database and then triggers the prompt for Safari. After you approve it, subsequent MCP calls from any child process chain will work.
 
 ---
 
@@ -466,6 +488,7 @@ Safari MCP needs these one-time permissions:
 | Issue | Fix |
 |-------|-----|
 | "AppleScript error" | Enable "Allow JavaScript from Apple Events" in Safari → Develop |
+| "Not authorized to send Apple events to Safari" | Grant Automation → Safari to your IDE (see above) |
 | Screenshots empty | Grant Screen Recording permission to Terminal/VS Code |
 | Tab not found | Call `safari_list_tabs` to refresh tab indices |
 | Hebrew keyboard issues | All typing uses JS events — immune to keyboard layout |

package/extension/popup/popup.html

@@ -37,42 +37,6 @@
       <span class="slider"></span>
     </label>
   </div>
-  <script>
-    // Inline script — cannot be cached separately by Safari
-    function setStatus(c, t, i) {
-      document.getElementById("statusDot").className = "dot " + c;
-      document.getElementById("statusText").textContent = t;
-      document.getElementById("info").textContent = i;
-    }
-    async function getVal(k, d) {
-      try { const r = await browser.storage.local.get(k); return r[k] !== undefined ? r[k] : d; }
-      catch { return d; }
-    }
-    async function check() {
-      const on = await getVal("mcpEnabled", true);
-      document.getElementById("enableToggle").checked = on;
-      if (!on) { setStatus("paused", "Paused", "Toggle to resume"); return; }
-      // Ask background script for real-time status first
-      try {
-        const resp = await browser.runtime.sendMessage({ action: "getStatus" });
-        if (resp) {
-          if (resp.connected) { setStatus("connected", "Connected", "Port 9224"); return; }
-          if (!resp.enabled) { setStatus("paused", "Paused", "Toggle to resume"); return; }
-        }
-      } catch {}
-      // Fallback: read from storage
-      const s = await getVal("mcpStatus", null);
-      if (s === "connected") setStatus("connected", "Connected", "Port 9224");
-      else if (s === "paused") setStatus("paused", "Paused", "Toggle to resume");
-      else if (s === "checking") setStatus("checking", "Connecting...", "Trying port 9224...");
-      else setStatus("disconnected", "Not connected", "Start the MCP server to connect");
-    }
-    document.getElementById("enableToggle").addEventListener("change", async (e) => {
-      await browser.storage.local.set({ mcpEnabled: e.target.checked });
-      try { browser.runtime.sendMessage({ action: "setEnabled", enabled: e.target.checked }); } catch {}
-      setTimeout(check, 500);
-    });
-    check();
-  </script>
+  <script src="popup.js"></script>
 </body>
 </html>

package/extension/popup/popup.js

@@ -0,0 +1,34 @@
+function setStatus(c, t, i) {
+  document.getElementById("statusDot").className = "dot " + c;
+  document.getElementById("statusText").textContent = t;
+  document.getElementById("info").textContent = i;
+}
+async function getVal(k, d) {
+  try { const r = await browser.storage.local.get(k); return r[k] !== undefined ? r[k] : d; }
+  catch { return d; }
+}
+async function check() {
+  const on = await getVal("mcpEnabled", true);
+  document.getElementById("enableToggle").checked = on;
+  if (!on) { setStatus("paused", "Paused", "Toggle to resume"); return; }
+  // Ask background script for real-time status first
+  try {
+    const resp = await browser.runtime.sendMessage({ action: "getStatus" });
+    if (resp) {
+      if (resp.connected) { setStatus("connected", "Connected", "Port 9224"); return; }
+      if (!resp.enabled) { setStatus("paused", "Paused", "Toggle to resume"); return; }
+    }
+  } catch {}
+  // Fallback: read from storage
+  const s = await getVal("mcpStatus", null);
+  if (s === "connected") setStatus("connected", "Connected", "Port 9224");
+  else if (s === "paused") setStatus("paused", "Paused", "Toggle to resume");
+  else if (s === "checking") setStatus("checking", "Connecting...", "Trying port 9224...");
+  else setStatus("disconnected", "Not connected", "Start the MCP server to connect");
+}
+document.getElementById("enableToggle").addEventListener("change", async (e) => {
+  await browser.storage.local.set({ mcpEnabled: e.target.checked });
+  try { browser.runtime.sendMessage({ action: "setEnabled", enabled: e.target.checked }); } catch {}
+  setTimeout(check, 500);
+});
+check();

package/index.js

@@ -147,7 +147,7 @@ let _lastMemoryWarningTime = 0;
 
 function _getWebKitMemoryMB() {
   try {
-    const pids = execFileSync("pgrep", ["-Ef", "WebKit|WebContent"], { encoding: "utf8" }).trim();
+    const pids = execFileSync("pgrep", ["-f", "WebKit|WebContent"], { encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] }).trim();
     if (!pids) return 0;
     const pidList = pids.split("\n").join(",");
     const psOut = execFileSync("ps", ["-p", pidList, "-o", "rss="], { encoding: "utf8" }).trim();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "safari-mcp",
-  "version": "2.7.8",
+  "version": "2.7.9",
   "mcpName": "io.github.achiya-automation/safari-mcp",
   "description": "Safari browser automation for AI agents — native macOS, zero Chrome overhead. 80 tools via AppleScript + JavaScript.",
   "type": "module",
@@ -71,5 +71,9 @@
   "dependencies": {
     "@modelcontextprotocol/sdk": "^1.12.1",
     "ws": "^8.19.0"
+  },
+  "overrides": {
+    "hono": "^4.12.12",
+    "@hono/node-server": "^1.19.13"
   }
 }

package/safari-helper.swift

@@ -324,30 +324,13 @@ while let line = readLine(strippingNewline: true) {
     continue
   }
 
-  // Execute on a background thread to avoid blocking stdin reading.
-  // Heavy pages (SourceForge, etc.) can cause executeAndReturnError() to block
-  // for 10-30+ seconds, preventing ALL subsequent commands from being read.
-  let semaphore = DispatchSemaphore(value: 0)
-  var scriptResult: NSAppleEventDescriptor?
-  var scriptError: NSDictionary?
-
-  DispatchQueue.global(qos: .userInitiated).async {
-    var errorDict: NSDictionary?
-    scriptResult = nsScript.executeAndReturnError(&errorDict)
-    scriptError = errorDict
-    semaphore.signal()
-  }
-
-  // Wait up to 30 seconds for the script to complete.
-  // If it times out, respond with error but don't block the loop forever.
-  let waitResult = semaphore.wait(timeout: .now() + 30.0)
+  var errorDict: NSDictionary?
+  let result = nsScript.executeAndReturnError(&errorDict)
 
-  if waitResult == .timedOut {
-    respond(["error": "AppleScript execution timed out (30s)"])
-  } else if let error = scriptError {
+  if let error = errorDict {
     let msg = (error["NSAppleScriptErrorMessage"] as? String) ?? "AppleScript error"
     respond(["error": msg])
   } else {
-    respond(["result": scriptResult?.stringValue ?? ""])
+    respond(["result": result.stringValue ?? ""])
   }
 }