saeeol 1.2.4 → 1.2.7

package/test/project/instance.test.ts

@@ -1,276 +0,0 @@
-import { afterEach, describe, expect } from "bun:test"
-import { CrossSpawnSpawner } from "@saeeol/core/cross-spawn-spawner"
-import { Effect, Fiber, Layer } from "effect"
-import { InstanceRef } from "../../src/effect/instance-ref"
-import { registerDisposer } from "../../src/effect/instance-registry"
-import { Instance } from "../../src/project/instance"
-import { InstanceStore } from "../../src/project/instance-store"
-import { disposeAllInstances, tmpdirScoped } from "../fixture/fixture"
-import { testEffect } from "../lib/effect"
-
-const it = testEffect(Layer.mergeAll(InstanceStore.defaultLayer, CrossSpawnSpawner.defaultLayer))
-
-afterEach(async () => {
-  await disposeAllInstances()
-})
-
-describe("InstanceStore", () => {
-  it.live("loads instance context without installing ALS for the caller", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      const ctx = yield* store.load({ directory: dir })
-
-      expect(ctx.directory).toBe(dir)
-      expect(ctx.worktree).toBe(dir)
-      expect(() => Instance.current).toThrow()
-    }),
-  )
-
-  it.live("runs load init with InstanceRef provided", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      let initializedDirectory: string | undefined
-
-      yield* store.load({
-        directory: dir,
-        init: Effect.gen(function* () {
-          initializedDirectory = (yield* InstanceRef)?.directory
-        }),
-      })
-
-      expect(initializedDirectory).toBe(dir)
-      expect(() => Instance.current).toThrow()
-    }),
-  )
-
-  it.live("caches loaded instance context by directory", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      let initialized = 0
-
-      const first = yield* store.load({
-        directory: dir,
-        init: Effect.sync(() => {
-          initialized++
-        }),
-      })
-      const second = yield* store.load({
-        directory: dir,
-        init: Effect.sync(() => {
-          initialized++
-        }),
-      })
-
-      expect(second).toBe(first)
-      expect(initialized).toBe(1)
-    }),
-  )
-
-  it.live("dedupes concurrent loads while init is in flight", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      const started = Promise.withResolvers<void>()
-      const release = Promise.withResolvers<void>()
-      let initialized = 0
-
-      const first = yield* store
-        .load({
-          directory: dir,
-          init: Effect.promise(async () => {
-            initialized++
-            started.resolve()
-            await release.promise
-          }),
-        })
-        .pipe(Effect.forkScoped)
-
-      yield* Effect.promise(() => started.promise)
-
-      const second = yield* store
-        .load({
-          directory: dir,
-          init: Effect.sync(() => {
-            initialized++
-          }),
-        })
-        .pipe(Effect.forkScoped)
-
-      expect(initialized).toBe(1)
-      release.resolve()
-
-      const [firstCtx, secondCtx] = yield* Effect.all([Fiber.join(first), Fiber.join(second)])
-      expect(secondCtx).toBe(firstCtx)
-      expect(initialized).toBe(1)
-    }),
-  )
-
-  it.live("removes failed loads from the cache", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      let attempts = 0
-
-      const failed = yield* store
-        .load({
-          directory: dir,
-          init: Effect.sync(() => {
-            attempts++
-            throw new Error("init failed")
-          }),
-        })
-        .pipe(
-          Effect.as(false),
-          Effect.catchCause(() => Effect.succeed(true)),
-        )
-
-      expect(failed).toBe(true)
-
-      const ctx = yield* store.load({
-        directory: dir,
-        init: Effect.sync(() => {
-          attempts++
-        }),
-      })
-
-      expect(ctx.directory).toBe(dir)
-      expect(attempts).toBe(2)
-    }),
-  )
-
-  it.live("reload replaces the cached context", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-
-      const first = yield* store.load({ directory: dir })
-      const second = yield* store.reload({ directory: dir })
-      const cached = yield* store.load({ directory: dir })
-
-      expect(second).not.toBe(first)
-      expect(cached).toBe(second)
-    }),
-  )
-
-  it.live("stale dispose does not delete an in-flight reload", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      const reloading = Promise.withResolvers<void>()
-      const releaseReload = Promise.withResolvers<void>()
-      const disposed: Array<string> = []
-      const off = registerDisposer(async (directory) => {
-        disposed.push(directory)
-      })
-      yield* Effect.addFinalizer(() => Effect.sync(off))
-
-      const first = yield* store.load({ directory: dir })
-      const reload = yield* store
-        .reload({
-          directory: dir,
-          init: Effect.promise(async () => {
-            reloading.resolve()
-            await releaseReload.promise
-          }),
-        })
-        .pipe(Effect.forkScoped)
-
-      yield* Effect.promise(() => reloading.promise)
-      const staleDispose = yield* store.dispose(first).pipe(Effect.forkScoped)
-      releaseReload.resolve()
-
-      const second = yield* Fiber.join(reload)
-      yield* Fiber.join(staleDispose)
-
-      expect(disposed).toEqual([dir])
-      expect(yield* store.load({ directory: dir })).toBe(second)
-    }),
-  )
-
-  it.live("dedupes concurrent disposeAll calls", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      const disposing = Promise.withResolvers<void>()
-      const releaseDispose = Promise.withResolvers<void>()
-      const disposed: Array<string> = []
-      const off = registerDisposer(async (directory) => {
-        disposed.push(directory)
-        disposing.resolve()
-        await releaseDispose.promise
-      })
-      yield* Effect.addFinalizer(() => Effect.sync(off))
-
-      yield* store.load({ directory: dir })
-      const first = yield* store.disposeAll().pipe(Effect.forkScoped)
-      yield* Effect.promise(() => disposing.promise)
-      const second = yield* store.disposeAll().pipe(Effect.forkScoped)
-
-      expect(disposed).toEqual([dir])
-      releaseDispose.resolve()
-      yield* Effect.all([Fiber.join(first), Fiber.join(second)])
-      expect(disposed).toEqual([dir])
-    }),
-  )
-
-  it.live("re-arms disposeAll after completion", () =>
-    Effect.gen(function* () {
-      const dir1 = yield* tmpdirScoped({ git: true })
-      const dir2 = yield* tmpdirScoped({ git: true })
-      const store = yield* InstanceStore.Service
-      const disposed: Array<string> = []
-      const off = registerDisposer(async (directory) => {
-        disposed.push(directory)
-      })
-      yield* Effect.addFinalizer(() => Effect.sync(off))
-
-      yield* store.load({ directory: dir1 })
-      yield* store.disposeAll()
-      expect(disposed).toEqual([dir1])
-
-      yield* store.load({ directory: dir2 })
-      yield* store.disposeAll()
-      expect(disposed).toEqual([dir1, dir2])
-    }),
-  )
-
-  it.live("keeps Instance.provide as the legacy ALS wrapper", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped({ git: true })
-
-      const directory = yield* Effect.promise(() =>
-        Instance.provide({
-          directory: dir,
-          fn: () => Instance.directory,
-        }),
-      )
-
-      expect(directory).toBe(dir)
-      expect(() => Instance.current).toThrow()
-    }),
-  )
-  // SaeeolIndexing.init that it forkDetaches) can read Instance.directory. Upstream's test
-  // asserted the opposite contract; rewrite to assert Saeeol's contract.
-  it.live("installs Instance ALS around Effect init for Saeeol bootstrap compatibility", () =>
-    Effect.gen(function* () {
-      const dir = yield* tmpdirScoped()
-      let directoryDuringInit: string | undefined
-
-      const directory = yield* Effect.promise(() =>
-        Instance.provide({
-          directory: dir,
-          init: Effect.sync(() => {
-            directoryDuringInit = Instance.directory
-          }),
-          fn: () => Instance.directory,
-        }),
-      )
-
-      expect(directoryDuringInit).toBe(dir)
-      expect(directory).toBe(dir)
-    }),
-  )
-})

package/test/project/migrate-global.test.ts

@@ -1,152 +0,0 @@
-import { describe, expect, test } from "bun:test"
-import { Project } from "@/project/project"
-import { Database } from "@/storage/db"
-import { eq } from "drizzle-orm"
-import { SessionTable } from "../../src/session/session.sql"
-import { ProjectTable } from "../../src/project/project.sql"
-import { ProjectID } from "../../src/project/schema"
-import { SessionID } from "../../src/session/schema"
-import * as Log from "@saeeol/core/util/log"
-import { $ } from "bun"
-import { tmpdir } from "../fixture/fixture"
-import { Effect } from "effect"
-
-Log.init({ print: false })
-
-function run<A>(fn: (svc: Project.Interface) => Effect.Effect<A>) {
-  return Effect.runPromise(
-    Effect.gen(function* () {
-      const svc = yield* Project.Service
-      return yield* fn(svc)
-    }).pipe(Effect.provide(Project.defaultLayer)),
-  )
-}
-
-function uid() {
-  return SessionID.make(crypto.randomUUID())
-}
-
-function seed(opts: { id: SessionID; dir: string; project: ProjectID }) {
-  const now = Date.now()
-  Database.use((db) =>
-    db
-      .insert(SessionTable)
-      .values({
-        id: opts.id,
-        project_id: opts.project,
-        slug: opts.id,
-        directory: opts.dir,
-        title: "test",
-        version: "0.0.0-test",
-        time_created: now,
-        time_updated: now,
-      })
-      .run(),
-  )
-}
-
-function ensureGlobal() {
-  Database.use((db) =>
-    db
-      .insert(ProjectTable)
-      .values({
-        id: ProjectID.global,
-        worktree: "/",
-        time_created: Date.now(),
-        time_updated: Date.now(),
-        sandboxes: [],
-      })
-      .onConflictDoNothing()
-      .run(),
-  )
-}
-
-describe("migrateFromGlobal", () => {
-  test("migrates global sessions on first project creation", async () => {
-    // 1. Start with git init but no commits — creates "global" project row
-    await using tmp = await tmpdir()
-    await $`git init`.cwd(tmp.path).quiet()
-    await $`git config user.name "Test"`.cwd(tmp.path).quiet()
-    await $`git config user.email "test@saeeol.test"`.cwd(tmp.path).quiet()
-    await $`git config commit.gpgsign false`.cwd(tmp.path).quiet()
-    const { project: pre } = await run((svc) => svc.fromDirectory(tmp.path))
-    expect(pre.id).toBe(ProjectID.global)
-
-    // 2. Seed a session under "global" with matching directory
-    const id = uid()
-    seed({ id, dir: tmp.path, project: ProjectID.global })
-
-    // 3. Make a commit so the project gets a real ID
-    await $`git commit --allow-empty -m "root"`.cwd(tmp.path).quiet()
-
-    const { project: real } = await run((svc) => svc.fromDirectory(tmp.path))
-    expect(real.id).not.toBe(ProjectID.global)
-
-    // 4. The session should have been migrated to the real project ID
-    const row = Database.use((db) => db.select().from(SessionTable).where(eq(SessionTable.id, id)).get())
-    expect(row).toBeDefined()
-    expect(row!.project_id).toBe(real.id)
-  })
-
-  test("migrates global sessions even when project row already exists", async () => {
-    // 1. Create a repo with a commit — real project ID created immediately
-    await using tmp = await tmpdir({ git: true })
-    const { project } = await run((svc) => svc.fromDirectory(tmp.path))
-    expect(project.id).not.toBe(ProjectID.global)
-
-    // 2. Ensure "global" project row exists (as it would from a prior no-git session)
-    ensureGlobal()
-
-    // 3. Seed a session under "global" with matching directory.
-    //    This simulates a session created before git init that wasn't
-    //    present when the real project row was first created.
-    const id = uid()
-    seed({ id, dir: tmp.path, project: ProjectID.global })
-
-    // 4. Call fromDirectory again — project row already exists,
-    //    so the current code skips migration entirely. This is the bug.
-    await run((svc) => svc.fromDirectory(tmp.path))
-
-    const row = Database.use((db) => db.select().from(SessionTable).where(eq(SessionTable.id, id)).get())
-    expect(row).toBeDefined()
-    expect(row!.project_id).toBe(project.id)
-  })
-
-  test("does not claim sessions with empty directory", async () => {
-    await using tmp = await tmpdir({ git: true })
-    const { project } = await run((svc) => svc.fromDirectory(tmp.path))
-    expect(project.id).not.toBe(ProjectID.global)
-
-    ensureGlobal()
-
-    // Legacy sessions may lack a directory value.
-    // Without a matching origin directory, they should remain global.
-    const id = uid()
-    seed({ id, dir: "", project: ProjectID.global })
-
-    await run((svc) => svc.fromDirectory(tmp.path))
-
-    const row = Database.use((db) => db.select().from(SessionTable).where(eq(SessionTable.id, id)).get())
-    expect(row).toBeDefined()
-    expect(row!.project_id).toBe(ProjectID.global)
-  })
-
-  test("does not steal sessions from unrelated directories", async () => {
-    await using tmp = await tmpdir({ git: true })
-    const { project } = await run((svc) => svc.fromDirectory(tmp.path))
-    expect(project.id).not.toBe(ProjectID.global)
-
-    ensureGlobal()
-
-    // Seed a session under "global" but for a DIFFERENT directory
-    const id = uid()
-    seed({ id, dir: "/some/other/dir", project: ProjectID.global })
-
-    await run((svc) => svc.fromDirectory(tmp.path))
-
-    const row = Database.use((db) => db.select().from(SessionTable).where(eq(SessionTable.id, id)).get())
-    expect(row).toBeDefined()
-    // Should remain under "global" — not stolen
-    expect(row!.project_id).toBe(ProjectID.global)
-  })
-})