sad-mcp 2.3.4 → 2.3.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sad-mcp",
-  "version": "2.3.4",
+  "version": "2.3.6",
   "description": "MCP server for Software Analysis and Design course materials at BGU",
   "type": "module",
   "bin": {

package/skills/uml-class-diagram/SKILL.md

@@ -207,10 +207,10 @@ Font:             'IBM Plex Mono', monospace (Google Fonts import)
 
 ## 7. Legend Bar
 
-Include at the bottom of every SVG:
+Include at the bottom of every SVG (no dependency entry — dependencies are not used, §3):
 ```
-── Association   ◇── Aggregation   ◆── Composition   ──▷ Generalization   --→ Dependency
-Multiplicity at both ends  |  italic = operations
+── Association   ◇── Aggregation   ◆── Composition   ──▷ Generalization
+Multiplicity at both ends (rendered outside both boxes)  |  italic = operations
 ```
 
 ---
@@ -385,13 +385,18 @@ function svgRel(rel) {
   // 'assoc': no markers — plain line
 
   let s = `<polyline points="${pts}" fill="none" stroke="#334155" stroke-width="1.8" ${dash} ${mS} ${mE}/>`;
-  if (rel.fromMult) {
-    const [fx, fy] = rel.points[0];
-    s += `<text x="${fx + 4}" y="${fy - 4}" fill="#64748b" font-size="9.5" ${FM}>${escXml(rel.fromMult)}</text>`;
-  }
+  // Multiplicity labels — placed just OUTSIDE each box, offset along the line
+  // (away from the box) and beside it, so BOTH ends are always legible.
+  const multLabel = (end, adj, txt) => {
+    const dx = adj[0] - end[0], dy = adj[1] - end[1];
+    const L = Math.hypot(dx, dy) || 1, ux = dx / L, uy = dy / L;
+    const x = end[0] + ux * 16 - uy * 9, y = end[1] + uy * 16 + ux * 9 + 3;
+    return `<text x="${x}" y="${y}" text-anchor="middle" fill="#64748b" font-size="9.5" ${FM}>${escXml(txt)}</text>`;
+  };
+  if (rel.fromMult) s += multLabel(rel.points[0], rel.points[1], rel.fromMult);
   if (rel.toMult) {
-    const [tx, ty] = rel.points[rel.points.length - 1];
-    s += `<text x="${tx + 4}" y="${ty - 4}" fill="#64748b" font-size="9.5" ${FM}>${escXml(rel.toMult)}</text>`;
+    const n = rel.points.length;
+    s += multLabel(rel.points[n - 1], rel.points[n - 2], rel.toMult);
   }
   if (rel.label) {
     const mid = rel.points[Math.floor(rel.points.length / 2)];
@@ -435,7 +440,7 @@ function render() {
   const rels  = RELS.map(svgRel).join('');
   const boxes = CLASSES.map(svgBox).join('');
   // Legend is placed at totalHeight - 60 so it always lands inside the viewBox.
-  const legend = `<text x="16" y="${totalHeight - 60}" fill="#64748b" font-size="9" ${FM}>── Association  ◇── Aggregation  ◆── Composition  ──▷ Generalization  --→ Dependency (enum only)</text>`;
+  const legend = `<text x="16" y="${totalHeight - 60}" fill="#64748b" font-size="9" ${FM}>── Association  ◇── Aggregation  ◆── Composition  ──▷ Generalization  |  קרדינליות בשני קצות הקשר</text>`;
 
   const svg = document.getElementById('diagram-svg');
   svg.setAttribute('width',   totalWidth);
@@ -454,6 +459,7 @@ When splitting (§5), generate one `<svg id="svg-part-N">` per part. Split `CLAS
 ## 10. Output
 
 - Save as `[system_name]_class_diagram.html`
+- **Visual verification (required) — a loop, not a one-shot.** Structural validity ≠ visual validity. If a browser is available, render the HTML to an image, inspect it, and **fix → re-render → repeat until visually clean**. Scan every pass for: box overlaps; boxes off-canvas/clipped; a **multiplicity or role label landing inside a box** or on a line; **any line crossing through a foreign box**; the association-class tether hitting the wrong association; enum boxes overlapping. Do not report the diagram as done until a rendered pass is clean.
 - After saving, briefly state: number of classes, enumerations, relationships, whether split (and why), whether VP export is included
 
 ---

package/skills/uml-state-diagram/SKILL.md

@@ -257,6 +257,7 @@ Include at the bottom of every SVG:
 ## 11. Output
 
 - Save as `[entity_name]_state_diagram.html`
+- **Visual verification (required) — a loop, not a one-shot.** Structural validity ≠ visual validity. If a browser is available, render the HTML, inspect it, and **fix → re-render → repeat until visually clean**. Scan for: state-box overlaps; transition **labels/guards landing on a box or on another line**; arrows crossing through a foreign state; the initial/final markers misplaced; self-transitions unreadable. Confirm the lifecycle reads as **non-linear** (branches + returns), not a straight line. Don't report done until a rendered pass is clean.
 - Briefly state: entity modeled, state count, transition count, composite states, whether split
 
 ---

package/skills/uml-use-case-diagram/SKILL.md

@@ -907,6 +907,9 @@ The validator runs locally (no API cost) and catches what the §4 and CR gates c
 If the response is `✗ Model invalid`, fix every listed error and call the validator again. **Do not write the HTML file until the validator returns `✓ Model valid`.**
 
 After the validator passes, save the HTML as `[system_name]_use_case_diagram.html`.
+
+**Visual verification (required) — a loop, not a one-shot.** The validator passing is necessary but NOT sufficient: it does not catch layout problems. If a browser is available, render the HTML and inspect it, then **fix → re-render → repeat until visually clean**. Check **both tabs** (toggle which `.diagram-part` is `hidden`) and open at least one UC modal to confirm the wireframe renders. Scan every pass for: ellipse **overlaps**; actors too close (min ~200px); actor figure detached from its own line; a UC crowded into a **center column** (usually a recipient-only human actor on a system-initiated UC — remove it per §4.1); wide ellipses colliding with the boundary title bar; timing/label text on top of a line. Do not report the diagram as done until a rendered pass of each tab is clean.
+
 Briefly report: actor count, use case count, include/extend count, whether split, and any warnings the validator surfaced.
 
 ---