sad-mcp 2.3.3 → 2.3.5

package/dist/usecase/validate.js

@@ -348,7 +348,7 @@ export function validateModel(model) {
                 const isHuman = !pa || pa.actorType !== "system";
                 const wfMissing = typeof wf !== "string" || wf.trim() === "";
                 if (isHuman && wfMissing) {
-                    warn("wireframe-missing", `${path}.wireframe`, `UC "${id}" has a human primary actor ("${primaryActor}") but no wireframe. Wireframes are opt-in per §WF — add one only if the user requested wireframes.`);
+                    err("wireframe-missing", `${path}.wireframe`, `UC "${id}" has a human primary actor ("${primaryActor}") but no wireframe. Wireframes are mandatory for every human-initiated UC (§WF) — add one.`);
                 }
             }
             if (typeof wf === "string" && wf.length > 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sad-mcp",
-  "version": "2.3.3",
+  "version": "2.3.5",
   "description": "MCP server for Software Analysis and Design course materials at BGU",
   "type": "module",
   "bin": {

package/skills/uml-class-diagram/SKILL.md

@@ -207,10 +207,10 @@ Font:             'IBM Plex Mono', monospace (Google Fonts import)
 
 ## 7. Legend Bar
 
-Include at the bottom of every SVG:
+Include at the bottom of every SVG (no dependency entry — dependencies are not used, §3):
 ```
-── Association   ◇── Aggregation   ◆── Composition   ──▷ Generalization   --→ Dependency
-Multiplicity at both ends  |  italic = operations
+── Association   ◇── Aggregation   ◆── Composition   ──▷ Generalization
+Multiplicity at both ends (rendered outside both boxes)  |  italic = operations
 ```
 
 ---
@@ -385,13 +385,18 @@ function svgRel(rel) {
   // 'assoc': no markers — plain line
 
   let s = `<polyline points="${pts}" fill="none" stroke="#334155" stroke-width="1.8" ${dash} ${mS} ${mE}/>`;
-  if (rel.fromMult) {
-    const [fx, fy] = rel.points[0];
-    s += `<text x="${fx + 4}" y="${fy - 4}" fill="#64748b" font-size="9.5" ${FM}>${escXml(rel.fromMult)}</text>`;
-  }
+  // Multiplicity labels — placed just OUTSIDE each box, offset along the line
+  // (away from the box) and beside it, so BOTH ends are always legible.
+  const multLabel = (end, adj, txt) => {
+    const dx = adj[0] - end[0], dy = adj[1] - end[1];
+    const L = Math.hypot(dx, dy) || 1, ux = dx / L, uy = dy / L;
+    const x = end[0] + ux * 16 - uy * 9, y = end[1] + uy * 16 + ux * 9 + 3;
+    return `<text x="${x}" y="${y}" text-anchor="middle" fill="#64748b" font-size="9.5" ${FM}>${escXml(txt)}</text>`;
+  };
+  if (rel.fromMult) s += multLabel(rel.points[0], rel.points[1], rel.fromMult);
   if (rel.toMult) {
-    const [tx, ty] = rel.points[rel.points.length - 1];
-    s += `<text x="${tx + 4}" y="${ty - 4}" fill="#64748b" font-size="9.5" ${FM}>${escXml(rel.toMult)}</text>`;
+    const n = rel.points.length;
+    s += multLabel(rel.points[n - 1], rel.points[n - 2], rel.toMult);
   }
   if (rel.label) {
     const mid = rel.points[Math.floor(rel.points.length / 2)];
@@ -435,7 +440,7 @@ function render() {
   const rels  = RELS.map(svgRel).join('');
   const boxes = CLASSES.map(svgBox).join('');
   // Legend is placed at totalHeight - 60 so it always lands inside the viewBox.
-  const legend = `<text x="16" y="${totalHeight - 60}" fill="#64748b" font-size="9" ${FM}>── Association  ◇── Aggregation  ◆── Composition  ──▷ Generalization  --→ Dependency (enum only)</text>`;
+  const legend = `<text x="16" y="${totalHeight - 60}" fill="#64748b" font-size="9" ${FM}>── Association  ◇── Aggregation  ◆── Composition  ──▷ Generalization  |  קרדינליות בשני קצות הקשר</text>`;
 
   const svg = document.getElementById('diagram-svg');
   svg.setAttribute('width',   totalWidth);

package/skills/uml-use-case-diagram/SKILL.md

@@ -200,7 +200,7 @@ UC documentation: [uc-id]
     - בתור [תפקיד שונה או אותו תפקיד עם מטרה שונה], אני רוצה [...], כדי ש[...].
     - ... (keep adding until every user-facing goal tied to this UC is represented)
 
-  wireframe?:  (optional — only where the UC benefits from a UI mock; see §WF)
+  wireframe:   (REQUIRED for every human-initiated UC; omit only for system/cron primary actors and include-targets — see §WF)
 ```
 
 **Gates enforced before publishing:**
@@ -652,15 +652,13 @@ Every connection from a system-time actor MUST carry a `timing` field:
 
 ---
 
-## §WF. Wireframe Authoring (Opt-In)
+## §WF. Wireframe Authoring (Always On)
 
-**Wireframes are generated only when the user explicitly requests them** (e.g., "add wireframes", "include UI mocks"). Do not generate wireframes unless asked — they significantly increase generation time.
-
-When wireframes are requested, generate them only for UCs whose `primaryActor.actorType === 'human'`. Skip wireframes for:
+**Generate a wireframe for every human-initiated UC — always.** This course wants a UI mock on every human-facing screen; author them as part of normal generation, not on request. Generate a wireframe for every UC whose `primaryActor.actorType === 'human'`. Skip wireframes ONLY for:
 - UCs whose primary actor is a system or cron (`actorType: 'system'`) — no human sees a screen.
 - Pure include-target UCs (sub-behaviors with no actor association).
 
-When generated, emit a wireframe as an inline HTML fragment and attach it to `useCaseDocs[ucId].wireframe`. The modal renderer (§8a) injects the fragment after passing a safety check (see `wireframeSafe()` in §8a).
+Emit each wireframe as an inline HTML fragment and attach it to `useCaseDocs[ucId].wireframe` (and thus to the derived `diagramModel` useCase element). The modal renderer (§8a) injects the fragment after passing a safety check (see `wireframeSafe()` in §8a). A missing wireframe on a human-initiated UC is a validation ERROR (§12).
 
 Claude authors the wireframe using its own UI-generation judgment — there is no DSL. But the skill enforces a consistent look and safe sandbox via a scoped CSS theme and a set of forbidden patterns.
 
@@ -903,7 +901,8 @@ The validator runs locally (no API cost) and catches what the §4 and CR gates c
 - Extensions referencing invalid step numbers → ERROR
 - Narrative text missing Hebrew characters (description, preconditions, postconditions, flow/extension text, user stories, assumptions, openQuestions) → ERROR
 - Unsafe wireframe HTML (script / on*= / iframe / external URL / @import / inline style) → ERROR
-- Warnings: fewer than 2 user stories on a UC, no preconditions/postconditions, overall >2 include+extend relationships, wireframe present on a UC when none were requested
+- Missing wireframe on a human-initiated UC (§WF — wireframes are mandatory) → ERROR
+- Warnings: fewer than 2 user stories on a UC, no preconditions/postconditions, overall >2 include+extend relationships
 
 If the response is `✗ Model invalid`, fix every listed error and call the validator again. **Do not write the HTML file until the validator returns `✓ Model valid`.**
 
@@ -921,7 +920,7 @@ Briefly report: actor count, use case count, include/extend count, whether split
 - [ ] Every `primaryActor` id exists in `actors[]` AND has an association with `role: 'initiator'` on that UC (aligning §4.1 with §4.4).
 - [ ] Every flow step of `kind: 'actor'` references a real actor id; every `kind: 'include'` references a real UC id; every `extension.at` references a valid step number in its scenario's flow.
 - [ ] Clicking a UC on the diagram opens the full-screen modal (§8a); Esc / backdrop click closes it. Step actor/UC references are clickable. Actor popup + association popup (§8b) still work for non-UC clicks.
-- [ ] Wireframes generated only if the user explicitly requested them (§WF). If generated, only for human-initiated UCs; system/cron and include-targets omitted.
+- [ ] Wireframes generated for EVERY human-initiated UC (§WF — mandatory); system/cron primary actors and include-targets omitted.
 - [ ] Any `wireframe` HTML passes `wireframeSafe()` (no `<script>`, no `on*=`, no `<iframe>`, no external URLs, no `@import`, no inline `<style>`); all classes are `wf-*` only; visible text is in Hebrew.
 - [ ] Every actor-UC association has a written §4.1 justification block (role, initiates? one-line "why"); every UC has ≥1 association with `initiates = yes`.
 - [ ] Every association line carries a transparent click-hitbox (stroke-width ≥12, `data-conn-id`) wired to `showDesc(id,'assoc',event)`; `assocDescriptions` entry exists for each id.