sad-mcp 2.3.2 → 2.3.4

package/dist/usecase/validate.js

@@ -348,7 +348,7 @@ export function validateModel(model) {
                 const isHuman = !pa || pa.actorType !== "system";
                 const wfMissing = typeof wf !== "string" || wf.trim() === "";
                 if (isHuman && wfMissing) {
-                    warn("wireframe-missing", `${path}.wireframe`, `UC "${id}" has a human primary actor ("${primaryActor}") but no wireframe. Wireframes are opt-in per §WF — add one only if the user requested wireframes.`);
+                    err("wireframe-missing", `${path}.wireframe`, `UC "${id}" has a human primary actor ("${primaryActor}") but no wireframe. Wireframes are mandatory for every human-initiated UC (§WF) — add one.`);
                 }
             }
             if (typeof wf === "string" && wf.length > 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sad-mcp",
-  "version": "2.3.2",
+  "version": "2.3.4",
   "description": "MCP server for Software Analysis and Design course materials at BGU",
   "type": "module",
   "bin": {

package/skills/uml-class-diagram/NOTATION.md

@@ -5,7 +5,7 @@ Source lectures: שיעורים 6-7 תרשים מחלקות.pptx, ניתוץ ש
 ## Elements Taught
 
 - **Classes** — three compartments: name, attributes, operations
-- **Enumerations** — `«enumeration»` stereotype; use when: closed list, textual values, ≤~20 items. Do NOT use for open-ended or numeric choices
+- **Enumerations** — `«enumeration»` stereotype; use when: closed list, textual values, ≤~20 items. Do NOT use for open-ended or numeric choices. Draw as an **unconnected box** next to the class that uses it — no dependency or association line to the class.
 - **Packages (חבילה)** — grouping mechanism for related classes; taught as an organizational concept
 - **Abstract classes / interfaces** — not explicitly covered in lectures; avoid adding unless user asks
 
@@ -69,7 +69,7 @@ Source lectures: שיעורים 6-7 תרשים מחלקות.pptx, ניתוץ ש
 - Strict LEFT/CENTER/RIGHT zone layout — lectures don't prescribe this
 - Interactive composition-toggle panel — not a teaching concept
 - Enumerations placed only in a "RIGHT zone" — not explicitly taught
-- No dependency lines from enums to classes — not mentioned; lectures use dependencies normally
+- Enumerations are drawn as **unconnected boxes** next to their using class — the course does **not** draw a dependency (or any) line from a class to an enum; the attribute type reference is the only link (instructor rule, 2026)
 - Association class connected to midpoint — taught in principle but not the dashed-line-to-midpoint rule specifically
 
 ### Rules lectures teach that SKILL.md omits or misrepresents

package/skills/uml-class-diagram/SKILL.md

@@ -66,6 +66,7 @@ Two common false positives:
 - Use enumerations when: closed list, textual values, ≤~20 items, will not change often
 - Do NOT use for open-ended, numeric, or frequently changing value sets
 - Place enumerations adjacent to the class that uses them, not in a fixed zone
+- **Do NOT connect an enumeration to a class with any line** (no dependency, no association). The attribute type reference (`status : RegistrationStatus`) is the only link. `type: 'dep'` in RELS is not used.
 
 ### Packages (חבילה)
 - Draw as a tabbed rectangle enclosing related classes
@@ -83,11 +84,11 @@ Two common false positives:
 | Aggregation | Solid | Hollow diamond at whole | "has-a", part can exist independently |
 | Composition | Solid | Filled diamond at whole | Part cannot exist without whole |
 | Generalization | Solid | Hollow triangle at parent | True is-a; subtypes have different attributes/ops |
-| Dependency | Dashed | Open arrow | **ONLY** when a class references an enumeration type as an attribute type. Never between two regular classes — use plain association instead |
+| Dependency | Dashed | Open arrow | **Not used in this course's class diagrams.** Enumerations are NOT connected to their using class by any line (see §2 / §3 CRITICAL). Never draw a dependency between two regular classes either — use a plain association. |
 
 > **CRITICAL — domain diagram association rules:**
 > - Plain association (──): the default for every class-to-class relationship. No arrowheads.
-> - Dependency (---→): only for enumeration usage. Never on class-to-class relationships.
+> - Dependency (---→): **not used at all.** Enumerations are drawn as unconnected boxes placed next to their using class — no line of any kind. The attribute type reference (`status : RegistrationStatus`) is the only link. Do not draw a dependency between two regular classes either.
 > - Directed association (──→): never in a domain or analysis diagram.
 
 **Multiplicity at both ends of every association**: `1`, `0..1`, `1..*`, `0..*`. Never leave one end unlabeled.
@@ -484,7 +485,7 @@ When in doubt, use the male form.
 - [ ] Hebrew names use male form
 - [ ] **No raw SVG class boxes** — class boxes are rendered by `svgBox()` from `CLASSES` data, not hand-written SVG
 - [ ] **No arrowheads on plain associations** — `type: 'assoc'` in RELS produces no marker; directed association never appears in domain/analysis diagrams
-- [ ] **Dependency (---→) only for enum usage** — `type: 'dep'` only when a class references an enum type; never between two regular classes
+- [ ] **No dependency lines at all** — enumerations are unconnected boxes placed near their using class (no `type: 'dep'`); dependency is not used in this course's class diagrams, and never between two regular classes
 - [ ] **`<html>` has no `dir="rtl"`** — SVG coordinates are LTR; page language does not affect SVG rendering
 - [ ] **`boxH()` / `boxW()` from §9d engine used** — never hardcode box dimensions in data or SVG
 - [ ] **Attribute/operation rows: `text-anchor="start"` at `x = box.x + 6`** — enforced by engine; do not override

package/skills/uml-use-case-diagram/SKILL.md

@@ -200,7 +200,7 @@ UC documentation: [uc-id]
     - בתור [תפקיד שונה או אותו תפקיד עם מטרה שונה], אני רוצה [...], כדי ש[...].
     - ... (keep adding until every user-facing goal tied to this UC is represented)
 
-  wireframe?:  (optional — only where the UC benefits from a UI mock; see §WF)
+  wireframe:   (REQUIRED for every human-initiated UC; omit only for system/cron primary actors and include-targets — see §WF)
 ```
 
 **Gates enforced before publishing:**
@@ -652,15 +652,13 @@ Every connection from a system-time actor MUST carry a `timing` field:
 
 ---
 
-## §WF. Wireframe Authoring (Opt-In)
+## §WF. Wireframe Authoring (Always On)
 
-**Wireframes are generated only when the user explicitly requests them** (e.g., "add wireframes", "include UI mocks"). Do not generate wireframes unless asked — they significantly increase generation time.
-
-When wireframes are requested, generate them only for UCs whose `primaryActor.actorType === 'human'`. Skip wireframes for:
+**Generate a wireframe for every human-initiated UC — always.** This course wants a UI mock on every human-facing screen; author them as part of normal generation, not on request. Generate a wireframe for every UC whose `primaryActor.actorType === 'human'`. Skip wireframes ONLY for:
 - UCs whose primary actor is a system or cron (`actorType: 'system'`) — no human sees a screen.
 - Pure include-target UCs (sub-behaviors with no actor association).
 
-When generated, emit a wireframe as an inline HTML fragment and attach it to `useCaseDocs[ucId].wireframe`. The modal renderer (§8a) injects the fragment after passing a safety check (see `wireframeSafe()` in §8a).
+Emit each wireframe as an inline HTML fragment and attach it to `useCaseDocs[ucId].wireframe` (and thus to the derived `diagramModel` useCase element). The modal renderer (§8a) injects the fragment after passing a safety check (see `wireframeSafe()` in §8a). A missing wireframe on a human-initiated UC is a validation ERROR (§12).
 
 Claude authors the wireframe using its own UI-generation judgment — there is no DSL. But the skill enforces a consistent look and safe sandbox via a scoped CSS theme and a set of forbidden patterns.
 
@@ -903,7 +901,8 @@ The validator runs locally (no API cost) and catches what the §4 and CR gates c
 - Extensions referencing invalid step numbers → ERROR
 - Narrative text missing Hebrew characters (description, preconditions, postconditions, flow/extension text, user stories, assumptions, openQuestions) → ERROR
 - Unsafe wireframe HTML (script / on*= / iframe / external URL / @import / inline style) → ERROR
-- Warnings: fewer than 2 user stories on a UC, no preconditions/postconditions, overall >2 include+extend relationships, wireframe present on a UC when none were requested
+- Missing wireframe on a human-initiated UC (§WF — wireframes are mandatory) → ERROR
+- Warnings: fewer than 2 user stories on a UC, no preconditions/postconditions, overall >2 include+extend relationships
 
 If the response is `✗ Model invalid`, fix every listed error and call the validator again. **Do not write the HTML file until the validator returns `✓ Model valid`.**
 
@@ -921,7 +920,7 @@ Briefly report: actor count, use case count, include/extend count, whether split
 - [ ] Every `primaryActor` id exists in `actors[]` AND has an association with `role: 'initiator'` on that UC (aligning §4.1 with §4.4).
 - [ ] Every flow step of `kind: 'actor'` references a real actor id; every `kind: 'include'` references a real UC id; every `extension.at` references a valid step number in its scenario's flow.
 - [ ] Clicking a UC on the diagram opens the full-screen modal (§8a); Esc / backdrop click closes it. Step actor/UC references are clickable. Actor popup + association popup (§8b) still work for non-UC clicks.
-- [ ] Wireframes generated only if the user explicitly requested them (§WF). If generated, only for human-initiated UCs; system/cron and include-targets omitted.
+- [ ] Wireframes generated for EVERY human-initiated UC (§WF — mandatory); system/cron primary actors and include-targets omitted.
 - [ ] Any `wireframe` HTML passes `wireframeSafe()` (no `<script>`, no `on*=`, no `<iframe>`, no external URLs, no `@import`, no inline `<style>`); all classes are `wf-*` only; visible text is in Hebrew.
 - [ ] Every actor-UC association has a written §4.1 justification block (role, initiates? one-line "why"); every UC has ≥1 association with `initiates = yes`.
 - [ ] Every association line carries a transparent click-hitbox (stroke-width ≥12, `data-conn-id`) wired to `showDesc(id,'assoc',event)`; `assocDescriptions` entry exists for each id.