sad-mcp 0.1.21 → 0.1.23

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "sad-mcp",
-  "version": "0.1.21",
+  "version": "0.1.23",
   "description": "MCP server for Software Analysis and Design course materials at BGU",
   "type": "module",
   "bin": {

package/skills/bpmn-diagram/SKILL.md

@@ -5,7 +5,23 @@ description: Create BPMN (Business Process Model and Notation) diagrams as inter
 
 # BPMN Diagram Creation Skill
 
-This skill creates professional, standards-compliant BPMN diagrams rendered as interactive HTML files with embedded SVG. The diagrams support Hebrew (RTL) and English text, and follow BPMN 2.0 notation with BPMN 1.1-style intermediate events (plain double circles without internal icons).
+This skill creates professional BPMN 1.1 diagrams rendered as interactive HTML files with embedded SVG. The diagrams support Hebrew (RTL) and English text.
+
+## NON-NEGOTIABLE RULES — READ BEFORE ANYTHING ELSE
+
+These rules are violated most often. You MUST follow every one. No exceptions.
+
+1. **GATEWAYS**: The diamond shape contains ONLY a marker symbol: **X** (XOR), **+** (AND), or **O** (OR). NEVER put text/labels inside the diamond. Labels go ABOVE the diamond. Every gateway (split AND merge) must have its marker.
+
+2. **CUSTOMERS / EXTERNAL PARTIES get their own POOL**: If a customer, patient, citizen, or external company (e.g., חברת אשראי, ספק) acts independently — they are a SEPARATE POOL with message flows (dashed lines) between pools. They are NOT a lane. The only exception: if the organization fully controls the participant's actions within its system (e.g., customer using a bank app).
+
+3. **DATA STORES are mandatory**: If any task involves "block account", "generate invoice", "credit account", "update record", "register", "look up", or any read/write to persistent state — you MUST draw a Data Store (cylinder) with data associations connecting it to the relevant tasks.
+
+4. **NO ELEMENTS ON LANE BOUNDARIES**: Every task, gateway, and event must be fully inside one lane, centered vertically with clear spacing from lane borders.
+
+5. **EVERY PARTICIPANT MUST APPEAR**: If the process description mentions a customer/patient/company — they MUST appear in the diagram. Never omit a participant.
+
+6. **OUTPUT STRUCTURAL ANALYSIS FIRST**: Before writing ANY SVG, you must output the structural analysis (participants → pool/lane, data stores, message flows). The SVG must match this analysis.
 
 ## When to Use
 
@@ -73,6 +89,11 @@ STRUCTURAL ANALYSIS:
 - Putting a customer/patient/citizen as a lane when they act independently — they need a separate pool with message flows, not sequence flows
 - Using sequence flows between independent participants instead of message flows between separate pools
 - Forgetting that external companies (e.g., חברת אשראי, ספק, קבלן) also need their own pool — they are not part of the organization
+- Omitting a participant entirely — if the process description mentions a customer/patient/citizen, they MUST appear in the diagram as a pool with their own flow
+
+### Element Placement — CRITICAL
+
+**Every BPMN element (task, gateway, event) must be fully contained within a single lane or pool.** No element may overlap a lane divider line or sit on the boundary between two lanes. If an element belongs to a lane, it must be clearly centered vertically within that lane's area, with visible spacing from the lane borders above and below.
 
 ### Color Scheme by Participant Type
 
@@ -109,13 +130,28 @@ Example: If a Resident interacts with both a Delivery Company and a Development
 
 ### Gateways — CRITICAL RULE
 
-**Every gateway — both split AND merge/join — MUST display the X marker (for XOR) or + marker (for AND/parallel).** Merge gateways are never left as blank diamonds. This is a non-negotiable requirement.
+**Gateway diamonds must contain ONLY the marker symbol — NEVER text.** No labels, descriptions, or questions inside the diamond shape. Gateway labels go ABOVE or BESIDE the diamond, never inside it.
+
+- XOR (exclusive): **X** marker inside the diamond
+- AND (parallel): **+** marker inside the diamond
+- OR (inclusive): **O** marker inside the diamond
+
+**Every gateway — both split AND merge/join — MUST display its marker symbol.** Merge gateways are never left as blank diamonds. This is a non-negotiable requirement.
+
+**Anti-pattern — NEVER do this:**
+```svg
+<!-- WRONG: text inside gateway diamond -->
+<polygon points="..." fill="..." stroke="..."/>
+<text x="CX" y="CY">כמה ימים?</text>  <!-- FORBIDDEN -->
+```
 
+**Correct pattern:**
 ```svg
-<!-- XOR Gateway template (both split and merge) -->
+<!-- RIGHT: X marker inside, label outside -->
 <rect x="X" y="Y" width="34" height="34" class="gateway" transform="rotate(45, CX, CY)"/>
 <line x1="CX-7" y1="CY-10" x2="CX+7" y2="CY+10" class="gateway-x"/>
 <line x1="CX+7" y1="CY-10" x2="CX-7" y2="CY+10" class="gateway-x"/>
+<text x="CX" y="CY-25" text-anchor="middle">כמה ימים?</text>  <!-- label ABOVE -->
 ```
 
 ### Intermediate Events (Waiting/Catching)
@@ -210,7 +246,7 @@ When a process includes an approval step where the participant can reject:
 
 Output a single self-contained HTML file with:
 
-1. **Header bar**: Gradient background with process title in Hebrew + English subtitle
+1. **Header bar**: Gradient background with process title in Hebrew + English subtitle. Must say "BPMN 1.1" (NOT 2.0)
 2. **Legend**: Horizontal bar showing all BPMN symbols used in the diagram (start, end, task, XOR gateway, intermediate event, data object, data store, message flow)
 3. **SVG canvas**: The full BPMN diagram in a scrollable wrapper
 4. **SVG definitions**: Drop shadow filters, arrow markers (sequence, message, data association)
@@ -225,9 +261,12 @@ Output a single self-contained HTML file with:
 
 **STOP before delivering the diagram. Verify EVERY item below. If any item fails, you MUST fix it before delivering. Do NOT skip this step.**
 
-- [ ] Every gateway (split AND merge) has an X or + symbol
+- [ ] Every gateway (split AND merge) has ONLY an X/+/O marker inside — no text inside the diamond
+- [ ] Gateway labels (questions, conditions) are positioned ABOVE or BESIDE the diamond, never inside
+- [ ] Every element (task, gateway, event) is fully inside a single lane — nothing sits on a lane boundary
 - [ ] No arrow paths overlap or cross ambiguously
 - [ ] Data objects (📄) and data stores (🗄️) use different icons
+- [ ] Every participant mentioned in the process description appears in the diagram — none are omitted
 - [ ] External participants are in separate pools with message flows
 - [ ] Passive waiting uses intermediate events, not regular tasks
 - [ ] Flow labels (כן/לא) are clearly positioned near their gateway