ryugi-artifacts 1.64.0 → 1.65.0

package/dist/server.cjs

@@ -48383,7 +48383,7 @@ var import_node_os2 = __toESM(require("node:os"), 1);
 var import_node_path41 = __toESM(require("node:path"), 1);
 
 // package.json
-var version = "1.64.0";
+var version = "1.65.0";
 
 // src/server/browser-focus.ts
 var import_node_child_process = require("node:child_process");
@@ -50268,6 +50268,16 @@ function blocksOf(diff) {
   }
   return [...blocks.values()];
 }
+function countStates(items) {
+  const summary = /* @__PURE__ */ new Map();
+  for (const item2 of items) {
+    const status = item2.kind === "choose" ? item2.choice ? "chosen" : "empty" : String(item2.state ?? item2.verdict ?? item2.status ?? "unknown");
+    summary.set(status, (summary.get(status) ?? 0) + 1);
+    if (item2.waitingOn === "agent")
+      summary.set("waitingOnAgent", (summary.get("waitingOnAgent") ?? 0) + 1);
+  }
+  return Object.fromEntries(summary);
+}
 function createAgentReview(stateDir, options2 = {}) {
   const root = import_node_path7.default.join(stateDir, "agent-review");
   const now = options2.now ?? Date.now;
@@ -50408,6 +50418,9 @@ function createAgentReview(stateDir, options2 = {}) {
         waitingOn: waitingOn(thread),
         anchor: thread.anchor,
         stale: item2.stale ?? false,
+        ...item2.orphan === true ? { orphan: true } : {},
+        ...item2.draft === true ? { draft: true } : {},
+        ...typeof item2.page === "string" ? { page: item2.page } : {},
         preview: preview(
           last?.text ?? (thread.messages.some((message2) => message2.deleted) ? "[deleted]" : "")
         ),
@@ -50423,16 +50436,9 @@ function createAgentReview(stateDir, options2 = {}) {
         )
       )
     ) : materialized;
-    const summary = /* @__PURE__ */ new Map();
-    for (const item2 of values) {
-      const status = item2.kind === "choose" ? item2.choice ? "chosen" : "empty" : String(item2.state ?? item2.verdict ?? item2.status ?? "unknown");
-      summary.set(status, (summary.get(status) ?? 0) + 1);
-      if (item2.waitingOn === "agent")
-        summary.set("waitingOnAgent", (summary.get("waitingOnAgent") ?? 0) + 1);
-    }
     return {
       items,
-      summary: Object.fromEntries(summary),
+      summary: snap.value.counts ?? countStates(values),
       snapshot: snap.id,
       ...receipt ? { receipt } : {},
       page: {
@@ -50440,6 +50446,7 @@ function createAgentReview(stateDir, options2 = {}) {
         total: values.length,
         hasMore: nextCursor !== null,
         nextCursor,
+        offset,
         scope: snap.value.all ? "historical" : snap.value.kind === "threads" ? input.thread ? "thread" : "unread" : "current_state",
         snapshot: snap.id
       }
@@ -50468,9 +50475,12 @@ function createAgentReview(stateDir, options2 = {}) {
       return page(input, snap, !!input.detail || !!input.thread);
     },
     state(input) {
+      const narrowed = !!(input.all || input.filters?.status || input.filters?.choiceState);
+      const keep = !narrowed && input.actionable ? input.actionable : () => true;
       const snap = snapshot2(input, input.section, () => ({
+        counts: countStates(input.items),
         items: input.items.filter(
-          (item2) => (!input.filters?.status || item2.state === input.filters.status || item2.verdict === input.filters.status) && (!input.filters?.kind || item2.kind === input.filters.kind) && (!input.filters?.choiceState || (input.filters.choiceState === "chosen" ? !!item2.choice : !item2.choice))
+          (item2) => keep(item2) && (!input.filters?.status || item2.state === input.filters.status || item2.verdict === input.filters.status) && (!input.filters?.kind || item2.kind === input.filters.kind) && (!input.filters?.choiceState || (input.filters.choiceState === "chosen" ? !!item2.choice : !item2.choice))
         )
       }));
       return page(input, snap, !!input.detail);
@@ -65163,7 +65173,7 @@ function installInspector(win, properties, commentCursor = "crosshair", pointerC
   };
   const label = (el3) => (el3.getAttribute("data-layer-name") || el3.getAttribute("aria-label") || el3.id || (!el3.childElementCount ? el3.textContent?.trim() : "") || "").slice(0, 100);
   const selector = (el3) => (el3.id ? `#${el3.id}` : el3.tagName.toLowerCase() + Array.from(el3.classList).slice(0, 2).map((name) => `.${name}`).join("")).slice(0, 200);
-  const pathOf = (el3) => {
+  const pathOf2 = (el3) => {
     const segments = [];
     for (let node = el3; node && node !== doc.documentElement; node = node.parentElement) {
       const tag = node.tagName.toLowerCase();
@@ -65253,7 +65263,7 @@ function installInspector(win, properties, commentCursor = "crosshair", pointerC
         name: label(el3),
         tag: el3.tagName.toLowerCase(),
         selector: selector(el3),
-        path: pathOf(el3),
+        path: pathOf2(el3),
         kind: kind(el3, win.getComputedStyle(el3)),
         children: []
       };
@@ -157464,26 +157474,26 @@ var checkPartialGroup = function checkPartialGroup2(node) {
   }
   return null;
 };
-var _getOutermostNode = function getOutermostNode(node, side) {
+var _getOutermostNode = function getOutermostNode(node, side2) {
   var partialGroup = checkPartialGroup(node);
   if (partialGroup) {
     var children2 = partialGroup.children;
     if (children2.length) {
-      if (side === "right") {
+      if (side2 === "right") {
         return _getOutermostNode(children2[children2.length - 1], "right");
-      } else if (side === "left") {
+      } else if (side2 === "left") {
         return _getOutermostNode(children2[0], "left");
       }
     }
   }
   return node;
 };
-var getTypeOfDomTree = function getTypeOfDomTree2(node, side) {
+var getTypeOfDomTree = function getTypeOfDomTree2(node, side2) {
   if (!node) {
     return null;
   }
-  if (side) {
-    node = _getOutermostNode(node, side);
+  if (side2) {
+    node = _getOutermostNode(node, side2);
   }
   var className = node.classes[0];
   return DomEnum[className] || null;
@@ -170595,10 +170605,10 @@ var LoroList = class _LoroList {
    * @param {Side} side
    * @returns {Cursor | undefined}
    */
-  getCursor(pos, side) {
+  getCursor(pos, side2) {
     try {
       const retptr = wasm.__wbindgen_add_to_stack_pointer(-16);
-      wasm.lorolist_getCursor(retptr, this.__wbg_ptr, pos, addHeapObject(side));
+      wasm.lorolist_getCursor(retptr, this.__wbg_ptr, pos, addHeapObject(side2));
       var r02 = getDataViewMemory0().getInt32(retptr + 4 * 0, true);
       var r12 = getDataViewMemory0().getInt32(retptr + 4 * 1, true);
       var r23 = getDataViewMemory0().getInt32(retptr + 4 * 2, true);
@@ -172080,10 +172090,10 @@ var LoroMovableList = class _LoroMovableList {
    * @param {Side} side
    * @returns {Cursor | undefined}
    */
-  getCursor(pos, side) {
+  getCursor(pos, side2) {
     try {
       const retptr = wasm.__wbindgen_add_to_stack_pointer(-16);
-      wasm.loromovablelist_getCursor(retptr, this.__wbg_ptr, pos, addHeapObject(side));
+      wasm.loromovablelist_getCursor(retptr, this.__wbg_ptr, pos, addHeapObject(side2));
       var r02 = getDataViewMemory0().getInt32(retptr + 4 * 0, true);
       var r12 = getDataViewMemory0().getInt32(retptr + 4 * 1, true);
       var r23 = getDataViewMemory0().getInt32(retptr + 4 * 2, true);
@@ -172935,10 +172945,10 @@ var LoroText = class _LoroText {
    * @param {Side} side
    * @returns {Cursor | undefined}
    */
-  getCursor(pos, side) {
+  getCursor(pos, side2) {
     try {
       const retptr = wasm.__wbindgen_add_to_stack_pointer(-16);
-      wasm.lorotext_getCursor(retptr, this.__wbg_ptr, pos, addHeapObject(side));
+      wasm.lorotext_getCursor(retptr, this.__wbg_ptr, pos, addHeapObject(side2));
       var r02 = getDataViewMemory0().getInt32(retptr + 4 * 0, true);
       var r12 = getDataViewMemory0().getInt32(retptr + 4 * 1, true);
       var r23 = getDataViewMemory0().getInt32(retptr + 4 * 2, true);
@@ -182070,6 +182080,157 @@ function createVerifyRecordings(options2) {
 // src/server/whiteboard.ts
 var import_node_fs33 = __toESM(require("node:fs"), 1);
 var import_node_path29 = __toESM(require("node:path"), 1);
+
+// src/server/whiteboard-lint.ts
+var LINE_TYPES = /* @__PURE__ */ new Set(["arrow", "line"]);
+var NOT_OBSTACLES = /* @__PURE__ */ new Set(["text", "frame", "magicframe", "freedraw", "arrow", "line"]);
+var GRAZE = 2;
+var LABEL_MARGIN = 40;
+var CROSSINGS_SHOWN = 5;
+var containerSizeFor = (dimension, type) => {
+  const padded = Math.ceil(dimension) + 10;
+  if (type === "ellipse") return Math.round(padded / Math.SQRT2 * 2);
+  if (type === "diamond") return 2 * padded;
+  return padded;
+};
+var overlaps = (a5, b6) => a5.x < b6.x + b6.w && b6.x < a5.x + a5.w && a5.y < b6.y + b6.h && b6.y < a5.y + a5.h;
+var holds = (box2, [x9, y5]) => x9 > box2.x && x9 < box2.x + box2.w && y5 > box2.y && y5 < box2.y + box2.h;
+var inset = (box2, by2) => ({
+  x: box2.x + by2,
+  y: box2.y + by2,
+  w: box2.w - 2 * by2,
+  h: box2.h - 2 * by2
+});
+var segmentHits = (a5, b6, box2) => {
+  if (box2.w <= 0 || box2.h <= 0) return false;
+  const dx2 = b6[0] - a5[0];
+  const dy2 = b6[1] - a5[1];
+  let lo4 = 0;
+  let hi3 = 1;
+  for (const [p7, q4] of [
+    [-dx2, a5[0] - box2.x],
+    [dx2, box2.x + box2.w - a5[0]],
+    [-dy2, a5[1] - box2.y],
+    [dy2, box2.y + box2.h - a5[1]]
+  ]) {
+    if (p7 === 0) {
+      if (q4 < 0) return false;
+      continue;
+    }
+    const t7 = q4 / p7;
+    if (p7 < 0) lo4 = Math.max(lo4, t7);
+    else hi3 = Math.min(hi3, t7);
+    if (lo4 > hi3) return false;
+  }
+  return true;
+};
+var side = (a5, b6, c10) => Math.sign((b6[0] - a5[0]) * (c10[1] - a5[1]) - (b6[1] - a5[1]) * (c10[0] - a5[0]));
+var segmentsCross = (a5, b6, c10, d10) => side(a5, b6, c10) * side(a5, b6, d10) < 0 && side(c10, d10, a5) * side(c10, d10, b6) < 0;
+var pathOf = (element) => {
+  const { points: points2 } = element;
+  if (!Array.isArray(points2) || points2.length < 2) return null;
+  const path44 = [];
+  for (const point2 of points2) {
+    if (!Array.isArray(point2) || typeof point2[0] !== "number" || typeof point2[1] !== "number")
+      return null;
+    path44.push([(element.x ?? 0) + point2[0], (element.y ?? 0) + point2[1]]);
+  }
+  return path44;
+};
+var segmentsOf = (path44) => path44.slice(1).map((end, index) => [path44[index], end]);
+var lengthOf = (path44) => segmentsOf(path44).reduce((sum2, [a5, b6]) => sum2 + Math.hypot(b6[0] - a5[0], b6[1] - a5[1]), 0);
+var boundIds = (element) => [element.startBinding?.elementId, element.endBinding?.elementId].filter(
+  (id3) => typeof id3 === "string"
+);
+function overflowWarnings(live3, geometry) {
+  const byId = new Map(live3.map((element) => [element.id, element]));
+  const warnings = [];
+  for (const text5 of live3) {
+    const box2 = geometry[text5.id];
+    if (text5.type !== "text" || !box2?.overflow) continue;
+    const container = text5.containerId ? byId.get(text5.containerId) : void 0;
+    const outer = container ? geometry[container.id] : void 0;
+    if (!container || !outer) {
+      warnings.push(`text ${text5.id} overflows its container`);
+      continue;
+    }
+    const width = containerSizeFor(box2.w, container.type);
+    const height = containerSizeFor(box2.h, container.type);
+    const short = [width > outer.w && `${width} wide`, height > outer.h && `${height} tall`].filter(
+      Boolean
+    );
+    const now = short.length === 2 ? `${Math.round(outer.w)}\xD7${Math.round(outer.h)}` : width > outer.w ? Math.round(outer.w) : Math.round(outer.h);
+    warnings.push(
+      short.length ? `label of ${container.id} does not fit \u2014 make ${container.id} at least ${short.join(" and ")} (now ${now})` : `label of ${container.id} sticks out of it \u2014 re-center the label or enlarge ${container.id}`
+    );
+  }
+  return warnings;
+}
+function arrowWarnings(live3, geometry) {
+  const obstacles = live3.filter(
+    (element) => !NOT_OBSTACLES.has(element.type) && !element.containerId && geometry[element.id]
+  );
+  const labels = new Map(
+    live3.filter((element) => element.type === "text" && element.containerId && geometry[element.id]).map((text5) => [text5.containerId, geometry[text5.id]])
+  );
+  const arrows = live3.flatMap((element) => {
+    if (!LINE_TYPES.has(element.type) || ryugi(element).author !== "agent") return [];
+    const path44 = pathOf(element);
+    return path44 ? [{ element, path: path44, bound: boundIds(element) }] : [];
+  });
+  const warnings = [];
+  for (const { element, path: path44 } of arrows) {
+    const ends = [path44[0], path44.at(-1)];
+    const around = obstacles.filter(
+      (shape2) => !ends.some((end) => holds(geometry[shape2.id], end))
+    );
+    for (const shape2 of around) {
+      const box2 = inset(geometry[shape2.id], GRAZE);
+      if (segmentsOf(path44).some(([a5, b6]) => segmentHits(a5, b6, box2)))
+        warnings.push(
+          `arrow ${element.id} crosses ${shape2.id} \u2014 move ${shape2.id} or bend the arrow around it`
+        );
+    }
+    const label = labels.get(element.id);
+    if (!label) continue;
+    for (const shape2 of around)
+      if (overlaps(label, inset(geometry[shape2.id], GRAZE)))
+        warnings.push(
+          `label of arrow ${element.id} covers ${shape2.id} \u2014 move ${shape2.id} or shorten the label`
+        );
+    const [dx2, dy2] = [ends[1][0] - ends[0][0], ends[1][1] - ends[0][1]];
+    const chord = Math.hypot(dx2, dy2);
+    if (chord === 0) continue;
+    const need = Math.ceil(
+      (Math.abs(dx2) * label.w + Math.abs(dy2) * label.h) / chord + LABEL_MARGIN
+    );
+    const length = lengthOf(path44);
+    if (length < need)
+      warnings.push(
+        `label of arrow ${element.id} needs the arrow to be at least ${need} px long (now ${Math.round(length)}) \u2014 move its ends apart or shorten the label`
+      );
+  }
+  const crossings = [];
+  for (const [index, a5] of arrows.entries())
+    for (const b6 of arrows.slice(index + 1)) {
+      if (a5.bound.some((id3) => b6.bound.includes(id3))) continue;
+      const crossed = segmentsOf(a5.path).some(
+        ([p7, q4]) => segmentsOf(b6.path).some(([r8, s7]) => segmentsCross(p7, q4, r8, s7))
+      );
+      if (crossed) crossings.push(`${a5.element.id} \xD7 ${b6.element.id}`);
+    }
+  if (crossings.length) {
+    const shown = crossings.slice(0, CROSSINGS_SHOWN).join(", ");
+    const more = crossings.length > CROSSINGS_SHOWN ? `, and ${crossings.length - CROSSINGS_SHOWN} more` : "";
+    const places = crossings.length === 1 ? "1 place" : `${crossings.length} places`;
+    warnings.push(
+      `arrows cross in ${places}: ${shown}${more} \u2014 reorder the shapes so fewer arrows cross`
+    );
+  }
+  return warnings;
+}
+
+// src/server/whiteboard.ts
 var sceneVersionOf = (scene) => scene.elements.reduce((sum2, element) => sum2 + (element.version ?? 0), 0);
 function readWhiteboard(dir, id3) {
   const version3 = latestMtime(dir);
@@ -182092,8 +182253,8 @@ function readWhiteboard(dir, id3) {
   return { title: name || id3, warnings, version: version3, sceneVersion: sceneVersionOf(parsed.scene) };
 }
 var SCENE_SIZE_LIMIT = 5 * 1024 * 1024;
-var LINE_TYPES = /* @__PURE__ */ new Set(["arrow", "line"]);
-var overlaps = (a5, b6) => a5.x < b6.x + b6.w && b6.x < a5.x + a5.w && a5.y < b6.y + b6.h && b6.y < a5.y + a5.h;
+var LINE_TYPES2 = /* @__PURE__ */ new Set(["arrow", "line"]);
+var overlaps2 = (a5, b6) => a5.x < b6.x + b6.w && b6.x < a5.x + a5.w && a5.y < b6.y + b6.h && b6.y < a5.y + a5.h;
 var contains = (outer, inner2) => inner2.x >= outer.x && inner2.y >= outer.y && inner2.x + inner2.w <= outer.x + outer.w && inner2.y + inner2.h <= outer.y + outer.h;
 function whiteboardWarnings2(scene, context2) {
   const file = context2.file ?? "scene.excalidraw";
@@ -182101,7 +182262,7 @@ function whiteboardWarnings2(scene, context2) {
   const ids = new Set(live3.map((element) => element.id));
   const warnings = [];
   for (const element of live3) {
-    if (LINE_TYPES.has(element.type)) {
+    if (LINE_TYPES2.has(element.type)) {
       for (const binding of [element.startBinding, element.endBinding])
         if (binding && !ids.has(binding.elementId)) {
           const other = context2.elsewhere?.(binding.elementId);
@@ -182129,28 +182290,27 @@ function whiteboardWarnings2(scene, context2) {
     );
   const geometry = context2.geometry?.sceneVersion === sceneVersionOf(scene) ? context2.geometry.elements : null;
   if (geometry) {
-    for (const element of live3)
-      if (element.type === "text" && geometry[element.id]?.overflow)
-        warnings.push(`text ${element.id} overflows its container`);
+    warnings.push(...overflowWarnings(live3, geometry));
     for (const element of live3) {
       const box2 = geometry[element.id];
       const frame = element.frameId ? geometry[element.frameId] : void 0;
-      if (!box2 || !frame || element.containerId || LINE_TYPES.has(element.type)) continue;
+      if (!box2 || !frame || element.containerId || LINE_TYPES2.has(element.type)) continue;
       if (ryugi(element).lastBy !== "agent" || contains(frame, box2)) continue;
       warnings.push(
         `element ${element.id} sticks out of frame ${element.frameId}, which hides the part outside \u2014 move it in or resize the frame`
       );
     }
     const shapes = live3.filter(
-      (element) => ryugi(element).author === "agent" && element.type !== "frame" && element.type !== "text" && !LINE_TYPES.has(element.type) && geometry[element.id]
+      (element) => ryugi(element).author === "agent" && element.type !== "frame" && element.type !== "text" && !LINE_TYPES2.has(element.type) && geometry[element.id]
     );
     for (const [index, a5] of shapes.entries())
       for (const b6 of shapes.slice(index + 1)) {
         const boxA = geometry[a5.id];
         const boxB = geometry[b6.id];
-        if (overlaps(boxA, boxB) && !contains(boxA, boxB) && !contains(boxB, boxA))
+        if (overlaps2(boxA, boxB) && !contains(boxA, boxB) && !contains(boxB, boxA))
           warnings.push(`elements ${a5.id} and ${b6.id} overlap`);
       }
+    warnings.push(...arrowWarnings(live3, geometry));
   }
   const pending = live3.some(isSkeleton) ? ["skeleton_not_completed"] : [];
   return { warnings, pending };
@@ -182442,8 +182602,8 @@ function mergeBrowser(current, incoming, opts = {}) {
   for (const element of incoming) {
     const existing = replaced.get(element.id) ?? known.get(element.id);
     if (!existing) {
-      const side = opts.completion ? "agent" : "human";
-      added.push(withRyugi(element, { author: side, rev: 1, lastBy: side }));
+      const side2 = opts.completion ? "agent" : "human";
+      added.push(withRyugi(element, { author: side2, rev: 1, lastBy: side2 }));
       changed.push(element.id);
       continue;
     }
@@ -183572,7 +183732,7 @@ var import_node_path34 = __toESM(require("node:path"), 1);
 
 // src/shared/whiteboard/summary.ts
 var STICKY_FILL = "#ffec99";
-var LINE_TYPES2 = /* @__PURE__ */ new Set(["arrow", "line"]);
+var LINE_TYPES3 = /* @__PURE__ */ new Set(["arrow", "line"]);
 function provenance(element) {
   const fields = ryugi(element);
   const author = fields.author ?? null;
@@ -183595,7 +183755,7 @@ function summarize(scene, opts = {}) {
     ...provenance(element)
   });
   const shapes = live3.filter(
-    (element) => element.type !== "frame" && !LINE_TYPES2.has(element.type) && !(element.type === "text" && element.containerId)
+    (element) => element.type !== "frame" && !LINE_TYPES3.has(element.type) && !(element.type === "text" && element.containerId)
   );
   const frames = live3.filter((element) => element.type === "frame" && (!opts.frame || element.id === opts.frame)).map((frame) => ({
     id: frame.id,
@@ -183604,7 +183764,7 @@ function summarize(scene, opts = {}) {
   }));
   const loose = opts.frame ? [] : shapes.filter((element) => !element.frameId).map(item2);
   const inFrame = (id3) => id3 !== null && frameOf.get(id3) === opts.frame;
-  const arrows = live3.filter((element) => LINE_TYPES2.has(element.type)).map((arrow) => ({
+  const arrows = live3.filter((element) => LINE_TYPES3.has(element.type)).map((arrow) => ({
     arrow,
     from: arrow.startBinding?.elementId ?? null,
     to: arrow.endBinding?.elementId ?? null
@@ -184127,6 +184287,16 @@ var agentEventRoute = {
   }
 };
 
+// src/server/review-defaults.ts
+function actionable(section, rounds) {
+  if (section === "asks") return (item2) => item2.state === "submitted";
+  if (section === "rounds") return (item2) => item2.state === "open" || item2.state === "submitted";
+  const submitted = new Set(
+    rounds.filter((round) => round.state === "submitted").map((round) => round.id)
+  );
+  return (item2) => item2.kind === "verify" ? item2.verdict === "reject" : submitted.has(item2.round);
+}
+
 // src/server/routes/agent-review.ts
 var schema = "ryugi.review/v1";
 var text3 = (value) => typeof value === "string" ? value : void 0;
@@ -184191,13 +184361,20 @@ async function threads(ctx, type, id3, input) {
 }
 async function state(ctx, type, id3, input, section) {
   let items = [];
+  let rounds = [];
   if (section === "asks" && type === "document")
     items = (await ctx.documents.asks(id3)).asks.map((ask) => ({ ...ask }));
-  else if (section === "groups" && type === "artboard")
+  else if (section === "groups" && type === "artboard") {
     items = ctx.boardComments.groups(id3).map((group) => ({ ...group }));
-  else if (section === "rounds" && type === "artboard")
+    rounds = ctx.boardComments.rounds(id3).map((round) => ({ ...round }));
+  } else if (section === "rounds" && type === "artboard")
     items = ctx.boardComments.rounds(id3).map((round) => ({ ...round }));
-  return ctx.agentReview.state({ ...input, section, items });
+  return ctx.agentReview.state({
+    ...input,
+    section,
+    items,
+    actionable: actionable(section, rounds)
+  });
 }
 function validateSection(input, section) {
   const error = validateReviewQuery({ ...input, section });