rx-player 4.2.0-dev.2024082600 → 4.2.0-dev.2024090500

package/src/manifest/classes/__tests__/update_period_in_place.test.ts

@@ -5,8 +5,6 @@ import type Period from "../period";
 import { MANIFEST_UPDATE_TYPE } from "../types";
 import updatePeriodInPlace from "../update_period_in_place";
 
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
 const oldVideoRepresentation1 = {
   id: "rep-video-1",
   getMetadataSnapshot() {

package/src/manifest/classes/__tests__/update_periods.test.ts

@@ -1,10 +1,9 @@
 import { describe, beforeEach, it, expect, vi } from "vitest";
-
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
-/* eslint-disable @typescript-eslint/no-unsafe-call */
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-/* eslint-disable @typescript-eslint/no-unsafe-return */
-/* eslint-disable @typescript-eslint/no-explicit-any */
+import type IPeriod from "../period";
+import type {
+  replacePeriods as IReplacePeriods,
+  updatePeriods as IUpatePeriods,
+} from "../update_periods";
 
 const MANIFEST_UPDATE_TYPE = {
   Full: 0,
@@ -22,16 +21,17 @@ function generateFakePeriod({
   start,
   end,
 }: {
-  id?: string | undefined;
-  start?: number;
+  id: string;
+  start?: number | undefined;
   end?: number | undefined;
-}) {
+}): IPeriod {
   return {
     id: id ?? String(start),
     start: start ?? 0,
     end,
     duration: end === undefined ? undefined : end - (start ?? 0),
     streamEvents: [],
+    adaptations: {},
     refreshCodecSupport() {
       // noop
     },
@@ -41,8 +41,8 @@ function generateFakePeriod({
     getAdaptationsForType() {
       return [];
     },
-    getAdaptation() {
-      return;
+    getAdaptation(): undefined {
+      return undefined;
     },
     getSupportedAdaptations() {
       return [];
@@ -84,8 +84,8 @@ describe("Manifest - replacePeriods", () => {
     ];
     const initialPeriods = oldPeriods.slice();
     const newPeriods = [generateFakePeriod({ id: "p2" })];
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [],
@@ -131,8 +131,8 @@ describe("Manifest - replacePeriods", () => {
       generateFakePeriod({ id: "p2" }),
       generateFakePeriod({ id: "p3" }),
     ];
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [newPeriods[1].getMetadataSnapshot()],
@@ -175,8 +175,8 @@ describe("Manifest - replacePeriods", () => {
     }));
     const oldPeriods = [generateFakePeriod({ id: "p1" })];
     const newPeriods = [generateFakePeriod({ id: "p2" })];
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [newPeriods[0].getMetadataSnapshot()],
@@ -212,8 +212,8 @@ describe("Manifest - replacePeriods", () => {
       generateFakePeriod({ id: "p3" }),
     ];
     const initialPeriods = oldPeriods.slice();
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [
@@ -272,8 +272,8 @@ describe("Manifest - replacePeriods", () => {
       generateFakePeriod({ id: "p2" }),
     ];
     const initialPeriods = oldPeriods.slice();
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [newPeriods[0].getMetadataSnapshot()],
@@ -309,12 +309,12 @@ describe("Manifest - replacePeriods", () => {
       default: fakeUpdatePeriodInPlace,
     }));
     const oldPeriods = [
-      generateFakePeriod({ id: "p1" }),
-      generateFakePeriod({ id: "p2" }),
+      generateFakePeriod({ id: "p1", start: 0 }),
+      generateFakePeriod({ id: "p2", start: 0 }),
     ];
-    const newPeriods = [] as any[];
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const newPeriods = [] as IPeriod[];
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [],
@@ -339,13 +339,13 @@ describe("Manifest - replacePeriods", () => {
     vi.doMock("../update_period_in_place", () => ({
       default: fakeUpdatePeriodInPlace,
     }));
-    const oldPeriods = [] as any[];
+    const oldPeriods = [] as IPeriod[];
     const newPeriods = [
       generateFakePeriod({ id: "p1" }),
       generateFakePeriod({ id: "p2" }),
     ];
-    const replacePeriods = ((await vi.importActual("../update_periods")) as any)
-      .replacePeriods;
+    const replacePeriods = (await vi.importActual("../update_periods"))
+      .replacePeriods as typeof IReplacePeriods;
     const res = replacePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [
@@ -385,8 +385,8 @@ describe("Manifest - updatePeriods", () => {
     const newPeriods = [generateFakePeriod({ id: "p2", start: 60 })];
     const initialPeriods = oldPeriods.slice();
 
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [],
@@ -426,8 +426,8 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p3", start: 80 }),
     ];
     const initialPeriods = oldPeriods.slice();
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [newPeriods[1].getMetadataSnapshot()],
@@ -464,8 +464,8 @@ describe("Manifest - updatePeriods", () => {
     }));
     const oldPeriods = [generateFakePeriod({ id: "p1", start: 50, end: 60 })];
     const newPeriods = [generateFakePeriod({ id: "p3", start: 70, end: 80 })];
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
 
     let error: unknown = null;
     try {
@@ -515,8 +515,8 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p3", start: 80 }),
     ];
     const initialPeriods = oldPeriods.slice();
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [
@@ -576,8 +576,8 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p2", start: 70 }),
     ];
 
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
 
     let error: unknown = null;
     try {
@@ -617,9 +617,9 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p1" }),
       generateFakePeriod({ id: "p2" }),
     ];
-    const newPeriods = [] as any[];
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const newPeriods = [] as IPeriod[];
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [],
@@ -643,13 +643,13 @@ describe("Manifest - updatePeriods", () => {
     vi.doMock("../update_period_in_place", () => ({
       default: fakeUpdatePeriodInPlace,
     }));
-    const oldPeriods = [] as any[];
+    const oldPeriods = [] as IPeriod[];
     const newPeriods = [
       generateFakePeriod({ id: "p1" }),
       generateFakePeriod({ id: "p2" }),
     ];
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [
@@ -676,8 +676,8 @@ describe("Manifest - updatePeriods", () => {
     vi.doMock("../update_period_in_place", () => ({
       default: fakeUpdatePeriodInPlace,
     }));
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const oldPeriods = [
       generateFakePeriod({ id: "p0", start: 50, end: 60 }),
       generateFakePeriod({ id: "p1", start: 60, end: 70 }),
@@ -721,8 +721,8 @@ describe("Manifest - updatePeriods", () => {
     }));
     const oldPeriods = [generateFakePeriod({ id: "p1", start: 50, end: 60 })];
     const newPeriods = [generateFakePeriod({ id: "p2", start: 60, end: 80 })];
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
 
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
@@ -749,8 +749,8 @@ describe("Manifest - updatePeriods", () => {
     }));
     const oldPeriods = [generateFakePeriod({ id: "p1", start: 50, end: 60 })];
     const newPeriods = [generateFakePeriod({ id: "px", start: 50, end: 70 })];
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
 
     let error: unknown = null;
     try {
@@ -797,8 +797,8 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p3", start: 80 }),
     ];
     const initialPeriods = oldPeriods.slice();
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [newPeriods[2].getMetadataSnapshot()],
@@ -857,8 +857,8 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p3", start: 80 }),
     ];
     const initialPeriods = oldPeriods.slice();
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [],
@@ -917,8 +917,8 @@ describe("Manifest - updatePeriods", () => {
       generateFakePeriod({ id: "p1", start: 60, end: 70 }),
       generateFakePeriod({ id: "p3", start: 80, end: 90 }),
     ];
-    const updatePeriods = ((await vi.importActual("../update_periods")) as any)
-      .updatePeriods;
+    const updatePeriods = (await vi.importActual("../update_periods"))
+      .updatePeriods as typeof IUpatePeriods;
     const res = updatePeriods(oldPeriods, newPeriods);
     expect(res).toEqual({
       addedPeriods: [],

package/src/manifest/classes/adaptation.ts

@@ -49,55 +49,55 @@ export default class Adaptation implements IAdaptationMetadata {
    */
   public manuallyAdded?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.representations
    */
   public readonly representations: Representation[];
   /**
-   * @see IRepresentationMetadata
+   * @see ITrackType
    */
   public readonly type: ITrackType;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isAudioDescription
    */
   public isAudioDescription?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isClosedCaption
    */
   public isClosedCaption?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isForcedSubtitles
    */
   public isForcedSubtitles?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isSignInterpreted
    */
   public isSignInterpreted?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isDub
    */
   public isDub?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.language
    */
   public language?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.normalizedLanguage
    */
   public normalizedLanguage?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationSupportStatus
    */
   public supportStatus: IAdaptationSupportStatus;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isTrickModeTrack
    */
   public isTrickModeTrack?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.label
    */
   public label?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.trickModeTracks
    */
   public readonly trickModeTracks?: Adaptation[];
 

package/src/manifest/classes/manifest.ts

@@ -360,9 +360,7 @@ export default class Manifest
      * @deprecated It is here to ensure compatibility with the way the
      * v3.x.x manages adaptations at the Manifest level
      */
-    /* eslint-disable import/no-deprecated */
     this.adaptations = this.periods[0] === undefined ? {} : this.periods[0].adaptations;
-    /* eslint-enable import/no-deprecated */
 
     this.timeBounds = parsedManifest.timeBounds;
     this.isDynamic = parsedManifest.isDynamic;
@@ -595,9 +593,7 @@ export default class Manifest
       "manifest.getAdaptation(id) is deprecated." +
         " Please use manifest.period[].getAdaptation(id) instead",
     );
-    /* eslint-disable import/no-deprecated */
     return arrayFind(this.getAdaptations(), ({ id }) => wantedId === id);
-    /* eslint-enable import/no-deprecated */
   }
 
   /**
@@ -691,9 +687,7 @@ export default class Manifest
     this.updateCodecSupport();
 
     // Re-set this.adaptations for retro-compatibility in v3.x.x
-    /* eslint-disable import/no-deprecated */
     this.adaptations = this.periods[0] === undefined ? {} : this.periods[0].adaptations;
-    /* eslint-enable import/no-deprecated */
 
     // Let's trigger events at the end, as those can trigger side-effects.
     // We do not want the current Manifest object to be incomplete when those

package/src/manifest/classes/representation.ts

@@ -37,15 +37,15 @@ class Representation implements IRepresentationMetadata {
   /** ID uniquely identifying the Representation in its parent Adaptation. */
   public readonly id: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.uniqueId
    */
   public readonly uniqueId: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.bitrate
    */
   public bitrate: number;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.frameRate
    */
   public frameRate?: number;
   /**
@@ -65,39 +65,47 @@ class Representation implements IRepresentationMetadata {
    */
   public cdnMetadata: ICdnMetadata[] | null;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.isSpatialAudio
    */
   public isSpatialAudio?: boolean | undefined;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.codecs
    */
   public codecs: string[];
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.mimeType
    */
   public mimeType?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.width
    */
   public width?: number;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.height
    */
   public height?: number;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.contentProtections
    */
   public contentProtections?: IContentProtections;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.hdrInfo
    */
   public hdrInfo?: IHDRInformation;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.decipherable
+   *
+   * Note that this property should __NEVER__ be updated directly on an
+   * instanciated `Representation`, you are supposed to rely on
+   * `Manifest` methods for this.
    */
   public decipherable?: boolean | undefined;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.isSupported
+   *
+   * Note that this property should __NEVER__ be updated directly on an
+   * instanciated `Representation`, you are supposed to rely on
+   * `Manifest` methods for this.
    */
   public isSupported: boolean | undefined;
   /**

package/src/manifest/utils.ts

@@ -138,8 +138,7 @@ export function getPeriodForTime(
   time: number,
 ): IPeriod | IPeriodMetadata | undefined {
   let nextPeriod = null;
-  for (let i = manifest.periods.length - 1; i >= 0; i--) {
-    const period = manifest.periods[i];
+  for (const period of manifest.periods) {
     if (periodContainsTime(period, time, nextPeriod)) {
       return period;
     }

package/src/mse/main_media_source_interface.ts

@@ -86,7 +86,7 @@ export default class MainMediaSourceInterface
     const mediaSource = new MediaSource_();
     const handle = (mediaSource as unknown as { handle: MediaProvider }).handle;
     this.handle = isNullOrUndefined(handle)
-      ? /* eslint-disable-next-line @typescript-eslint/no-restricted-types */
+      ? // eslint-disable-next-line @typescript-eslint/no-restricted-types
         { type: "media-source", value: mediaSource as unknown as MediaSource }
       : { type: "handle", value: handle };
     this._mediaSource = mediaSource;

package/src/mse/types.ts

@@ -163,7 +163,7 @@ export type IMediaSourceHandle =
        * Do not forget to revoke such URL (e.g. through `URL.revokeObjectURL`) when
        * you're done.
        */
-      /* eslint-disable-next-line @typescript-eslint/no-restricted-types */
+      // eslint-disable-next-line @typescript-eslint/no-restricted-types
       value: MediaSource;
     };
 

package/src/multithread_types.ts

@@ -8,7 +8,7 @@ import type { ISegmentSinkMetrics } from "./core/segment_sinks/segment_buffers_s
 import type {
   IResolutionInfo,
   IManifestFetcherSettings,
-  ISegmentFetcherCreatorBackoffOptions,
+  ISegmentQueueCreatorBackoffOptions,
   IInbandEvent,
   IPausedPlaybackObservation,
   IRepresentationsChoice,
@@ -140,7 +140,7 @@ export interface IContentInitializationData {
    */
   manifestRetryOptions: Omit<IManifestFetcherSettings, "cmcdDataBuilder">;
   /** Options relative to the fetching of media segments. */
-  segmentRetryOptions: ISegmentFetcherCreatorBackoffOptions;
+  segmentRetryOptions: ISegmentQueueCreatorBackoffOptions;
 }
 
 export interface ILogLevelUpdateMessage {

package/src/parsers/manifest/dash/common/__tests__/get_clock_offset.test.ts

@@ -1,10 +1,5 @@
 import { describe, beforeEach, it, expect, vi } from "vitest";
-
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
-/* eslint-disable @typescript-eslint/no-unsafe-call */
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-/* eslint-disable @typescript-eslint/no-unsafe-return */
-/* eslint-disable @typescript-eslint/no-explicit-any */
+import type IGetClockOffset from "../get_clock_offset";
 
 describe("DASH Parser - getClockOffset", () => {
   beforeEach(() => {
@@ -17,8 +12,8 @@ describe("DASH Parser - getClockOffset", () => {
       default: { warn: mockWarn },
     }));
 
-    const getClockOffset = ((await vi.importActual("../get_clock_offset")) as any)
-      .default;
+    const getClockOffset = (await vi.importActual("../get_clock_offset"))
+      .default as typeof IGetClockOffset;
     const mockDate = vi
       .spyOn(performance, "now")
       .mockReturnValue(Date.parse("2019-03-24T13:00:00Z"));
@@ -33,8 +28,8 @@ describe("DASH Parser - getClockOffset", () => {
     vi.doMock("../../../../../log", () => ({
       default: { warn: mockWarn },
     }));
-    const getClockOffset = ((await vi.importActual("../get_clock_offset")) as any)
-      .default;
+    const getClockOffset = (await vi.importActual("../get_clock_offset"))
+      .default as typeof IGetClockOffset;
 
     expect(getClockOffset("2018/412/13")).toEqual(undefined);
     expect(mockWarn).toHaveBeenCalledTimes(1);