rx-player 4.2.0-dev.2024082600 → 4.2.0-dev.2024090300

package/src/compat/__tests__/can_reuse_media_keys.test.ts

@@ -10,9 +10,9 @@ describe("Compat - canReuseMediaKeys", () => {
     vi.resetModules();
   });
 
-  it("should return true on any browser but WebOS", async () => {
+  it("should return true on most browsers", async () => {
     vi.doMock("../browser_detection", () => {
-      return { isWebOs: false, isPanasonic: false };
+      return { isWebOs: false, isPhilipsNetTv: false, isPanasonic: false };
     });
     const canReuseMediaKeys = (await vi.importActual(
       "../can_reuse_media_keys.ts",
@@ -26,6 +26,37 @@ describe("Compat - canReuseMediaKeys", () => {
         isWebOs: true,
         isWebOs2022: false,
         isPanasonic: false,
+        isPhilipsNetTv: false,
+      };
+    });
+    const canReuseMediaKeys = (await vi.importActual(
+      "../can_reuse_media_keys.ts",
+    )) as any;
+    expect(canReuseMediaKeys.default()).toBe(false);
+  });
+
+  it("should return false on Panasonic", async () => {
+    vi.doMock("../browser_detection", () => {
+      return {
+        isWebOs: false,
+        isWebOs2022: false,
+        isPanasonic: true,
+        isPhilipsNetTv: false,
+      };
+    });
+    const canReuseMediaKeys = (await vi.importActual(
+      "../can_reuse_media_keys.ts",
+    )) as any;
+    expect(canReuseMediaKeys.default()).toBe(false);
+  });
+
+  it("should return false on Philips' NETTV", async () => {
+    vi.doMock("../browser_detection", () => {
+      return {
+        isWebOs: false,
+        isWebOs2022: false,
+        isPanasonic: false,
+        isPhilipsNetTv: true,
       };
     });
     const canReuseMediaKeys = (await vi.importActual(

package/src/compat/browser_detection.ts

@@ -67,6 +67,9 @@ let isWebOs2022 = false;
 /** `true` for Panasonic devices. */
 let isPanasonic = false;
 
+/** `true` we're relying on Philips's NetTv browser. */
+let isPhilipsNetTv = false;
+
 /** `true` for the PlayStation 4 game console. */
 let isPlayStation4 = false;
 
@@ -155,6 +158,11 @@ let isXbox = false;
     ) {
       isWebOs2021 = true;
     }
+  } else if (
+    navigator.userAgent.indexOf("NETTV") !== -1 &&
+    navigator.userAgent.indexOf("Philips") !== -1
+  ) {
+    isPhilipsNetTv = true;
   } else if (/[Pp]anasonic/.test(navigator.userAgent)) {
     isPanasonic = true;
   } else if (navigator.userAgent.indexOf("Xbox") !== -1) {
@@ -168,6 +176,7 @@ export {
   isIEOrEdge,
   isFirefox,
   isPanasonic,
+  isPhilipsNetTv,
   isPlayStation4,
   isPlayStation5,
   isXbox,

package/src/compat/can_reuse_media_keys.ts

@@ -1,4 +1,4 @@
-import { isPanasonic, isWebOs } from "./browser_detection";
+import { isPanasonic, isPhilipsNetTv, isWebOs } from "./browser_detection";
 
 /**
  * Returns `true` if a `MediaKeys` instance (the  `Encrypted Media Extension`
@@ -9,9 +9,11 @@ import { isPanasonic, isWebOs } from "./browser_detection";
  *   - (2022-11-21): WebOS (LG TVs), for some encrypted contents, just
  *     rebuffered indefinitely when loading a content already-loaded on the
  *     HTMLMediaElement.
+ *   - (2024-08-23): Seen on Philips 2024 and 2023 in:
+ *     https://github.com/canalplus/rx-player/issues/1464
  *
  * @returns {boolean}
  */
 export default function canReuseMediaKeys(): boolean {
-  return !isWebOs && !isPanasonic;
+  return !isWebOs && !isPhilipsNetTv && !isPanasonic;
 }

package/src/core/cmcd/cmcd_data_builder.ts

@@ -377,8 +377,8 @@ export default class CmcdDataBuilder {
       }
     };
 
-    addNumberProperty("br", "object");
     addNumberProperty("bl", "request");
+    addNumberProperty("br", "object");
     addBooleanProperty("bs", "status");
     addStringProperty("cid", "session");
     addNumberProperty("d", "object");

package/src/core/main/worker/worker_main.ts

@@ -744,6 +744,7 @@ function loadOrReloadPreparedContent(
           }
         }
 
+        contentTimeBoundariesObserver.onPeriodCleared(value.type, value.period);
         preparedContent.trackChoiceSetter.removeTrackSetter(value.period.id, value.type);
         sendMessage({
           type: WorkerMessageType.PeriodStreamCleared,

package/src/main_thread/api/public_api.ts

@@ -409,7 +409,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     // See: https://bugzilla.mozilla.org/show_bug.cgi?id=1194624
     videoElement.preload = "auto";
 
-    this.version = /* PLAYER_VERSION */ "4.2.0-dev.2024082600";
+    this.version = /* PLAYER_VERSION */ "4.2.0-dev.2024090300";
     this.log = log;
     this.state = "STOPPED";
     this.videoElement = videoElement;
@@ -3307,7 +3307,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     }
   }
 }
-Player.version = /* PLAYER_VERSION */ "4.2.0-dev.2024082600";
+Player.version = /* PLAYER_VERSION */ "4.2.0-dev.2024090300";
 
 /** Every events sent by the RxPlayer's public API. */
 interface IPublicAPIEvent {

package/src/manifest/classes/adaptation.ts

@@ -49,55 +49,55 @@ export default class Adaptation implements IAdaptationMetadata {
    */
   public manuallyAdded?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.representations
    */
   public readonly representations: Representation[];
   /**
-   * @see IRepresentationMetadata
+   * @see ITrackType
    */
   public readonly type: ITrackType;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isAudioDescription
    */
   public isAudioDescription?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isClosedCaption
    */
   public isClosedCaption?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isForcedSubtitles
    */
   public isForcedSubtitles?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isSignInterpreted
    */
   public isSignInterpreted?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isDub
    */
   public isDub?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.language
    */
   public language?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.normalizedLanguage
    */
   public normalizedLanguage?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationSupportStatus
    */
   public supportStatus: IAdaptationSupportStatus;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.isTrickModeTrack
    */
   public isTrickModeTrack?: boolean;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.label
    */
   public label?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IAdaptationMetadata.trickModeTracks
    */
   public readonly trickModeTracks?: Adaptation[];
 

package/src/manifest/classes/representation.ts

@@ -37,15 +37,15 @@ class Representation implements IRepresentationMetadata {
   /** ID uniquely identifying the Representation in its parent Adaptation. */
   public readonly id: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.uniqueId
    */
   public readonly uniqueId: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.bitrate
    */
   public bitrate: number;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.frameRate
    */
   public frameRate?: number;
   /**
@@ -65,39 +65,47 @@ class Representation implements IRepresentationMetadata {
    */
   public cdnMetadata: ICdnMetadata[] | null;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.isSpatialAudio
    */
   public isSpatialAudio?: boolean | undefined;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.codecs
    */
   public codecs: string[];
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.mimeType
    */
   public mimeType?: string;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.width
    */
   public width?: number;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.height
    */
   public height?: number;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.contentProtections
    */
   public contentProtections?: IContentProtections;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.hdrInfo
    */
   public hdrInfo?: IHDRInformation;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.decipherable
+   *
+   * Note that this property should __NEVER__ be updated directly on an
+   * instanciated `Representation`, you are supposed to rely on
+   * `Manifest` methods for this.
    */
   public decipherable?: boolean | undefined;
   /**
-   * @see IRepresentationMetadata
+   * @see IRepresentationMetadata.isSupported
+   *
+   * Note that this property should __NEVER__ be updated directly on an
+   * instanciated `Representation`, you are supposed to rely on
+   * `Manifest` methods for this.
    */
   public isSupported: boolean | undefined;
   /**

package/.vscode/settings.json

@@ -1,7 +0,0 @@
-{
-    "files.watcherExclude": {
-        "**/node_modules/**": true,
-        "**/dist/**": true,
-        "**/build/**": true
-    }
-}