rx-player 3.29.0-dev.2022110200 → 3.29.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "rx-player",
   "author": "Canal+",
-  "version": "3.29.0-dev.2022110200",
+  "version": "3.29.0",
   "description": "Canal+ HTML5 Video Player",
   "main": "./dist/rx-player.js",
   "keywords": [
@@ -81,34 +81,34 @@
     "rxjs": "7.5.7"
   },
   "devDependencies": {
-    "@babel/core": "7.19.6",
+    "@babel/core": "7.20.2",
     "@babel/plugin-transform-runtime": "7.19.6",
-    "@babel/preset-env": "7.19.4",
+    "@babel/preset-env": "7.20.2",
     "@babel/preset-react": "7.18.6",
-    "@types/chai": "4.3.3",
-    "@types/jest": "29.2.0",
+    "@types/chai": "4.3.4",
+    "@types/jest": "29.2.3",
     "@types/mocha": "10.0.0",
-    "@types/node": "18.11.8",
+    "@types/node": "18.11.9",
     "@types/sinon": "10.0.13",
-    "@typescript-eslint/eslint-plugin": "5.41.0",
-    "@typescript-eslint/eslint-plugin-tslint": "5.41.0",
-    "@typescript-eslint/parser": "5.41.0",
+    "@typescript-eslint/eslint-plugin": "5.43.0",
+    "@typescript-eslint/eslint-plugin-tslint": "5.43.0",
+    "@typescript-eslint/parser": "5.43.0",
     "arraybuffer-loader": "1.0.8",
-    "babel-loader": "9.0.0",
-    "chai": "4.3.6",
+    "babel-loader": "9.1.0",
+    "chai": "4.3.7",
     "cheerio": "1.0.0-rc.12",
-    "core-js": "3.26.0",
-    "esbuild": "0.15.12",
-    "eslint": "8.26.0",
+    "core-js": "3.26.1",
+    "esbuild": "0.15.14",
+    "eslint": "8.27.0",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jsdoc": "39.4.0",
+    "eslint-plugin-jsdoc": "39.6.2",
     "eslint-plugin-react": "7.31.10",
     "esm": "3.2.25",
     "express": "4.18.2",
     "highlight.js": "11.6.0",
     "html-entities": "2.3.3",
-    "jest": "29.2.2",
-    "jest-environment-jsdom": "29.2.2",
+    "jest": "29.3.1",
+    "jest-environment-jsdom": "29.3.1",
     "karma": "6.4.1",
     "karma-chrome-launcher": "3.1.1",
     "karma-firefox-launcher": "2.1.2",
@@ -123,13 +123,13 @@
     "regenerator-runtime": "0.13.10",
     "rimraf": "3.0.2",
     "semver": "7.3.8",
-    "sinon": "14.0.1",
+    "sinon": "14.0.2",
     "terser-webpack-plugin": "5.3.6",
     "ts-jest": "29.0.3",
     "ts-loader": "9.4.1",
     "tslint": "6.1.3",
-    "typescript": "4.8.4",
-    "webpack": "5.74.0",
+    "typescript": "4.9.3",
+    "webpack": "5.75.0",
     "webpack-bundle-analyzer": "4.7.0",
     "webpack-cli": "4.10.0"
   },

package/sonar-project.properties

@@ -1,7 +1,7 @@
 sonar.projectKey=rx-player
 sonar.organization=rx-player
 sonar.projectName=rx-player
-sonar.projectVersion=3.29.0-dev.2022110200
+sonar.projectVersion=3.29.0
 sonar.sources=./src,./demo,./tests
 sonar.exclusions=demo/full/bundle.js,demo/standalone/lib.js,demo/bundle.js
 sonar.host.url=https://sonarcloud.io

package/src/compat/browser_detection.ts

@@ -51,11 +51,21 @@ const isTizen : boolean = !isNode &&
                           /Tizen/.test(navigator.userAgent);
 
 const isWebOs : boolean = !isNode &&
-                          /Web0S/.test(navigator.userAgent);
-const isWebOs2021 : boolean = !isNode &&
-                              /WebOS.TV-2021/.test(navigator.userAgent);
-const isWebOs2022 : boolean = !isNode &&
-                              /WebOS.TV-2022/.test(navigator.userAgent);
+                          navigator.userAgent.indexOf("Web0S") >= 0;
+
+// Inspired form: http://webostv.developer.lge.com/discover/specifications/web-engine/
+// Note: even that page doesn't correspond to what we've actually seen in the
+// wild
+const isWebOs2021 : boolean = isWebOs &&
+                              (
+                                /[Ww]eb[O0]S.TV-2021/.test(navigator.userAgent) ||
+                                /[Cc]hr[o0]me\/79/.test(navigator.userAgent)
+                              );
+const isWebOs2022 : boolean = isWebOs &&
+                              (
+                                /[Ww]eb[O0]S.TV-2022/.test(navigator.userAgent) ||
+                                /[Cc]hr[o0]me\/87/.test(navigator.userAgent)
+                              );
 
 interface ISafariWindowObject extends Window {
   safari? : { pushNotification? : { toString() : string } };

package/src/core/api/public_api.ts

@@ -460,7 +460,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     // See: https://bugzilla.mozilla.org/show_bug.cgi?id=1194624
     videoElement.preload = "auto";
 
-    this.version = /* PLAYER_VERSION */"3.29.0-dev.2022110200";
+    this.version = /* PLAYER_VERSION */"3.29.0";
     this.log = log;
     this.state = "STOPPED";
     this.videoElement = videoElement;
@@ -3002,7 +3002,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     return activeRepresentations[currentPeriod.id];
   }
 }
-Player.version = /* PLAYER_VERSION */"3.29.0-dev.2022110200";
+Player.version = /* PLAYER_VERSION */"3.29.0";
 
 /** Every events sent by the RxPlayer's public API. */
 interface IPublicAPIEvent {

package/src/core/decrypt/content_decryptor.ts

@@ -487,10 +487,9 @@ export default class ContentDecryptor extends EventEmitter<IContentDecryptorEven
       .subscribe({
 
         next: (evt) : void => {
-          switch (evt.type) {
-            case "warning":
-              this.trigger("warning", evt.value);
-              return;
+          if (evt.type === "warning") {
+            this.trigger("warning", evt.value);
+            return;
           }
 
           const linkedKeys = getKeyIdsLinkedToSession(
@@ -853,20 +852,19 @@ function updateDecipherability(
     }
     const contentKIDs = representation.contentProtections.keyIds;
     if (contentKIDs !== undefined) {
-      for (let i = 0; i < contentKIDs.length; i++) {
-        const elt = contentKIDs[i];
-        for (let j = 0; j < blacklistedKeyIds.length; j++) {
-          if (areKeyIdsEqual(blacklistedKeyIds[j], elt.keyId)) {
+      for (const elt of contentKIDs) {
+        for (const blacklistedKeyId of blacklistedKeyIds) {
+          if (areKeyIdsEqual(blacklistedKeyId, elt.keyId)) {
             return false;
           }
         }
-        for (let j = 0; j < whitelistedKeyIds.length; j++) {
-          if (areKeyIdsEqual(whitelistedKeyIds[j], elt.keyId)) {
+        for (const whitelistedKeyId of whitelistedKeyIds) {
+          if (areKeyIdsEqual(whitelistedKeyId, elt.keyId)) {
             return true;
           }
         }
-        for (let j = 0; j < delistedKeyIds.length; j++) {
-          if (areKeyIdsEqual(delistedKeyIds[j], elt.keyId)) {
+        for (const delistedKeyId of delistedKeyIds) {
+          if (areKeyIdsEqual(delistedKeyId, elt.keyId)) {
             return undefined;
           }
         }
@@ -891,13 +889,13 @@ function blackListProtectionData(
       return false;
     }
     const segmentProtections = representation.contentProtections?.initData ?? [];
-    for (let i = 0; i < segmentProtections.length; i++) {
+    for (const protection of segmentProtections) {
       if (initData.type === undefined ||
-          segmentProtections[i].type === initData.type)
+          protection.type === initData.type)
       {
         const containedInitData = initData.values.getFormattedValues()
           .every(undecipherableVal => {
-            return segmentProtections[i].values.some(currVal => {
+            return protection.values.some(currVal => {
               return (undecipherableVal.systemId === undefined ||
                       currVal.systemId === undecipherableVal.systemId) &&
                       areArraysOfNumbersEqual(currVal.data,

package/src/core/fetchers/segment/prioritized_segment_fetcher.ts

@@ -53,11 +53,13 @@ export default function applyPrioritizerToSegmentFetcher<TSegmentDataType>(
      * @param {Object} content - content to request
      * @param {Number} priority - priority at which the content should be requested.
      * Lower number == higher priority.
+     * @param {Object} callbacks
+     * @param {Object} cancelSignal
      * @returns {Promise}
      */
     createRequest(
       content : ISegmentLoaderContent,
-      priority : number = 0,
+      priority : number,
       callbacks : IPrioritizedSegmentFetcherCallbacks<TSegmentDataType>,
       cancelSignal : CancellationSignal
     ) : Promise<void> {

package/src/core/init/load_on_media_source.ts

@@ -195,14 +195,12 @@ export default function createMediaSourceLoader(
                                                               streamObserver)
       .pipe(
         mergeMap((evt) => {
-          switch (evt.type) {
-            case "contentDurationUpdate":
-              log.debug("Init: Duration has to be updated.", evt.value);
-              mediaDurationUpdater.updateKnownDuration(evt.value);
-              return EMPTY;
-            default:
-              return observableOf(evt);
+          if (evt.type === "contentDurationUpdate") {
+            log.debug("Init: Duration has to be updated.", evt.value);
+            mediaDurationUpdater.updateKnownDuration(evt.value);
+            return EMPTY;
           }
+          return observableOf(evt);
         }));
 
    /**

package/src/core/stream/representation/force_garbage_collection.ts

@@ -59,7 +59,6 @@ export default async function forceGarbageCollection(
       await bufferingQueue.removeBuffer(start, end, cancellationSignal);
     }
   }
-  return;
 }
 
 /**
@@ -89,9 +88,7 @@ function selectGCedRanges(
   // current time and respect the gcGap
   for (let i = 0; i < outerRanges.length; i++) {
     const outerRange = outerRanges[i];
-    if (position - gcGap > outerRange.end) {
-      cleanedupRanges.push(outerRange);
-    } else if (position + gcGap < outerRange.start) {
+    if ((position - gcGap > outerRange.end) || (position + gcGap < outerRange.start)) {
       cleanedupRanges.push(outerRange);
     }
   }

package/src/experimental/tools/VideoThumbnailLoader/remove_buffer_around_time.ts

@@ -33,19 +33,20 @@ export default function removeBufferAroundTime(
   videoElement: HTMLMediaElement,
   sourceBuffer: AudioVideoSegmentBuffer,
   time: number,
-  margin: number = 10 * 60,
+  margin: number | undefined,
   cancelSignal: CancellationSignal
 ): Promise<unknown> {
+  const removalMargin = margin ?? 10 * 60;
   if (videoElement.buffered.length === 0) {
     return Promise.resolve();
   }
   const bufferRemovals = [];
-  if ((time - margin) > 0) {
+  if ((time - removalMargin) > 0) {
     bufferRemovals.push(
-      sourceBuffer.removeBuffer(0, time - margin, cancelSignal));
+      sourceBuffer.removeBuffer(0, time - removalMargin, cancelSignal));
   }
-  if ((time + margin) < videoElement.duration) {
-    bufferRemovals.push(sourceBuffer.removeBuffer(time + margin,
+  if ((time + removalMargin) < videoElement.duration) {
+    bufferRemovals.push(sourceBuffer.removeBuffer(time + removalMargin,
                                                   videoElement.duration,
                                                   cancelSignal));
   }

package/src/parsers/manifest/dash/wasm-parser/ts/generators/BaseURL.ts

@@ -31,10 +31,8 @@ export function generateBaseUrlAttrParser(
 )  : IAttributeParser {
   const textDecoder = new TextDecoder();
   return function onMPDAttribute(attr : number, ptr : number, len : number) {
-    switch (attr) {
-      case AttributeName.Text:
-        baseUrlAttrs.value = parseString(textDecoder, linearMemory.buffer, ptr, len);
-        break;
+    if (attr === AttributeName.Text) {
+      baseUrlAttrs.value = parseString(textDecoder, linearMemory.buffer, ptr, len);
     }
   };
 }