rx-player 3.28.0-dev.2022062300 → 3.28.0-dev.2022062700

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "rx-player",
   "author": "Canal+",
-  "version": "3.28.0-dev.2022062300",
+  "version": "3.28.0-dev.2022062700",
   "description": "Canal+ HTML5 Video Player",
   "main": "./dist/rx-player.js",
   "keywords": [
@@ -32,7 +32,7 @@
     "build:modular": "./scripts/build/generate_build.js",
     "build:report": "webpack --progress --config webpack.config.js --env production --env reportSize",
     "build:rxp:all": "npm run build && npm run build:min && npm run build:modular",
-    "build:watch": "webpack --progress --config webpack.config.js -w -env production",
+    "build:watch": "webpack --progress --config webpack.config.js -w --env production",
     "build:min:watch": "webpack --progress --config webpack.config.js -w --env production --env minify",
     "build:wasm:debug": "cd ./src/parsers/manifest/dash/wasm-parser && cargo build --target wasm32-unknown-unknown && cp target/wasm32-unknown-unknown/debug/mpd_node_parser.wasm ../../../../../dist/mpd-parser.wasm",
     "build:wasm:release": "cd ./src/parsers/manifest/dash/wasm-parser && cargo build --target wasm32-unknown-unknown --release && wasm-opt -O3 -o ../../../../../dist/mpd-parser.wasm target/wasm32-unknown-unknown/release/mpd_node_parser.wasm && cd ../../../../../ && npm run wasm-strip",

package/sonar-project.properties

@@ -1,7 +1,7 @@
 sonar.projectKey=rx-player
 sonar.organization=rx-player
 sonar.projectName=rx-player
-sonar.projectVersion=3.28.0-dev.2022062300
+sonar.projectVersion=3.28.0-dev.2022062700
 sonar.sources=./src,./demo,./tests
 sonar.exclusions=demo/full/bundle.js,demo/standalone/lib.js,demo/bundle.js
 sonar.host.url=https://sonarcloud.io

package/src/core/adaptive/adaptive_representation_selector.ts

@@ -268,14 +268,8 @@ function getEstimateReference(
      */
     const guessBasedChooser = new GuessBasedChooser(scoreCalculator, prevEstimate);
 
-    let lastPlaybackObservation : IRepresentationEstimatorPlaybackObservation;
-
     // get initial observation for initial estimate
-    const unregisterInitial = playbackObserver.listen(obs => {
-      lastPlaybackObservation = obs;
-    }, { includeLastObservation: true });
-    unregisterInitial(); // The initial is emitted synchronously, we can now remove it
-                         // TODO cleaner playbackObserver.getLast() or something?
+    let lastPlaybackObservation = playbackObserver.getReference().getValue();
 
     /** Reference through which estimates are emitted. */
     const innerEstimateRef = createSharedReference<IABREstimate>(getCurrentEstimate());

package/src/core/api/playback_observer.ts

@@ -14,25 +14,17 @@
  * limitations under the License.
  */
 
-import {
-  defer as observableDefer,
-  fromEvent as observableFromEvent,
-  interval as observableInterval,
-  map,
-  merge as observableMerge,
-  Observable,
-  share,
-  shareReplay,
-  skip,
-  startWith,
-} from "rxjs";
 import config from "../../config";
 import log from "../../log";
 import noop from "../../utils/noop";
 import objectAssign from "../../utils/object_assign";
 import { getRange } from "../../utils/ranges";
-import { CancellationSignal } from "../../utils/task_canceller";
-
+import createSharedReference, {
+  IReadOnlySharedReference,
+} from "../../utils/reference";
+import TaskCanceller, {
+  CancellationSignal,
+} from "../../utils/task_canceller";
 
 /**
  * HTMLMediaElement Events for which playback observations are calculated and
@@ -93,19 +85,23 @@ export default class PlaybackObserver {
   private _internalSeekingEventsIncomingCounter : number;
 
   /**
-   * Last playback observation made by the `PlaybackObserver`.
-   *
-   * `null` if no observation has been made yet.
+   * Stores the last playback observation produced by the `PlaybackObserver`.:
    */
-  private _lastObservation : IPlaybackObservation | null;
+  private _observationRef : IReadOnlySharedReference<IPlaybackObservation>;
 
   /**
-   * Lazily-created shared Observable that will emit playback observations.
-   * Set to `null` until the first time it is generated.
+   * `TaskCanceller` allowing to free all resources and stop producing playback
+   * observations.
    */
-  private _observation$ : Observable<IPlaybackObservation> | null;
+  private _canceller : TaskCanceller;
 
   /**
+   * Create a new `PlaybackObserver`, which allows to produce new "playback
+   * observations" on various media events and intervals.
+   *
+   * Note that creating a `PlaybackObserver` lead to the usage of resources,
+   * such as event listeners which will only be freed once the `stop` method is
+   * called.
    * @param {HTMLMediaElement} mediaElement
    * @param {Object} options
    */
@@ -114,8 +110,22 @@ export default class PlaybackObserver {
     this._mediaElement = mediaElement;
     this._withMediaSource = options.withMediaSource;
     this._lowLatencyMode = options.lowLatencyMode;
-    this._lastObservation = null;
-    this._observation$ = null;
+    this._canceller = new TaskCanceller();
+    this._observationRef = this._createSharedReference();
+  }
+
+  /**
+   * Stop the `PlaybackObserver` from emitting playback observations and free all
+   * resources reserved to emitting them such as event listeners, intervals and
+   * subscribing callbacks.
+   *
+   * Once `stop` is called, no new playback observation will ever be emitted.
+   *
+   * Note that it is important to call stop once the `PlaybackObserver` is no
+   * more needed to avoid unnecessarily leaking resources.
+   */
+  public stop() {
+    this._canceller.cancel();
   }
 
   /**
@@ -162,29 +172,17 @@ export default class PlaybackObserver {
   }
 
   /**
-   * Returns an Observable regularly emitting playback observation, optionally
-   * starting with the last one.
+   * Returns an `IReadOnlySharedReference` storing the last playback observation
+   * produced by the `PlaybackObserver` and updated each time a new one is
+   * produced.
    *
-   * Note that this Observable is shared and unique, so that multiple `observe`
-   * call will return the exact same Observable and multiple concurrent
-   * `subscribe` will receive the same events at the same time.
-   * This was done for performance and simplicity reasons.
+   * This value can then be for example subscribed to to be notified of future
+   * playback observations.
    *
-   * @param {boolean} includeLastObservation
-   * @returns {Observable}
+   * @returns {Object}
    */
-  public observe(includeLastObservation : boolean) : Observable<IPlaybackObservation> {
-    return observableDefer(() : Observable<IPlaybackObservation> => {
-      if (this._observation$ === null || this._lastObservation === null) {
-        this._lastObservation = this._generateInitialObservation();
-        this._observation$ = this._createInnerObservable().pipe(share());
-        return this.observe(includeLastObservation);
-      } else {
-        return includeLastObservation ?
-          this._observation$.pipe(startWith(this._lastObservation)) :
-          this._observation$;
-      }
-    });
+  public getReference() : IReadOnlySharedReference<IPlaybackObservation> {
+    return this._observationRef;
   }
 
   /**
@@ -195,26 +193,19 @@ export default class PlaybackObserver {
    *     be first emitted synchronously.
    *   - `clearSignal`: If set, the callback will be unregistered when this
    *     CancellationSignal emits.
-   * @returns {Function} - Allows to easily unregister the callback
    */
   public listen(
     cb : (observation : IPlaybackObservation) => void,
     options? : { includeLastObservation? : boolean | undefined;
                  clearSignal? : CancellationSignal | undefined; }
-  ) : () => void {
-    if (options?.clearSignal?.isCancelled === true) {
+  ) {
+    if (this._canceller.isUsed || options?.clearSignal?.isCancelled === true) {
       return noop;
     }
-    const sub = this.observe(options?.includeLastObservation ?? false)
-      .subscribe(cb);
-    const unregister = options?.clearSignal?.register(() => {
-      sub.unsubscribe();
-    }) ?? noop;
-
-    return () => {
-      unregister();
-      sub.unsubscribe();
-    };
+    this._observationRef.onUpdate(cb, {
+      clearSignal: options?.clearSignal,
+      emitCurrentValue: options?.includeLastObservation,
+    });
   }
 
   /**
@@ -228,99 +219,122 @@ export default class PlaybackObserver {
    *
    * As argument, this method takes a function which will allow to produce
    * the new set of properties to be present on each observation.
-   * @param {Function} mapObservable
+   * @param {Function} transform
    * @returns {Object}
    */
   public deriveReadOnlyObserver<TDest>(
-    mapObservable : (
-      observation$ : Observable<IPlaybackObservation>
-    ) => Observable<TDest>
+    transform : (
+      observationRef : IReadOnlySharedReference<IPlaybackObservation>,
+      cancellationSignal : CancellationSignal
+    ) => IReadOnlySharedReference<TDest>
   ) : IReadOnlyPlaybackObserver<TDest> {
-    return generateReadOnlyObserver(this, mapObservable);
+    return generateReadOnlyObserver(this, transform, this._canceller.signal);
   }
 
   /**
-   * Creates the observable that will generate playback observations.
+   * Creates the `IReadOnlySharedReference` that will generate playback
+   * observations.
    * @returns {Observable}
    */
-  private _createInnerObservable() : Observable<IPlaybackObservation> {
-
-
-    return observableDefer(() : Observable<IPlaybackObservation> => {
-      const { SAMPLING_INTERVAL_MEDIASOURCE,
-              SAMPLING_INTERVAL_LOW_LATENCY,
-              SAMPLING_INTERVAL_NO_MEDIASOURCE } = config.getCurrent();
-      const getCurrentObservation = (
-        event : IPlaybackObserverEventType
-      ) : IPlaybackObservation => {
-        let tmpEvt: IPlaybackObserverEventType = event;
-        if (tmpEvt === "seeking" && this._internalSeekingEventsIncomingCounter > 0) {
-          tmpEvt = "internal-seeking";
-          this._internalSeekingEventsIncomingCounter -= 1;
-        }
-        const lastObservation = this._lastObservation ??
-                                this._generateInitialObservation();
-        const mediaTimings = getMediaInfos(this._mediaElement, tmpEvt);
-        const internalSeeking = mediaTimings.seeking &&
-          // We've just received the event for internally seeking
-          (tmpEvt === "internal-seeking" ||
-            // or We're still waiting on the previous internal-seek
-            (lastObservation.internalSeeking && tmpEvt !== "seeking"));
-        const rebufferingStatus = getRebufferingStatus(
-          lastObservation,
-          mediaTimings,
-          { lowLatencyMode: this._lowLatencyMode,
-            withMediaSource: this._withMediaSource });
-
-        const freezingStatus = getFreezingStatus(lastObservation, mediaTimings);
-        const timings = objectAssign(
-          {},
-          { rebuffering: rebufferingStatus,
-            freezing: freezingStatus,
-            internalSeeking },
-          mediaTimings);
-        if (log.hasLevel("DEBUG")) {
-          log.debug("API: current media element state tick",
-                    "event", timings.event,
-                    "position", timings.position,
-                    "seeking", timings.seeking,
-                    "internalSeeking", timings.internalSeeking,
-                    "rebuffering", timings.rebuffering !== null,
-                    "freezing", timings.freezing !== null,
-                    "ended", timings.ended,
-                    "paused", timings.paused,
-                    "playbackRate", timings.playbackRate,
-                    "readyState", timings.readyState);
-        }
-        return timings;
+  private _createSharedReference() : IReadOnlySharedReference<IPlaybackObservation> {
+    if (this._observationRef !== undefined) {
+      return this._observationRef;
+    }
+
+    let lastObservation : IPlaybackObservation | null;
+    const { SAMPLING_INTERVAL_MEDIASOURCE,
+            SAMPLING_INTERVAL_LOW_LATENCY,
+            SAMPLING_INTERVAL_NO_MEDIASOURCE } = config.getCurrent();
+
+    const getCurrentObservation = (
+      event : IPlaybackObserverEventType
+    ) : IPlaybackObservation => {
+      let tmpEvt: IPlaybackObserverEventType = event;
+      if (tmpEvt === "seeking" && this._internalSeekingEventsIncomingCounter > 0) {
+        tmpEvt = "internal-seeking";
+        this._internalSeekingEventsIncomingCounter -= 1;
+      }
+      const _lastObservation = lastObservation ?? this._generateInitialObservation();
+      const mediaTimings = getMediaInfos(this._mediaElement, tmpEvt);
+      const internalSeeking = mediaTimings.seeking &&
+        // We've just received the event for internally seeking
+        (tmpEvt === "internal-seeking" ||
+          // or We're still waiting on the previous internal-seek
+          (_lastObservation.internalSeeking && tmpEvt !== "seeking"));
+      const rebufferingStatus = getRebufferingStatus(
+        _lastObservation,
+        mediaTimings,
+        { lowLatencyMode: this._lowLatencyMode,
+          withMediaSource: this._withMediaSource });
+
+      const freezingStatus = getFreezingStatus(_lastObservation, mediaTimings);
+      const timings = objectAssign(
+        {},
+        { rebuffering: rebufferingStatus,
+          freezing: freezingStatus,
+          internalSeeking },
+        mediaTimings);
+      if (log.hasLevel("DEBUG")) {
+        log.debug("API: current media element state tick",
+                  "event", timings.event,
+                  "position", timings.position,
+                  "seeking", timings.seeking,
+                  "internalSeeking", timings.internalSeeking,
+                  "rebuffering", timings.rebuffering !== null,
+                  "freezing", timings.freezing !== null,
+                  "ended", timings.ended,
+                  "paused", timings.paused,
+                  "playbackRate", timings.playbackRate,
+                  "readyState", timings.readyState);
+      }
+      return timings;
+    };
+
+    const returnedSharedReference = createSharedReference(getCurrentObservation("init"));
+
+    const generateObservationForEvent = (event : IPlaybackObserverEventType) => {
+      const newObservation = getCurrentObservation(event);
+      if (log.hasLevel("DEBUG")) {
+        log.debug("API: current playback timeline:\n" +
+                  prettyPrintBuffered(newObservation.buffered,
+                                      newObservation.position),
+                  `\n${event}`);
+      }
+      lastObservation = newObservation;
+      returnedSharedReference.setValue(newObservation);
+    };
+
+    const interval = this._lowLatencyMode  ? SAMPLING_INTERVAL_LOW_LATENCY :
+                     this._withMediaSource ? SAMPLING_INTERVAL_MEDIASOURCE :
+                                             SAMPLING_INTERVAL_NO_MEDIASOURCE;
+    let intervalId = setInterval(onInterval, interval);
+    const removeEventListeners = SCANNED_MEDIA_ELEMENTS_EVENTS.map((eventName) => {
+      this._mediaElement.addEventListener(eventName, onMediaEvent);
+      function onMediaEvent() {
+        restartInterval();
+        generateObservationForEvent(eventName);
+      }
+      return () => {
+        this._mediaElement.removeEventListener(eventName, onMediaEvent);
       };
+    });
 
-      const eventObs : Array< Observable< IPlaybackObserverEventType > > =
-        SCANNED_MEDIA_ELEMENTS_EVENTS.map((eventName) =>
-          observableFromEvent(this._mediaElement, eventName)
-            .pipe(map(() => eventName)));
-
-      const interval = this._lowLatencyMode  ? SAMPLING_INTERVAL_LOW_LATENCY :
-                       this._withMediaSource ? SAMPLING_INTERVAL_MEDIASOURCE :
-                                               SAMPLING_INTERVAL_NO_MEDIASOURCE;
-
-      const interval$ : Observable<"timeupdate"> =
-        observableInterval(interval)
-          .pipe(map(() => "timeupdate"));
-
-      return observableMerge(interval$, ...eventObs).pipe(
-        map((event : IPlaybackObserverEventType) => {
-          const newObservation = getCurrentObservation(event);
-          if (log.hasLevel("DEBUG")) {
-            log.debug("API: current playback timeline:\n" +
-                      prettyPrintBuffered(newObservation.buffered,
-                                          newObservation.position),
-                      `\n${event}`);
-          }
-          this._lastObservation = newObservation;
-          return newObservation;
-        }));
+    this._canceller.signal.register(() => {
+      clearInterval(intervalId);
+      removeEventListeners.forEach(cb => cb());
+      returnedSharedReference.finish();
     });
+
+    return returnedSharedReference;
+
+    function onInterval() {
+      generateObservationForEvent("timeupdate");
+    }
+
+    function restartInterval() {
+      clearInterval(intervalId);
+      intervalId = setInterval(onInterval, interval);
+    }
   }
 
   private _generateInitialObservation() : IPlaybackObservation {
@@ -472,18 +486,16 @@ export interface IReadOnlyPlaybackObserver<TObservationType> {
    */
   getIsPaused() : boolean;
   /**
-   * Returns an Observable regularly emitting playback observation, optionally
-   * starting with the last one.
+   * Returns an `IReadOnlySharedReference` storing the last playback observation
+   * produced by the `IReadOnlyPlaybackObserver` and updated each time a new one
+   * is produced.
    *
-   * Note that this Observable is shared and unique, so that multiple `observe`
-   * call will return the exact same Observable and multiple concurrent
-   * `subscribe` will receive the same events at the same time.
-   * This was done for performance and simplicity reasons.
+   * This value can then be for example subscribed to to be notified of future
+   * playback observations.
    *
-   * @param {boolean} includeLastObservation
-   * @returns {Observable}
+   * @returns {Object}
    */
-  observe(includeLastObservation : boolean) : Observable<TObservationType>;
+  getReference() : IReadOnlySharedReference<TObservationType>;
   /**
    * Register a callback so it regularly receives playback observations.
    * @param {Function} cb
@@ -498,18 +510,20 @@ export interface IReadOnlyPlaybackObserver<TObservationType> {
     cb : (observation : TObservationType) => void,
     options? : { includeLastObservation? : boolean | undefined;
                  clearSignal? : CancellationSignal | undefined; }
-  ) : () => void;
+  ) : void;
   /**
    * Generate a new `IReadOnlyPlaybackObserver` from this one.
    *
    * As argument, this method takes a function which will allow to produce
    * the new set of properties to be present on each observation.
-   * @param {Function} mapObservable
+   * @param {Function} transform
    * @returns {Object}
    */
   deriveReadOnlyObserver<TDest>(
-    mapObservable : (observation$ : Observable<TObservationType>) => Observable<TDest>,
-    mapObservation : (observation : TObservationType) => TDest
+    transform : (
+      observationRef : IReadOnlySharedReference<TObservationType>,
+      cancellationSignal : CancellationSignal
+    ) => IReadOnlySharedReference<TDest>
   ) : IReadOnlyPlaybackObserver<TDest>;
 }
 
@@ -826,16 +840,18 @@ function prettyPrintBuffered(
  * Create `IReadOnlyPlaybackObserver` from a source `IReadOnlyPlaybackObserver`
  * and a mapping function.
  * @param {Object} src
- * @param {Function} mapObservable
+ * @param {Function} transform
  * @returns {Object}
  */
 function generateReadOnlyObserver<TSource, TDest>(
   src : IReadOnlyPlaybackObserver<TSource>,
-  mapObservable : (observation$ : Observable<TSource>) => Observable<TDest>
+  transform : (
+    observationRef : IReadOnlySharedReference<TSource>,
+    cancellationSignal : CancellationSignal
+  ) => IReadOnlySharedReference<TDest>,
+  cancellationSignal : CancellationSignal
 ) : IReadOnlyPlaybackObserver<TDest> {
-  const newObs = observableDefer(() =>
-    mapObservable(src.observe(true))
-  ).pipe(shareReplay({ bufferSize: 1, refCount: true }));
+  const mappedRef = transform(src.getReference(), cancellationSignal);
   return {
     getCurrentTime() {
       return src.getCurrentTime();
@@ -846,33 +862,29 @@ function generateReadOnlyObserver<TSource, TDest>(
     getIsPaused() {
       return src.getIsPaused();
     },
-    observe(includeLastObservation : boolean) : Observable<TDest> {
-      return includeLastObservation ? newObs :
-                                      newObs.pipe(skip(1));
+    getReference() : IReadOnlySharedReference<TDest> {
+      return mappedRef;
     },
     listen(
       cb : (observation : TDest) => void,
       options? : { includeLastObservation? : boolean | undefined;
                    clearSignal? : CancellationSignal | undefined; }
-    ) : () => void {
-      if (options?.clearSignal?.isCancelled === true) {
-        return noop;
+    ) : void {
+      if (cancellationSignal.isCancelled || options?.clearSignal?.isCancelled === true) {
+        return ;
       }
-      const obs = options?.includeLastObservation === true ? newObs :
-                                                             newObs.pipe(skip(1));
-      const sub = obs.subscribe(cb);
-      const unregister = options?.clearSignal?.register(() => {
-        sub.unsubscribe();
-      }) ?? noop;
-      return () => {
-        unregister();
-        sub.unsubscribe();
-      };
+      mappedRef.onUpdate(cb, {
+        clearSignal: options?.clearSignal,
+        emitCurrentValue: options?.includeLastObservation,
+      });
     },
     deriveReadOnlyObserver<TNext>(
-      newUdateObserver : (observation$ : Observable<TDest>) => Observable<TNext>
+      newTransformFn : (
+        observationRef : IReadOnlySharedReference<TDest>,
+        signal : CancellationSignal
+      ) => IReadOnlySharedReference<TNext>
     ) : IReadOnlyPlaybackObserver<TNext> {
-      return generateReadOnlyObserver(this, newUdateObserver);
+      return generateReadOnlyObserver(this, newTransformFn, cancellationSignal);
     },
   };
 }

package/src/core/api/public_api.ts

@@ -170,7 +170,10 @@ class Player extends EventEmitter<IPublicAPIEvent> {
   /** Current version of the RxPlayer.  */
   public readonly version : string;
 
-  /** Media element attached to the RxPlayer.  */
+  /**
+   * Media element attached to the RxPlayer.
+   * Set to `null` when the RxPlayer is disposed.
+   */
   public videoElement : HTMLMediaElement|null; // null on dispose
 
   /** Logger the RxPlayer uses.  */
@@ -429,7 +432,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     // See: https://bugzilla.mozilla.org/show_bug.cgi?id=1194624
     videoElement.preload = "auto";
 
-    this.version = /* PLAYER_VERSION */"3.28.0-dev.2022062300";
+    this.version = /* PLAYER_VERSION */"3.28.0-dev.2022062700";
     this.log = log;
     this.state = "STOPPED";
     this.videoElement = videoElement;
@@ -720,6 +723,10 @@ class Player extends EventEmitter<IPublicAPIEvent> {
       lowLatencyMode,
     });
 
+    currentContentCanceller.signal.register(() => {
+      playbackObserver.stop();
+    });
+
     /** Emit playback events. */
     let playback$ : Connectable<IInitEvent>;
 
@@ -971,7 +978,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
             share());
 
     /** Emit when the media element emits a "seeking" event. */
-    const observation$ = playbackObserver.observe(true);
+    const observation$ = playbackObserver.getReference().asObservable();
 
     const stateChangingEvent$ = observation$.pipe(filter(o => {
       return o.event === "seeking" || o.event === "ended" ||
@@ -2325,8 +2332,10 @@ class Player extends EventEmitter<IPublicAPIEvent> {
 
     // DRM-related clean-up
     const freeUpContentLock = () => {
-      log.debug("Unlocking `contentLock`. Next content can begin.");
-      this._priv_contentLock.setValue(false);
+      if (this.videoElement !== null) { // If not disposed
+        log.debug("Unlocking `contentLock`. Next content can begin.");
+        this._priv_contentLock.setValue(false);
+      }
     };
 
     if (!isNullOrUndefined(this.videoElement)) {
@@ -2934,7 +2943,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     return activeRepresentations[currentPeriod.id];
   }
 }
-Player.version = /* PLAYER_VERSION */"3.28.0-dev.2022062300";
+Player.version = /* PLAYER_VERSION */"3.28.0-dev.2022062700";
 
 /** Every events sent by the RxPlayer's public API. */
 interface IPublicAPIEvent {

package/src/core/init/content_time_boundaries_observer.ts

@@ -73,7 +73,7 @@ export default function ContentTimeBoundariesObserver(
 
   // trigger warnings when the wanted time is before or after the manifest's
   // segments
-  const outOfManifest$ = playbackObserver.observe(true).pipe(
+  const outOfManifest$ = playbackObserver.getReference().asObservable().pipe(
     filterMap<IContentTimeObserverPlaybackObservation, IWarningEvent, null>((
       { position }
     ) => {