rx-player 3.26.2 → 3.26.3-dev.2022021400

package/src/core/api/public_api.ts

@@ -163,13 +163,13 @@ interface IPositionUpdateItem {
   /** Amount of buffer available for now in front of the current position, in seconds. */
   bufferGap : number;
   /** Current maximum seekable position. */
-  maximumBufferTime? : number;
-  wallClockTime? : number;
+  maximumBufferTime? : number | undefined;
+  wallClockTime? : number | undefined;
   /**
    * Only for live contents. Difference between the "live edge" and the current
    * position, in seconds.
    */
-  liveGap? : number;
+  liveGap? : number | undefined;
 }
 
 /** Payload emitted with a `bitrateEstimationChange` event. */
@@ -321,7 +321,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
      * URL of the Manifest (or just of the content for DirectFile contents)
      * currently being played.
      */
-    url? : string;
+    url : string | undefined;
 
     /** Subject allowing to stop playing that content. */
     stop$ : Subject<void>;
@@ -494,7 +494,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     // See: https://bugzilla.mozilla.org/show_bug.cgi?id=1194624
     videoElement.preload = "auto";
 
-    this.version = /* PLAYER_VERSION */"3.26.2";
+    this.version = /* PLAYER_VERSION */"3.26.3-dev.2022021400";
     this.log = log;
     this.state = "STOPPED";
     this.videoElement = videoElement;
@@ -2975,7 +2975,7 @@ class Player extends EventEmitter<IPublicAPIEvent> {
     return activeRepresentations[currentPeriod.id];
   }
 }
-Player.version = /* PLAYER_VERSION */"3.26.2";
+Player.version = /* PLAYER_VERSION */"3.26.3-dev.2022021400";
 
 export default Player;
 export { IStreamEventData };

package/src/core/api/track_choice_manager.ts

@@ -63,7 +63,7 @@ interface IVideoTrackPreferenceObject {
  */
 interface ITMAudioRepresentation { id : string|number;
                                    bitrate : number;
-                                   codec? : string; }
+                                   codec? : string | undefined; }
 
 /** Audio track returned by the TrackChoiceManager. */
 export interface ITMAudioTrack { language : string;
@@ -85,11 +85,11 @@ export interface ITMTextTrack { language : string;
  */
 interface ITMVideoRepresentation { id : string|number;
                                    bitrate : number;
-                                   width? : number;
-                                   height? : number;
-                                   codec? : string;
-                                   frameRate? : string;
-                                   hdrInfo?: IHDRInformation; }
+                                   width? : number | undefined;
+                                   height? : number | undefined;
+                                   codec? : string | undefined;
+                                   frameRate? : string | undefined;
+                                   hdrInfo?: IHDRInformation | undefined; }
 
 /** Video track returned by the TrackChoiceManager. */
 export interface ITMVideoTrack { id : number|string;
@@ -134,10 +134,11 @@ type INormalizedPreferredAudioTrack = null |
 
 /** Audio track preference when it is not set to `null`. */
 interface INormalizedPreferredAudioTrackObject {
-  normalized? : string;
-  audioDescription? : boolean;
+  normalized? : string | undefined;
+  audioDescription? : boolean | undefined;
   codec? : { all: boolean;
-             test: RegExp; };
+             test: RegExp; } |
+           undefined;
 }
 
 /** Text track preference once normalized by the TrackChoiceManager. */

package/src/core/eme/__tests__/__global__/utils.ts

@@ -44,20 +44,15 @@ import {
 
 /** Default MediaKeySystemAccess configuration used by the RxPlayer. */
 export const defaultKSConfig = [{
-  audioCapabilities: [ { contentType: "audio/mp4;codecs=\"mp4a.40.2\"",
-                         robustness: undefined },
-                       { contentType: "audio/webm;codecs=opus",
-                         robustness: undefined } ],
+  audioCapabilities: [ { contentType: "audio/mp4;codecs=\"mp4a.40.2\"" },
+                       { contentType: "audio/webm;codecs=opus" } ],
   distinctiveIdentifier: "optional" as const,
   initDataTypes: ["cenc"] as const,
   persistentState: "optional" as const,
   sessionTypes: ["temporary"] as const,
-  videoCapabilities: [ { contentType: "video/mp4;codecs=\"avc1.4d401e\"",
-                         robustness: undefined },
-                       { contentType: "video/mp4;codecs=\"avc1.42e01e\"",
-                         robustness: undefined },
-                       { contentType: "video/webm;codecs=\"vp8\"",
-                         robustness: undefined } ],
+  videoCapabilities: [ { contentType: "video/mp4;codecs=\"avc1.4d401e\"" },
+                       { contentType: "video/mp4;codecs=\"avc1.42e01e\"" },
+                       { contentType: "video/webm;codecs=\"vp8\"" } ],
 }];
 
 /** Default Widevine MediaKeySystemAccess configuration used by the RxPlayer. */

package/src/core/eme/find_key_system.ts

@@ -192,21 +192,23 @@ function buildKeySystemConfigurations(
   // More details here:
   // https://storage.googleapis.com/wvdocs/Chrome_EME_Changes_and_Best_Practices.pdf
   // https://www.w3.org/TR/encrypted-media/#get-supported-configuration-and-consent
+
   const videoCapabilities: IMediaCapability[] =
-    flatMap(videoRobustnesses,
-            robustness => [{ contentType: "video/mp4;codecs=\"avc1.4d401e\"",
-                             robustness },
-                           { contentType: "video/mp4;codecs=\"avc1.42e01e\"",
-                             robustness },
-                           { contentType: "video/webm;codecs=\"vp8\"",
-                             robustness } ]);
+    flatMap(audioRobustnesses, (robustness) =>
+      ["video/mp4;codecs=\"avc1.4d401e\"",
+       "video/mp4;codecs=\"avc1.42e01e\"",
+       "video/webm;codecs=\"vp8\""].map(contentType => {
+        return robustness !== undefined ? { contentType, robustness } :
+                                          { contentType };
+      }));
 
   const audioCapabilities: IMediaCapability[] =
-    flatMap(audioRobustnesses,
-            robustness => [{ contentType: "audio/mp4;codecs=\"mp4a.40.2\"",
-                             robustness },
-                           { contentType: "audio/webm;codecs=opus",
-                             robustness } ]);
+    flatMap(audioRobustnesses, (robustness) =>
+      ["audio/mp4;codecs=\"mp4a.40.2\"",
+       "audio/webm;codecs=opus"].map(contentType => {
+        return robustness !== undefined ? { contentType, robustness } :
+                                          { contentType };
+      }));
 
   // TODO Re-test with a set contentType but an undefined robustness on the
   // STBs on which this problem was found.

package/src/core/eme/types.ts

@@ -40,7 +40,7 @@ export interface IInitializationDataInfo {
    * `undefined` when not known (different from an empty array - which would
    * just mean that there's no key id involved).
    */
-  keyIds? : Uint8Array[];
+  keyIds? : Uint8Array[] | undefined;
   /** Every initialization data for that type. */
   values: Array<{
     /**
@@ -298,7 +298,7 @@ export interface IContentProtection {
    * `undefined` when not known (different from an empty array - which would
    * just mean that there's no key id involved).
    */
-  keyIds? : Uint8Array[];
+  keyIds? : Uint8Array[] | undefined;
   /** Every initialization data for that type. */
   values: Array<{
     /**

package/src/core/fetchers/manifest/manifest_fetcher.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import PPromise from "pinkie";
 import {
   Observable,
 } from "rxjs";
@@ -31,6 +30,7 @@ import {
   ITransportPipelines,
 } from "../../../transports";
 import assert from "../../../utils/assert";
+import PPromise from "../../../utils/promise";
 import TaskCanceller from "../../../utils/task_canceller";
 import errorSelector from "../utils/error_selector";
 import {
@@ -54,11 +54,11 @@ export interface IManifestFetcherParsedResult {
    * The time (`performance.now()`) at which the request was started (at which
    * the JavaScript call was done).
    */
-  sendingTime? : number;
+  sendingTime? : number | undefined;
   /** The time (`performance.now()`) at which the request was fully received. */
-  receivedTime? : number;
+  receivedTime? : number | undefined;
   /* The time taken to parse the Manifest through the corresponding parse function. */
-  parsingTime? : number;
+  parsingTime? : number | undefined;
 }
 
 /** Emitted when a fetching or parsing minor error happened. */
@@ -86,7 +86,7 @@ export interface IManifestFetcherParserOptions {
    * If set, offset to add to `performance.now()` to obtain the current
    * server's time.
    */
-  externalClockOffset? : number;
+  externalClockOffset? : number | undefined;
   /** The previous value of the Manifest (when updating). */
   previousManifest : Manifest | null;
   /**

package/src/core/fetchers/segment/segment_fetcher.ts

@@ -119,7 +119,8 @@ export default function createSegmentFetcher<TLoadedFormat, TSegmentDataType>(
       /**
        * If the request succeeded, set to the corresponding
        * `IChunkCompleteInformation` object.
-       * If the request failed or was cancelled, set to `null`.
+       * For any other completion cases: if the request either failed, was
+       * cancelled or just if no request was needed, set to `null`.
        *
        * Stays to `undefined` when the request is still pending.
        */
@@ -216,6 +217,8 @@ export default function createSegmentFetcher<TLoadedFormat, TSegmentDataType>(
           if (res.resultType !== "segment-created") {
             requestInfo = res.resultData;
             sendNetworkMetricsIfAvailable();
+          } else {
+            requestInfo = null;
           }
 
           if (!canceller.isUsed) {
@@ -439,8 +442,8 @@ export function getSegmentFetcherOptions(
   bufferType : string,
   { maxRetryRegular,
     maxRetryOffline,
-    lowLatencyMode } : { maxRetryRegular? : number;
-                         maxRetryOffline? : number;
+    lowLatencyMode } : { maxRetryRegular? : number | undefined;
+                         maxRetryOffline? : number | undefined;
                          lowLatencyMode : boolean; }
 ) : ISegmentFetcherOptions {
   return { maxRetryRegular: bufferType === "image" ? 0 :

package/src/core/fetchers/utils/try_urls_with_backoff.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import PPromise from "pinkie";
 import { isOffline } from "../../../compat";
 import {
   CustomLoaderError,
@@ -25,6 +24,7 @@ import {
 import log from "../../../log";
 import cancellableSleep from "../../../utils/cancellable_sleep";
 import getFuzzedDelay from "../../../utils/get_fuzzed_delay";
+import PPromise from "../../../utils/promise";
 import TaskCanceller, {
   CancellationSignal,
 } from "../../../utils/task_canceller";

package/src/core/init/initialize_directfile.ts

@@ -100,8 +100,8 @@ export interface IDirectFileOptions { autoPlay : boolean;
                                       mediaElement : HTMLMediaElement;
                                       playbackObserver : PlaybackObserver;
                                       speed : IReadOnlySharedReference<number>;
-                                      startAt? : IInitialTimeOptions;
-                                      url? : string; }
+                                      startAt? : IInitialTimeOptions | undefined;
+                                      url? : string | undefined; }
 
 /**
  * Launch a content in "Directfile mode".

package/src/core/init/initialize_media_source.ts

@@ -127,7 +127,7 @@ export interface IInitializeArguments {
   /** Emit the playback rate (speed) set by the user. */
   speed : IReadOnlySharedReference<number>;
   /** The configured starting position. */
-  startAt? : IInitialTimeOptions;
+  startAt? : IInitialTimeOptions | undefined;
   /** Configuration specific to the text track. */
   textTrackOptions : ITextTrackSegmentBufferOptions;
 }
@@ -237,7 +237,7 @@ export default function InitializeOnMediaSource(
          * ID identifying the current MediaKeys' system ID. Can be used to only
          * send initialization data linked to that ID as an optimization measure.
          */
-        drmSystemId? : string;
+        drmSystemId? : string | undefined;
       },
       evt : IEMEManagerEvent | IEMEDisabledEvent
     ) => {

package/src/core/init/manifest_update_scheduler.ts

@@ -48,9 +48,9 @@ export interface IManifestUpdateSchedulerArguments {
   manifestFetcher : ManifestFetcher;
   /** Information about the initial load of the manifest */
   initialManifest : { manifest : Manifest;
-                      sendingTime? : number;
-                      receivedTime? : number;
-                      parsingTime? : number; };
+                      sendingTime? : number | undefined;
+                      receivedTime? : number | undefined;
+                      parsingTime? : number | undefined; };
   /** Minimum interval to keep between Manifest updates */
   minimumManifestUpdateInterval : number;
   /** Allows the rest of the code to ask for a Manifest refresh */
@@ -74,7 +74,7 @@ export interface IManifestRefreshSchedulerEvent {
    * Optional wanted refresh delay, which is the minimum time you want to wait
    * before updating the Manifest
    */
-  delay? : number;
+  delay? : number | undefined;
   /**
    * Whether the parsing can be done in the more efficient "unsafeMode".
    * This mode is extremely fast but can lead to de-synchronisation with the
@@ -127,9 +127,9 @@ export default function manifestUpdateScheduler({
    * encountered.
    */
   function handleManifestRefresh$(
-    { sendingTime, parsingTime, updatingTime } : { sendingTime?: number;
-                                                   parsingTime? : number;
-                                                   updatingTime? : number; }
+    { sendingTime, parsingTime, updatingTime } : { sendingTime?: number | undefined;
+                                                   parsingTime? : number | undefined;
+                                                   updatingTime? : number | undefined; }
   ) : Observable<IWarningEvent> {
     /**
      * Total time taken to fully update the last Manifest, in milliseconds.

package/src/core/init/stream_events_emitter/are_same_stream_events.ts

@@ -28,12 +28,12 @@
  * @param {Object} evt2
  * @returns {Boolean}
  */
-function areSameStreamEvents(evt1: { id?: string;
+function areSameStreamEvents(evt1: { id?: string | undefined;
                                      start: number;
-                                     end?: number; },
-                             evt2: { id?: string;
+                                     end?: number | undefined; },
+                             evt2: { id?: string | undefined;
                                      start: number;
-                                     end?: number; }): boolean {
+                                     end?: number | undefined; }): boolean {
   return evt1.id === evt2.id &&
          evt1.start === evt2.start &&
          evt1.end === evt2.end;

package/src/core/init/stream_events_emitter/types.ts

@@ -22,7 +22,7 @@ export interface IStreamEventData {
 }
 
 export interface IStreamEventPayload {
-  id?: string;
+  id?: string | undefined;
   start: number;
   end: number;
   data: IStreamEventData;
@@ -30,7 +30,7 @@ export interface IStreamEventPayload {
 }
 
 export interface INonFiniteStreamEventPayload {
-  id?: string;
+  id?: string | undefined;
   start: number;
   data: IStreamEventData;
   publicEvent: IPublicNonFiniteStreamEvent;

package/src/core/segment_buffers/implementations/text/html/html_text_segment_buffer.ts

@@ -445,11 +445,11 @@ export interface INativeTextTracksBufferSegmentData {
    * This is mostly needed for "sami" subtitles, to know which cues can / should
    * be parsed.
    */
-  language? : string;
+  language? : string | undefined;
   /** start time from which the segment apply, in seconds. */
-  start? : number;
+  start? : number | undefined;
   /** end time until which the segment apply, in seconds. */
-  end? : number;
+  end? : number | undefined;
 }
 
 /**

package/src/core/segment_buffers/implementations/text/html/text_track_cues_store.ts

@@ -63,8 +63,8 @@ export default class TextTrackCuesStore {
 
     // begins at the end as most of the time the player will ask for the last
     // CuesGroup
-    for (let i = cuesBuffer.length - 1; i >= 0; i--) {
-      const segment = cuesBuffer[i];
+    for (let cueIdx = cuesBuffer.length - 1; cueIdx >= 0; cueIdx--) {
+      const segment = cuesBuffer[cueIdx];
       if (time < segment.end && time >= segment.start) {
         const cues = segment.cues;
         for (let j = 0; j < cues.length; j++) {
@@ -92,10 +92,10 @@ export default class TextTrackCuesStore {
 
     const to = Math.max(from, _to);
     const cuesBuffer = this._cuesBuffer;
-    for (let i = 0; i < cuesBuffer.length; i++) {
-      if (cuesBuffer[i].end > from) {
+    for (let cueIdx = 0; cueIdx < cuesBuffer.length; cueIdx++) {
+      if (cuesBuffer[cueIdx].end > from) {
         // this cuesInfos is concerned by the remove
-        const startCuesInfos = cuesBuffer[i];
+        const startCuesInfos = cuesBuffer[cueIdx];
         if (startCuesInfos.start >= to) {
           // our cuesInfos is strictly after this interval, we have nothing to do
           return;
@@ -112,8 +112,8 @@ export default class TextTrackCuesStore {
                     cuesInfos2 ] = removeCuesInfosBetween(startCuesInfos,
                                                           from,
                                                           to);
-            this._cuesBuffer[i] = cuesInfos1;
-            cuesBuffer.splice(i + 1, 0, cuesInfos2);
+            this._cuesBuffer[cueIdx] = cuesInfos1;
+            cuesBuffer.splice(cueIdx + 1, 0, cuesInfos2);
           }
           // No cuesInfos can be concerned after this one, we can quit
           return;
@@ -122,8 +122,8 @@ export default class TextTrackCuesStore {
         // Else remove all part after `from`
         if (startCuesInfos.start >= from) {
           // all the segment is concerned
-          cuesBuffer.splice(i, 1);
-          i--; // one less element, we have to decrement the loop
+          cuesBuffer.splice(cueIdx, 1);
+          cueIdx--; // one less element, we have to decrement the loop
         } else {
           // only the end is concerned
           startCuesInfos.cues = getCuesBefore(startCuesInfos.cues, from);
@@ -207,8 +207,8 @@ export default class TextTrackCuesStore {
       }
     }
 
-    for (let i = 0; i < cuesBuffer.length; i++) {
-      let cuesInfos = cuesBuffer[i];
+    for (let cueIdx = 0; cueIdx < cuesBuffer.length; cueIdx++) {
+      let cuesInfos = cuesBuffer[cueIdx];
       if (start < cuesInfos.end) {
         if (areNearlyEqual(start, cuesInfos.start)) {
           if (areNearlyEqual(end, cuesInfos.end)) {
@@ -218,7 +218,7 @@ export default class TextTrackCuesStore {
             //   Result:          |AAAAA|
             // Which means:
             //   1. replace the current cue with ours
-            cuesBuffer[i] = cuesInfosToInsert;
+            cuesBuffer[cueIdx] = cuesInfosToInsert;
             return;
           } else if (end < cuesInfos.end) {
             // our cue overlaps with the current one:
@@ -231,7 +231,7 @@ export default class TextTrackCuesStore {
             //   3. add ours before the current one
             cuesInfos.cues = getCuesAfter(cuesInfos.cues, end);
             cuesInfos.start = end;
-            cuesBuffer.splice(i, 0, cuesInfosToInsert);
+            cuesBuffer.splice(cueIdx, 0, cuesInfosToInsert);
             return;
           }
 
@@ -242,10 +242,10 @@ export default class TextTrackCuesStore {
           // Here we have to delete any cuesInfos which end before ours end,
           // and see about the following one.
           do {
-            cuesBuffer.splice(i, 1);
-            cuesInfos = cuesBuffer[i];
+            cuesBuffer.splice(cueIdx, 1);
+            cuesInfos = cuesBuffer[cueIdx];
           } while (cuesInfos !== undefined && end > cuesInfos.end);
-          onIndexOfNextCueFound(i);
+          onIndexOfNextCueFound(cueIdx);
           return;
         } else if (start < cuesInfos.start) {
           if (end < cuesInfos.start) {
@@ -255,7 +255,7 @@ export default class TextTrackCuesStore {
             //   Result:          |AAAAAAA| |BBBB|
             // Which means:
             //   - add ours before the current one
-            cuesBuffer.splice(i, 0, cuesInfosToInsert);
+            cuesBuffer.splice(cueIdx, 0, cuesInfosToInsert);
             return;
           } else if (areNearlyEqual(end, cuesInfos.start)) {
             // our cue goes just before the current one:
@@ -266,14 +266,14 @@ export default class TextTrackCuesStore {
             //   - update start time of the current one to be sure
             //   - add ours before the current one
             cuesInfos.start = end;
-            cuesBuffer.splice(i, 0, cuesInfosToInsert);
+            cuesBuffer.splice(cueIdx, 0, cuesInfosToInsert);
             return;
           } else if (areNearlyEqual(end, cuesInfos.end)) {
             //   ours:            |AAAAAAA|
             //   the current one:    |BBBB|
             //   Result:          |AAAAAAA|
             // Replace
-            cuesBuffer.splice(i, 1, cuesInfosToInsert);
+            cuesBuffer.splice(cueIdx, 1, cuesInfosToInsert);
             return;
           } else if (end < cuesInfos.end) {
             //   ours:            |AAAAAAA|
@@ -281,7 +281,7 @@ export default class TextTrackCuesStore {
             //   Result:          |AAAAAAABB|
             cuesInfos.cues = getCuesAfter(cuesInfos.cues, end);
             cuesInfos.start = end;
-            cuesBuffer.splice(i, 0, cuesInfosToInsert);
+            cuesBuffer.splice(cueIdx, 0, cuesInfosToInsert);
             return;
           }
 
@@ -289,10 +289,10 @@ export default class TextTrackCuesStore {
           //   the current one:   |BBB|...
           //   Result:          |AAAAAAA|...
           do {
-            cuesBuffer.splice(i, 1);
-            cuesInfos = cuesBuffer[i];
+            cuesBuffer.splice(cueIdx, 1);
+            cuesInfos = cuesBuffer[cueIdx];
           } while (cuesInfos !== undefined && end > cuesInfos.end);
-          onIndexOfNextCueFound(i);
+          onIndexOfNextCueFound(cueIdx);
           return;
         }
         // else -> start > cuesInfos.start
@@ -303,7 +303,7 @@ export default class TextTrackCuesStore {
           //   Result:          |BBAAAAAA|
           cuesInfos.cues = getCuesBefore(cuesInfos.cues, start);
           cuesInfos.end = start;
-          cuesBuffer.splice(i + 1, 0, cuesInfosToInsert);
+          cuesBuffer.splice(cueIdx + 1, 0, cuesInfosToInsert);
           return;
         } else if (cuesInfos.end > end) {
           //   ours:              |AAAAAA|
@@ -311,9 +311,9 @@ export default class TextTrackCuesStore {
           //   Result:          |BBAAAAAABBB|
           const [ cuesInfos1,
                   cuesInfos2 ] = removeCuesInfosBetween(cuesInfos, start, end);
-          this._cuesBuffer[i] = cuesInfos1;
-          cuesBuffer.splice(i + 1, 0, cuesInfosToInsert);
-          cuesBuffer.splice(i + 2, 0, cuesInfos2);
+          this._cuesBuffer[cueIdx] = cuesInfos1;
+          cuesBuffer.splice(cueIdx + 1, 0, cuesInfosToInsert);
+          cuesBuffer.splice(cueIdx + 2, 0, cuesInfos2);
           return;
         } else {
           //   ours:              |AAAAAA|
@@ -322,12 +322,13 @@ export default class TextTrackCuesStore {
           cuesInfos.cues = getCuesBefore(cuesInfos.cues, start);
           cuesInfos.end = start;
 
-          cuesInfos = cuesBuffer[i + 1];
+          const nextCueIdx = cueIdx + 1;
+          cuesInfos = cuesBuffer[nextCueIdx];
           while (cuesInfos !== undefined && end > cuesInfos.end) {
-            cuesBuffer.splice(i, 1);
-            cuesInfos = cuesBuffer[i];
+            cuesBuffer.splice(nextCueIdx, 1);
+            cuesInfos = cuesBuffer[nextCueIdx];
           }
-          onIndexOfNextCueFound(i);
+          onIndexOfNextCueFound(nextCueIdx);
           return;
         }
       }

package/src/core/segment_buffers/implementations/text/native/native_text_segment_buffer.ts

@@ -45,7 +45,7 @@ export default class NativeTextSegmentBuffer extends SegmentBuffer {
 
   private readonly _videoElement : HTMLMediaElement;
   private readonly _track : ICompatTextTrack;
-  private readonly _trackElement? : HTMLTrackElement;
+  private readonly _trackElement : HTMLTrackElement | undefined;
 
   private _buffered : ManualTimeRanges;
 
@@ -268,11 +268,11 @@ export interface INativeTextTracksBufferSegmentData {
    * This is mostly needed for "sami" subtitles, to know which cues can / should
    * be parsed.
    */
-  language? : string;
+  language? : string | undefined;
   /** start time from which the segment apply, in seconds. */
-  start? : number;
+  start? : number | undefined;
   /** end time until which the segment apply, in seconds. */
-  end? : number;
+  end? : number | undefined;
 }
 
 /**

package/src/core/stream/representation/force_garbage_collection.ts

@@ -84,19 +84,17 @@ function selectGCedRanges(
 
   // start by trying to remove all ranges that do not contain the
   // current time and respect the gcGap
-  // respect the gcGap? FIXME?
   for (let i = 0; i < outerRanges.length; i++) {
     const outerRange = outerRanges[i];
-    if (position - gcGap < outerRange.end) {
+    if (position - gcGap > outerRange.end) {
       cleanedupRanges.push(outerRange);
-    }
-    else if (position + gcGap > outerRange.start) {
+    } else if (position + gcGap < outerRange.start) {
       cleanedupRanges.push(outerRange);
     }
   }
 
   // try to clean up some space in the current range
-  if (innerRange != null) {
+  if (innerRange !== null) {
     log.debug("Stream: GC removing part of inner range", cleanedupRanges);
     if (position - gcGap > innerRange.start) {
       cleanedupRanges.push({ start: innerRange.start,

package/src/errors/request_error.ts

@@ -50,7 +50,10 @@ export default class RequestError extends Error {
 
     this.name = "RequestError";
     this.url = url;
-    this.xhr = xhr;
+
+    if (xhr !== undefined) {
+      this.xhr = xhr;
+    }
     this.status = status;
     this.type = type;
     this.message = type;

package/src/experimental/tools/VideoThumbnailLoader/thumbnail_loader.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import pinkie from "pinkie";
 import {
   catchError,
   combineLatest,
@@ -36,6 +35,7 @@ import createSegmentFetcher, {
 import log from "../../../log";
 import { ISegment } from "../../../manifest";
 import objectAssign from "../../../utils/object_assign";
+import PPromise from "../../../utils/promise";
 import { freeRequest } from "./create_request";
 import getCompleteSegmentId from "./get_complete_segment_id";
 import getContentInfos from "./get_content_infos";
@@ -52,9 +52,6 @@ import {
 } from "./types";
 import VideoThumbnailLoaderError from "./video_thumbnail_loader_error";
 
-const PPromise = typeof Promise === "function" ? Promise :
-                                                 pinkie;
-
 const MIN_NEEDED_DATA_AFTER_TIME = 2;
 
 interface ITimeSettingTask { contentInfos: IContentInfos;
@@ -75,8 +72,8 @@ export default class VideoThumbnailLoader {
   private readonly _videoElement: HTMLVideoElement;
 
   private _player: Player;
-  private _currentTask?: ITimeSettingTask;
-  private _nextTaskSegmentsCompleteIds?: string[];
+  private _currentTask : ITimeSettingTask | undefined;
+  private _nextTaskSegmentsCompleteIds : string[] | undefined;
   constructor(videoElement: HTMLVideoElement,
               player: Player) {
     this._videoElement = videoElement;