rwsdk 1.2.12 → 1.2.13

package/dist/use-synced-state/__tests__/client-core.test.js

@@ -279,6 +279,30 @@ describe("client-core reconnection", () => {
             expect(sharedCallback).toHaveBeenCalledWith("disconnected");
             unsubB();
         });
+        it("duplicates active subscriptions on every reconnect", async () => {
+            const client = getSyncedStateClient(ENDPOINT);
+            const handler = vi.fn();
+            await client.subscribe("counter", handler);
+            expect(__testing.activeSubscriptions.size).toBe(1);
+            // First reconnect
+            mockClients[0].simulateBreak();
+            vi.runOnlyPendingTimers();
+            await __testing.warmUp(ENDPOINT);
+            await vi.runAllTimersAsync();
+            // Second reconnect
+            mockClients[1].simulateBreak();
+            vi.runOnlyPendingTimers();
+            await __testing.warmUp(ENDPOINT);
+            await vi.runAllTimersAsync();
+            // Third reconnect
+            mockClients[2].simulateBreak();
+            vi.runOnlyPendingTimers();
+            await __testing.warmUp(ENDPOINT);
+            await vi.runAllTimersAsync();
+            // Should remain exactly one subscription per logical subscription.
+            // Buggy implementation doubles the set on every reconnect.
+            expect(__testing.activeSubscriptions.size).toBe(1);
+        });
         it("BUG: reconnect emits 'connected' and resets backoff even when subscribe() rejects", async () => {
             const client = getSyncedStateClient(ENDPOINT);
             const handler = vi.fn();

package/dist/use-synced-state/client-core.js

@@ -35,6 +35,9 @@ function notifyStatusChange(endpoint, status) {
  * Returns an unsubscribe function.
  */
 export const onStatusChange = (endpoint, callback) => {
+    // Normalize the endpoint so listeners registered with a relative URL
+    // (e.g. "/__synced-state") are notified using the same key as the
+    // cached client and the reconnect path.
     const normalized = normalizeEndpoint(endpoint);
     let listeners = statusListeners.get(normalized);
     if (!listeners) {
@@ -164,25 +167,29 @@ export const getSyncedStateClient = (endpoint = DEFAULT_SYNCED_STATE_PATH) => {
         get(_target, prop) {
             if (prop === "subscribe") {
                 return async (key, handler) => {
-                    const subscription = {
-                        key,
-                        handler,
-                        client: wrappedClient,
-                    };
-                    activeSubscriptions.add(subscription);
+                    // Idempotent subscription registration. Reconnect mutates the
+                    // existing entry's client in place and then re-subscribes on the
+                    // new transport; without this guard we create duplicate registry
+                    // entries that double on every reconnect and leak component
+                    // closures after unmount.
+                    const exists = [...activeSubscriptions].some((s) => s.key === key && s.handler === handler && s.client === wrappedClient);
+                    if (!exists) {
+                        activeSubscriptions.add({ key, handler, client: wrappedClient });
+                    }
                     const base = await getBaseClient();
                     return base[prop](key, handler);
                 };
             }
             if (prop === "unsubscribe") {
                 return async (key, handler) => {
-                    // Find and remove the subscription
-                    for (const sub of activeSubscriptions) {
+                    // Remove every matching registry entry. The reconnect path can
+                    // create duplicates for the same (key, handler) pair, so a single
+                    // component unmount must clean up all of them.
+                    for (const sub of [...activeSubscriptions]) {
                         if (sub.key === key &&
                             sub.handler === handler &&
                             sub.client === wrappedClient) {
                             activeSubscriptions.delete(sub);
-                            break;
                         }
                     }
                     const base = await getBaseClient();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rwsdk",
-  "version": "1.2.12",
+  "version": "1.2.13",
   "description": "Build fast, server-driven webapps on Cloudflare with SSR, RSC, and realtime",
   "type": "module",
   "bin": {
@@ -219,7 +219,7 @@
     "semver": "~7.7.4",
     "tsx": "~4.21.0",
     "typescript": "~6.0.3",
-    "vite": "~7.3.2",
+    "vite": "~7.3.5",
     "vitest": "~4.1.5"
   }
 }