rwsdk 0.3.10 → 0.3.12

package/dist/vite/directiveModulesDevPlugin.mjs

@@ -14,7 +14,7 @@ export const generateVendorBarrelContent = (files, projectRootDir) => {
     const exports = "export default {\n" +
         [...files]
             .filter((file) => file.includes("node_modules"))
-            .map((file, i) => `  '${normalizeModulePath(file, projectRootDir).slice(1)}': M${i},`)
+            .map((file, i) => `  '${normalizeModulePath(file, projectRootDir)}': M${i},`)
             .join("\n") +
         "\n};";
     return `${imports}\n\n${exports}`;

package/dist/vite/directiveModulesDevPlugin.test.mjs

@@ -14,8 +14,8 @@ describe("directiveModulesDevPlugin helpers", () => {
 import * as M1 from '${projectRootDir}/node_modules/lib-b/component.tsx';
 
 export default {
-  'node_modules/lib-a/index.js': M0,
-  'node_modules/lib-b/component.tsx': M1,
+  '/node_modules/lib-a/index.js': M0,
+  '/node_modules/lib-b/component.tsx': M1,
 };`;
             expect(content).toEqual(expected);
         });

package/dist/vite/hasDirective.d.mts

@@ -1,7 +1,10 @@
 /**
  * Efficiently checks if a React directive (e.g., "use server", "use client")
- * is present in the code. Optimized for performance with a two-step approach:
- * 1. Quick string search to see if directive exists anywhere
- * 2. Line-by-line check only if the directive might be present
+ * is present in the code.
+ *
+ * This function is optimized for performance by only checking the first few
+ * lines of the code, as directives must appear at the very top of a file.
+ * It handles comments, whitespace, and any valid directive prologue
+ * (e.g., "use strict").
  */
 export declare function hasDirective(code: string, directive: string): boolean;

package/dist/vite/hasDirective.mjs

@@ -1,54 +1,70 @@
 /**
  * Efficiently checks if a React directive (e.g., "use server", "use client")
- * is present in the code. Optimized for performance with a two-step approach:
- * 1. Quick string search to see if directive exists anywhere
- * 2. Line-by-line check only if the directive might be present
+ * is present in the code.
+ *
+ * This function is optimized for performance by only checking the first few
+ * lines of the code, as directives must appear at the very top of a file.
+ * It handles comments, whitespace, and any valid directive prologue
+ * (e.g., "use strict").
  */
 export function hasDirective(code, directive) {
-    // Quick performance check: if directive doesn't exist anywhere, skip line checking
-    const singleQuoteDirective = `'${directive}'`;
-    const doubleQuoteDirective = `"${directive}"`;
-    if (!code.includes(singleQuoteDirective) &&
-        !code.includes(doubleQuoteDirective)) {
-        return false;
-    }
-    // Split into lines and check each one
-    const lines = code.split("\n");
+    const lines = code.slice(0, 512).split("\n"); // Check first ~512 chars
     let inMultiLineComment = false;
+    let foundUseClient = false;
+    let foundTargetDirective = false;
+    const doubleQuoteDirective = `"${directive}"`;
+    const singleQuoteDirective = `'${directive}'`;
+    const doubleQuoteUseClient = `"use client"`;
+    const singleQuoteUseClient = `'use client'`;
     for (const line of lines) {
         const trimmedLine = line.trim();
-        // Skip empty lines
         if (trimmedLine.length === 0) {
             continue;
         }
-        // Handle multi-line comments
-        if (trimmedLine.startsWith("/*")) {
-            inMultiLineComment = true;
-            // Check if the comment ends on the same line
+        if (inMultiLineComment) {
             if (trimmedLine.includes("*/")) {
                 inMultiLineComment = false;
             }
             continue;
         }
-        if (inMultiLineComment) {
-            // Check if this line ends the multi-line comment
-            if (trimmedLine.includes("*/")) {
-                inMultiLineComment = false;
+        if (trimmedLine.startsWith("/*")) {
+            if (!trimmedLine.includes("*/")) {
+                inMultiLineComment = true;
             }
             continue;
         }
-        // Skip single-line comments
         if (trimmedLine.startsWith("//")) {
             continue;
         }
-        // Check if this line starts with the directive
+        const cleanedLine = trimmedLine.endsWith(";")
+            ? trimmedLine.slice(0, -1)
+            : trimmedLine;
+        if (trimmedLine.startsWith(doubleQuoteUseClient) ||
+            trimmedLine.startsWith(singleQuoteUseClient)) {
+            foundUseClient = true;
+            if (directive === "use client") {
+                return true;
+            }
+        }
         if (trimmedLine.startsWith(doubleQuoteDirective) ||
             trimmedLine.startsWith(singleQuoteDirective)) {
-            return true;
+            foundTargetDirective = true;
+            if (directive !== "use server") {
+                return true;
+            }
         }
-        // If we hit a non-empty, non-comment line that's not a directive, we can stop
-        // (directives must be at the top of the file/scope, after comments)
+        // Any other string literal is part of a valid directive prologue.
+        // We can continue searching.
+        if (trimmedLine.startsWith('"') || trimmedLine.startsWith("'")) {
+            continue;
+        }
+        // If we encounter any other non-directive, non-comment, non-string-literal
+        // line of code, the directive prologue is over. Stop.
         break;
     }
-    return false;
+    // If looking for 'use server' and 'use client' was found, return false (client takes priority)
+    if (directive === "use server" && foundUseClient) {
+        return false;
+    }
+    return foundTargetDirective;
 }

package/dist/vite/hasDirective.test.mjs

@@ -1,109 +1,107 @@
 import { describe, it, expect } from "vitest";
 import { hasDirective } from "./hasDirective.mjs";
 describe("hasDirective", () => {
-    it('should find "use client" directive with double quotes', () => {
-        const code = `"use client";
-    
-    import React from "react";
-    
-    const MyComponent = () => <div>Hello</div>;
-    export default MyComponent;`;
+    it('should find "use client" directive', () => {
+        const code = `"use client"; import React from "react";`;
         expect(hasDirective(code, "use client")).toBe(true);
     });
-    it("should find 'use server' directive with single quotes", () => {
-        const code = `'use server';
-    
-    export async function myAction() {
-      // ...
-    }`;
+    it('should find "use server" directive', () => {
+        const code = `'use server'; export async function myAction() {}`;
         expect(hasDirective(code, "use server")).toBe(true);
     });
-    it("should find directive with leading whitespace", () => {
-        const code = `    "use client";
-    
-    const MyComponent = () => <div>Hello</div>;`;
+    it("should not find a directive that is not there", () => {
+        const code = `import React from "react";`;
+        expect(hasDirective(code, "use client")).toBe(false);
+    });
+    it('should find "use client" directive with single quotes', () => {
+        const code = `'use client'; import React from "react";`;
         expect(hasDirective(code, "use client")).toBe(true);
     });
-    it("should find directive after single-line comments", () => {
-        const code = `// This is a component
-    "use client";
-    
-    const MyComponent = () => <div>Hello</div>;`;
+    it("should find directive when preceded by comments and whitespace", () => {
+        const code = `
+      // This is a client component
+      /* And here is another comment */
+
+      "use client";
+      import React from 'react';
+      export default () => <div>Hello</div>;
+    `;
         expect(hasDirective(code, "use client")).toBe(true);
     });
-    it("should find directive after multi-line comments", () => {
-        const code = `/* This is a component */
-    "use client";
-    
-    const MyComponent = () => <div>Hello</div>;`;
+    it('should find "use client" directive when preceded by "use strict"', () => {
+        const code = `
+      "use strict";
+      "use client";
+      import React from 'react';
+      export default () => <div>Hello</div>;
+    `;
         expect(hasDirective(code, "use client")).toBe(true);
     });
-    it("should find directive after empty lines", () => {
+    it('should find "use server" directive when preceded by "use strict" and comments', () => {
         const code = `
-
-    "use client";
-    
-    const MyComponent = () => <div>Hello</div>;`;
+      // server stuff
+      "use strict";
+      /* another comment */
+      "use server";
+      export async function myAction() {}
+    `;
+        expect(hasDirective(code, "use server")).toBe(true);
+    });
+    it("should find directive when preceded by another string literal directive", () => {
+        const code = `
+      "use awesome"; // Some other directive
+      "use client";
+      import React from 'react';
+      export default () => <div>Hello</div>;
+    `;
         expect(hasDirective(code, "use client")).toBe(true);
     });
     it("should return false if no directive is present", () => {
         const code = `import React from "react";
-    
-    const MyComponent = () => <div>Hello</div>;`;
+    export default () => <div>Hello</div>;`;
         expect(hasDirective(code, "use client")).toBe(false);
     });
-    it("should return false if directive is not at the top", () => {
-        const code = `import React from "react";
-    "use client";
-    
-    const MyComponent = () => <div>Hello</div>;`;
-        expect(hasDirective(code, "use client")).toBe(false);
-    });
-    it("should return false if directive is inside a single-line comment", () => {
+    it("should return false if the directive is commented out", () => {
         const code = `// "use client";
-    
-    const MyComponent = () => <div>Hello</div>;`;
+    import React from "react";
+    export default () => <div>Hello</div>;`;
         expect(hasDirective(code, "use client")).toBe(false);
     });
-    it("should return false if directive is inside a multi-line comment", () => {
-        const code = `/*
-     * "use client";
-     */
-    
-    const MyComponent = () => <div>Hello</div>;`;
+    it("should return false if the directive appears after code", () => {
+        const code = `import React from "react";
+    "use client";
+    export default () => <div>Hello</div>;`;
         expect(hasDirective(code, "use client")).toBe(false);
     });
-    it("should return false if directive is a substring in other code", () => {
-        const code = `const message = 'please "use client" wisely';`;
+    it("should handle multi-line comments correctly", () => {
+        const code = `
+      /*
+       * "use client";
+       */
+      import React from "react";
+    `;
         expect(hasDirective(code, "use client")).toBe(false);
     });
-    it("should handle a file with only the directive", () => {
-        const code = `"use client"`;
+    it("should handle code with no whitespace", () => {
+        const code = `"use client";import React from "react";`;
         expect(hasDirective(code, "use client")).toBe(true);
     });
-    it("should handle mixed comments, whitespace, and the directive", () => {
-        const code = `// A component
-    
-    /* 
-      Another comment
-    */
-   
-    'use client';
-
-    const MyComponent = () => <div>Hello</div>;
-    `;
-        expect(hasDirective(code, "use client")).toBe(true);
+    it("should handle empty code", () => {
+        const code = "";
+        expect(hasDirective(code, "use client")).toBe(false);
     });
-    it("should handle multi-line comment ending on same line", () => {
-        const code = `/* "use client" */
-    const MyComponent = () => <div>Hello</div>;
-    `;
+    it("should handle code with only whitespace", () => {
+        const code = "  \n\t  ";
         expect(hasDirective(code, "use client")).toBe(false);
     });
-    it("should return false for code where directive appears after a valid line of code", () => {
-        const code = `const a = 1;
-    "use client";
-    `;
+    it("should handle files with only comments", () => {
+        const code = `// comment 1
+    /* comment 2 */`;
         expect(hasDirective(code, "use client")).toBe(false);
     });
+    it("should prioritize 'use client' over 'use server'", () => {
+        const code = `'use client';\n'use server';\nconsole.log('hello');`;
+        expect(hasDirective(code, "use client")).toBe(true);
+        expect(hasDirective(code, "use server")).toBe(false);
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rwsdk",
-  "version": "0.3.10",
+  "version": "0.3.12",
   "description": "Build fast, server-driven webapps on Cloudflare with SSR, RSC, and realtime",
   "type": "module",
   "bin": {