rvlib-shipkit 0.17.0 → 0.17.1

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.17.1
+
+- **Fixed: `shipkit ci`'s fix pass ignored `defaults: { 'imports:check': false }`** and rewrote every relative import anyway. Reported from a repo that deliberately keeps relative imports: one plain `shipkit ci` rewrote 215 files with no tsconfig paths wired, so typecheck and the tests went red on the gate's own repair. A fix slot repairs the same concern its floor task checks, so one disable governs both directions now.
+- **A disabled fixer says so.** The fix pass had no skipped-by-config vocabulary and printed `ok: fix pass clean` whether a slot was off or merely had nothing to do, so a cold agent read that as "imports are canonical here". Disabled slots print `skip: <id> (skipped-by-config …)`, the same line the task side already prints one row above.
+
 ## 0.17.0
 
 **Correction to 0.16.0.** Its notes and its `--frozen` flag description claimed some combination of flags made `shipkit ci` write nothing. None does: STATUS.md is refreshed on every run unless a caller passes `status: false`. If you wired `ci --no-fix --frozen` into CI expecting a read-only run, it leaves STATUS.md behind, and `--json` is the only output that writes nothing. 0.16.0 also flipped rule SK005 from warning to BLOCKING without saying so: a `link:` dependency that no longer resolves, or a declared dependency that is not installed, now fails the gate.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "rvlib-shipkit",
-    "version": "0.17.0",
+    "version": "0.17.1",
     "description": "All-in-one repo companion: ci gate (task DAG), auto-discovered health checks, release-contract fulfillness, asks queue, md-wiki tools, asset atelier, live tui",
     "license": "MIT",
     "type": "module",

package/src/core/run-fixers.ts

@@ -27,13 +27,21 @@ export type FixerResolution = {
     slots: FixerSlot[]
     /** slots nothing could fill, printed, never silent */
     unfilled: { id: string; reason: string }[]
+    /** slots the repo turned off, printed with the same vocabulary the task
+     *  side uses, so a disable is never invisible in the output */
+    disabled: { id: string; reason: string }[]
 }
 
+// a fix slot repairs the same concern a floor task checks, so ONE disable
+// governs both. Turning a check off and having the fixer rewrite the files
+// anyway is the config saying one thing and the tool doing another.
+const GOVERNED_BY: Record<string, string> = { 'imports:fix': 'imports:check' }
+
 // one fixer per mechanical concern. `fmt` accepts the two names the house
 // vocabulary allows so a repo that calls it `format` is not silently unfixed.
 const FMT_SCRIPTS = ['fmt', 'format'] as const
 
-export function resolveFixers(root: string): FixerResolution {
+export function resolveFixers(root: string, config?: RepoConfig): FixerResolution {
     const pkgPath = join(root, 'package.json')
     let scripts: Record<string, string> = {}
     if (existsSync(pkgPath)) {
@@ -42,19 +50,28 @@ export function resolveFixers(root: string): FixerResolution {
     }
     const slots: FixerSlot[] = []
     const unfilled: { id: string; reason: string }[] = []
+    const disabled: { id: string; reason: string }[] = []
+    const offByConfig = (id: string): boolean => {
+        const governing = GOVERNED_BY[id]
+        if (governing == null) return false
+        if (config?.defaults?.[governing] !== false) return false
+        disabled.push({ id, reason: `skipped-by-config (defaults: { '${governing}': false })` })
+        return true
+    }
 
     const fmtName = FMT_SCRIPTS.find((n) => scripts[n] != null)
     if (fmtName != null) slots.push({ id: 'fmt', cmd: ['bun', 'run', fmtName], source: 'package.json script' })
     else unfilled.push({ id: 'fmt', reason: `no 'fmt' or 'format' script — formatting stays a manual step` })
 
-    if (scripts['imports:fix'] != null) slots.push({ id: 'imports:fix', cmd: ['bun', 'run', 'imports:fix'], source: 'package.json script' })
+    if (offByConfig('imports:fix')) { /* the repo said no, in the one place that governs both directions */ }
+    else if (scripts['imports:fix'] != null) slots.push({ id: 'imports:fix', cmd: ['bun', 'run', 'imports:fix'], source: 'package.json script' })
     else {
         let cli: string | null = null
         try { cli = fileURLToPath(import.meta.resolve('rvlib-ts-tools/src/cli.ts')) } catch { cli = null }
         if (cli == null) unfilled.push({ id: 'imports:fix', reason: `no 'imports:fix' script and rvlib-ts-tools is unresolvable` })
         else slots.push({ id: 'imports:fix', cmd: ['bun', cli, 'imports', '--fix'], source: 'built-in (rvlib-ts-tools)' })
     }
-    return { slots, unfilled }
+    return { slots, unfilled, disabled }
 }
 
 /** worktree fingerprint: every dirty path mapped to `<status>:<content hash>`,
@@ -103,8 +120,9 @@ export async function runFixPass(root: string, config: RepoConfig, o: FixPassOpt
     // verify mode: same fixers, but rewriting anything means the COMMIT was
     // not clean, and the gate says so instead of quietly repairing it
     const verify = process.env.CI != null && process.env.CI !== ''
-    const { slots, unfilled } = resolveFixers(root)
+    const { slots, unfilled, disabled } = resolveFixers(root, config)
     for (const u of unfilled) o.print(`skip: ${u.id} (${u.reason})`)
+    for (const d of disabled) o.print(`skip: ${d.id} (${d.reason})`)
     const before = treeState(root)
 
     for (const s of slots) {