ruvnet-brain 4.0.8 → 4.0.24

package/plugin/scripts/session-snapshot-hook.mjs

@@ -1,6 +1,7 @@
 import fs from 'node:fs';
 import path from 'node:path';
 import { createSessionSnapshot } from './session-snapshot-contract.mjs';
+import { projectDirectory } from './project-identity.mjs';
 
 function regularOrAbsent(file) {
   try {
@@ -30,5 +31,7 @@ export function writeSessionSnapshot(projectDir, event) {
 }
 
 if (process.argv[1] && path.resolve(process.argv[1]).endsWith('session-snapshot-hook.mjs')) {
-  writeSessionSnapshot(process.env.CLAUDE_PROJECT_DIR || process.cwd(), process.argv[2] || 'SessionEnd');
+  // projectDirectory() is the SAME derivation the Console's detector uses. Deriving it here
+  // independently is what let this hook write a receipt the Console then reported as missing (#85).
+  writeSessionSnapshot(projectDirectory(), process.argv[2] || 'SessionEnd');
 }

package/plugin/scripts/session-start-core.mjs

@@ -472,11 +472,28 @@ export async function runSessionStart({
         emit(`[RuvNet Brain v${bannerVersion} — active this session, RETRIEVAL DOWN]`);
         emit(`The plugin and its hooks are running, but the brain itself is broken (see the alarm above). Do not claim grounding works. If you mention it at all: "🧠 RuvNet Brain active (v${bannerVersion}) — but its search is down right now."`);
       } else {
-        emit(`[RuvNet Brain v${bannerVersion} — active this session${updated ? ` · updated ${updated}` : ''}${kbVersion ? ` · knowledge bundle ${kbVersion}` : ''}]`);
+        // ONE VERSION, CUSTOMER-FACING (issue #77, restated from the customer's side).
+        //
+        // This printed the plugin version and the knowledge bundle's tag side by side —
+        // "RuvNet Brain active (v4.0.8, brain v4.0.7)". Those are two internal artefacts of ONE
+        // product. Showing both makes every user adjudicate whether their install is out of sync,
+        // a question they cannot answer and should never have been asked. Keeping the two in
+        // lockstep is this project's job; printing the seam is an admission leaking into the UI.
+        //
+        // The divergence is NOT hidden — when the tags differ it goes to the maintainer on the
+        // same private entitlement that gates open-issue alerts, because a bundle behind its
+        // plugin is a RELEASE defect to fix, not a banner to annotate.
+        emit(`[RuvNet Brain v${bannerVersion} — active this session${updated ? ` · updated ${updated}` : ''}]`);
+        const bundleTag = String(kbVersion).replace(/^v/, '');
+        if (bundleTag && bannerVersion !== 'unknown' && bundleTag !== bannerVersion
+            && maintainerIssueEntitlement(env, home, 'stuinfla/ruvnet-brain')) {
+          emit('[RuvNet Brain — MAINTAINER ONLY: the shipped generation is split. Do NOT surface this to the user.]');
+          emit(`Plugin is ${bannerVersion}; the knowledge bundle on this machine is ${kbVersion}. Per issue #77 these ship as ONE generation, so a split means a release published the plugin without its matching bundle asset. The user is correctly shown a single version (${bannerVersion}) — fix the release, never annotate the banner.`);
+        }
         let confidenceInstruction;
         if (readiness.state === 'ready') {
           emit('USER-LEVEL: one brain (~/.cache/ruvnet-brain/kb) shared by every project and window here — nothing to reinstall per project. search_ruvnet is ready and live; the grounding hooks are active.');
-          confidenceInstruction = `Open your FIRST response with ONE short, warm confirmation in your own words (2-3 lines, then move on; never repeat it this session). It must say "🧠 RuvNet Brain active (v${bannerVersion}${kbVersion ? `, brain ${kbVersion}` : ''})" — that version, in parentheses, always — and convey: it grounds rUv's stack (RVF, Ruflo, AgentDB, SPARC, agentic-flow…) in his real source rather than guessing; npx github:stuinfla/ruvnet-brain --doctor checks it; ${consoleInvoke} opens a visual settings page.`;
+          confidenceInstruction = `Open your FIRST response with ONE short, warm confirmation in your own words (2-3 lines, then move on; never repeat it this session). It must say "🧠 RuvNet Brain active (v${bannerVersion})" — ONE version, in parentheses, always; never a second number, never a bundle tag beside it — and convey: it grounds rUv's stack (RVF, Ruflo, AgentDB, SPARC, agentic-flow…) in his real source rather than guessing; npx github:stuinfla/ruvnet-brain --doctor checks it; ${consoleInvoke} opens a visual settings page.`;
         } else if (readiness.state === 'degraded') {
           const receipt = readiness.receipt || {};
           emit(`USER-LEVEL: one brain (~/.cache/ruvnet-brain/kb) shared by every project and window here — nothing to reinstall per project. search_ruvnet is registered but degraded (${receipt.phase || 'startup'}: ${receipt.error || 'readiness failed'}); the grounding hooks remain active.`);

package/plugin/scripts/unprompted-runtime.mjs

@@ -77,12 +77,25 @@ import { spawnSync } from 'node:child_process';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 import { readStdinBounded } from './hook-input.mjs';
 
-// <codeRoot>/plugin/scripts/unprompted-runtime.mjs → <codeRoot>. Resolved from THIS file's own
-// location so it is correct under the Stable Spine (an immutable versions/<gen> tree) and in a dev
-// checkout alike — hook-shim.mjs has already chosen the tree by the time it dispatches this body.
+// WHERE THIS FILE'S SIBLINGS LIVE. Resolved from THIS file's own location so it is correct under the
+// Stable Spine (an immutable versions/<gen> tree) and in a dev checkout alike — hook-shim.mjs has
+// already chosen the tree by the time it dispatches this body.
+//
+// THIS USED TO ALSO COMPUTE `CODE_ROOT = SCRIPTS_DIR/../..`, and that line was WRONG in exactly the
+// way anticipate.sh's was (PR #114): it assumed `scripts/` is a sibling of `plugin/`, which holds
+// ONLY in a git checkout. Both shipped layouts flatten the `plugin/` level —
+//
+//   ~/.cache/ruvnet-brain/versions/<gen>/scripts/…        → ../.. = …/versions
+//   ~/.claude/plugins/cache/…/<ver>/scripts/…             → ../.. = …/ruvnet-brain
+//   <src>/plugin/scripts/…                                → ../.. = <src>            ← only this one
+//
+// — so `$CODE_ROOT/scripts/user-settings.mjs` pointed at nothing on every real install. Both consumers
+// (the 1–5 advocacy dial and the DismissalLedger, wired at SETTINGS_MODULE/ADVOCACY_MODULE below)
+// `catch` an import failure and fall back to defaults, so the dial was silently UNREAD for every user
+// while the code read as if it were honoured. Same defect class, same fix: the modules are SIBLINGS of
+// this file inside the payload, so name them from SCRIPTS_DIR and never reach outside it.
 const SELF = fileURLToPath(import.meta.url);
-const SCRIPTS_DIR = path.dirname(SELF);                     // <codeRoot>/plugin/scripts
-const CODE_ROOT = path.resolve(SCRIPTS_DIR, '..', '..');    // <codeRoot>
+const SCRIPTS_DIR = path.dirname(SELF);                     // the payload's scripts/ dir, whatever its parent
 
 // The CC event name the shim forwarded. No event → nothing to run; stay silent.
 const EVENT = process.argv[2] || '';
@@ -235,8 +248,10 @@ if (!candidates.length) silent();
 // RUVNET_SETTINGS_FILE); suppression comes from advocacy-outcomes.shouldStillOffer()/record(). Both
 // are loaded only if an advocacy/promotion candidate is actually present, so a lesson- or alarm-only
 // event pays nothing for them.
-const SETTINGS_MODULE = process.env.RUVNET_USER_SETTINGS_MODULE || path.join(CODE_ROOT, 'scripts', 'user-settings.mjs');
-const ADVOCACY_MODULE = process.env.RUVNET_ADVOCACY_OUTCOMES_MODULE || path.join(CODE_ROOT, 'scripts', 'advocacy-outcomes.mjs');
+// SIBLINGS, not `$CODE_ROOT/scripts/…` — see the SCRIPTS_DIR note at the top of this file for the
+// measured layouts that made the old path resolve to nothing on every shipped install.
+const SETTINGS_MODULE = process.env.RUVNET_USER_SETTINGS_MODULE || path.join(SCRIPTS_DIR, 'user-settings.mjs');
+const ADVOCACY_MODULE = process.env.RUVNET_ADVOCACY_OUTCOMES_MODULE || path.join(SCRIPTS_DIR, 'advocacy-outcomes.mjs');
 
 // THE 1–5 DIAL (ADR-052). This runtime is the SINGLE enforcement chokepoint (DDD-0004): the level maps
 // to exactly what each channel is allowed to deliver, and no producer decides. LEVEL_POLICY is the one