runcloud 0.2.162 → 0.2.163

package/dist/commands/appStoreEvaluate.js

@@ -1,6 +1,8 @@
 import { existsSync, readFileSync, readdirSync, statSync, } from 'node:fs';
 import path from 'node:path';
 const PREVIEW_APP_ID = 'app.newly.preview';
+const SCAFFOLD_SCHEME = 'expobase';
+const INBOUND_LINK = /Linking\.createURL|makeRedirectUri|emailRedirectTo|\bredirectTo\s*:|expobase:\/\//;
 const PLACEHOLDER_COPY = /lorem ipsum|example\.com|\bTBD\b|\bTODO\b|\bplaceholder\b/i;
 const INPUT_PLACEHOLDER = /\bplaceholder\??\s*[=:]\s*(\{[^}]*\}|"[^"]*"|'[^']*'|`[^`]*`|[\w.$]+)/gi;
 const PLACEHOLDER_NAME = /\.placeholder\b|\bplaceholder\b(?=\s*[,})\]])/gi;
@@ -45,6 +47,9 @@ const LIVE_STORE_IDS = new Set([
     'apple_content_rights',
     'apple_age_rating',
     'apple_privacy_label',
+    'apple_review_notes',
+    'apple_review_contact',
+    'apple_review_recording',
     'apple_eu_trader_status',
     'google_play_title',
     'google_play_short_description',
@@ -87,6 +92,7 @@ const TEXT_EXTENSIONS = new Set([
     '.swift',
     '.ts',
     '.tsx',
+    '.xcprivacy',
     '.xml',
 ]);
 const SKIP_DIRS = new Set([
@@ -155,6 +161,8 @@ function activeItems(manifest) {
     return manifest.items.filter((item) => !item.deferred && item.resolvedBy !== 'card');
 }
 function evaluateLocalItem(root, appJson, item) {
+    if (item.id === 'scheme')
+        return evaluateScheme(root, appJson, item);
     const rule = CONFIG_RULES[item.id];
     if (rule)
         return evaluateConfigItem(appJson, item, rule);
@@ -201,7 +209,7 @@ function evaluateLocalItem(root, appJson, item) {
         case 'permission_descriptions':
             return evaluatePermissionDescriptions(root, appJson, item);
         case 'privacy_manifest':
-            return evaluatePrivacyManifest(root, item);
+            return evaluatePrivacyManifest(root, appJson, item);
         default:
             if (STORE_REMINDER_IDS.has(item.id)) {
                 return makeItem(item, 'info', 'Complete this declaration in Google Play Console.', 'Play Console questionnaire');
@@ -226,6 +234,14 @@ function evaluateConfigItem(appJson, item, rule) {
         return makeItem(item, 'pass', `${item.label} is set.`, evidence);
     return makeItem(item, rule.absent, `${item.label} is not set.`, evidence);
 }
+function evaluateScheme(root, appJson, item) {
+    const value = getPath(appJson, ['expo', 'scheme']);
+    const schemes = typeof value === 'string' ? [value] : arrayOfStrings(value);
+    const shared = schemes.includes(SCAFFOLD_SCHEME) ? scan(root, INBOUND_LINK, { dirs: ['app', 'src', 'components'] }) : [];
+    if (!shared.length)
+        return evaluateConfigItem(appJson, item, CONFIG_RULES['scheme']);
+    return makeItem(item, 'warning', `This app still uses the link name every new Newly app starts with (${SCAFFOLD_SCHEME}). A link back into the app, such as a sign-in email, can open another Newly-built app on the same phone. Give it its own scheme, and update any redirect address saved with your sign-in provider. The next preview then takes several minutes to rebuild.`, `app.json expo.scheme = ${JSON.stringify(value)}\n${evidence(shared)}`);
+}
 function evaluateEncryption(appJson, item) {
     const plist = getPath(appJson, ['expo', 'ios', 'infoPlist', 'ITSAppUsesNonExemptEncryption']);
     const config = getPath(appJson, ['expo', 'ios', 'config', 'usesNonExemptEncryption']);
@@ -289,16 +305,19 @@ function evaluatePermissionDescriptions(root, appJson, item) {
         return makeItem(item, 'pass', 'Used iOS capabilities have usage descriptions.', 'app.json ios.infoPlist cross-check');
     return makeItem(item, 'fail', 'Used iOS capability is missing an NS*UsageDescription.', missing.join('; '));
 }
-function evaluatePrivacyManifest(root, item) {
-    const hasManifest = findByName(root, 'PrivacyInfo.xcprivacy').length > 0;
-    const requiredReasonApi = scan(root, /NSUserDefaults|systemUptime|fileModificationDate|diskSpace|activeInputModes/i);
-    const tracking = scan(root, TRACKING_SDK);
-    if (hasManifest)
+function evaluatePrivacyManifest(root, appJson, item) {
+    if (findByName(root, 'PrivacyInfo.xcprivacy').length > 0)
         return makeItem(item, 'pass', 'PrivacyInfo.xcprivacy is present.', 'scan: PrivacyInfo.xcprivacy found');
-    if (tracking.length)
-        return makeItem(item, 'fail', 'Tracking SDK pattern found but no PrivacyInfo.xcprivacy file was found.', evidence(tracking));
-    if (requiredReasonApi.length)
-        return makeItem(item, 'warning', 'Required-reason API pattern found but no PrivacyInfo.xcprivacy file was found.', evidence(requiredReasonApi));
+    if (Object.keys(objectValue(getPath(appJson, ['expo', 'ios', 'privacyManifests']))).length > 0)
+        return makeItem(item, 'pass', 'app.json declares the privacy manifest.', 'app.json expo.ios.privacyManifests is set');
+    const tracking = scan(root, TRACKING_SDK);
+    if (tracking.length) {
+        return makeItem(item, 'warning', 'This app uses a tracking SDK and app.json declares no privacy manifest. Add expo.ios.privacyManifests with NSPrivacyTracking and the domains the SDK tracks through, so the manifest matches your App Privacy answers.', evidence(tracking));
+    }
+    const requiredReasonApi = scan(root, /NSUserDefaults|systemUptime|fileModificationDate|diskSpace|activeInputModes/i);
+    if (requiredReasonApi.length) {
+        return makeItem(item, 'warning', 'This code uses an API Apple wants a reason for, and app.json declares none. Add the reason under expo.ios.privacyManifests (NSPrivacyAccessedAPITypes).', evidence(requiredReasonApi));
+    }
     return makeItem(item, 'pass', 'No required-reason API patterns found and no tracking SDK patterns found.', 'scan: no required privacy manifest signals found');
 }
 function patternItem(root, item, regex, statusOnHit, messageOnHit, messageOnMiss, options = {}) {

package/dist/version.js

@@ -1 +1 @@
-export const CLI_VERSION = '0.2.162';
+export const CLI_VERSION = '0.2.163';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "runcloud",
-  "version": "0.2.162",
+  "version": "0.2.163",
   "description": "Create and control run.cloud remote mobile simulators and cloud sandboxes",
   "license": "Apache-2.0",
   "keywords": [