runcloud 0.2.155 → 0.2.156

package/dist/commands/appStoreEvaluate.js

@@ -1,6 +1,14 @@
 import { existsSync, readFileSync, readdirSync, statSync, } from 'node:fs';
 import path from 'node:path';
 const PREVIEW_APP_ID = 'app.newly.preview';
+const PLACEHOLDER_COPY = /lorem ipsum|example\.com|\bTBD\b|\bTODO\b|\bplaceholder\b/i;
+const INPUT_PLACEHOLDER = /\bplaceholder\??\s*[=:]\s*(\{[^}]*\}|"[^"]*"|'[^']*'|`[^`]*`|[\w.$]+)/gi;
+const PLACEHOLDER_NAME = /\.placeholder\b|\bplaceholder\b(?=\s*[,})\]])/gi;
+function withoutInputPlaceholders(line) {
+    return line
+        .replace(INPUT_PLACEHOLDER, (_prop, value) => (/^["'`]/.test(value) ? value.replace(/example\.com/gi, '') : ''))
+        .replace(PLACEHOLDER_NAME, '');
+}
 const CONFIG_RULES = {
     app_name: { path: ['expo', 'name'], absent: 'fail' },
     slug: { path: ['expo', 'slug'], absent: 'fail' },
@@ -157,7 +165,9 @@ function evaluateLocalItem(root, appJson, item) {
         case 'http_endpoints':
             return patternItem(root, item, /http:\/\/(?!localhost|127\.0\.0\.1)/i, 'warning', 'Non-local HTTP endpoint found.', 'No non-local HTTP endpoints found.');
         case 'placeholder_content':
-            return patternItem(root, item, /lorem ipsum|example\.com|\bTBD\b|\bTODO\b|Coming soon|placeholder/i, 'warning', 'Placeholder text found.', 'No placeholder text found.');
+            return patternItem(root, item, PLACEHOLDER_COPY, 'warning', 'Placeholder text found.', 'No placeholder text found.', {
+                filter: (match) => PLACEHOLDER_COPY.test(withoutInputPlaceholders(match.text)),
+            });
         case 'competitor_reference':
             return patternItem(root, item, /google play|\.apk\b|samsung|android app/i, 'warning', 'Possible platform/competitor reference found in user-facing copy.', 'No competitor platform references found.', { dirs: ['app', 'src', 'components'] });
         case 'private_api_usage':
@@ -180,7 +190,7 @@ function evaluateLocalItem(root, appJson, item) {
         case 'external_payment_digital':
             return evaluateExternalPayment(root, item);
         case 'expo_layout_missing':
-            return evaluateExpoLayout(root, item);
+            return makeItem(item, 'pass', 'Expo Router adds a layout where a directory has none.', 'expo-router getRoutesCore.js');
         case 'expo_duplicate_route':
             return evaluateDuplicateRoutes(root, item);
         case 'ios_encryption':
@@ -248,16 +258,6 @@ function evaluateExternalPayment(root, item) {
         return makeItem(item, 'pass', 'No external payment SDK patterns found.', 'scan: no Stripe/PayPal/Braintree patterns found');
     return makeItem(item, 'warning', 'External payment SDK found; verify it is not used for digital goods on iOS.', evidence(matches));
 }
-function evaluateExpoLayout(root, item) {
-    const appDir = path.join(root, 'app');
-    if (!existsSync(appDir))
-        return makeItem(item, 'pass', 'No Expo Router app directory found.', 'scan: app/ directory absent');
-    const dirs = walkDirs(appDir).map((dir) => path.relative(root, dir) || 'app');
-    const missing = dirs.filter((dir) => !hasLayoutFile(path.join(root, dir)));
-    if (!missing.length)
-        return makeItem(item, 'pass', 'Every app route directory has a layout file.', 'scan: app route directories');
-    return makeItem(item, 'fail', 'Expo Router directories without _layout files found.', missing.slice(0, 8).join(', '));
-}
 function evaluateDuplicateRoutes(root, item) {
     const appDir = routerDir(root);
     if (!existsSync(appDir))
@@ -516,17 +516,6 @@ function walkFiles(dir) {
     }
     return files;
 }
-function walkDirs(dir) {
-    const dirs = [dir];
-    for (const entry of safeReadDir(dir)) {
-        if (SKIP_DIRS.has(entry.name))
-            continue;
-        const full = path.join(dir, entry.name);
-        if (entry.isDirectory())
-            dirs.push(...walkDirs(full));
-    }
-    return dirs;
-}
 function shouldScanFile(file) {
     return TEXT_EXTENSIONS.has(path.extname(file));
 }
@@ -536,9 +525,6 @@ function findByName(root, name) {
 function sourceText(root, dirs) {
     return collectScanFiles(root, dirs).map((file) => readText(file) ?? '').join('\n');
 }
-function hasLayoutFile(dir) {
-    return ['_layout.tsx', '_layout.ts', '_layout.jsx', '_layout.js'].some((name) => existsSync(path.join(dir, name)));
-}
 function routerDir(root) {
     const src = path.join(root, 'src', 'app');
     return safeStat(src)?.isDirectory() ? src : path.join(root, 'app');

package/dist/version.js

@@ -1 +1 @@
-export const CLI_VERSION = '0.2.155';
+export const CLI_VERSION = '0.2.156';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "runcloud",
-  "version": "0.2.155",
+  "version": "0.2.156",
   "description": "Create and control run.cloud remote mobile simulators and cloud sandboxes",
   "license": "Apache-2.0",
   "keywords": [