runcloud 0.2.154 → 0.2.156

package/dist/commands/appStoreEvaluate.js

@@ -1,13 +1,21 @@
 import { existsSync, readFileSync, readdirSync, statSync, } from 'node:fs';
 import path from 'node:path';
+const PREVIEW_APP_ID = 'app.newly.preview';
+const PLACEHOLDER_COPY = /lorem ipsum|example\.com|\bTBD\b|\bTODO\b|\bplaceholder\b/i;
+const INPUT_PLACEHOLDER = /\bplaceholder\??\s*[=:]\s*(\{[^}]*\}|"[^"]*"|'[^']*'|`[^`]*`|[\w.$]+)/gi;
+const PLACEHOLDER_NAME = /\.placeholder\b|\bplaceholder\b(?=\s*[,})\]])/gi;
+function withoutInputPlaceholders(line) {
+    return line
+        .replace(INPUT_PLACEHOLDER, (_prop, value) => (/^["'`]/.test(value) ? value.replace(/example\.com/gi, '') : ''))
+        .replace(PLACEHOLDER_NAME, '');
+}
 const CONFIG_RULES = {
     app_name: { path: ['expo', 'name'], absent: 'fail' },
     slug: { path: ['expo', 'slug'], absent: 'fail' },
-    ios_bundle_id: { path: ['expo', 'ios', 'bundleIdentifier'], absent: 'fail' },
-    android_package: { path: ['expo', 'android', 'package'], absent: 'fail' },
+    ios_bundle_id: { path: ['expo', 'ios', 'bundleIdentifier'], absent: 'info', storeId: /^[A-Za-z0-9-]+(\.[A-Za-z0-9-]+)+$/ },
+    android_package: { path: ['expo', 'android', 'package'], absent: 'info', storeId: /^[a-z][a-z0-9_]*(\.[a-z][a-z0-9_]*)+$/ },
     version: { path: ['expo', 'version'], absent: 'warning' },
     scheme: { path: ['expo', 'scheme'], absent: 'info' },
-    ios_encryption: { path: ['expo', 'ios', 'infoPlist', 'ITSAppUsesNonExemptEncryption'], absent: 'warning' },
     user_interface_style: { path: ['expo', 'userInterfaceStyle'], absent: 'info' },
     orientation: { path: ['expo', 'orientation'], absent: 'info' },
     ios_supports_tablet: { path: ['expo', 'ios', 'supportsTablet'], absent: 'info' },
@@ -157,7 +165,9 @@ function evaluateLocalItem(root, appJson, item) {
         case 'http_endpoints':
             return patternItem(root, item, /http:\/\/(?!localhost|127\.0\.0\.1)/i, 'warning', 'Non-local HTTP endpoint found.', 'No non-local HTTP endpoints found.');
         case 'placeholder_content':
-            return patternItem(root, item, /lorem ipsum|example\.com|\bTBD\b|\bTODO\b|Coming soon|placeholder/i, 'warning', 'Placeholder text found.', 'No placeholder text found.');
+            return patternItem(root, item, PLACEHOLDER_COPY, 'warning', 'Placeholder text found.', 'No placeholder text found.', {
+                filter: (match) => PLACEHOLDER_COPY.test(withoutInputPlaceholders(match.text)),
+            });
         case 'competitor_reference':
             return patternItem(root, item, /google play|\.apk\b|samsung|android app/i, 'warning', 'Possible platform/competitor reference found in user-facing copy.', 'No competitor platform references found.', { dirs: ['app', 'src', 'components'] });
         case 'private_api_usage':
@@ -180,9 +190,11 @@ function evaluateLocalItem(root, appJson, item) {
         case 'external_payment_digital':
             return evaluateExternalPayment(root, item);
         case 'expo_layout_missing':
-            return evaluateExpoLayout(root, item);
+            return makeItem(item, 'pass', 'Expo Router adds a layout where a directory has none.', 'expo-router getRoutesCore.js');
         case 'expo_duplicate_route':
             return evaluateDuplicateRoutes(root, item);
+        case 'ios_encryption':
+            return evaluateEncryption(appJson, item);
         case 'plugin_permission_missing':
             return evaluatePluginPermissions(root, appJson, item);
         case 'permission_descriptions':
@@ -202,10 +214,25 @@ function evaluateConfigItem(appJson, item, rule) {
     const value = getPath(appJson, rule.path);
     const present = hasValue(value);
     const evidence = `app.json ${rule.path.join('.')} = ${value === undefined ? 'undefined' : JSON.stringify(value)}`;
+    if (rule.storeId) {
+        const id = stringValue(value);
+        if (!id || id.toLowerCase() === PREVIEW_APP_ID)
+            return makeItem(item, rule.absent, `${item.label} is assigned when you publish.`, evidence);
+        if (!rule.storeId.test(id) || id.length > 255)
+            return makeItem(item, 'fail', `${item.label} is not valid. Use a reverse-domain ID like com.yourname.app.`, evidence);
+    }
     if (present)
         return makeItem(item, 'pass', `${item.label} is set.`, evidence);
     return makeItem(item, rule.absent, `${item.label} is not set.`, evidence);
 }
+function evaluateEncryption(appJson, item) {
+    const plist = getPath(appJson, ['expo', 'ios', 'infoPlist', 'ITSAppUsesNonExemptEncryption']);
+    const config = getPath(appJson, ['expo', 'ios', 'config', 'usesNonExemptEncryption']);
+    const evidence = `app.json expo.ios.infoPlist.ITSAppUsesNonExemptEncryption = ${JSON.stringify(plist) ?? 'undefined'}, expo.ios.config.usesNonExemptEncryption = ${JSON.stringify(config) ?? 'undefined'}`;
+    if (hasValue(plist) || hasValue(config))
+        return makeItem(item, 'pass', `${item.label} is set.`, evidence);
+    return makeItem(item, 'info', `${item.label} is declared exempt (no non-exempt encryption) when you publish.`, evidence);
+}
 function evaluateRestorePurchases(root, item) {
     const iap = scan(root, /react-native-purchases|expo-in-app-purchases|StoreKit/i);
     if (!iap.length)
@@ -231,25 +258,15 @@ function evaluateExternalPayment(root, item) {
         return makeItem(item, 'pass', 'No external payment SDK patterns found.', 'scan: no Stripe/PayPal/Braintree patterns found');
     return makeItem(item, 'warning', 'External payment SDK found; verify it is not used for digital goods on iOS.', evidence(matches));
 }
-function evaluateExpoLayout(root, item) {
-    const appDir = path.join(root, 'app');
-    if (!existsSync(appDir))
-        return makeItem(item, 'pass', 'No Expo Router app directory found.', 'scan: app/ directory absent');
-    const dirs = walkDirs(appDir).map((dir) => path.relative(root, dir) || 'app');
-    const missing = dirs.filter((dir) => !hasLayoutFile(path.join(root, dir)));
-    if (!missing.length)
-        return makeItem(item, 'pass', 'Every app route directory has a layout file.', 'scan: app route directories');
-    return makeItem(item, 'fail', 'Expo Router directories without _layout files found.', missing.slice(0, 8).join(', '));
-}
 function evaluateDuplicateRoutes(root, item) {
-    const appDir = path.join(root, 'app');
+    const appDir = routerDir(root);
     if (!existsSync(appDir))
         return makeItem(item, 'pass', 'No Expo Router app directory found.', 'scan: app/ directory absent');
     const routes = new Map();
     for (const file of walkFiles(appDir)) {
         if (!/\.(tsx|ts|jsx|js)$/.test(file) || /(^|\/)_layout\.(tsx|ts|jsx|js)$/.test(toRel(root, file)))
             continue;
-        const route = routePath(root, file);
+        const route = routePath(appDir, file);
         const current = routes.get(route) ?? [];
         current.push(toRel(root, file));
         routes.set(route, current);
@@ -422,14 +439,10 @@ function unresolvedReason(item) {
     return `no deterministic evaluator is registered for ${item.check} item`;
 }
 function targetPlatformsFromAppJson(appJson) {
-    const ios = stringValue(getPath(appJson, ['expo', 'ios', 'bundleIdentifier']));
-    const android = stringValue(getPath(appJson, ['expo', 'android', 'package']));
-    const platforms = [];
-    if (ios)
-        platforms.push('ios');
-    if (android)
-        platforms.push('android');
-    return platforms.length ? platforms : ['ios', 'android'];
+    const declared = getPath(appJson, ['expo', 'platforms']);
+    if (!Array.isArray(declared))
+        return ['ios', 'android'];
+    return ['ios', 'android'].filter((platform) => declared.includes(platform));
 }
 function targetsItem(item, targetPlatforms) {
     return item.platform.some((platform) => targetPlatforms.includes(platform));
@@ -503,17 +516,6 @@ function walkFiles(dir) {
     }
     return files;
 }
-function walkDirs(dir) {
-    const dirs = [dir];
-    for (const entry of safeReadDir(dir)) {
-        if (SKIP_DIRS.has(entry.name))
-            continue;
-        const full = path.join(dir, entry.name);
-        if (entry.isDirectory())
-            dirs.push(...walkDirs(full));
-    }
-    return dirs;
-}
 function shouldScanFile(file) {
     return TEXT_EXTENSIONS.has(path.extname(file));
 }
@@ -523,11 +525,12 @@ function findByName(root, name) {
 function sourceText(root, dirs) {
     return collectScanFiles(root, dirs).map((file) => readText(file) ?? '').join('\n');
 }
-function hasLayoutFile(dir) {
-    return ['_layout.tsx', '_layout.ts', '_layout.jsx', '_layout.js'].some((name) => existsSync(path.join(dir, name)));
+function routerDir(root) {
+    const src = path.join(root, 'src', 'app');
+    return safeStat(src)?.isDirectory() ? src : path.join(root, 'app');
 }
-function routePath(root, file) {
-    const rel = toRel(root, file).replace(/^app\//, '').replace(/\.(tsx|ts|jsx|js)$/, '');
+function routePath(appDir, file) {
+    const rel = toRel(appDir, file).replace(/\.(tsx|ts|jsx|js)$/, '');
     const parts = rel.split('/').filter((part) => part && !/^\(.+\)$/.test(part));
     if (parts[parts.length - 1] === 'index')
         parts.pop();

package/dist/version.js

@@ -1 +1 @@
-export const CLI_VERSION = '0.2.154';
+export const CLI_VERSION = '0.2.156';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "runcloud",
-  "version": "0.2.154",
+  "version": "0.2.156",
   "description": "Create and control run.cloud remote mobile simulators and cloud sandboxes",
   "license": "Apache-2.0",
   "keywords": [