runcloud 0.2.152 → 0.2.154

package/dist/commands/appStoreEvaluate.js

@@ -151,7 +151,9 @@ function evaluateLocalItem(root, appJson, item) {
         return evaluateConfigItem(appJson, item, rule);
     switch (item.id) {
         case 'hardcoded_secrets':
-            return patternItem(root, item, /sk-[A-Za-z0-9]{20,}|AIza[0-9A-Za-z_-]{30,}|-----BEGIN.*PRIVATE KEY|api[_-]?key\s*[:=]\s*['"][A-Za-z0-9]{16,}/i, 'fail', 'Hardcoded secret-like value found.', 'No secret-like values found.');
+            return patternItem(root, item, /sk-[A-Za-z0-9]{20,}|AIza[0-9A-Za-z_-]{30,}|-----BEGIN.*PRIVATE KEY|api[_-]?key\s*[:=]\s*['"][A-Za-z0-9]{16,}/i, 'fail', 'Hardcoded secret-like value found.', 'No secret-like values found.', {
+                filter: (match) => !isFirebaseClientKey(root, match),
+            });
         case 'http_endpoints':
             return patternItem(root, item, /http:\/\/(?!localhost|127\.0\.0\.1)/i, 'warning', 'Non-local HTTP endpoint found.', 'No non-local HTTP endpoints found.');
         case 'placeholder_content':
@@ -287,21 +289,60 @@ function patternItem(root, item, regex, statusOnHit, messageOnHit, messageOnMiss
         return makeItem(item, statusOnHit, messageOnHit, evidence(matches));
     return makeItem(item, 'pass', messageOnMiss, `scan: no matches for ${regex}`);
 }
+const MICROPHONE_USE = /expo-av|AudioRecorder|requestRecordingPermissionsAsync|requestMicrophonePermissions|useMicrophonePermissions|recordAsync/i;
+const CAMERA_USE = /expo-camera|CameraView|requestCameraPermissions|launchCameraAsync/i;
+const LOCATION_USE = /expo-location|getCurrentPositionAsync|watchPositionAsync/i;
+const ANDROID_PACKAGE_PERMISSIONS = [
+    { pkg: 'expo-camera', permissions: ['CAMERA'] },
+    { pkg: 'expo-camera', option: 'recordAudioAndroid', permissions: ['RECORD_AUDIO'] },
+    { pkg: 'expo-image-picker', permissions: ['CAMERA', 'READ_EXTERNAL_STORAGE'] },
+    { pkg: 'expo-image-picker', option: 'microphonePermission', permissions: ['RECORD_AUDIO'] },
+    { pkg: 'expo-audio', option: 'recordAudioAndroid', permissions: ['RECORD_AUDIO'] },
+    { pkg: 'expo-location', permissions: ['ACCESS_COARSE_LOCATION', 'ACCESS_FINE_LOCATION'] },
+    { pkg: 'expo-media-library', permissions: ['READ_EXTERNAL_STORAGE'] },
+    { pkg: 'expo-notifications', permissions: ['POST_NOTIFICATIONS'] },
+];
+function isFirebaseClientKey(root, match) {
+    if (!/AIza[0-9A-Za-z_-]{30,}/.test(match.text))
+        return false;
+    if (/(^|\/)(GoogleService-Info\.plist|google-services\.json)$/.test(match.file))
+        return true;
+    if (!/\bapiKey['"]?\s*:/.test(match.text))
+        return false;
+    return /initializeApp\s*\(|authDomain/.test(readText(path.join(root, match.file)) ?? '');
+}
 function missingPermissionRequirements(root, appJson) {
     const missing = [...missingIosUsageDescriptions(root, appJson)];
-    const permissions = arrayOfStrings(getPath(appJson, ['expo', 'android', 'permissions']));
+    const bare = (permission) => permission.replace(/^android\.permission\./, '');
+    const blocked = new Set(arrayOfStrings(getPath(appJson, ['expo', 'android', 'blockedPermissions'])).map(bare));
+    const picker = configPluginOptions(appJson, 'expo-image-picker');
+    if (picker?.cameraPermission === false)
+        blocked.add('CAMERA');
+    if (picker?.microphonePermission === false)
+        blocked.add('RECORD_AUDIO');
+    const installed = installedPackages(root);
+    const granted = new Set(arrayOfStrings(getPath(appJson, ['expo', 'android', 'permissions'])).map(bare));
+    for (const { pkg, option, permissions } of ANDROID_PACKAGE_PERMISSIONS) {
+        const listed = configPluginOptions(appJson, pkg);
+        const auto = PLUGIN_PURPOSE_STRINGS[pkg]?.auto ?? false;
+        const adds = option === undefined
+            ? installed.has(pkg) || listed !== undefined
+            : listed ? listed[option] !== false : auto && installed.has(pkg);
+        if (adds)
+            permissions.forEach((permission) => granted.add(permission));
+    }
     const source = sourceText(root, ['app', 'src', 'components']);
     const androidChecks = [
-        { name: 'camera', used: /expo-camera|CameraView|requestCameraPermissions/i, permissions: ['CAMERA'] },
-        { name: 'location', used: /expo-location|getCurrentPositionAsync|watchPositionAsync/i, permissions: ['ACCESS_FINE_LOCATION', 'ACCESS_COARSE_LOCATION'] },
-        { name: 'photos', used: /expo-image-picker|expo-media-library|MediaLibrary/i, permissions: ['READ_MEDIA_IMAGES', 'READ_EXTERNAL_STORAGE'] },
-        { name: 'microphone', used: /expo-av|expo-audio|Audio\.|requestMicrophonePermissions/i, permissions: ['RECORD_AUDIO'] },
+        { name: 'camera', used: CAMERA_USE, permissions: ['CAMERA'] },
+        { name: 'location', used: LOCATION_USE, permissions: ['ACCESS_FINE_LOCATION', 'ACCESS_COARSE_LOCATION'] },
+        { name: 'photos', used: /expo-media-library|MediaLibrary/i, permissions: ['READ_MEDIA_IMAGES', 'READ_EXTERNAL_STORAGE'] },
+        { name: 'microphone', used: MICROPHONE_USE, permissions: ['RECORD_AUDIO'] },
         { name: 'notifications', used: /expo-notifications/i, permissions: ['POST_NOTIFICATIONS'] },
     ];
     for (const check of androidChecks) {
         if (!check.used.test(source))
             continue;
-        if (!check.permissions.some((permission) => permissions.includes(permission))) {
+        if (!check.permissions.some((permission) => granted.has(permission) && !blocked.has(permission))) {
             missing.push(`android ${check.name} permission (${check.permissions.join(' or ')})`);
         }
     }
@@ -311,13 +352,12 @@ function missingIosUsageDescriptions(root, appJson) {
     const infoPlist = objectValue(getPath(appJson, ['expo', 'ios', 'infoPlist']));
     const source = sourceText(root, ['app', 'src', 'components']);
     const checks = [
-        { name: 'camera', used: /expo-camera|CameraView|requestCameraPermissions/i, keys: ['NSCameraUsageDescription'] },
-        { name: 'location', used: /expo-location|getCurrentPositionAsync|watchPositionAsync/i, keys: ['NSLocationWhenInUseUsageDescription', 'NSLocationAlwaysAndWhenInUseUsageDescription'] },
+        { name: 'camera', used: CAMERA_USE, keys: ['NSCameraUsageDescription'] },
+        { name: 'location', used: LOCATION_USE, keys: ['NSLocationWhenInUseUsageDescription', 'NSLocationAlwaysAndWhenInUseUsageDescription'] },
         { name: 'photos', used: /expo-image-picker|expo-media-library|MediaLibrary/i, keys: ['NSPhotoLibraryUsageDescription'] },
-        { name: 'microphone', used: /expo-av|AudioRecorder|requestRecordingPermissionsAsync|requestMicrophonePermissions/i, keys: ['NSMicrophoneUsageDescription'] },
+        { name: 'microphone', used: MICROPHONE_USE, keys: ['NSMicrophoneUsageDescription'] },
     ];
-    const pkg = readJson(path.join(root, 'package.json'));
-    const installed = new Set(['dependencies', 'devDependencies'].flatMap((field) => Object.keys(objectValue(getPath(pkg, [field])))));
+    const installed = installedPackages(root);
     const missing = [];
     for (const check of checks) {
         if (!check.used.test(source))
@@ -358,6 +398,10 @@ function builtWithPurposeString(key, infoPlist, appJson, installed) {
     }
     return written;
 }
+function installedPackages(root) {
+    const pkg = readJson(path.join(root, 'package.json'));
+    return new Set(['dependencies', 'devDependencies'].flatMap((field) => Object.keys(objectValue(getPath(pkg, [field])))));
+}
 function configPluginOptions(appJson, name) {
     const plugins = getPath(appJson, ['expo', 'plugins']);
     if (!Array.isArray(plugins))

package/dist/version.js

@@ -1 +1 @@
-export const CLI_VERSION = '0.2.152';
+export const CLI_VERSION = '0.2.154';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "runcloud",
-  "version": "0.2.152",
+  "version": "0.2.154",
   "description": "Create and control run.cloud remote mobile simulators and cloud sandboxes",
   "license": "Apache-2.0",
   "keywords": [