rsuite 5.33.0 → 5.33.1

package/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [5.33.1](https://github.com/rsuite/rsuite/compare/v5.33.0...v5.33.1) (2023-05-12)
+
+### Bug Fixes
+
+- **Carousel:** fix index not being reset when children change ([#3185](https://github.com/rsuite/rsuite/issues/3185)) ([3afb746](https://github.com/rsuite/rsuite/commit/3afb7460f5d12b34eb0e7944fa9f5a461b663028))
+- **CheckPicker:** avoid mutating data when groupBy is specified ([#3173](https://github.com/rsuite/rsuite/issues/3173)) ([1a9805a](https://github.com/rsuite/rsuite/commit/1a9805a00cffcb8e527fbeb1df3a346da9a707f0))
+- **DatePicker:** fix defaultValue not changing month on calendar ([#3183](https://github.com/rsuite/rsuite/issues/3183)) ([b0a2b5f](https://github.com/rsuite/rsuite/commit/b0a2b5f5cfe6ea94c1c13f8e9451c5d60f7f5b80))
+- **pickers:** fix keyboard events still responding when readOnly ([#3184](https://github.com/rsuite/rsuite/issues/3184)) ([56e7563](https://github.com/rsuite/rsuite/commit/56e7563b2035be767f5ed8429cd8c3622708abe8))
+
 # [5.33.0](https://github.com/rsuite/rsuite/compare/v5.32.0...v5.33.0) (2023-04-28)
 
 ### Features

package/cjs/Carousel/Carousel.js

@@ -59,13 +59,23 @@ var Carousel = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
 
   var _useControlled = (0, _utils.useControlled)(activeIndexProp, defaultActiveIndex),
       activeIndex = _useControlled[0],
-      setActiveIndex = _useControlled[1];
+      setActiveIndex = _useControlled[1],
+      isControlled = _useControlled[2];
 
   var _useState = (0, _react.useState)(0),
       lastIndex = _useState[0],
       setLastIndex = _useState[1];
 
-  var rootRef = (0, _react.useRef)(null); // Set a timer for automatic playback.
+  var rootRef = (0, _react.useRef)(null);
+  (0, _utils.useUpdateEffect)(function () {
+    // When the index is controlled, the index is not updated when the number of children changes.
+    if (isControlled) {
+      return;
+    } // Reset the index when the number of children changes.
+
+
+    setActiveIndex(0);
+  }, [children, isControlled]); // Set a timer for automatic playback.
   // `autoplay` needs to be cast to boolean type to avoid undefined parameters.
 
   var _useTimeout = (0, _utils.useTimeout)(function () {

package/cjs/CheckPicker/CheckPicker.js

@@ -35,6 +35,8 @@ var _treeUtils = require("../utils/treeUtils");
 
 var _utils = require("../utils");
 
+var _getDataGroupBy = require("../utils/getDataGroupBy");
+
 var _Picker = require("../Picker");
 
 var _templateObject;
@@ -323,7 +325,7 @@ var CheckPicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
 
 
     if (groupBy) {
-      items = (0, _utils.getDataGroupBy)(items, groupBy, sort);
+      items = (0, _getDataGroupBy.getDataGroupBy)(items, groupBy, sort);
     } else if (typeof sort === 'function') {
       items = items.sort(sort(false));
     }
@@ -342,8 +344,10 @@ var CheckPicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
       dropdownMenuItemAs: _Picker.DropdownMenuCheckItem,
       activeItemValues: value,
       focusItemValue: focusItemValue,
-      data: [].concat(filteredStickyItems, items),
+      data: [].concat(filteredStickyItems, items) // `group` is redundant so long as `groupBy` exists
+      ,
       group: !(0, _isUndefined.default)(groupBy),
+      groupBy: groupBy,
       onSelect: handleItemSelect,
       onGroupTitleClick: onGroupTitleClick,
       virtualized: virtualized

package/cjs/DatePicker/DatePicker.js

@@ -117,7 +117,7 @@ var DatePicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
       value = _useControlled[0],
       setValue = _useControlled[1];
 
-  var _useCalendarDate = (0, _useCalendarDate2.default)(valueProp, calendarDefaultDate),
+  var _useCalendarDate = (0, _useCalendarDate2.default)(value, calendarDefaultDate),
       calendarDate = _useCalendarDate.calendarDate,
       setCalendarDate = _useCalendarDate.setCalendarDate,
       resetCalendarDate = _useCalendarDate.resetCalendarDate;

package/cjs/InputPicker/InputPicker.js

@@ -43,6 +43,8 @@ var _Plaintext = _interopRequireDefault(require("../Plaintext"));
 
 var _utils = require("../utils");
 
+var _getDataGroupBy = require("../utils/getDataGroupBy");
+
 var _Picker = require("../Picker");
 
 var _Tag = _interopRequireDefault(require("../Tag"));
@@ -629,7 +631,7 @@ var InputPicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
 
 
     if (groupBy) {
-      items = (0, _utils.getDataGroupBy)(items, groupBy, sort);
+      items = (0, _getDataGroupBy.getDataGroupBy)(items, groupBy, sort);
     } else if (typeof sort === 'function') {
       items = items.sort(sort(false));
     }
@@ -653,8 +655,11 @@ var InputPicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref) {
       activeItemValues: multi ? value : [value],
       focusItemValue: focusItemValue,
       maxHeight: menuMaxHeight,
-      data: items,
+      data: items // FIXME-Doma
+      // `group` is redundant so long as `groupBy` exists
+      ,
       group: !(0, _isUndefined.default)(groupBy),
+      groupBy: groupBy,
       onSelect: multi ? handleCheckTag : handleSelectItem // fixme don't use any
       ,
       renderMenuGroup: renderMenuGroup,

package/cjs/MultiCascader/MultiCascader.js

@@ -249,6 +249,7 @@ var MultiCascader = /*#__PURE__*/_react.default.forwardRef(function (props, ref)
     (_triggerRef$current = triggerRef.current) === null || _triggerRef$current === void 0 ? void 0 : (_triggerRef$current$u = _triggerRef$current.updatePosition) === null || _triggerRef$current$u === void 0 ? void 0 : _triggerRef$current$u.call(_triggerRef$current);
   }, [onSelect, getChildren, childrenKey, inline, addFlattenData, addColumn, removeColumnByIndex]);
   var handleCheck = (0, _react.useCallback)(function (node, event, checked) {
+    console.log('handleCheck');
     var nodeValue = node[valueKey];
     var nextValue = [];
 

package/cjs/Picker/DropdownMenu.d.ts

@@ -6,6 +6,7 @@ export interface DropdownMenuProps<Multiple = false> extends StandardProps, Omit
     classPrefix: string;
     data?: ItemDataType[];
     group?: boolean;
+    groupBy?: string;
     disabledItemValues?: any[];
     activeItemValues?: any[];
     focusItemValue?: any;

package/cjs/Picker/DropdownMenu.js

@@ -11,6 +11,8 @@ var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends")
 
 var _objectWithoutPropertiesLoose2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutPropertiesLoose"));
 
+var _get2 = _interopRequireDefault(require("lodash/get"));
+
 var _react = _interopRequireWildcard(require("react"));
 
 var _propTypes = _interopRequireDefault(require("prop-types"));
@@ -47,6 +49,7 @@ var DropdownMenu = /*#__PURE__*/_react.default.forwardRef(function (props, ref)
   var _props$data = props.data,
       data = _props$data === void 0 ? [] : _props$data,
       group = props.group,
+      groupBy = props.groupBy,
       _props$maxHeight = props.maxHeight,
       maxHeight = _props$maxHeight === void 0 ? 320 : _props$maxHeight,
       _props$activeItemValu = props.activeItemValues,
@@ -75,7 +78,7 @@ var DropdownMenu = /*#__PURE__*/_react.default.forwardRef(function (props, ref)
       renderMenuItem = props.renderMenuItem,
       onGroupTitleClick = props.onGroupTitleClick,
       onSelect = props.onSelect,
-      rest = (0, _objectWithoutPropertiesLoose2.default)(props, ["data", "group", "maxHeight", "activeItemValues", "disabledItemValues", "classPrefix", "valueKey", "labelKey", "virtualized", "listProps", "listRef", "className", "style", "focusItemValue", "dropdownMenuItemClassPrefix", "dropdownMenuItemAs", "rowHeight", "rowGroupHeight", "renderMenuGroup", "renderMenuItem", "onGroupTitleClick", "onSelect"]);
+      rest = (0, _objectWithoutPropertiesLoose2.default)(props, ["data", "group", "groupBy", "maxHeight", "activeItemValues", "disabledItemValues", "classPrefix", "valueKey", "labelKey", "virtualized", "listProps", "listRef", "className", "style", "focusItemValue", "dropdownMenuItemClassPrefix", "dropdownMenuItemAs", "rowHeight", "rowGroupHeight", "renderMenuGroup", "renderMenuItem", "onGroupTitleClick", "onSelect"]);
 
   var _useClassNames = (0, _utils.useClassNames)(classPrefix),
       withClassPrefix = _useClassNames.withClassPrefix,
@@ -205,11 +208,21 @@ var DropdownMenu = /*#__PURE__*/_react.default.forwardRef(function (props, ref)
   };
 
   var filteredItems = group ? data.filter(function (item) {
-    return !(foldedGroupKeys !== null && foldedGroupKeys !== void 0 && foldedGroupKeys.some(function (key) {
-      var _item$parent;
-
-      return key === ((_item$parent = item.parent) === null || _item$parent === void 0 ? void 0 : _item$parent[_getDataGroupBy.KEY_GROUP_TITLE]);
-    }));
+    var _item$parent;
+
+    // Display group title items
+    if (item[_getDataGroupBy.KEY_GROUP]) return true; // Display items under the unfolded group
+    // FIXME-Doma
+    // `groupBy` is bound to be string when `group` is true
+    // because `group` is actually redundant as a prop
+    // It could simply be derived from `groupBy` value
+
+    var groupValue = (0, _get2.default)(item, groupBy, '') || ( // FIXME-Doma
+    // Usage of `item.parent` is strongly discouraged
+    // It's only here for legacy support
+    // Remove once `item.parent` is completely removed across related components
+    (_item$parent = item.parent) === null || _item$parent === void 0 ? void 0 : _item$parent[_getDataGroupBy.KEY_GROUP_TITLE]);
+    return !foldedGroupKeys.includes(groupValue);
   }) : data;
   var rowCount = filteredItems.length;
   (0, _utils.useMount)(function () {

package/cjs/Picker/utils.d.ts

@@ -73,6 +73,8 @@ export interface ToggleKeyDownEventProps {
     overlayRef?: React.RefObject<any>;
     searchInputRef?: React.RefObject<any>;
     active?: boolean;
+    readOnly?: boolean;
+    disabled?: boolean;
     onExit?: (event: any) => void;
     onKeyDown?: (event: any) => void;
     onOpen?: () => void;

package/cjs/Picker/utils.js

@@ -433,6 +433,8 @@ var useToggleKeyDownEvent = function useToggleKeyDownEvent(props) {
       overlayRef = props.overlayRef,
       searchInputRef = props.searchInputRef,
       active = props.active,
+      readOnly = props.readOnly,
+      disabled = props.disabled,
       onExit = props.onExit,
       onOpen = props.onOpen,
       onClose = props.onClose,
@@ -461,6 +463,11 @@ var useToggleKeyDownEvent = function useToggleKeyDownEvent(props) {
     handleOpen();
   }, [active, handleOpen, handleClose]);
   var onToggle = (0, _react.useCallback)(function (event) {
+    // Keyboard events should not be processed when readOnly and disabled are set.
+    if (readOnly || disabled) {
+      return;
+    }
+
     if (event.target === (targetRef === null || targetRef === void 0 ? void 0 : targetRef.current)) {
       // enter
       if (toggle && event.key === _utils.KEY_VALUES.ENTER) {
@@ -510,7 +517,7 @@ var useToggleKeyDownEvent = function useToggleKeyDownEvent(props) {
 
 
     onKeyDown === null || onKeyDown === void 0 ? void 0 : onKeyDown(event);
-  }, [handleClose, handleToggleDropdown, overlayRef, onExit, onKeyDown, onMenuKeyDown, onMenuPressBackspace, onMenuPressEnter, toggle, targetRef, searchInputRef]);
+  }, [readOnly, disabled, targetRef, overlayRef, onKeyDown, toggle, handleToggleDropdown, onExit, onMenuKeyDown, searchInputRef, onMenuPressEnter, onMenuPressBackspace, handleClose]);
   return onToggle;
 };
 

package/cjs/SelectPicker/SelectPicker.js

@@ -29,6 +29,8 @@ var _omit = _interopRequireDefault(require("lodash/omit"));
 
 var _utils = require("../utils");
 
+var _getDataGroupBy = require("../utils/getDataGroupBy");
+
 var _Picker = require("../Picker");
 
 var _templateObject;
@@ -258,7 +260,7 @@ var SelectPicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref)
     var items = filteredData; // Create a tree structure data when set `groupBy`
 
     if (groupBy) {
-      items = (0, _utils.getDataGroupBy)(items, groupBy, sort);
+      items = (0, _getDataGroupBy.getDataGroupBy)(items, groupBy, sort);
     } else if (typeof sort === 'function') {
       items = items.sort(sort(false));
     }
@@ -278,8 +280,11 @@ var SelectPicker = /*#__PURE__*/_react.default.forwardRef(function (props, ref)
       dropdownMenuItemAs: _Picker.DropdownMenuItem,
       activeItemValues: [value],
       focusItemValue: focusItemValue,
-      data: items,
+      data: items // FIXME-Doma
+      // `group` is redundant so long as `groupBy` exists
+      ,
       group: !(0, _isUndefined.default)(groupBy),
+      groupBy: groupBy,
       onSelect: handleItemSelect,
       onGroupTitleClick: onGroupTitleClick,
       virtualized: virtualized

package/cjs/utils/getDataGroupBy.d.ts

@@ -1,3 +1,6 @@
 export declare const KEY_GROUP: string | symbol;
 export declare const KEY_GROUP_TITLE = "groupTitle";
-export default function getDataGroupBy(data: any[] | undefined, key: string, sort?: any): any[];
+export declare function getDataGroupBy<T>(data: readonly T[], key: string, sort?: (isGroup: boolean) => <T>(a: T, b: T) => number): (T | {
+    groupTitle: string;
+    children: T[];
+})[];

package/cjs/utils/getDataGroupBy.js

@@ -3,10 +3,10 @@
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 
 exports.__esModule = true;
-exports.default = getDataGroupBy;
+exports.getDataGroupBy = getDataGroupBy;
 exports.KEY_GROUP_TITLE = exports.KEY_GROUP = void 0;
 
-var _get2 = _interopRequireDefault(require("lodash/get"));
+var _groupBy2 = _interopRequireDefault(require("lodash/groupBy"));
 
 var _treeUtils = require("../utils/treeUtils");
 
@@ -17,26 +17,9 @@ var KEY_GROUP_TITLE = 'groupTitle';
 exports.KEY_GROUP_TITLE = KEY_GROUP_TITLE;
 
 function getDataGroupBy(data, key, sort) {
-  if (data === void 0) {
-    data = [];
-  }
-
-  var tempData = {};
+  var groupMap = (0, _groupBy2.default)(data, key);
   var isSort = typeof sort === 'function';
-  data.forEach(function (item) {
-    // this will allow getting data using dot notation
-    // i.e groupBy="country.name" as country will be a nested object
-    // to the item and the name will be nested key to the country object
-    // can be used with values in arrays, i.e groupBy="addresses.0.country.name"
-    var groupByValue = (0, _get2.default)(item, key, '');
-
-    if (!tempData[groupByValue]) {
-      tempData[groupByValue] = [];
-    }
-
-    tempData[groupByValue].push(item);
-  });
-  var nextData = Object.entries(tempData).map(function (_ref) {
+  var groups = Object.entries(groupMap).map(function (_ref) {
     var _ref2;
 
     var groupTitle = _ref[0],
@@ -47,8 +30,13 @@ function getDataGroupBy(data, key, sort) {
   });
 
   if (isSort) {
-    nextData = nextData.sort(sort(true));
-  }
+    groups.sort(sort(true));
+  } // Use DFS traverse
+  // Because I want the result to be [group, child, child, group, child, child]
+  // rather than [group, group, child, child, child, child]
+
 
-  return (0, _treeUtils.UNSAFE_flattenTree)(nextData);
+  return (0, _treeUtils.flattenTree)(groups, function (group) {
+    return group.children;
+  }, _treeUtils.WalkTreeStrategy.DFS);
 }

package/cjs/utils/index.d.ts

@@ -12,7 +12,6 @@ export { default as ReactChildren } from './ReactChildren';
 export { default as tplTransform } from './tplTransform';
 export { default as ajaxUpload } from './ajaxUpload';
 export { default as previewFile } from './previewFile';
-export { default as getDataGroupBy } from './getDataGroupBy';
 export { default as clone } from './clone';
 export { default as placementPolyfill } from './placementPolyfill';
 export { default as getDOMNode } from './getDOMNode';

package/cjs/utils/index.js

@@ -14,7 +14,6 @@ var _exportNames = {
   tplTransform: true,
   ajaxUpload: true,
   previewFile: true,
-  getDataGroupBy: true,
   clone: true,
   placementPolyfill: true,
   getDOMNode: true,
@@ -49,7 +48,7 @@ var _exportNames = {
   DateUtils: true,
   TypeChecker: true
 };
-exports.TypeChecker = exports.DateUtils = exports.globalKey = exports.getClassNamePrefix = exports.defaultClassPrefix = exports.useMount = exports.useIsMounted = exports.useUpdateEffect = exports.useWillUnmount = exports.useUpdatedRef = exports.useEventCallback = exports.stringToObject = exports.getSafeRegExpString = exports.useRootClose = exports.useControlled = exports.useTimeout = exports.createComponent = exports.usePortal = exports.useCustom = exports.useElementResize = exports.useEventListener = exports.useClassNames = exports.render = exports.appendTooltip = exports.scrollTopAnimation = exports.reactToString = exports.composeFunctions = exports.shallowEqualArray = exports.shallowEqual = exports.mergeRefs = exports.getDOMNode = exports.placementPolyfill = exports.clone = exports.getDataGroupBy = exports.previewFile = exports.ajaxUpload = exports.tplTransform = exports.ReactChildren = exports.isOneOf = exports.createChainedFunction = exports.prefix = exports.guid = void 0;
+exports.TypeChecker = exports.DateUtils = exports.globalKey = exports.getClassNamePrefix = exports.defaultClassPrefix = exports.useMount = exports.useIsMounted = exports.useUpdateEffect = exports.useWillUnmount = exports.useUpdatedRef = exports.useEventCallback = exports.stringToObject = exports.getSafeRegExpString = exports.useRootClose = exports.useControlled = exports.useTimeout = exports.createComponent = exports.usePortal = exports.useCustom = exports.useElementResize = exports.useEventListener = exports.useClassNames = exports.render = exports.appendTooltip = exports.scrollTopAnimation = exports.reactToString = exports.composeFunctions = exports.shallowEqualArray = exports.shallowEqual = exports.mergeRefs = exports.getDOMNode = exports.placementPolyfill = exports.clone = exports.previewFile = exports.ajaxUpload = exports.tplTransform = exports.ReactChildren = exports.isOneOf = exports.createChainedFunction = exports.prefix = exports.guid = void 0;
 
 var _BrowserDetection = require("./BrowserDetection");
 
@@ -130,10 +129,6 @@ var _previewFile = _interopRequireDefault(require("./previewFile"));
 
 exports.previewFile = _previewFile.default;
 
-var _getDataGroupBy = _interopRequireDefault(require("./getDataGroupBy"));
-
-exports.getDataGroupBy = _getDataGroupBy.default;
-
 var _clone = _interopRequireDefault(require("./clone"));
 
 exports.clone = _clone.default;

package/cjs/utils/treeUtils.d.ts

@@ -21,7 +21,13 @@ export declare function shouldShowNodeByParentExpanded<T>(expandItemValues?: T[]
  *             Use {@link flattenTree} instead.
  */
 export declare function UNSAFE_flattenTree<TItem>(tree: TItem[], childrenKey?: string, executor?: (node: any, index: number) => any): TItem[];
-export declare function flattenTree<T>(rootNodes: readonly T[], getChildren: (node: T) => readonly T[] | undefined): T[];
+export declare enum WalkTreeStrategy {
+    DFS = 0,
+    BFS = 1
+}
+export declare function flattenTree<T>(rootNodes: readonly T[], getChildren: (node: T) => readonly T[] | undefined, walkStrategy?: WalkTreeStrategy): T[];
+export declare function walkTreeBfs<T>(rootNodes: readonly T[], getChildren: (node: T) => readonly T[] | undefined, callback: (node: T) => void): void;
+export declare function walkTreeDfs<T>(rootNodes: readonly T[], getChildren: (node: T) => readonly T[] | undefined, callback: (node: T) => void): void;
 /**
  * get all ancestor nodes of given node
  * @param {*} node
@@ -293,6 +299,6 @@ export declare function getParentMap<T extends Record<string, unknown>>(items: r
  */
 export declare function getKeyParentMap<T extends Record<string, unknown>, K = React.Key>(items: readonly T[], getKey: (item: T) => K, getChildren: (item: T) => readonly T[] | undefined): Map<K, T>;
 /**
- * Returns an array indicating the hirearchy path from root towards `target` item
+ * Returns an array indicating the hierarchy path from root towards `target` item
  */
 export declare function getPathTowardsItem<T>(target: T | undefined, getParent: (item: T) => T | undefined): T[];

package/cjs/utils/treeUtils.js

@@ -8,6 +8,8 @@ exports.__esModule = true;
 exports.shouldShowNodeByParentExpanded = shouldShowNodeByParentExpanded;
 exports.UNSAFE_flattenTree = UNSAFE_flattenTree;
 exports.flattenTree = flattenTree;
+exports.walkTreeBfs = walkTreeBfs;
+exports.walkTreeDfs = walkTreeDfs;
 exports.getNodeParents = getNodeParents;
 exports.getNodeParentKeys = getNodeParentKeys;
 exports.hasVisibleChildren = hasVisibleChildren;
@@ -42,7 +44,7 @@ exports.stringifyTreeNodeLabel = stringifyTreeNodeLabel;
 exports.getParentMap = getParentMap;
 exports.getKeyParentMap = getKeyParentMap;
 exports.getPathTowardsItem = getPathTowardsItem;
-exports.getScrollToIndex = exports.focusPreviousItem = exports.focusNextItem = exports.focusTreeNode = exports.getElementByDataKey = exports.getActiveItem = exports.getActiveIndex = exports.getFocusableItems = void 0;
+exports.getScrollToIndex = exports.focusPreviousItem = exports.focusNextItem = exports.focusTreeNode = exports.getElementByDataKey = exports.getActiveItem = exports.getActiveIndex = exports.getFocusableItems = exports.WalkTreeStrategy = void 0;
 
 var _extends3 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 
@@ -144,15 +146,35 @@ function UNSAFE_flattenTree(tree, childrenKey, executor) {
   return flattenData;
 }
 
-function flattenTree(rootNodes, getChildren) {
+var WalkTreeStrategy;
+exports.WalkTreeStrategy = WalkTreeStrategy;
+
+(function (WalkTreeStrategy) {
+  WalkTreeStrategy[WalkTreeStrategy["DFS"] = 0] = "DFS";
+  WalkTreeStrategy[WalkTreeStrategy["BFS"] = 1] = "BFS";
+})(WalkTreeStrategy || (exports.WalkTreeStrategy = WalkTreeStrategy = {}));
+
+function flattenTree(rootNodes, getChildren, walkStrategy) {
+  if (walkStrategy === void 0) {
+    walkStrategy = WalkTreeStrategy.BFS;
+  }
+
   var result = [];
-  walkTree(rootNodes, getChildren, function (node) {
-    return result.push(node);
-  });
+
+  if (walkStrategy === WalkTreeStrategy.BFS) {
+    walkTreeBfs(rootNodes, getChildren, function (node) {
+      return result.push(node);
+    });
+  } else if (walkStrategy === WalkTreeStrategy.DFS) {
+    walkTreeDfs(rootNodes, getChildren, function (node) {
+      return result.push(node);
+    });
+  }
+
   return result;
 }
 
-function walkTree(rootNodes, getChildren, callback) {
+function walkTreeBfs(rootNodes, getChildren, callback) {
   for (var queue = [].concat(rootNodes); queue.length > 0;) {
     var _node = queue.shift();
 
@@ -164,6 +186,18 @@ function walkTree(rootNodes, getChildren, callback) {
     }
   }
 }
+
+function walkTreeDfs(rootNodes, getChildren, callback) {
+  for (var _iterator = _createForOfIteratorHelperLoose(rootNodes), _step; !(_step = _iterator()).done;) {
+    var _node2 = _step.value;
+    callback(_node2);
+    var children = getChildren(_node2);
+
+    if (children) {
+      walkTreeDfs(children, getChildren, callback);
+    }
+  }
+}
 /**
  * get all ancestor nodes of given node
  * @param {*} node
@@ -413,10 +447,10 @@ function findNodeOfTree(data, check) {
       var _item3 = nodes[i];
 
       if ((0, _isArray2.default)(_item3.children)) {
-        var _node2 = findNode(_item3.children);
+        var _node3 = findNode(_item3.children);
 
-        if (_node2) {
-          return _node2;
+        if (_node3) {
+          return _node3;
         }
       }
 
@@ -1220,8 +1254,8 @@ function getParentMap(items, getChildren) {
     var children = getChildren(_item5);
 
     if (children) {
-      for (var _iterator = _createForOfIteratorHelperLoose(children), _step; !(_step = _iterator()).done;) {
-        var child = _step.value;
+      for (var _iterator2 = _createForOfIteratorHelperLoose(children), _step2; !(_step2 = _iterator2()).done;) {
+        var child = _step2.value;
         map.set(child, _item5);
         queue.push(child);
       }
@@ -1249,8 +1283,8 @@ function getKeyParentMap(items, getKey, getChildren) {
     var children = getChildren(_item6);
 
     if (children) {
-      for (var _iterator2 = _createForOfIteratorHelperLoose(children), _step2; !(_step2 = _iterator2()).done;) {
-        var child = _step2.value;
+      for (var _iterator3 = _createForOfIteratorHelperLoose(children), _step3; !(_step3 = _iterator3()).done;) {
+        var child = _step3.value;
         map.set(getKey(child), _item6);
         queue.push(child);
       }
@@ -1260,7 +1294,7 @@ function getKeyParentMap(items, getKey, getChildren) {
   return map;
 }
 /**
- * Returns an array indicating the hirearchy path from root towards `target` item
+ * Returns an array indicating the hierarchy path from root towards `target` item
  */