npm - roxxie-proxy-u-prod - Versions diffs - 0.2.2 → 0.2.4 - Mend

roxxie-proxy-u-prod 0.2.2 → 0.2.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (41) hide show

package/embed.js CHANGED Viewed

@@ -3,7 +3,7 @@
 	"use strict";
 	var DEFAULT_SHELL_URL =
-		"https://unpkg.com/roxxie-proxy-u-prod@0.2.2/runtime/index.html";
+		"https://unpkg.com/roxxie-proxy-u-prod@0.2.4/runtime/index.html";
 	var loadingScript = document.currentScript;
 	function resolveContainer(target) {

package/examples/single-page.html CHANGED Viewed

@@ -18,8 +18,8 @@
 		<div id="roxxie-browser"></div>
 		<script
 			defer
-			src="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.2/embed.js"
-			integrity="sha384-3QVF5CQiWk0SKqCDSEAoupN0KXK0bxo9qaZeS5Tj8/8mO8J719dv+fvmrqmdthH2"
+			src="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.4/embed.js"
+			integrity="sha384-o6wwoyCvQbj3evNh2USZSUAOc625OxxX2yUnWs7o2i4NmKGhII4Y9SxvCG03OjAk"
 			crossorigin="anonymous"
 			data-roxxie-target="#roxxie-browser"
 		></script>

package/package.json CHANGED Viewed

@@ -1,44 +1,43 @@
 {
-	"name": "roxxie-proxy-u-prod",
-	"version": "0.2.2",
-	"description": "Production CDN assets and embed loader for Roxxie Proxy U",
-	"license": "AGPL-3.0-only",
-	"private": false,
-	"main": "embed.js",
-	"browser": "embed.js",
-	"jsdelivr": "embed.js",
-	"unpkg": "embed.js",
-	"files": [
-		"dist",
-		"runtime",
-		"examples",
-		"scripts",
-		"source",
-		"third_party",
-		"embed.js",
-		"standalone.html",
-		"LICENSE",
-		"SOURCE.md",
-		"THIRD_PARTY_NOTICES.md",
-		"README.md"
-	],
-	"scripts": {
-		"build": "node scripts/build.mjs",
-		"smoke": "node scripts/smoke.mjs",
-		"verify": "node scripts/verify.mjs",
-		"prepack": "npm run verify"
-	},
-	"publishConfig": {
-		"access": "public"
-	},
-	"devDependencies": {
-		"playwright": "1.59.1"
-	},
-	"keywords": [
-		"roxxie",
-		"browser",
-		"proxy",
-		"webrtc",
-		"embed"
-	]
-}
+  "name": "roxxie-proxy-u-prod",
+  "version": "0.2.4",
+  "description": "Production CDN assets and embed loader for Roxxie Proxy U",
+  "license": "AGPL-3.0-only",
+  "private": false,
+  "main": "embed.js",
+  "browser": "embed.js",
+  "jsdelivr": "embed.js",
+  "unpkg": "embed.js",
+  "files": [
+    "dist",
+    "runtime",
+    "examples",
+    "scripts",
+    "source",
+    "third_party",
+    "embed.js",
+    "standalone.html",
+    "LICENSE",
+    "SOURCE.md",
+    "THIRD_PARTY_NOTICES.md",
+    "README.md"
+  ],
+  "publishConfig": {
+    "access": "public"
+  },
+  "devDependencies": {
+    "playwright": "1.59.1"
+  },
+  "keywords": [
+    "roxxie",
+    "browser",
+    "proxy",
+    "webrtc",
+    "embed"
+  ],
+  "scripts": {
+    "build": "node scripts/build.mjs",
+    "smoke": "node scripts/smoke.mjs",
+    "verify": "node scripts/verify.mjs"
+  }
+}

package/runtime/index.html CHANGED Viewed

@@ -2,14 +2,14 @@
 <html lang="en">
 	<head>
 		<meta charset="UTF-8" />
-		<link rel="icon" type="image/png" sizes="any" href="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.2/dist/favicon.png" />
+		<link rel="icon" type="image/png" sizes="any" href="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.4/dist/favicon.png" />
 		<meta name="theme-color" content="#222230" />
 		<meta name="viewport" content="width=device-width, initial-scale=1.0" />
 		<title>Roxxie Proxy U</title>
 		<!--ssr-head-->
-		<script type="module" crossorigin src="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.2/dist/assets/index-CttvagWK.js"></script>
-		<link rel="stylesheet" crossorigin href="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.2/dist/assets/index-EeRhLAof.css">
+		<script type="module" crossorigin src="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.4/dist/assets/index-MRhaNu_Q.js"></script>
+		<link rel="stylesheet" crossorigin href="https://cdn.jsdelivr.net/npm/roxxie-proxy-u-prod@0.2.4/dist/assets/index-EeRhLAof.css">
 	</head>
 	<body>

package/scripts/verify.mjs CHANGED Viewed

@@ -118,8 +118,8 @@ if (
 	throw new Error("Start screen must remain flat and glow-free");
 }
-if (manifest.version !== "0.2.2") {
-	throw new Error("This production release must be version 0.2.2");
+if (manifest.version !== "0.2.4") {
+	throw new Error("This production release must be version 0.2.4");
 }
 const embedBytes = await readFile(join(packageRoot, "embed.js"));

package/source/packages/adrift-protocol/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
 	"name": "roxxie-transports-adrift-protocol",
-	"version": "6.0.0",
+	"version": "6.0.1",
 	"description": "Browser-safe wire types and codecs for Roxxie Proxy U transports",
 	"type": "module",
 	"sideEffects": false,
@@ -18,7 +18,7 @@
 		"test": "npm run build && node --test dist/test/*.test.js"
 	},
 	"engines": {
-		"node": ">=20"
+		"node": ">=18"
 	},
 	"publishConfig": {
 		"access": "public"

package/source/packages/adrift-protocol/src/index.ts CHANGED Viewed

@@ -47,6 +47,17 @@ export const S2CRequestTypes = {
 	WSDataEnd: 8,
 	WSError: 9,
 	Pong: 10,
+	/**
+	 * Terminates a response whose body was cut short after the headers were
+	 * already delivered. `HTTPResponseEnd` means "the body is complete", so it
+	 * must never be used for a truncated stream: the client cannot tell a
+	 * partial body from a whole one and will happily parse and cache it.
+	 *
+	 * Purely additive, so `PROTOCOL_VERSION` stays at 6.0. A node that sends
+	 * this to an older client makes that client fail the session loudly, which
+	 * is strictly better than the silent corruption it replaces.
+	 */
+	HTTPResponseError: 11,
 } as const;
 export type ObjectValue<T> = T[keyof T];

package/source/packages/chrome/src/Tab/History.test.ts ADDED Viewed

@@ -0,0 +1,137 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+// History records visited pages into the global profile; stub it so the model
+// can be exercised on its own.
+vi.mock("..", () => ({
+	profileService: { globalhistory: [] as unknown[] },
+}));
+import { History } from "./History";
+/** Only the surface History touches on its owning tab. */
+function fakeTab() {
+	return {
+		url: null as URL | null,
+		title: null as string | null,
+		icon: null as string | null,
+		canGoBack: false,
+		canGoForward: false,
+		navigated: [] as string[],
+		_directnavigate(url: URL) {
+			this.navigated.push(url.href);
+			this.url = url;
+		},
+	};
+}
+function makeHistory() {
+	const tab = fakeTab();
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any
+	const history = new History(tab as any);
+	return { tab, history };
+}
+const A = new URL("https://a.example/");
+const B = new URL("https://b.example/");
+const C = new URL("https://c.example/");
+const D = new URL("https://d.example/");
+describe("tab history", () => {
+	let tab: ReturnType<typeof fakeTab>;
+	let history: History;
+	beforeEach(() => {
+		({ tab, history } = makeHistory());
+	});
+	it("tracks a linear trail and walks back through it", () => {
+		history.push(A);
+		history.push(B);
+		history.push(C);
+		expect(history.current().url.href).toBe(C.href);
+		expect(history.canGoBack()).toBe(true);
+		expect(history.canGoForward()).toBe(false);
+		expect(history.go(-1).url.href).toBe(B.href);
+		expect(history.go(-1).url.href).toBe(A.href);
+		expect(history.canGoBack()).toBe(false);
+	});
+	it("keeps the current entry when a new navigation forks the trail", () => {
+		// Regression: the fork used to splice from the current index rather than
+		// after it, deleting the entry the user was on. index then pointed past the
+		// end of the array, so states[index] was undefined and going back walked
+		// into that hole.
+		history.push(A);
+		history.push(B);
+		history.push(C);
+		history.go(-2);
+		expect(history.current().url.href).toBe(A.href);
+		history.push(D);
+		expect(history.states.map((s) => s.url.href)).toEqual([A.href, D.href]);
+		expect(history.index).toBe(1);
+		expect(history.current().url.href).toBe(D.href);
+		expect(history.states[history.index]).toBeDefined();
+	});
+	it("goes back to a real page after forking rather than an empty state", () => {
+		history.push(A);
+		history.push(B);
+		history.push(C);
+		history.go(-2);
+		history.push(D);
+		expect(history.canGoBack()).toBe(true);
+		const back = history.go(-1);
+		expect(back).toBeDefined();
+		expect(back.url).toBeInstanceOf(URL);
+		expect(back.url.href).toBe(A.href);
+		// The URL actually handed to the tab must be a real page, never "undefined".
+		expect(tab.navigated.at(-1)).toBe(A.href);
+		expect(tab.navigated.some((href) => href.includes("undefined"))).toBe(false);
+	});
+	it("never reports canGoBack while sitting on the first entry", () => {
+		history.push(A);
+		history.push(B);
+		history.go(-1);
+		expect(history.index).toBe(0);
+		expect(history.canGoBack()).toBe(false);
+	});
+	it("clamps overshooting travel to the ends of the trail", () => {
+		history.push(A);
+		history.push(B);
+		expect(history.go(-99).url.href).toBe(A.href);
+		expect(history.go(99).url.href).toBe(B.href);
+	});
+	it("replaces the current entry without growing the trail", () => {
+		history.push(A);
+		history.push(B);
+		history.replace(C, null, null, false);
+		expect(history.states.map((s) => s.url.href)).toEqual([A.href, C.href]);
+		expect(history.index).toBe(1);
+	});
+	it("survives a round trip through serialization", () => {
+		history.push(A);
+		history.push(B);
+		history.go(-1);
+		const restoredTab = fakeTab();
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any
+		const restored = new History(restoredTab as any, history.serialize());
+		expect(restored.index).toBe(history.index);
+		expect(restored.current().url.href).toBe(A.href);
+		expect(restored.canGoForward()).toBe(true);
+	});
+});

package/source/packages/chrome/src/Tab/History.ts CHANGED Viewed

@@ -94,8 +94,11 @@ export class History extends StatefulClass {
 			// disown states we're removing
 			this.states.slice(this.index + 1).forEach((state) => this.disown(state));
-			// "fork" history tree, creating a new timeline
-			this.states.splice(this.index, this.states.length - this.index);
+			// "fork" history tree, creating a new timeline. Only the entries *after*
+			// the current one are dropped: removing the current entry as well left
+			// index pointing past the end of the array, so states[index] was
+			// undefined and going back navigated into that hole.
+			this.states.splice(this.index + 1);
 		}
 		const hstate = new HistoryState({ url, state, title });
 		if (virtual) hstate.virtual = true;
@@ -129,7 +132,9 @@ export class History extends StatefulClass {
 			this.current().title = title;
 			this.current().favicon = null;
 		} else {
-			return this.push(url, state);
+			// push takes (url, title, state, navigate); passing state positionally
+			// as the title corrupted the new entry.
+			return this.push(url, title, state, navigate);
 		}
 		if (navigate) {

package/source/packages/chrome/src/Tab/Tab.tsx CHANGED Viewed

@@ -62,7 +62,7 @@ export class Tab extends StatefulClass {
 		this.url ??= new URL(`${INTERNAL_URL_PROTOCOL}//newtab`);
 		this.id ??= uuid("tab-");
-		this.frame = new ProxyFrame();
+		this.frame = new ProxyFrame(() => this.commitExternalNavigation());
 		this.history = new History(this, history);
 		this.own(this.history);
 		this.waitForInit = new Promise((resolve) => {
@@ -135,6 +135,7 @@ export class Tab extends StatefulClass {
 	// only caller should be history.ts for this
 	_directnavigate(url: URL) {
+		this.frame.cancelPendingNavigation();
 		this.url = url;
 		this.icon = defaultFaviconUrl;
 		if (url.protocol == INTERNAL_URL_PROTOCOL) {
@@ -188,6 +189,13 @@ export class Tab extends StatefulClass {
 	}
 	initialLoad() {
+		this.commitExternalNavigation();
+	}
+	private commitExternalNavigation() {
+		// A late response from a page we have already left must not hide a newly
+		// selected internal page.
+		if (this.url.protocol === INTERNAL_URL_PROTOCOL) return;
 		this.initResolve();
 		this.internalpage = null;
 	}
@@ -196,7 +204,10 @@ export class Tab extends StatefulClass {
 		this.history.push(url, null, null, true, false);
 	}
 	replaceNavigate(url: URL) {
-		this.history.replace(url, null, true);
+		// replace takes (url, title, state, navigate); `true` was landing in the
+		// state slot, so the replacement carried a bogus state and never navigated
+		// explicitly.
+		this.history.replace(url, null, null, true);
 	}
 	back() {

package/source/packages/chrome/src/components/Omnibar/Omnibox.tsx CHANGED Viewed

@@ -9,6 +9,7 @@ import {
 	type OmniboxResult,
 } from "./suggestions";
 import { trimUrl } from "./utils";
+import { inlineCompletion } from "./autocomplete";
 import { UrlInput } from "@components/Omnibar/UrlInput";
 import { Suggestion } from "@components/Omnibar/Suggestion";
 import { requestUnfocusFrames } from "@components/Shell";
@@ -97,32 +98,19 @@ export function Omnibox(
 		// if the user is actually trying to search something we can kill the trending suggestions
 		this.trendingSuggestions = [];
-		fetchSuggestions(this.realvalue, this.suggestionDenied, (results) => {
+		// Capture the flag for this run. It is cleared synchronously below, well
+		// before fetchSuggestions calls back, so the callback cannot read it.
+		const justDeleted = this.suggestionDenied;
+		fetchSuggestions(this.realvalue, justDeleted, (results) => {
 			this.searchSuggestions = results;
 			const firstResult = results[0];
 			if (!firstResult) return;
-			if (firstResult.kind === "search") {
-				if (!firstResult.title) return;
-				if (this.realvalue.length >= firstResult.title.length) return;
-				if (
-					!firstResult.title
-						.toLowerCase()
-						.startsWith(this.realvalue.toLowerCase())
-				)
-					return;
-				let currentCursor = this.input.selectionStart || 0;
-				this.input.setSelectionRange(
-					currentCursor,
-					currentCursor + firstResult.title.length
-				);
-				this.value = firstResult.title;
-				this.input.setSelectionRange(
-					currentCursor,
-					currentCursor + firstResult.title.length
-				);
+			let candidate: string | null | undefined;
+			if (firstResult.kind === "search") {
+				candidate = firstResult.title;
 			} else {
 				if (!firstResult.url) return;
@@ -136,24 +124,26 @@ export function Omnibox(
 				if (normalizedUrl.endsWith("/") && !this.realvalue.endsWith("/")) {
 					normalizedUrl = normalizedUrl.slice(0, -1);
 				}
-				if (this.realvalue.length >= normalizedUrl.length) return;
-				if (
-					!normalizedUrl.toLowerCase().startsWith(this.realvalue.toLowerCase())
-				)
-					return;
-				let currentCursor = this.input.selectionStart || 0;
-				this.input.setSelectionRange(
-					currentCursor,
-					currentCursor + normalizedUrl.length
-				);
-				this.value = normalizedUrl;
-				this.input.setSelectionRange(
-					currentCursor,
-					currentCursor + normalizedUrl.length
-				);
+				candidate = normalizedUrl;
 			}
+			const completion = inlineCompletion(
+				this.realvalue,
+				candidate,
+				justDeleted
+			);
+			if (completion === null) return;
+			const currentCursor = this.input.selectionStart || 0;
+			this.input.setSelectionRange(
+				currentCursor,
+				currentCursor + completion.length
+			);
+			this.value = completion;
+			this.input.setSelectionRange(
+				currentCursor,
+				currentCursor + completion.length
+			);
 		});
 		this.suggestionDenied = false;
 	});

package/source/packages/chrome/src/components/Omnibar/autocomplete.test.ts ADDED Viewed

@@ -0,0 +1,51 @@
+import { describe, expect, it } from "vitest";
+import { inlineCompletion } from "./autocomplete";
+describe("omnibox inline completion", () => {
+	it("completes a prefix while the user is typing", () => {
+		expect(inlineCompletion("ama", "amazon.com", false)).toBe("amazon.com");
+	});
+	it("never re-adds text right after a deletion", () => {
+		// The completion is written back into the box with its tail selected, so
+		// re-adding it after a backspace means the next backspace only removes the
+		// completion again and the final character can never be deleted.
+		expect(inlineCompletion("a", "amazon.com", true)).toBeNull();
+	});
+	it("leaves an emptied box empty", () => {
+		expect(inlineCompletion("", "amazon.com", true)).toBeNull();
+		expect(inlineCompletion("", "amazon.com", false)).toBeNull();
+	});
+	it("ignores candidates that are not a continuation of the input", () => {
+		expect(inlineCompletion("xyz", "amazon.com", false)).toBeNull();
+	});
+	it("matches case-insensitively but preserves the candidate's casing", () => {
+		expect(inlineCompletion("AmA", "amazon.com", false)).toBe("amazon.com");
+	});
+	it("adds nothing when the candidate is not longer than the input", () => {
+		expect(inlineCompletion("amazon.com", "amazon.com", false)).toBeNull();
+		expect(inlineCompletion("amazon.com/x", "amazon.com", false)).toBeNull();
+	});
+	it("tolerates a missing candidate", () => {
+		expect(inlineCompletion("ama", undefined, false)).toBeNull();
+		expect(inlineCompletion("ama", null, false)).toBeNull();
+		expect(inlineCompletion("ama", "", false)).toBeNull();
+	});
+	it("lets a full deletion sequence reach an empty box", () => {
+		// Walk "ama" down to "" the way repeated backspaces would, asserting the
+		// box is never refilled at any step.
+		let typed = "ama";
+		while (typed.length > 0) {
+			typed = typed.slice(0, -1);
+			expect(inlineCompletion(typed, "amazon.com", true)).toBeNull();
+		}
+		expect(typed).toBe("");
+	});
+});

package/source/packages/chrome/src/components/Omnibar/autocomplete.ts ADDED Viewed

@@ -0,0 +1,30 @@
+/**
+ * Inline omnibox autocompletion.
+ *
+ * The omnibox completes what you type by writing the candidate into the input
+ * and selecting the added tail, so the next keystroke replaces it. That is only
+ * correct while text is being *added*. Applying it after a deletion makes the
+ * next backspace consume the re-added completion instead of the character the
+ * user meant to remove, which strands the final character permanently.
+ */
+/**
+ * The text to place in the omnibox, or null to leave what the user typed alone.
+ *
+ * @param typed what the user actually has in the box
+ * @param candidate the top suggestion, if any
+ * @param justDeleted whether the last edit removed characters
+ */
+export function inlineCompletion(
+	typed: string,
+	candidate: string | undefined | null,
+	justDeleted: boolean
+): string | null {
+	// Never re-add text the user is in the middle of removing.
+	if (justDeleted) return null;
+	if (!typed || !candidate) return null;
+	// A candidate that is not strictly longer adds nothing to complete.
+	if (candidate.length <= typed.length) return null;
+	if (!candidate.toLowerCase().startsWith(typed.toLowerCase())) return null;
+	return candidate;
+}